From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 82609C71157 for ; Wed, 18 Jun 2025 04:47:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C612A6B0088; Wed, 18 Jun 2025 00:47:20 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C124A6B0089; Wed, 18 Jun 2025 00:47:20 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B28096B008A; Wed, 18 Jun 2025 00:47:20 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id A24EA6B0088 for ; Wed, 18 Jun 2025 00:47:20 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 598E9802CE for ; Wed, 18 Jun 2025 04:47:20 +0000 (UTC) X-FDA: 83567287440.09.3CFD23D Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf08.hostedemail.com (Postfix) with ESMTP id 22CDF160007 for ; Wed, 18 Jun 2025 04:47:17 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=xRnL3Qcl; spf=none (imf08.hostedemail.com: domain of BATV+826cfafe48c3f27d09fc+7969+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+826cfafe48c3f27d09fc+7969+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1750222038; a=rsa-sha256; cv=none; b=2sAS55jwijxQQ/GIvFXJVtcZCPFmPC6zHunJfmY+7gGZ2e2j5TQPKxpnCQ2cF7uE9TOM3I g9wEvuUzmaGqJvGol30nS43TnqEhEmcOWULhYvPVc7spv+xCy2IWwS/EbVBMOjS7IJCprD WsnX63JeV67uonxRtmH4axY/IwMV0e8= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=xRnL3Qcl; spf=none (imf08.hostedemail.com: domain of BATV+826cfafe48c3f27d09fc+7969+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+826cfafe48c3f27d09fc+7969+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750222038; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=g0EyjvhAS1Km3yCILzus7ZZgUkl096TgjUz70d73o+s=; b=5qROqrvYld1NR2cedwok6R/jIhG5Mmj3IyvkiLr9XFQi51qNjIW+9pUmp3FyMva4WeLNcH q0ugAm0rzik+FbAWKHFtJ+Z6RYFBEcNQ4Z6Q4/C1lc8wQPtfORxHKHWKoNpjSgaNrTQrov 85FpDYjQKsQbOx+Z2A3QI1ShsY31Fh4= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=g0EyjvhAS1Km3yCILzus7ZZgUkl096TgjUz70d73o+s=; b=xRnL3QclCBTneZxyRvOQKeoAJw WFWsJRoUO17O0yPeqzV/lXobZwMedKmPqKiQuYYY/W8cjidH9cYQY9TknREFhB54Vln4cAuuaKrfI uQjqMorruhedHG2gDmZX9BdhJd3vPxGvK2HtGafdCxzVjwEkeHx/43ybyiXUanAUfCPTmO3jkuyOK 5WhZZejGs9FW9D8WEgSExF1Ca5NH5e9O7YFWgvEhEdZP8vciOyUNIhjHY5qHFrx1ytDrCeGMMHXeH Nfi7EwG+OfK2fsKFiKLuxkUYgb9gv1LvvvVamBLUrYuz3aY0LyurBJEtxBE9vbFV9vu1W+bcwpKHH w9wZMM7g==; Received: from hch by bombadil.infradead.org with local (Exim 4.98.2 #2 (Red Hat Linux)) id 1uRkhc-000000092bR-1D3q; Wed, 18 Jun 2025 04:47:12 +0000 Date: Tue, 17 Jun 2025 21:47:12 -0700 From: Christoph Hellwig To: Matthew Wilcox Cc: Christoph Hellwig , "Darrick J. Wong" , Joanne Koong , miklos@szeredi.hu, brauner@kernel.org, linux-fsdevel@vger.kernel.org, linux-xfs@vger.kernel.org, bernd.schubert@fastmail.fm, kernel-team@meta.com, linux-mm@kvack.org, linux-nfs@vger.kernel.org Subject: does fuse need ->launder_folios, was: Re: [PATCH v1 5/8] iomap: add iomap_writeback_dirty_folio() Message-ID: References: <20250606233803.1421259-1-joannelkoong@gmail.com> <20250606233803.1421259-6-joannelkoong@gmail.com> <20250609171444.GL6156@frogsfrogsfrogs> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 22CDF160007 X-Stat-Signature: ikjkcpj5zdyb8n78uuobuakik78rsbhh X-Rspam-User: X-HE-Tag: 1750222037-586999 X-HE-Meta: U2FsdGVkX1+6uHCkqOcbtYvyK37ODJsVcBuTi9+T091DvVc6S99v8q3D/X6Qj6z0n8dHKa40byCvQWwJZQS5n9goYReN3Pfuv/5vfBH0j8pl+hK+50FCfm+FlAmTSjllSEJlAF1UADaWs5CBId+t8TIvt6NGQeHUykHuyjt3FGyw8UW5q4Xg55PmJN18+yvjhZ4q/+BSP+QKMgwJ8QrjWnXnOqjN2O3DheMQ7g8f05jYcDB+XChoTMMMRYn2heGNZehoS6Hkuu0pGeyDbGp8PNUstjttbu+aAlJEvKoFLrn1C6b+rHf3t7qaWy8GRniNTI9PZcrSXMfU0vkwywIQbt8L/11mixN5ejpvTlu0VMY6miKbyGnYosK5Wui/gr0tzaROWMcMyXGZ+FLSTQ/7A/ZWam97gjIB8phWyhwy9ubFITFvqfmAsHFka9xxVYdmRui8JGsK5HVTEf9x774J7ZL/rPTT1M0HSFt/WXrIMf+ytgW95iu7wdCSQHKGKAhRCxfVmB24AexrWwi2bYeE93JhybwwK1Pfga0eCzDMRfnZrGKQD3Em89+w87HCy3bXRXX/IRiYJpmpUfDjstTdOOvO4pnGhvudn9Z5/TZQ59T5DuTJjfNeRC5rtdyJ4oouepHVo0SZgYbDTcTZuKLqmP7wCtzBfloju6tG2NHOPKv5qD0TsdUzIHT4KMUm5iUkapKofZWeTG/GfoJ+eGmBHtbgljGI3T5wFvnua+xVre375HmFDYyF7IIOw1rvj6dNN83v+m51JI53JZ/LAUkpEgi98zz6xsnlvlDkevhh4tXezkeYmRrS0F4a6tCLG83fLpQMEp7KxrsHHDzJYUQ4ZWGW5NxGeVTYmxwmvfvUW0Q34dW9vnQjavUGBrDBv35ziyp4VoUsXOId5nJxGHLppSHxXiWzl0YtyXxr6IVOra7/jYgOfdjXUSsw63fjpNCT4DsOc2zJZGKzLvp92OX LmbLrfE9 K3pyRCEU+nVl/8I3PS1sYQmwToq1uE6X+gV+wJ2L6YzAFURInrADoWER1rLd8637cFy+UnbRYvE0RQH2XS6EAWxgeY7m38RhrmBbemTLogyRUFWwCgikTY1Qz65P4yPciKDaATnSgHc9UfK3CS8gFB7dJIeLWFt26NJXsxXOqwI+1mNZc/mlsJoDSnpYnMNvYo+mA0jwFWjiWWNXe4m6qQCfnYmngNefuE7HhoiEApGQE+AmJsAyvQdr5Jdej2jrhl0XwwgaCaoyzWat7dHLRlT0+MvYp3/jVwQsDItj+bcdhWFwBpS03aFjXJXhXTzn+OqV4hyaiK/Ko1rPU9dULoywAkUYpIFTUpWbNT3V73CZ/U9Xq0az72uwd9yQRfbNCuTqLVvj0sKJORQO/3jFAENmpjPu1/BLbHCN1gj68A0EhVg/pjVbGCOwC2v2kf73iuyK/9ZZKB1mKHEXdS7pn6RA/SZiMe6tPj8L/stUBCD6lKAPuO4VBuTrIKemsxaIkGxc7in2VYMqTEaxBL8a7PyP2yI6mglNn6Pql28pklqFmjPQP2y5zsMc7Ll5GbwGSPkV0qFtyKJvBWPM= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Jun 11, 2025 at 05:34:50AM +0100, Matthew Wilcox wrote: > > My memory might be betraying me, but I think willy once launched an > > attempt to see if we can kill launder_folio. Adding him, and the > > mm and nfs lists to check if I have a point :) > > I ... got distracted with everything else. > > Looking at the original addition of ->launder_page (e3db7691e9f3), I > don't understand why we need it. invalidate_inode_pages2() isn't > supposed to invalidate dirty pages, so I don't understand why nfs > found it necessary to do writeback from ->releasepage() instead > of just returning false like iomap does. Yeah. Miklos (and other fuse folks), can you help figuring out if fuse really wants ->launder_folio? Because it would be really good to settle this question before we have to add iomap infrastruture for it.