From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0008FC71157 for ; Tue, 17 Jun 2025 17:22:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 69AD16B009F; Tue, 17 Jun 2025 13:22:43 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 64BD56B00A0; Tue, 17 Jun 2025 13:22:43 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 588B96B00A1; Tue, 17 Jun 2025 13:22:43 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 4AB246B009F for ; Tue, 17 Jun 2025 13:22:43 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 4563BC086B for ; Tue, 17 Jun 2025 17:22:42 +0000 (UTC) X-FDA: 83565562164.03.E6CF1CF Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf14.hostedemail.com (Postfix) with ESMTP id DF87A100002 for ; Tue, 17 Jun 2025 17:22:39 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=h3OG3ntj; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf14.hostedemail.com: domain of peterx@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=peterx@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1750180960; a=rsa-sha256; cv=none; b=fc5UH8317lRAeGPs30lXVmVb++PTgG68Znjb1pMAKobKp3w9Usrhyd/wRhaumejAxaj43C tKYf+mN1kja1apiuEgbHc6fRXDT+Jv9tX67sSXa/QL59L+ygK02r2xegdgdZv1hj12gX9/ RpXXf4jAGz4OnUVLvPi3r6I5iXmf3x4= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=h3OG3ntj; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf14.hostedemail.com: domain of peterx@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=peterx@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750180960; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=34DKIigEpcgfa4tv94Inm/gSRCZZNbs35BdPm5ILfHc=; b=KoYkgKrbqD8TufL7PJ+g1jB+ru1wuS1YQbJ+25IJ2sb8roT7jmtnY8WmHQqMDz+/CUvVER lNYyosjP3vemaMews9+oK+XcPQvhdVjuyMiusMsxgv0/FlXWRkgJcDoXmnZRmUnPoGEcT8 7l2yubH976vfFwXMnJhMJArvlvRAip4= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1750180959; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=34DKIigEpcgfa4tv94Inm/gSRCZZNbs35BdPm5ILfHc=; b=h3OG3ntjL0Min7R6XomFqByaPlb76RuMxrt7RreqVQQQL6Pu9YOmibUfNk7I0ggb9yYv82 wsYgVPR22y0/si14hHNL742aOUi7AYj3fcUmFfgyWe+AMLf3vwuY9H0jvR/gbYtRT0YNSz V+bPOFZLbExy3VOt2ll6ZLv1d+CMwCQ= Received: from mail-pf1-f200.google.com (mail-pf1-f200.google.com [209.85.210.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-373-LGS8Wg8mNmWQH47yK-t2gQ-1; Tue, 17 Jun 2025 13:22:38 -0400 X-MC-Unique: LGS8Wg8mNmWQH47yK-t2gQ-1 X-Mimecast-MFC-AGG-ID: LGS8Wg8mNmWQH47yK-t2gQ_1750180957 Received: by mail-pf1-f200.google.com with SMTP id d2e1a72fcca58-7425efba1a3so4911546b3a.0 for ; Tue, 17 Jun 2025 10:22:37 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750180957; x=1750785757; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=34DKIigEpcgfa4tv94Inm/gSRCZZNbs35BdPm5ILfHc=; b=VmmwcAi1EixY+8u+/z4++KYThbelrLDbvYp8L7myVxuV/PQ6Svc/DHmVMB5a2RNBZV 3A3OklBQAsQyvIle5elKOoPPRPJDfrum5YfyvTnk71+FUsHJfphGtTAk3m+joomCHZ6P n6rr16GVMkPLYJTRDnslkefTQb05xPFvffEE3FZT8ZpjE2kLZX9bEGR9GJ9MYk1YBp9/ ck/raz7S9RvcObiYTglnXtHG3w3YTZju9kCYJMTzU+hC3u9LeZ3rdR0nhHkefevsVq0S litSnVXhC4aStDCx5atSUEQP/L1moWYTNaqTynzVTTkzWP3yDuQbTZLkNl4apmqSv6QS U55w== X-Forwarded-Encrypted: i=1; AJvYcCVB3GnWgLxRcln4Yk+ntE7msupGgO/gw3nytJ0GNQ6s9DOleews95sRzo5spLlDLgxhRJOn6dOgJA==@kvack.org X-Gm-Message-State: AOJu0YytLuhn3Z4/lGHFFal8uYS9SjxbChBs09PyBlAi3asnJgtTD3gb cGSSiUyx/Kfk6jHH+6sl35pSHDy9dfdw2BkIhTRfzHZZ0IzeK10CgRb1mNmKrXb6WZJjhmL+RXQ ff5J9vudY3AD46ZfbwBh4QRIv9GhXoW1fusv2ApK0gVMSi1EpqQW0 X-Gm-Gg: ASbGncvR04MA7oI82oqMZmyKUCWTevx2AgEHE/EV4w8eXEcJrrctdCvZg9GGEUBsJy9 iXEkPR4RMefYGrD6GdviRA83QZ2IxccJkpAgkkRXEpeTIfWdV7M8aaQB20aZwSyPd72ounrf9bK rqJ5VMCMefTUR9H33g79SdhrQdIBoqfU+kHxdfrT2hpCGY8kSB5qokGL1qzaV5LAc6k6BdT9PGU 40pis+PEDjc07Pvb7xOxlr2cQDtWSbV6DyuSrKWIfj9iHAVI9ULFxQsQS+q4bAB9ZLpynrCmFk5 ketvYWG4OOvuYA== X-Received: by 2002:a05:6a00:b8b:b0:748:6a12:1b47 with SMTP id d2e1a72fcca58-7489c47e470mr18490199b3a.10.1750180956805; Tue, 17 Jun 2025 10:22:36 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFM6/AhfqpvtyHQaLreUDoYWYWZc8npPOOqClxjD7RFi7IF9gRDq4KeeMPXcwtHEi9K0833AA== X-Received: by 2002:a05:6a00:b8b:b0:748:6a12:1b47 with SMTP id d2e1a72fcca58-7489c47e470mr18490157b3a.10.1750180956304; Tue, 17 Jun 2025 10:22:36 -0700 (PDT) Received: from x1.local ([85.131.185.92]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-74890083bb2sm9450419b3a.94.2025.06.17.10.22.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Jun 2025 10:22:35 -0700 (PDT) Date: Tue, 17 Jun 2025 13:22:30 -0400 From: Peter Xu To: Andrew Morton Cc: Ujwal Kundur , shuah@kernel.org, jackmanb@google.com, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH v5 1/1] selftests/mm/uffd: Refactor non-composite global vars into struct Message-ID: References: <20250501163827.2598-1-ujwal.kundur@gmail.com> <20250616100406.2853-1-ujwal.kundur@gmail.com> <20250616172618.0609127a8b1e406d4c228d24@linux-foundation.org> MIME-Version: 1.0 In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: B0ZOaLPP6gi7wbeuLlebbhLY08sm7GSaLA9cvePW68w_1750180957 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Stat-Signature: 1ousmhot61shs9cufhjxio4sier3w81r X-Rspamd-Queue-Id: DF87A100002 X-Rspam-User: X-Rspamd-Server: rspam06 X-HE-Tag: 1750180959-973357 X-HE-Meta: U2FsdGVkX18xRpo1Rz4lx2eQO8EU/8d1L1IRiOEKguqyFB1qbOsn7X5WC1DyVsSzwuFfS4fct2ZLccOIYQpe6BU72Yu9wgUJco0USxYd6NnT/Gr9igGSiHE2grr3+z2Zw7ptn4twhe1fTKCK+8GcO0D6NFfdYzKQxI1kVXSJX9zM2F6tlEbRyJB7mhos5ze0F93HgJeR6E93AfR1FPDNjk/NVEXB6VP1+W1hwMQHe7OtKsrvkrR1pEbRiM5EpmjV8zZACiO1Dfk7wHj6lhQwlGZbj+0+Hs/SwEv7u0QG1/oDzgU8SUpoALHuS/QuSO/bbdGkxzRvFNAB0iOrUx0IitWG5/BmxfRZyi2X/44WWw8WIGhCCe/GnCanzpAAiCj6IUi1TC3CG6MtAbp3f8HLUJb28s52rW3uiLOI6a8naoAGXV/HE0cWxtjjsYestmJzX5WyzKhdaZfZtjlv0lWRjGieG8eDs615d586GR8MdzFLsyIj8+B+XkTyeKIp7AYRyqbfclZlbymU+kOQeL3+tfthC/7rf59HC4yJJjtJZV3DW7f88qOdrn4JWcRIARkWodKvyrIRA70priAQlhzWDANS6Ssc/h2TRhgeRnkGpqnlQlFz9d2DoZiqrH981wWnWMFppiQYCNFzEPVeXvUtpiiTUcebZDub5DJ0w6IFUCtCdKDqo7aeK6wYay8ynsP9eO6NhtKhnK9SBryOOui+/3xVrPntNEd0PTa2CxuTKj9B3TfHJbQ2LdLW0j9kBNxvOIQdoMo6Rp6tdNqfhfJo3wIUV002kbeiZZeniwqzjWwGIKbJ1eYb46TE0CQiuft6Jj84GARitlTvYXxhP/1Qcqwpz5UBMMqDOcPXrqExgQabIfwTD6OhJ4OdOa3bdMlUYR0sld5Yq5E8R+dSvRvE3/ynYdjDQO7f0ZxOWjAI3+cwBx9uunlcutW7dc0V4FHi3OM7xS0Mc2Y66iCCRJF HghKKkgs FqIiMpfiIQjieJhi0dmDVA/mb6WYN3lVuN+78eisiv9SRuHdM1S1PgVSdPpeTlnSHYPWZu+obd01/LVB9y2QPMZlnHXVQbUuJocmgCqjHL6G7no3XRkAzrBQGipbRWNZUROwbYqFCdKSnoWbgJXyKS2FBKHMP40HVbRbyPE9xZgscYycDNyg702oA0N1RVKlSXgN9PBFONw94l7IQreRS+aq5HXMZYHIBVkGDgH5rRWe7GkNFibu+zHJDQ1xjozGaBuIEuPkJ7OjJav/tEDQ15tb94tiyz+xCnBxFyS7XqFaMeWQr3LfVjq+qveuGqLz04khpp/xTTdRy7HqpF22Vv9+TAe23rF+sH1wCtoLNW3AtHx09WqrwQN2QDCSYHa2mmY4D4Hz3+7CWgOyUaHuBw+WtiQQ3fbLm4WkspBq1VtcEUMSu2TrVHbmtuw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Jun 17, 2025 at 11:52:52AM -0400, Peter Xu wrote: > On Mon, Jun 16, 2025 at 05:26:18PM -0700, Andrew Morton wrote: > > On Mon, 16 Jun 2025 15:34:06 +0530 Ujwal Kundur wrote: > > > > > Refactor macros and non-composite global variable definitions into a > > > struct that is defined at the start of a test and is passed around > > > instead of relying on global vars. > > > > Well I guess that's nicer. > > > > > 5 files changed, 616 insertions(+), 542 deletions(-) > > > > It needs to be! > > > > Thanks, I'll queue it for testing while Peter thinks about it :) > > I didn't pay much attention on this one as I saw Brandan was actively > reviewing it, which was great. > > This is definitely an improvement to the test. Thanks both! I did give it a quick run today, but I found I hit this: $ ./uffd-unit-tests Testing UFFDIO_API (with syscall)... done Testing UFFDIO_API (with /dev/userfaultfd)... done Testing register-ioctls on anon... done ERROR: munmap (errno=22, @uffd-common.c:277) IIUC it's because after moving most globals to stack, they are not properly zero-initialized anymore. In this case it failed at MEM_ANON of register-ioctls test, trying to munmap() some address that will start to be random garbage since it's on the stack. So maybe we at least need something like this? diff --git a/tools/testing/selftests/mm/uffd-unit-tests.c b/tools/testing/selftests/mm/uffd-unit-tests.c index bed96f41c578..0b66ca3e7b82 100644 --- a/tools/testing/selftests/mm/uffd-unit-tests.c +++ b/tools/testing/selftests/mm/uffd-unit-tests.c @@ -1744,7 +1744,7 @@ int main(int argc, char *argv[]) mem_type = &mem_types[j]; /* Initialize global test options */ - uffd_global_test_opts_t gopts; + uffd_global_test_opts_t gopts = { 0 }; gopts.map_shared = mem_type->shared; uffd_test_ops = mem_type->mem_ops; Even with that, it fails somewhere later. Ujwal, can you reproduce these issues and have a look? Thanks, -- Peter Xu