From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7B446C71136 for ; Tue, 17 Jun 2025 16:47:53 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CEACE6B008A; Tue, 17 Jun 2025 12:47:52 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C9B106B00A1; Tue, 17 Jun 2025 12:47:52 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B63246B00A3; Tue, 17 Jun 2025 12:47:52 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id A048D6B008A for ; Tue, 17 Jun 2025 12:47:52 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 1401016072C for ; Tue, 17 Jun 2025 16:47:52 +0000 (UTC) X-FDA: 83565474384.03.0F0B164 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf26.hostedemail.com (Postfix) with ESMTP id 9693D14000E for ; Tue, 17 Jun 2025 16:47:49 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Vlv6hpJH; spf=pass (imf26.hostedemail.com: domain of peterx@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1750178869; a=rsa-sha256; cv=none; b=7dEndfSpePriVRWf+XCBb2SIX/qMknpP6VkWMUx76vgS3H3BSV/W/1U5fk6c2TW2ADvKWs OKZPJ3I5qT6Kutce5qs8BYhgEKPsynrcJWW7Qe524mrjfyxd+vWTjlEW1FUV8sWC9Mw77M QPcNefhHm1uxP5KnusfHXiJLIHIcSJQ= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Vlv6hpJH; spf=pass (imf26.hostedemail.com: domain of peterx@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750178869; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=9udXpXMKLqnXjPpw+ssHtlTIRsjM/WGu/+kStlwAoqo=; b=i+VA1bnr9D6XvdR0ozXWeqEPGhVmGs4Fflhz/jj/BHm5KayiLfkyvXsRiRQBt2FZ9i//tM f8R+cdwjDG5+pid7x9BDgBMqmVqnmQK+74hfhtDXq6zeCW+Vu4VPu1l9ZmeIM6zNPN60Hy blrHJUNx5+PYTamYICVj7uxwRMXF+TQ= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1750178868; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=9udXpXMKLqnXjPpw+ssHtlTIRsjM/WGu/+kStlwAoqo=; b=Vlv6hpJHqpbGtIdHILoe/WcXugX4yrLY5UihrMBEM/8/AJtFpeCuHCYeVbRMkr/mXrSL5w SLg2vGScViwzk+sgVU1Q3cuoZEKy77zoY59sSxTOMFAronIn7PrGIrNlcrDU3rwFn99sx8 XrPRX4xNA/cQdLZahS/0psRIfuamviU= Received: from mail-pj1-f71.google.com (mail-pj1-f71.google.com [209.85.216.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-619-LA2Aa2swMla80TZirhaO3w-1; Tue, 17 Jun 2025 12:47:47 -0400 X-MC-Unique: LA2Aa2swMla80TZirhaO3w-1 X-Mimecast-MFC-AGG-ID: LA2Aa2swMla80TZirhaO3w_1750178866 Received: by mail-pj1-f71.google.com with SMTP id 98e67ed59e1d1-311e98ee3fcso5918501a91.0 for ; Tue, 17 Jun 2025 09:47:47 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750178866; x=1750783666; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=9udXpXMKLqnXjPpw+ssHtlTIRsjM/WGu/+kStlwAoqo=; b=FMK0sbeZoC86yyVBR0HcCQLQOgI6g0ZXNL6wJ8tIMkJTfdbiRjzXHRYGY89duHzTC/ eZv54yo4hUGdZvRsGQOwG1Ud9OkPsmR2lcgbUVhEiamR0OSgNtd7ERzuMOSFLxbsZrJQ RaLJri1WYPFzlMO2i2QfzbRT/dskh4HHVx29jNU1ofrvNo4r+a5E4wlJASuWWJGxhaut C9dcCVxtnPixcUWgF9Q1bEJmLvnsUqCCgbBSwACZ6SfH4Iqwc6lMyGQSraYM60g34w3W Q+1H9XDm16xEiY6e+eZBnJE0sDrOwgdtwi3Nc/qhVW6KdkGq4rJzq9Uho2hUTleLd5F0 SJlg== X-Forwarded-Encrypted: i=1; AJvYcCV3dZyAoZLTsQ6sVtbeGTbsekPWeLINLwEPx+oVavuOUjPNKjjvmV7mW5EnkRwdk+Kh7fZn9dOMFw==@kvack.org X-Gm-Message-State: AOJu0YxJGkz2V/m+wTbEQUy9+WoBCnOHhOri+w9ldK8Na6jy67FumkIa zcmbd9UCcQODEKoNev0KCrR1F74j/vs4oDizC6cMGV7kXfM2YkETkOa/DuJysqEoJc90CTHXcLu cSoT/8rzTdKaJyWDKg18zZp3OaDlslN2Na2UfmDBq17Ekl6e+OF2Z X-Gm-Gg: ASbGncvLXcYMSnI0GVFAOAQwnmfCTmGQ3va3uCJ3EWdrM6ZhLprXEV+XhJcZiojSONu qKFWlMkTTrHVualeGbUMi4Etc3wHo8SVb8KpWPJhEM/hjYPbKG19QAo3yiyceTYzZh8lTp7GbYu UUvPo0v0DtcF3WqEgVIGye9hAzsdMy01J9KvQ3IV4NbH9QIPC0i/ib7CL2K9gFHb6wpptzo5AJL F/U1ihw5wuhRbmlvQW9bX5qSuAyQlr2Jym/gpj2tqpI0EdEvzhMjN8BQUGIw5ap2G1oG+Tls1Wz WfGQJPtikvK4vw== X-Received: by 2002:a17:90b:2808:b0:30a:3e8e:ea30 with SMTP id 98e67ed59e1d1-31427e9f04cmr4387992a91.11.1750178866292; Tue, 17 Jun 2025 09:47:46 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGZ5RZvlcb8QDXdYGv2rCtK+dVH8l+O3RgQMnCOn4WGgTIeBHCIqlbbuc04Tn+tkV7OjqZJXw== X-Received: by 2002:a17:90b:2808:b0:30a:3e8e:ea30 with SMTP id 98e67ed59e1d1-31427e9f04cmr4387954a91.11.1750178865920; Tue, 17 Jun 2025 09:47:45 -0700 (PDT) Received: from x1.local ([85.131.185.92]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2365decb947sm82211815ad.225.2025.06.17.09.47.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Jun 2025 09:47:45 -0700 (PDT) Date: Tue, 17 Jun 2025 12:47:35 -0400 From: Peter Xu To: Jason Gunthorpe Cc: kernel test robot , linux-kernel@vger.kernel.org, linux-mm@kvack.org, kvm@vger.kernel.org, oe-kbuild-all@lists.linux.dev, Andrew Morton , Alex Williamson , Zi Yan , Alex Mastro , David Hildenbrand , Nico Pache Subject: Re: [PATCH 4/5] vfio: Introduce vfio_device_ops.get_unmapped_area hook Message-ID: References: <20250613134111.469884-5-peterx@redhat.com> <202506142215.koMEU2rT-lkp@intel.com> <20250617154157.GY1174925@nvidia.com> MIME-Version: 1.0 In-Reply-To: <20250617154157.GY1174925@nvidia.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: zb-4Pe06hLyZWlv6V9lyUFDJ8e35OEwW5DDuPfPnrIY_1750178866 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 9693D14000E X-Stat-Signature: xhgstgnmdtm4uzz4i84z4epphdjyq8jc X-Rspam-User: X-HE-Tag: 1750178869-441873 X-HE-Meta: U2FsdGVkX1/G9MTrmZJIGIkQnCEXM+xzJv4q4VkTpSbvY8tXarV3n7QitObE2kP+HZxg4wHEtjEEU/Q6UnYY/TPvBVyIhfeHXFsqQHjfFHBo4+BNCv3b8ZmhT9PyKUP3j2Sca2K7hRQAKPmpOH51XBNTMbRP+FS9Q7yUA0z6nscNbkB19KAD8HyffDHAApgCLEYsNipj5I5u2IaAbCPY5KxSwBGUL1YBY9wKlLbvfnbn78fVMF33Xz+6lFH3M68mmoJaqGYVD1vmcLwxFgHCWKn2FHZtceRrgJ1FNx7MW7XCMDKC+4bCQWlryKVJmSLFtAMc4gI+plGHx4xSzotX9kfSsAv/hBUQFupXSlmJ5cV1Upt/oCeabRxLRg4EtmmP5q1d13EPrMkZS5KW6Fh+Xc5UnoQ5YijKLBJm3glXSUFFgIRQwlu1BvZHAGNpuXFnTA7zZuWJHChMVdaRWzFHCCdk1gxZcSQrX0qU1T2TNmyFzsBUCSpeGuBZPnhJhD+mHsKJx/H/WgyjcUVzLKQmkbB7Wqdk9nRW7DdKR3DBOtF7Or7DIL2ypxYB/uV6hyfFBq/SpRlxusu+QX1+ErDkhel45LxxfKyzmZLtAhB1WwPolBJjErpJ+kc6LjZ0yddvipxupZWYQkfBNNdttGXAFTBKih7K8gU8RxGsIozkHmGK9FjM92H1J+9iXG1HUXsU1E6hhimDItwNZXlrq+3zZo50KI6LeRpxzOjnZItIqqu5aNELuIbUmT5lTtl9Oqg9Eajwotr4DArPwHTj589Icbp8wSrvO4bq2LQWX32nfllVyr42e8Vde/YGYTOF1yZC5VSLNOxvnuMe8ZKD9+//A2oLj0AlZENAUNHyHGhcaaVYEUt0CL3xFxin+PrRGUvRGQqoaRjVzUN/A56+kdqR5cC+OtErPwBSaklg+3cxCwr6ZDFPbiS8bFfnbvwazOunnhSaZQY5i9l07HamXSd Qe0mj9q7 0Qtmohyadexmq6bwDis84OlbxqBEmOv6NmqXU++c+DiWJD/M3Htvitq4u4T3av41xikg73FFHaIXIO+qwtbMkE4hpmN3xYwwLpaTUSySkRVRvSpdJysKlp3LmHYIGxg52tqgiy7D+kUKcaPaK0IBhGpdCWHiQWRm2w+KFavI8uM5bgho6+KCRN4wMNDEINYViUJwuq4opmlCEB91zWAGSvtg//s+tKYFMyZo0LIDHFIefPx97Gx05EApEYuNJpwegXuMSa+5ov9L3Pp/6ArPB0fcrQPTcaD6EHsuoaIIkKZzXhIEipvZ/UFdr1nzv9tXHuRaAX2D4M0AcGYUO1zgOjhBcXm1KHwpuC+VWLmoDTu5vzfQRVHPu6Sp1KTQ8a5sKLsQSw48JcsMqf7A= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Jun 17, 2025 at 12:41:57PM -0300, Jason Gunthorpe wrote: > On Tue, Jun 17, 2025 at 11:39:07AM -0400, Peter Xu wrote: > > > > +#ifdef CONFIG_ARCH_SUPPORTS_HUGE_PFNMAP > > static unsigned long vfio_device_get_unmapped_area(struct file *file, > > unsigned long addr, > > unsigned long len, > > @@ -1370,6 +1371,7 @@ static unsigned long vfio_device_get_unmapped_area(struct file *file, > > return device->ops->get_unmapped_area(device, file, addr, len, > > pgoff, flags); > > } > > +#endif > > > > const struct file_operations vfio_device_fops = { > > .owner = THIS_MODULE, > > @@ -1380,7 +1382,9 @@ const struct file_operations vfio_device_fops = { > > .unlocked_ioctl = vfio_device_fops_unl_ioctl, > > .compat_ioctl = compat_ptr_ioctl, > > .mmap = vfio_device_fops_mmap, > > +#ifdef CONFIG_ARCH_SUPPORTS_HUGE_PFNMAP > > .get_unmapped_area = vfio_device_get_unmapped_area, > > +#endif > > }; > > IMHO this also seems like something the core code should be dealing > with and not putting weird ifdefs in drivers. It may depend on whether we want to still do the fallbacks to mm_get_unmapped_area(). I get your point in the other email but not yet get a chance to reply. I'll try that out to see how it looks and reply there. -- Peter Xu