From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6ECDFC71157 for ; Tue, 17 Jun 2025 15:39:18 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0D32B6B008A; Tue, 17 Jun 2025 11:39:18 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 05CB96B0092; Tue, 17 Jun 2025 11:39:17 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E8DDD6B0093; Tue, 17 Jun 2025 11:39:17 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id D4B626B008A for ; Tue, 17 Jun 2025 11:39:17 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 8ACC2100AC9 for ; Tue, 17 Jun 2025 15:39:17 +0000 (UTC) X-FDA: 83565301554.08.56968BA Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf29.hostedemail.com (Postfix) with ESMTP id F353E12000B for ; Tue, 17 Jun 2025 15:39:14 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=cuEbhJ1p; spf=pass (imf29.hostedemail.com: domain of peterx@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1750174755; a=rsa-sha256; cv=none; b=UMh2ZZ0vxUkf3gG7Af6Es7gVcnzLmjtfIKUq6c+MQSgctgFu9SBFgGK9EmDKH24XD+B+Go WOWXDkEE/4S/z7ofcFkOFKQ/qLEq+UGOXfYVHGg/dUJ5n5nXm+W6qWZ1e9GtD3GilDT6A6 1rXhA+Y6jRlmiECiEAJTAQhwdJRScyE= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=cuEbhJ1p; spf=pass (imf29.hostedemail.com: domain of peterx@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750174755; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=bYA4vNkR1STXIkkbeACF7/tlzHC3egoFZWTXFv+IW1c=; b=XSP8eTEV05Gr0AM3MW4JP/9Xi4IbjX1QGj7uh1g396juMmCeiRNd53tZ5gWFGfJNRIIs7L e28aGZmv5LuulVJ9usXXXpDtT1Ryq+tb25xQcVjJKxq6PAa+7zBa5NuenKwJvJxYyYB7Bv feNuxAg9cjSf073esvUfpwvEr6RdqWU= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1750174754; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=bYA4vNkR1STXIkkbeACF7/tlzHC3egoFZWTXFv+IW1c=; b=cuEbhJ1pMJM4XQwzwQGCA/K2HnW6sqtFIeROTdR+HLLXmyZXOvrT40cADYyKF/bJXfBlBK GlMJjOOq/82WjI2oLflloX12pkXvH9XUl3tsKrE2kmm+JjGgbxl4sN+Mvxk3QTOTOxWE+a OFD2xD0hycza4dt/oFGtLydrN+05m4s= Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-575-cJZpHgX6PCmFa7s4-hJ3mw-1; Tue, 17 Jun 2025 11:39:13 -0400 X-MC-Unique: cJZpHgX6PCmFa7s4-hJ3mw-1 X-Mimecast-MFC-AGG-ID: cJZpHgX6PCmFa7s4-hJ3mw_1750174752 Received: by mail-qt1-f198.google.com with SMTP id d75a77b69052e-4a6f64eebecso114521751cf.2 for ; Tue, 17 Jun 2025 08:39:13 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750174752; x=1750779552; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=bYA4vNkR1STXIkkbeACF7/tlzHC3egoFZWTXFv+IW1c=; b=xMsHkp9MamNJeM/Y/A0+Mek6tnxr0cchA0yggUTlk87Dl9aax2BRl54CGzrs8f67fA u1r46WGgodv4c8tSXqgMsU281kLyqYqu4YMlpgR+xhHgUZt199R/vZnvIYaZSpBNJsdd +aKUAwqyJbcE1UlVBb8JrbfGMwmhGU/FGfCfDnRlv2OyN5Mjx6EDj1irtZUwa/s7SkIe IkQhIDH2W5NzEoTF5FJbAYuScQvI84gG9BuVcarYT44OugAE3PF+iSRbggkOG0XSwOiq ++e6LI/XBmhYxueB8tVVWt8WuEOD6rkotLiFnuOs+xNe1n2qxnNQsH6FZ+2W2gnCwd1c ZKyQ== X-Forwarded-Encrypted: i=1; AJvYcCWKWLIlstRdfyZxkgQ0/bCTKX+eA/3ukWVqOfQjNhl8EvQ1tdVCfpf1nRDX9uyQD0nxVopKt+JzQA==@kvack.org X-Gm-Message-State: AOJu0YxoWjn4COYkCh2P6cjcw2pCeGYJkgcU8yuVKyEuaNTnV9TNo0T3 pnIDm99VhpNvuu9SDEbjGTY/zompJhyqrOikKHvWHiCN7s6HONQIVKqKIG0zFQZ94hTwgTN4FOf x5+ba6CJxce7uNprmDzkCBnzcnkqEkpWyjYUNUygWs+GtdwEMQh2R X-Gm-Gg: ASbGncuIr5M0n+46tfFY7lmjflU2YEU9OOmLZyM9RtlU8jAEl84V+2rcsTxZqRJxUAu sUR3oP22gkk8x2z5gEUzlTPUjscdaQvdMUCTAFpkW4ClgCLPf+bKvdLFA9ozf2XLoxPRE3RpYkV L76I0zulJL0YbTNV9eRu/Ure74h818GvGeuoHmA2TS/SlivpOz/ot2b3qolDIZgSFhaqSHIGxPD 4KnBeeGWYQ8uqYeSgEwuGugF1km7ESGgiWz8H0agqt2pBZQSQ27SHOWxVd2wuA2KVKQsXSWuZQL YcFN95QAYcay4A== X-Received: by 2002:a05:622a:446:b0:4a5:a4e9:1333 with SMTP id d75a77b69052e-4a73c656171mr237038051cf.49.1750174752364; Tue, 17 Jun 2025 08:39:12 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEPIM43/kJAMEA2z+DJQLz3Nfj5J/K0A7FFjpnjYR1h2Y4Z5A/KK2hrX/uNeaSpJOy3GeFrSQ== X-Received: by 2002:a05:622a:446:b0:4a5:a4e9:1333 with SMTP id d75a77b69052e-4a73c656171mr237037031cf.49.1750174751109; Tue, 17 Jun 2025 08:39:11 -0700 (PDT) Received: from x1.local ([85.131.185.92]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-4a72a308f55sm62628021cf.28.2025.06.17.08.39.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Jun 2025 08:39:10 -0700 (PDT) Date: Tue, 17 Jun 2025 11:39:07 -0400 From: Peter Xu To: kernel test robot Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, kvm@vger.kernel.org, oe-kbuild-all@lists.linux.dev, Andrew Morton , Alex Williamson , Zi Yan , Jason Gunthorpe , Alex Mastro , David Hildenbrand , Nico Pache Subject: Re: [PATCH 4/5] vfio: Introduce vfio_device_ops.get_unmapped_area hook Message-ID: References: <20250613134111.469884-5-peterx@redhat.com> <202506142215.koMEU2rT-lkp@intel.com> MIME-Version: 1.0 In-Reply-To: <202506142215.koMEU2rT-lkp@intel.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: SXKXjBvRnsN1dYlcmql0KNEou_UhjpPp-gI187Lcj8E_1750174752 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: F353E12000B X-Stat-Signature: nufcxurakhkoxg6bfwk1uwa9gnezu96a X-Rspam-User: X-HE-Tag: 1750174754-799352 X-HE-Meta: U2FsdGVkX1+XcUMiL9O8cBw6WhCRNSsBkvVSWqf5Z4cHk2pDl6brR0aggfETEXyin1f9gSm64QVX5aWtL6X0JAU3uQdv7f0TVvSaWj3XDgSWb4xdAmXU9IevwuXxyisMxRPLGoUyHYPjpDZLooHqlMvQlGvsa8ShZHpWvn+fgm3P3+vdspVYzAPurKj0Hx1gclXYCTj4y/IrahR/ygs62vI0VVuYWM+oJAD0UYIkSnMMCN0cCD80tiyCWILZ30kouuOd/TR0P3GV9zGiZRyc3FXgxAT6WBb1BPYvHjpyiMYUq/lNnLx+gLlyvO0KEpitLdfa1a1JDOSLZbwbAg9K+tcNYgLstRqGVJTIRI+QGwbisRw188wVu0eJ9TF1ymsb/y0uC7VZGAZeUNhKukyIAMWuXvKV66KTe9Ro4giQ7FHVWa/4/NmNwaxU1/SyQLa8ORQk2TIZCZKuVnz4PJzj6xQY7qHFgi4a7ZIIIFRmNDVqkLBGEvRLLfbQMpod6oXEE08IT3Ee4nJzpXrrqXAI//O/aOGOcHw5APFUcpy2vIWM2AnZKjU8x6Ul3PZuf2XagPxLWIcdT9zqsMnrgN+isppByDNdWhVTT2WFGF+grrhWXRSKxqWTCuT47PgG/v4nXBHwas2ny705b8iygKOMwqjmJyjgNy5tjCG+JxD43+VwwGM9kK1naVesVEpTVevlqMyqv0Krit/IO8awjg83myePtPlz9KfZpX5dReCZVMqVXeWEsmkD79DjX2vU7kzb2YnOUdZaipd86zqXmTziIC4EPRoE+sfYw1tfxkJXk+hQS0aAuSo9qcdl1eukPvkNXndbpdrkpbJUtagQLQYQO0qStYPIUdyYOnExxmIxB8WTttZWZzsJLU1JBg0vs1uKXF9EH4g7FLwRV/Lwe4JPWtH4hK6RqkgmMhNII5Dqo8i3eDNBq10mdAuCZX2aVarRz2JpL8xGlW4BSwXUyQ3 syiX6JK1 PH3RQFPWUzdfcr4tVFUB0EEn+plD94Msjc5D3jjJ8IXdpf/P0nNhP4MVYVKHCXLr1gx3Ako/Scg2tywGcgXPtNVj4Lbsl1S3ziRTSh/NAEV63JNvUuyvvcn4wmNQn6G32VZehwzRorbU1ASbp1g6Lo1WQdVR6uPTnuUXQTRHoDGMoxu6HasdL5VDdBcxjAGx+LahXr6TTIfE/YgtFnZaHfngr3F7uu5CViBUM/9vygnvTaxzGayr9+O+s9RN52h8VhGwZluSjzPy5x+agVXwYCrIbxsh58MR3B/FIn52pij7GSmn04tOVPVBTOcyPYZpFNAXk+TnaRDrQZ+bf9zxJnrIDls2ypgNXClhNFEG9mvf3J0YmyshsxJSR6VE9/sr9unA/uAh3JfXirNZocAeIjmwGaxLQJeE4gtB0YAwTpkNk6VzwZP3nvTrD4Kxoa6v7urHn7HxyB3GUz7T7F1OnJBfYMkLRLwfRD5eqZnNnmEHrz9mXHxHZOAKBouxmPGayhE03ms+VprMGYsWY1NkQBMtU8wZ2FdDXwp/X X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sat, Jun 14, 2025 at 10:46:45PM +0800, kernel test robot wrote: > Hi Peter, > > kernel test robot noticed the following build errors: > > [auto build test ERROR on akpm-mm/mm-everything] > > url: https://github.com/intel-lab-lkp/linux/commits/Peter-Xu/mm-Deduplicate-mm_get_unmapped_area/20250613-214307 > base: https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-everything > patch link: https://lore.kernel.org/r/20250613134111.469884-5-peterx%40redhat.com > patch subject: [PATCH 4/5] vfio: Introduce vfio_device_ops.get_unmapped_area hook > config: sh-randconfig-002-20250614 (https://download.01.org/0day-ci/archive/20250614/202506142215.koMEU2rT-lkp@intel.com/config) > compiler: sh4-linux-gcc (GCC) 12.4.0 > reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250614/202506142215.koMEU2rT-lkp@intel.com/reproduce) > > If you fix the issue in a separate patch/commit (i.e. not just a new version of > the same patch/commit), kindly add following tags > | Reported-by: kernel test robot > | Closes: https://lore.kernel.org/oe-kbuild-all/202506142215.koMEU2rT-lkp@intel.com/ > > All errors (new ones prefixed by >>): > > drivers/vfio/vfio_main.c: In function 'vfio_device_get_unmapped_area': > >> drivers/vfio/vfio_main.c:1367:24: error: implicit declaration of function 'mm_get_unmapped_area'; did you mean 'get_unmapped_area'? [-Werror=implicit-function-declaration] > 1367 | return mm_get_unmapped_area(current->mm, file, addr, > | ^~~~~~~~~~~~~~~~~~~~ > | get_unmapped_area > cc1: some warnings being treated as errors > > > vim +1367 drivers/vfio/vfio_main.c > > 1356 > 1357 static unsigned long vfio_device_get_unmapped_area(struct file *file, > 1358 unsigned long addr, > 1359 unsigned long len, > 1360 unsigned long pgoff, > 1361 unsigned long flags) > 1362 { > 1363 struct vfio_device_file *df = file->private_data; > 1364 struct vfio_device *device = df->device; > 1365 > 1366 if (!device->ops->get_unmapped_area) > > 1367 return mm_get_unmapped_area(current->mm, file, addr, > 1368 len, pgoff, flags); > 1369 > 1370 return device->ops->get_unmapped_area(device, file, addr, len, > 1371 pgoff, flags); > 1372 } > 1373 This is "ARCH_SH + VFIO + !MMU".. I'll make sure to cover this config when repost. I'll squash below into the patch: diff --git a/drivers/vfio/vfio_main.c b/drivers/vfio/vfio_main.c index 19db8e58d223..cc14884d282f 100644 --- a/drivers/vfio/vfio_main.c +++ b/drivers/vfio/vfio_main.c @@ -1354,6 +1354,7 @@ static int vfio_device_fops_mmap(struct file *filep, struct vm_area_struct *vma) return device->ops->mmap(device, vma); } +#ifdef CONFIG_ARCH_SUPPORTS_HUGE_PFNMAP static unsigned long vfio_device_get_unmapped_area(struct file *file, unsigned long addr, unsigned long len, @@ -1370,6 +1371,7 @@ static unsigned long vfio_device_get_unmapped_area(struct file *file, return device->ops->get_unmapped_area(device, file, addr, len, pgoff, flags); } +#endif const struct file_operations vfio_device_fops = { .owner = THIS_MODULE, @@ -1380,7 +1382,9 @@ const struct file_operations vfio_device_fops = { .unlocked_ioctl = vfio_device_fops_unl_ioctl, .compat_ioctl = compat_ptr_ioctl, .mmap = vfio_device_fops_mmap, +#ifdef CONFIG_ARCH_SUPPORTS_HUGE_PFNMAP .get_unmapped_area = vfio_device_get_unmapped_area, +#endif }; static struct vfio_device *vfio_device_from_file(struct file *file) -- Peter Xu