From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B3165C71157 for ; Tue, 17 Jun 2025 13:08:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3ACE96B007B; Tue, 17 Jun 2025 09:08:17 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3843F6B0088; Tue, 17 Jun 2025 09:08:17 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 29AAF6B0089; Tue, 17 Jun 2025 09:08:17 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 1C8C96B007B for ; Tue, 17 Jun 2025 09:08:17 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id B380DC024C for ; Tue, 17 Jun 2025 13:08:16 +0000 (UTC) X-FDA: 83564920992.28.4EE140E Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by imf21.hostedemail.com (Postfix) with ESMTP id 3B8D91C000F for ; Tue, 17 Jun 2025 13:08:14 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b="cE4g/NAP"; spf=pass (imf21.hostedemail.com: domain of agordeev@linux.ibm.com designates 148.163.156.1 as permitted sender) smtp.mailfrom=agordeev@linux.ibm.com; dmarc=pass (policy=none) header.from=ibm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750165694; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=p5Zxse7e33GhKYCPPhVo4RKuXPasj0vsR46SoWT4Vlo=; b=8Sw5SnjUXPLdU1t/g6mO8JRqw9q9J/hQ2ZE6r94JL95P6H41s1uSVinbciKvHXwXQYQo91 sNolkJOChoh9RBTfvFZ83ysg2CUsCPi4rJ46hs2KCTaknzkqYytR61bDaqDvXQfGFg5IeE x7oQrnrfY5MGxgkGAihMcsG5SiqpoDc= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b="cE4g/NAP"; spf=pass (imf21.hostedemail.com: domain of agordeev@linux.ibm.com designates 148.163.156.1 as permitted sender) smtp.mailfrom=agordeev@linux.ibm.com; dmarc=pass (policy=none) header.from=ibm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1750165694; a=rsa-sha256; cv=none; b=qTnfD2i59TBuCubSxr7+t1qXi1cU/RtYyVh7TRDD5jd4isINoRRierYWcIdzhoTS+6dwO4 2Pp9S06KfmKC1csCM9+K0c9xAw73GD6zlipFZPuWCRf/XN9TSEkuTkRyvDWaKoXh5AGavm JtZqPzOO0WzgKpLerqpWdzLxlZL7oO0= Received: from pps.filterd (m0360083.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 55H8SBTp017991; Tue, 17 Jun 2025 13:08:11 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=pp1; bh=p5Zxse7e33GhKYCPPhVo4RKuXPasj0 vsR46SoWT4Vlo=; b=cE4g/NAPVIOb4hSoMezqqe56UDUnOWbhBgMDTohME8XUXH frMOH50hyGZB+NuHEmUPTqHQ9anDmljvxvqNUbhoQcO+hj4tQcPxtvm2bwNzGVzN uZsGUds6S+UaGkigEibjc5KrT8v81ptbDv5mIEpiIE+C9S9ZUZBER+AWj1iQs0Ii 9V0BjKlJtYjRvvYtmAzkYDdd98nEzFT5ONP3E+IqerJ5NLSlSjzKTyUwJ9RhiCMc PC/DPy+Ma4URaicfr0svf2qhzm4pqh5Yg84w8rnBkPSM/3KLLIVypD1nPfeU/Jn/ 4IfNF4Ah0AhVgUcwYAUy3Ct7dgdXTJnoE1Y7JCFw== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4790ktgjry-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 17 Jun 2025 13:08:10 +0000 (GMT) Received: from m0360083.ppops.net (m0360083.ppops.net [127.0.0.1]) by pps.reinject (8.18.0.8/8.18.0.8) with ESMTP id 55HCsuMf010266; Tue, 17 Jun 2025 13:08:10 GMT Received: from ppma11.dal12v.mail.ibm.com (db.9e.1632.ip4.static.sl-reverse.com [50.22.158.219]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4790ktgjrw-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 17 Jun 2025 13:08:10 +0000 (GMT) Received: from pps.filterd (ppma11.dal12v.mail.ibm.com [127.0.0.1]) by ppma11.dal12v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id 55HAODNF014278; Tue, 17 Jun 2025 13:08:09 GMT Received: from smtprelay06.fra02v.mail.ibm.com ([9.218.2.230]) by ppma11.dal12v.mail.ibm.com (PPS) with ESMTPS id 479p42b7rp-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 17 Jun 2025 13:08:08 +0000 Received: from smtpav01.fra02v.mail.ibm.com (smtpav01.fra02v.mail.ibm.com [10.20.54.100]) by smtprelay06.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 55HD85Sl20382042 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 17 Jun 2025 13:08:05 GMT Received: from smtpav01.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 3EBE42004B; Tue, 17 Jun 2025 13:08:05 +0000 (GMT) Received: from smtpav01.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 9C93120040; Tue, 17 Jun 2025 13:08:04 +0000 (GMT) Received: from li-008a6a4c-3549-11b2-a85c-c5cc2836eea2.ibm.com (unknown [9.155.204.135]) by smtpav01.fra02v.mail.ibm.com (Postfix) with ESMTPS; Tue, 17 Jun 2025 13:08:04 +0000 (GMT) Date: Tue, 17 Jun 2025 15:08:03 +0200 From: Alexander Gordeev To: Hao Ge Cc: Andrew Morton , David Hildenbrand , Lorenzo Stoakes , "Liam R. Howlett" , Vlastimil Babka , Suren Baghdasaryan , Mike Rapoport , Richard Henderson , Matt Turner , Dennis Zhou , Tejun Heo , Christoph Lameter , Heiko Carstens , Vasily Gorbik , Christian Borntraeger , Sven Schnelle , Kent Overstreet , linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-alpha@vger.kernel.org, linux-s390@vger.kernel.org, Hao Ge Subject: Re: [PATCH v5 1/1] mm/percpu: Conditionally define _shared_alloc_tag via CONFIG_ARCH_MODULE_NEEDS_WEAK_PER_CPU Message-ID: References: <7b912b54cdc12a3437edbd50dbadfc45545641b7.1750143986.git.gehao@kylinos.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <7b912b54cdc12a3437edbd50dbadfc45545641b7.1750143986.git.gehao@kylinos.cn> X-TM-AS-GCONF: 00 X-Proofpoint-GUID: kur0rvAEx469uj5a4sV_PVMfgwluIMH1 X-Proofpoint-ORIG-GUID: qeKjDJ8XglqOooSmeigyj6AVgCg4ohGO X-Authority-Analysis: v=2.4 cv=KaDSsRYD c=1 sm=1 tr=0 ts=685168ba cx=c_pps a=aDMHemPKRhS1OARIsFnwRA==:117 a=aDMHemPKRhS1OARIsFnwRA==:17 a=kj9zAlcOel0A:10 a=6IFa9wvqVegA:10 a=1XWaLZrsAAAA:8 a=VnNF1IyMAAAA:8 a=PyGK1ZaQhdLI2C9XA_0A:9 a=CjuIK1q_8ugA:10 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNjE3MDA5OCBTYWx0ZWRfX3O1mozk6l+7U qZmBnT6UGHDnfuTVGo5MP+yTvQAyDOhlzpgWd5VtyDHCL3hXrZMcmhAIlX+U1oNetUntb6vqTjE buYjbbRwSMPoEnwV2F2dwj4UPObc4qQDFB2Hleqp2iy2CD4ZKtNb6pFL10OEjQkCuqA0tP8mnjk vq+/UYKJEWMsaxR62JJc3xp4pfO5Dtu70cvfdRHqvBOrS04p9ehWoGW0r3G+cfU6VrNfdsGc6K5 pf2ai71sc8+8xZ3mp81VL3GKW0iBCcSxoRl72XqFFfDsHcw9bE/7t+/+78pzDzzkdBvfIOJjA+2 sNfc34cr+IpSGsSri7SE0L3xZbd8CbVvMNphj17GWXhXaN8uFnFEmPdIbE4tojSC+dU8DekLMmD Z7DzGkt1sGK+pU8bsVIyJVcXw4FJ4SMQzxgn1Y5/KaY1+WeGi+Xjild7nh9fMI9JNbW8pYzF X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.0.736,FMLib:17.12.80.40 definitions=2025-06-17_05,2025-06-13_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 mlxscore=0 spamscore=0 clxscore=1011 malwarescore=0 lowpriorityscore=0 suspectscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 phishscore=0 priorityscore=1501 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2505280000 definitions=main-2506170098 X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 3B8D91C000F X-Stat-Signature: zmzzuitdr6an84gwnb689f7jzcwrfuki X-Rspam-User: X-HE-Tag: 1750165694-367050 X-HE-Meta: U2FsdGVkX1/1RQKEyx+BSiJwBdOcOykO9AHWT5Td7Y9UfPOiuEFPxNffkSEep+Qpm2jGgtf3l+Fbz6ILXGaoaJNO8J3d32/Y/CJ8+AOfuar3BXCVY3wGQDdjIULpEcxInO3h+18HEkmd/uHefmeq8xeM+MnD1kFKRuJaFqRDdR5XKmbg/bkOSNWFuW0Q7+uNRUNL1HEaFu5ip6fu+F9wvGZYUj7bRbFDy4DUaKCGLxQE0rWqoiMTa3MraxqiwyA0pSkwpDz/vheRk+92aRedbi31nn8AbGnB9W2YtTY+wN3siDQsk+Pm4VZyMi+xyR7TWTryfO6wl8w8eOrWBq+sVJPAWjn5QDrwZylFB4SuDUZpg5NpwOgB+THrjAce24M9wLha9BNM3IA1YOi8kLHkKAaDaV64MxzUSlngGR7oQF6E4A/LT8VzRnbrjLuQ5vNA91j0d4i1l3A/k00DNxMh1fGjjJNX4MxfwigeLl2etnBXcHcMlR9m3vPY/wdiPUIt446pWUoFpq5HoVxbpkoej+KwxSj5QGZMxfZEJzvFnF5u5z4DM15m4eXWc7Xm0Dg87eFJdWhzJDAsCG4OrMi2TXlKhd8bUDhAvTtxFuA2OVUe65GWrnihAYCdXtQJGCqFMc6Plulktm5UOv+F8zlnm2Peq2JYEcOyRrw/kBg7qQWGCtF7yX181GFQgdRDhp7Sweew7riqvZ0a8uVnpXvAhXEieWZ8n88liymkpCC1J9Mreo90eXaiSC1hKqhiFQendFoqcY/vafMlLjtLXhZ8felFHITbmDZzGl7LeboNGak91Mfy5hx6lKSHgym4NSYppgNJr8iByke4nMFw3H1EU2wAiHZmfLaFLrGjOOi2Ckg5wG7zwhTGVjXw5LY7tXmTRdiYjguBMpzbmWPMtFutlQp2Q1qAhPeYhPEbZHejXFHd85NesgpcPgxC9jXRgsMqyShoYI+goVEbKPBlN4m SZ2wc6sm 4goAWyKZtpCXYTT+nz1O8voZH7AmqwLruf8w4lowi5gV/mRuq0eQfCwk2JfvYnMciziCdbV65+j2lgq3QIEDLawRQCARBQQjGn5xVG0McC0aXwCXNdYRXRHuT14iqOyxFBRAuHCEYmWlJVGbD4o6NwvtLJeqSmQeepd/uaprZxCwyE0mPunTPoLI+gJah2uTQn0TM/pVpqU5V2TpTa18CCQhMQm048fCuCN5YgvtCXIQtMsiABad5kYNCn/ADFv6JIXtUAR1C5vGorwdwctbCCZw1zHduQJGCjRKc2Wknefh6Fps1IOXDhgJSKHR/Ap9iG+C85U7jFd83lKf58uUjmMUyX3T7XV+3BnU2P8fwVLPpXPLmq3sQOHTHtu6/xeePqpobMXR7ey2rUvGDZMFz5ie1oyeLq3rv006fcbVj1pkJoyuZ131e++QHbS2GgJCDppcS X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Jun 17, 2025 at 03:10:52PM +0800, Hao Ge wrote: Hi Hao, > From: Hao Ge > > Recently discovered this entry while checking kallsyms on ARM64: > ffff800083e509c0 D _shared_alloc_tag > > If ARCH_NEEDS_WEAK_PER_CPU is not defined(it is only defined for > s390 and alpha architectures), there's no need to statically define > the percpu variable _shared_alloc_tag. > > Therefore, we need to implement isolation for this purpose. > > When building the core kernel code for s390 or alpha architectures, > ARCH_NEEDS_WEAK_PER_CPU remains undefined (as it is gated > by #if defined(MODULE)). However, when building modules for these > architectures, the macro is explicitly defined. > > Therefore, we remove all instances of ARCH_NEEDS_WEAK_PER_CPU from > the code and introduced CONFIG_ARCH_MODULE_NEEDS_WEAK_PER_CPU to > replace the relevant logic. We can now conditionally define the perpcu > variable _shared_alloc_tag based on CONFIG_ARCH_MODULE_NEEDS_WEAK_PER_CPU. > This allows architectures (such as s390/alpha) that require weak > definitions for percpu variables in modules to include the definition, > while others can omit it via compile-time exclusion. > > Suggested-by: Suren Baghdasaryan > Signed-off-by: Hao Ge > --- > arch/alpha/Kconfig | 1 + > arch/alpha/include/asm/percpu.h | 5 ++--- > arch/s390/Kconfig | 1 + > arch/s390/include/asm/percpu.h | 5 ++--- > include/linux/alloc_tag.h | 6 +++--- > include/linux/percpu-defs.h | 7 ++++--- > lib/alloc_tag.c | 2 ++ > mm/Kconfig | 7 +++++++ > 8 files changed, 22 insertions(+), 12 deletions(-) ... Acked-by: Alexander Gordeev # s390 Thanks!