From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A6755C71157 for ; Tue, 17 Jun 2025 14:00:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4AB966B0088; Tue, 17 Jun 2025 10:00:38 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 45CA36B008A; Tue, 17 Jun 2025 10:00:38 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 34B526B0092; Tue, 17 Jun 2025 10:00:38 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 2815A6B0088 for ; Tue, 17 Jun 2025 10:00:38 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id B3FFE1602AF for ; Tue, 17 Jun 2025 14:00:37 +0000 (UTC) X-FDA: 83565052914.08.811AA54 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf23.hostedemail.com (Postfix) with ESMTP id 0655814000A for ; Tue, 17 Jun 2025 14:00:34 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=WI78ZUD1; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=1GmTaEl9; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=WI78ZUD1; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=1GmTaEl9; spf=pass (imf23.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=osalvador@suse.de; dmarc=pass (policy=none) header.from=suse.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750168835; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=IvVmPtHchY7T1WbOEdnqVsO+lWBeP5pT8i3uT3/gZy8=; b=0nkFTtv1cjmkbaPoyA3PTRJHacjeguFkfWup32X1uFrhoaLd4txIWaKdRUrMBNSDo2QMuu HYhHJhanBHEiioKeAxzh/h7CVoZx99TP6QPT0CyFD8kx5y/a0R5qUQBq/r4sqhkhpxCj5E 9ZQNQDYBRlsZDT41GUDvSxHKQqgSrRo= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=WI78ZUD1; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=1GmTaEl9; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=WI78ZUD1; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=1GmTaEl9; spf=pass (imf23.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=osalvador@suse.de; dmarc=pass (policy=none) header.from=suse.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1750168835; a=rsa-sha256; cv=none; b=ZnDwCXftYoeUAISTcsRsbP58jQuthNneuq8o8o/ZYlF2sOCmMjjLJfUfT1uVKZZ2w6O4aM ZbmMy6upGnVFfzs9a7eG4jekDJiyQSmzbYH69sDaC5LdLT57mi+f95HX+RjcuV1W+ITzsh CVx8atW7AKGTgAFbfarhNZkxva2N3pA= Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 3C96E21163; Tue, 17 Jun 2025 14:00:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1750168833; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=IvVmPtHchY7T1WbOEdnqVsO+lWBeP5pT8i3uT3/gZy8=; b=WI78ZUD1BldogYHz8JLGx2q2LRS0gNKD0IBBgBfH1kPsWrzvUHzmyXYjCBE2GbEXmcv4ky 3w17TiiPH1Jj/PXw8H+bdbJNyqpRBDS+E+oNdmcjrEElyOvtc/LOiMXoDvZzifW7rYotS2 a5Pd6MD8EH2p/9hL9l9YjcYZe+UK7I0= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1750168833; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=IvVmPtHchY7T1WbOEdnqVsO+lWBeP5pT8i3uT3/gZy8=; b=1GmTaEl9u4tHar0du4TbzFZftcwy9odLI3e+I3RF4ZgaX6sXF+6NeLNqNIxVTr8rUcscR+ edQira45FlYGiuCg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1750168833; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=IvVmPtHchY7T1WbOEdnqVsO+lWBeP5pT8i3uT3/gZy8=; b=WI78ZUD1BldogYHz8JLGx2q2LRS0gNKD0IBBgBfH1kPsWrzvUHzmyXYjCBE2GbEXmcv4ky 3w17TiiPH1Jj/PXw8H+bdbJNyqpRBDS+E+oNdmcjrEElyOvtc/LOiMXoDvZzifW7rYotS2 a5Pd6MD8EH2p/9hL9l9YjcYZe+UK7I0= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1750168833; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=IvVmPtHchY7T1WbOEdnqVsO+lWBeP5pT8i3uT3/gZy8=; b=1GmTaEl9u4tHar0du4TbzFZftcwy9odLI3e+I3RF4ZgaX6sXF+6NeLNqNIxVTr8rUcscR+ edQira45FlYGiuCg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id B435F13A69; Tue, 17 Jun 2025 14:00:32 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id UjEyKQB1UWg0YQAAD6G6ig (envelope-from ); Tue, 17 Jun 2025 14:00:32 +0000 Date: Tue, 17 Jun 2025 16:00:31 +0200 From: Oscar Salvador To: David Hildenbrand Cc: Andrew Morton , Muchun Song , James Houghton , Peter Xu , Gavin Guo , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/5] mm,hugetlb: Document the reason to lock the folio in the faulting path Message-ID: References: <1297fdd5-3de2-45bc-b146-e14061643fee@redhat.com> <11a1d0f7-ef4e-4836-9bde-d7651eebcd03@redhat.com> <3eb8e1e2-5887-47ed-addc-3be664dd7053@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: 0655814000A X-Stat-Signature: 67n89bg8gkmszfk74as1uuqadmogdean X-Rspam-User: X-Rspamd-Server: rspam04 X-HE-Tag: 1750168834-420469 X-HE-Meta: U2FsdGVkX1/Ap6+hO3nn5ZcyU7K+PdeiXHT7IDwu5p26W72l/PcM6CtabFOv0UYVp3wm6cJtUY9TzfrIlCXnW29ptJdfiF9W9MXq1uotGyhBPS//asDcewLmriflRrEGGwF9WyUkB37NDjgAGv1ta7A2GEa+ywioOfkJJioGG+tGypa+IRjH1A/+kLEPKaO98meZjRKaqjPqzF8hWXcMrKgximo8Sx700/EhsoC54YXc049E2rcTBdwB/76rGkJL9xRG+xd9QA0CO/uYHN5HCBXqGs2CXGhqOn9uOq4wnFgLzqi9t7sluGpMkgoydTm6Pi5+qwLmj0pZXv+/lak36KIaXXyV6ub8t92+If1K3NBUKxcNJANbYfeuHgfxVmYCMrJP5GzAAOdu70SS2Mbinjcv2Ny6BB0pp5cwoFF8MIMSspasGWEBx3l1ozGtFf2ltn/D7IpXwB7lAEaaFhNVs5a3TTSi3k6dmG/KCWd9GcyDejHgRMjePXtcrLqOoBmpL05PEvxEvrHrnW4BIaBoyTFkQH648jpX/LQ5Da0yfMWna9DSBh5tunE5AYKtgyRlgCsofGMyKoLnRJABAzc37/hugtt/yigw8mVtrR+Tw5yZE+Yfd5RM3QowkFXA1l6McUI4dvvj39YBT/oE0YJZQJ8UC4cY8bUlwTH/PWEoBxP5F5zg3/zZjeLkfjJ9QGv0HJBiZR/NGaCzCZBTx04RXKA+GrNrVAS4Sqsp2trtkVwuwSFErz/4HChJJRQ8AWBvDZTWXdH4aZ0dirBz+LbVTXXFdnO9F7Y4mhIejChTA6T3hLewlziLdsBvmMY9favP4/LqaH8q4fp0NIUZyy+WajFmho52z7iKFCSXVS8aihwFos/4Gk8NUoowaxsPo6bkh0RDhCJLwbjSBA9RBtIJHcAT2zjYceUVh8sxsseo5HV0SC3AYwAIU3M++MjCl4kEmxjzJgg09ia4VwDmdYh BLZmgItE veYB805xEk933VrpbkZy/FPFGsRmXV7TmzwuyxKBTA9INyz6Rv+MJ4Ezf99N/v8pCNmgPeBYBZEUWg0pF1BxeodtCVKm3+LjmtjuvuGjzcWKz/GsnyMLzWUKOsBXM3mYcddWHoSSXlhYbo1dBWPzwoJW0owiq3UlagrbpaI+WRKsIzQ4FauSsqCMiKMZH22LLWeHgyiUnbL9cZ7Od5W7ZVoqesmncdP1IIRc3AASOrgn0PWk7n3xy1TfBPM0KXOiUbA4L9hZK+bRshjnL3y7GU5QIKCGzeHLrP3i1 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Jun 17, 2025 at 03:42:09PM +0200, David Hildenbrand wrote: > Yes. As an alternative, keep locking it in the caller and only unlock in the > !anon case? Yes, that crossed my mind too, and I think that that would the cleanest way. Since hugetlb_no_page() will be the only one taking the lock, we can drop it there for !anon case, and put a fat (maybe not so fat :-)?) explaining the deal. thanks for the insights David! -- Oscar Salvador SUSE Labs