From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 35065C71155 for ; Tue, 17 Jun 2025 05:11:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C86196B007B; Tue, 17 Jun 2025 01:11:38 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C36786B0088; Tue, 17 Jun 2025 01:11:38 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AD75F6B0089; Tue, 17 Jun 2025 01:11:38 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 9CBC16B0088 for ; Tue, 17 Jun 2025 01:11:38 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 664641A17E7 for ; Tue, 17 Jun 2025 05:11:38 +0000 (UTC) X-FDA: 83563719876.10.EDE32EA Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf06.hostedemail.com (Postfix) with ESMTP id 1C03C180009; Tue, 17 Jun 2025 05:11:35 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=xCxiDspW; spf=none (imf06.hostedemail.com: domain of BATV+4b43f024140bdadcbbf7+7968+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+4b43f024140bdadcbbf7+7968+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750137096; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=WPsxJQ/JXacvbaipg//fOLi1s4GO46A+9y4pCE6t2y4=; b=XnMLo2YIjI7/EBFOsvcZDQZYIrE87RY7jOH6VIsB4oHWk1+kBavkvPme46DZOvtOoHhieA 8KQjqbn//x8YRjYAQJI8zdduiM+aKLH8FK9WdAyUFl57Ebo03rfk4ExbP7JkQuG+qRrZj5 Xi3dPGiP9QsMeXfyU+NYiRb1P0xzN0o= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=xCxiDspW; spf=none (imf06.hostedemail.com: domain of BATV+4b43f024140bdadcbbf7+7968+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+4b43f024140bdadcbbf7+7968+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1750137096; a=rsa-sha256; cv=none; b=718mn8Os96tDQV8HLMrBFyCgCHX+shTVQJOC70wF37dlnxknxOTWnL4Ja2w90xo0B5Nj28 HZr/XkoeTJ3oFFzHgB79+77EZaVc7E2ZzBQzkzZKz8wmR9BTY4kXib6bYGfjl5sRxSItfZ Qv8z/M4qaNFsTuge58KL3L+rIHzspBA= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=WPsxJQ/JXacvbaipg//fOLi1s4GO46A+9y4pCE6t2y4=; b=xCxiDspWK79oWST3sh2t7cjJwF 3VtKzrTMd1ZyyEY3Yl1sQsmN0c46B/BWpmLx7GLhCFM16aw7g83BPPAETUVk7GelPlveK5I6sQ8E5 ZxtytrGUEhUU9WZrIuJuMFvFwuFp4vj1nvN+EaRMqHi+KIfudASk+LhjQu9+lmF+F3IZYi7Ydf/Wk JTa1n3Fl61HKkjYiCIqjoqvwn7L3e/9n7XP0zshPQ9POdY/W9y4mdeV8e8mm04X6AEWaAswnDA8V3 ZzeHtQqEnK2Y08dx0p/c6HZZCAPv4hvcg6CW2TmaFuNbCfjDhPGzoMVT4DrV3ggoDKSwdUATpVwPQ nIJAAeQw==; Received: from hch by bombadil.infradead.org with local (Exim 4.98.2 #2 (Red Hat Linux)) id 1uRObY-00000006ERs-1HY9; Tue, 17 Jun 2025 05:11:28 +0000 Date: Mon, 16 Jun 2025 22:11:28 -0700 From: Christoph Hellwig To: Lorenzo Stoakes Cc: Andrew Morton , "Liam R . Howlett" , Jens Axboe , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , David Airlie , Simona Vetter , Eric Van Hensbergen , Latchesar Ionkov , Dominique Martinet , Christian Schoenebeck , David Sterba , David Howells , Marc Dionne , Alexander Viro , Christian Brauner , Jan Kara , Benjamin LaHaise , Miklos Szeredi , Amir Goldstein , Kent Overstreet , "Tigran A . Aivazian" , Kees Cook , Chris Mason , Josef Bacik , Xiubo Li , Ilya Dryomov , Jan Harkes , coda@cs.cmu.edu, Tyler Hicks , Gao Xiang , Chao Yu , Yue Hu , Jeffle Xu , Sandeep Dhavale , Hongbo Li , Namjae Jeon , Sungjong Seo , Yuezhang Mo , Theodore Ts'o , Andreas Dilger , Jaegeuk Kim , OGAWA Hirofumi , Viacheslav Dubeyko , John Paul Adrian Glaubitz , Yangtao Li , Richard Weinberger , Anton Ivanov , Johannes Berg , Mikulas Patocka , David Woodhouse , Dave Kleikamp , Trond Myklebust , Anna Schumaker , Ryusuke Konishi , Konstantin Komarov , Mark Fasheh , Joel Becker , Joseph Qi , Bob Copeland , Mike Marshall , Martin Brandenburg , Steve French , Paulo Alcantara , Ronnie Sahlberg , Shyam Prasad N , Tom Talpey , Bharath SM , Zhihao Cheng , Hans de Goede , Carlos Maiolino , Damien Le Moal , Naohiro Aota , Johannes Thumshirn , Dan Williams , Matthew Wilcox , Vlastimil Babka , Jann Horn , Pedro Falcato , linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, v9fs@lists.linux.dev, linux-fsdevel@vger.kernel.org, linux-afs@lists.infradead.org, linux-aio@kvack.org, linux-unionfs@vger.kernel.org, linux-bcachefs@vger.kernel.org, linux-mm@kvack.org, linux-btrfs@vger.kernel.org, ceph-devel@vger.kernel.org, codalist@coda.cs.cmu.edu, ecryptfs@vger.kernel.org, linux-erofs@lists.ozlabs.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-um@lists.infradead.org, linux-mtd@lists.infradead.org, jfs-discussion@lists.sourceforge.net, linux-nfs@vger.kernel.org, linux-nilfs@vger.kernel.org, ntfs3@lists.linux.dev, ocfs2-devel@lists.linux.dev, linux-karma-devel@lists.sourceforge.net, devel@lists.orangefs.org, linux-cifs@vger.kernel.org, samba-technical@lists.samba.org, linux-xfs@vger.kernel.org, nvdimm@lists.linux.dev Subject: Re: [PATCH 03/10] fs: consistently use file_has_valid_mmap_hooks() helper Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 1C03C180009 X-Stat-Signature: 13kt8q5ar853d3cd871iymsoh4k1e7uh X-Rspam-User: X-HE-Tag: 1750137095-449107 X-HE-Meta: U2FsdGVkX18Ish7jgAQiH92cgA6+qE93DrsiCjyx650mMDB5nJrlHHn6V3eaRY2kIsXtyVtvAKJg3XKlFm50MhYdzKp8lwTn0p8kdgugUF6q7hk7bYdUNvSn4CSdOcLirdFFFBmMKieyv7pmICn92PKPSRY11BwOMJOTWqKRPYJl9kVo7R9uXjZpDdmf+FxGRrTp6RaHwL2gZqiAURVFA+pqFx7lKHJpPzd22xJGWpqRenF/RS2ADKOR3HD5AD5b2yU6UlOAh9vCjvA2iY9ywsruQx9H/B2L+uxdRTGUlMB9qDHZWrhIG9YY+o05pRKxPJSDHqymn8Nw5A+P+0uxFCA0Nw5FItTEqFWujM507U/Vr8hSwk1m0+kCcprNhMEn8QRMqMDomxavpKNUR1ycJPbS6ZEU2zFsD4R9wVEs8fLvibxU7TW1Mwguz79d5nmvNo5p7cYv7oz5RNHCVyFtgOR1bwIqeR1GOlMbERvn1weHu5Iqg/eVCsG0b8jni8SQd9uDe+P4rs1KpregkqGo01nJk7Ti7PQNdVG0bt9B8ZvAI05FRAdkX0sOebMUNu0u/2/m3NnxILyq5lpzhtWUZQABahl4ri2qH6EBopRG019X9KZPRhDePF3BbIICmaoP9TBdtdPtILqss8mBFBujeZXgdR9rboCMypEgn9ARmC9dFDcPwtj9dSKcG52qgHa2mPPp4rdtbxfVNQD6w2sDYthq8j4ecOm5NgHWh0LelXO6EeVrHMgkaBblXJMTOBFIo4XDJ8bwkWgeHWzZqX6bQ0Iwy5pdRYuBwfJ9kPK3mDmZGRGkNgO1hAs43Xvvau2ZbK2QuwhcjExT+Xjg6s6IET8zZXrAPKV9Nv1P6XOF4jhylEbr73bHOgGd4lAz70gDnuxCU82VWTNBd00hFwCHLM3w5WpDPo1MWOYHnltfM87di2kxB8SzwzQwg/8ca4apuhVotOFle1hMI5R+/85 C4UbNKYX /+yBr8LQJTuzePpLhVRgkxPs+tsWBElZz4GDtR8vMwuSD6hr2N2g5nKy2Vxedc1wwx6VMblA7xoDFP1q9qrMQkeTfxkqtytuo67k6sSf+T1f3OLrmiXqWnR8PrTzZg4t6LlJMytRB0pwBqYI55WaHqys0pcrcDi/ETzidOOWF9K7vfx5cu61oBaSJKywXKKxpbRU++suCVytD+HBt7hVJRU0CgYA23jg/z83Aaodacgd14Vjj/wegzxJXABQ9IuILFWYVMUHdaCVZ3u69MQIMBMplV7iI7Aj+Obzz3vUjgGj9/WUlMSzbBMIBWG95BT/PEZRo1BnHhTbHeIvGd9Jkzs6QKsrITUspXlPlAB9dKLHZwA+2CrL8L0VrPxNjpgh4I72Z4iGl0Qm9dnVo8iE1FF9A70c5XZvRoRrvmRaQau5rKvpogDleuP3uKqAYi7TmND0sRK1WnKXvTJ+pX4rEBr2rn6v/FFuLV5j/FBWR6uCDWhWvAoxtYV1oDRZy2PmuxxW7mWswnwwejGaszufB3Wcot8dwTxsPKGNIYYMLGQUOAWgc5KRLyDWETxhePgONMPge1Av51FN4E6yrPgX7e54q/ILydPx2hR0H X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Jun 16, 2025 at 08:33:22PM +0100, Lorenzo Stoakes wrote: > Since commit c84bf6dd2b83 ("mm: introduce new .mmap_prepare() file > callback"), the f_op->mmap() hook has been deprecated in favour of > f_op->mmap_prepare(). > > Additionally, commit bb666b7c2707 ("mm: add mmap_prepare() compatibility > layer for nested file systems") permits the use of the .mmap_prepare() hook > even in nested filesystems like overlayfs. > > There are a number of places where we check only for f_op->mmap - this is > incorrect now mmap_prepare exists, so update all of these to use the > general helper file_has_valid_mmap_hooks(). > > Most notably, this updates the elf logic to allow for the ability to > execute binaries on filesystems which have the .mmap_prepare hook, but > additionally we update nested filesystems. Can you please give the function a better name before spreading it? file operations aren't hooks by any classic definition.