From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B6555C71136 for ; Mon, 16 Jun 2025 11:45:12 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3F08D6B008A; Mon, 16 Jun 2025 07:45:12 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3C85C6B008C; Mon, 16 Jun 2025 07:45:12 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2DDD36B0092; Mon, 16 Jun 2025 07:45:12 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 1F95F6B008A for ; Mon, 16 Jun 2025 07:45:12 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 5913A10178E for ; Mon, 16 Jun 2025 11:45:11 +0000 (UTC) X-FDA: 83561082822.05.4D5338A Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf30.hostedemail.com (Postfix) with ESMTP id 144B980004 for ; Mon, 16 Jun 2025 11:45:08 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=mYxvLLWL; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=9dV2Pfdd; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=mYxvLLWL; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=9dV2Pfdd; spf=pass (imf30.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.131 as permitted sender) smtp.mailfrom=osalvador@suse.de; dmarc=pass (policy=none) header.from=suse.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750074309; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=cQ1bUAfux7Bc+S0s8QLpyx6GcxjzeCaMMaG6o/PQiwY=; b=2jhyVT+YtHGG3pMpTaYfczPWfmCumEC4qUYTi2P2t7JcihqDJCJc8lKYpiJTLrbd1ml09R aEt3SFosG6tM2DNi8FSyC/Xd24i2wo4zv5jF1/vzeS5LxW1nAj9a4NC50ICP7lxxgVsu/Q Tqn7eH07z19IDpZpZIv5RXjkRInjmq4= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=mYxvLLWL; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=9dV2Pfdd; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=mYxvLLWL; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=9dV2Pfdd; spf=pass (imf30.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.131 as permitted sender) smtp.mailfrom=osalvador@suse.de; dmarc=pass (policy=none) header.from=suse.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1750074309; a=rsa-sha256; cv=none; b=Bw5DOHS7Woe1/X0Nrky83G/YxWdyH1mhncd7aBVbGP7PDoTnG1IMyfOtimwk+ny1W2XBU2 isiPwB9mGcRybk5laLaG2cjQzk+jDjotqgpZM6d8j3mxzq4jixOPWNDCHhapRwFP9IxOAW yZkwtPIs1CPzkA2nbvGQDtMov+NVeeE= Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 439861F45F; Mon, 16 Jun 2025 11:45:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1750074307; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=cQ1bUAfux7Bc+S0s8QLpyx6GcxjzeCaMMaG6o/PQiwY=; b=mYxvLLWL/MZGfYqrHTYfUBtRHsoSZxnndetQVTv+TwTJXRHQVyWupKD7jmtq9h4Rlzj1kx XjptyYZcbhZWPCrYri6bjwP2gNeiVwXMQlT8wSHt62E5Bq8FFcAfAUTDgSNISUXWWcpGiU umRResmrtQIe9I1NZL10Mq2VWhNTtl0= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1750074307; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=cQ1bUAfux7Bc+S0s8QLpyx6GcxjzeCaMMaG6o/PQiwY=; b=9dV2PfddyhFzzUXqVkx/nAfmaeqBz0jZKBnBQFbvzIO6jHtxuQ1IgGlPAr/33VYctMwnLr 51tSFgLI6jCQ9WCg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1750074307; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=cQ1bUAfux7Bc+S0s8QLpyx6GcxjzeCaMMaG6o/PQiwY=; b=mYxvLLWL/MZGfYqrHTYfUBtRHsoSZxnndetQVTv+TwTJXRHQVyWupKD7jmtq9h4Rlzj1kx XjptyYZcbhZWPCrYri6bjwP2gNeiVwXMQlT8wSHt62E5Bq8FFcAfAUTDgSNISUXWWcpGiU umRResmrtQIe9I1NZL10Mq2VWhNTtl0= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1750074307; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=cQ1bUAfux7Bc+S0s8QLpyx6GcxjzeCaMMaG6o/PQiwY=; b=9dV2PfddyhFzzUXqVkx/nAfmaeqBz0jZKBnBQFbvzIO6jHtxuQ1IgGlPAr/33VYctMwnLr 51tSFgLI6jCQ9WCg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id AF00E13A6B; Mon, 16 Jun 2025 11:45:06 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id dL0lKMIDUGh7eQAAD6G6ig (envelope-from ); Mon, 16 Jun 2025 11:45:06 +0000 Date: Mon, 16 Jun 2025 13:45:05 +0200 From: Oscar Salvador To: David Hildenbrand Cc: Andrew Morton , Vlastimil Babka , Jonathan Cameron , Harry Yoo , Rakie Kim , Hyeonggon Yoo <42.hyeyoo@gmail.com>, Joshua Hahn , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v6 03/10] mm,memory_hotplug: Implement numa node notifier Message-ID: References: <20250609092149.312114-1-osalvador@suse.de> <20250609092149.312114-4-osalvador@suse.de> <2bec8b53-f788-493e-a76e-1f804ed3aa0c@redhat.com> <10c87a0e-c9fe-48fe-9bbd-16afd244b4ec@redhat.com> <360f2f04-4542-4595-bf36-c45ed10335af@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <360f2f04-4542-4595-bf36-c45ed10335af@redhat.com> X-Rspamd-Action: no action X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 144B980004 X-Stat-Signature: zcwt76rtpgjrbombi4x95e55m4ks3hkd X-Rspam-User: X-HE-Tag: 1750074308-637364 X-HE-Meta: U2FsdGVkX19MzMNfHSmjue5v0ZL0khw/YWX3MIhDOx3V6MmCpINHqQCgH7FN8nKsspcODbOimGDV0f0IxHyCYbPeaUmuxx7Hz4t5SsRsy6ED/B2fdkDZ1eFpomkOb7l+Q9mxql6ueJ4wpl5Yzwo9SYEIm6zhcIaNWE3sbQZ5F8tJdRMVBACq22PEncSurmKtSwGJmqFoQyN9zOGo5JhBtSomT3eLJE4xGljL6Al1lGXcfHhF1AJKzbaGKEXaFaFYZTWgV9AeSY9U64Xc0/Xy96K7x/NeXzG0h3s9xZhA9yxuHXIuhAVHZ1zkEOk5fFyIJZHnxJmme4Fprc/+2uPwCCVSZVcCMI2gnqn4mm6LIBmVRnpsHyaqw4DRij+BwWI7uIXjDL6vHyEhwe3pQsN325HYUT4bJwuYuwyB3EyXRASsC0UfhrTtWI8KZbe43bkjoVHfFHSxwA+LVA9pb/ZPSdtufzxQ2ByuTYJc5agHRWbltuQA1bR9a82OjxAkigmlDcKJoAUi/2LFJBZ1ll2+kHFIvazf4wxa31JUYLfhW2xnX4SUEdLG9kNMYRF5+eBZVadOPB1KsNNJ13+t2B+azNOTCaSilDZKlSjCgQsFI6JTjXA43KBhuLl3XZKaR11x9q5jpEYPwHXACnB0PdAy4HdeFOMU9L3pT8Cya4tD7XIGB7L3HH4FCIA7F4aqhZ5Ut+rG3YyxugcUtmNUiedCF6muOBmYO0pgyYOZ3g+/4wPCDgwWLPb6qyDaJGWNnWaGxYs9rmCquF6BHYFhz7pQGRjsPVhKh7tJxtOt/Xire5cw3jYvXA6k8S4NI3OWF/lAh1bn6GWkkXPDsEwCIqZIt8lsV3BYiLn3MzgP4cqfttS5hfA4NAc8OLnL+5JMp+qdmKLxAYWTbtaDHBdZCyyVmJH5879BtXlsBgAf1SoeeDDWa2wMKuw+5g3le+TQ6ASy4pKIn9uabfjuwjMlGh2 OGQmG7+k Mf7VLb3oFy3wW/yytJN8SsCxo25TVCbqQitvNgutXAbCGHwH+RAWnrflHGiJ5VKimeNRDjllyRxa/p4rjqfv29DBv+05/uPxFFTtoNrgEGgzs4ip6zqZjmF9uUih3BtQ0bsbgklGyeUzKBOd79NVXvrNkVdlk1kPjC2lQ1UQTHgvePBTYeQotzNf3ePe/Ax6Hd0ZMFyrVAeLZaN4kc7yfIDy0FNjSoqX8q/GSjHWcMW6y6hOo5puVnXxIHYjdPqaDkvBgar3HSqrRcRJmomQfhi5r3uhDVCYCy7UJEVD2I71n4HyqYBT4MjTN6Nt3szYk6+zAqP+l/WVTh2PNg7t2b+GntW1vNWqt71Gi988VvLZGjHV3sHuNuUW/wkpDtmQQyw+9KDnuwMC+z8ns+4mSyJiVIw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Jun 16, 2025 at 10:52:31AM +0200, David Hildenbrand wrote: > Probably worth checking, to make sure we don't have accidental bugs in there > ... I did a quick sweep, and we should be cool since users of the node notifier don't really use *_CANCEL* action. Only ADDED/REMOVED. Now, users of memory notifier is a different story. E.g: page_ext will call offline_page_ext to mark the section->page_ext invalid. online_page_ext does: base = alloc_page_ext(table_size, nid); section->page_ext = (void *)base - page_ext_size * pfn; This is fine, I think, offline_page_ext will not mark it as INVALID because section->page_ext is NULL, so we just skip it. This is just one example. I checked some others like kasan and hyperv and they seem fine. And anyway, the we could already hit this situation with MEM_* notifiers, so nothing new. I'll just make sure to document it so new users take this into account. -- Oscar Salvador SUSE Labs