From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 776D9C7EE2A for ; Fri, 27 Jun 2025 15:52:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0616F6B00AA; Fri, 27 Jun 2025 11:52:28 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0131B6B00B8; Fri, 27 Jun 2025 11:52:27 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E43E26B00BA; Fri, 27 Jun 2025 11:52:27 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id D33A96B00AA for ; Fri, 27 Jun 2025 11:52:27 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 948DCB6066 for ; Fri, 27 Jun 2025 15:52:27 +0000 (UTC) X-FDA: 83601622734.26.C08D679 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf14.hostedemail.com (Postfix) with ESMTP id E9E23100006 for ; Fri, 27 Jun 2025 15:52:25 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=Z0ceVbAZ ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1751039546; a=rsa-sha256; cv=none; b=4Q5EFQgOWHVo/BYXV9iNA/f4yfq7s+5phLscUBg4vkArweq5oIHLqKbe29YYAJKZ57GRDN 3U6QWyadHOblrOeVEiddBLxkOYV1UI9b1DwToQIrw4T+FDdwXjDhR9kBXa//+0f8ecvOS5 SmjljYb9+rtyulBBOSvHq+8uKonAidU= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=Z0ceVbAZ; spf=none (imf14.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1751039546; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Z+c/vMVBxvVliRM5Ba7u5qi1BNZCmTnatXuCT2DSf3s=; b=UoqN092S4U2qY4qQCnX/ycospboWzJDlDRZ6LERfC6uL66x/Qv7etBFWVi6cb2aK0Ac5nP ZhbaIMq7GcQu+mL4DFK6RE6ZEBvNN8xAkJOj9Jb512eWJ4QXdTZ0S4U2CVpZT15jc05JPg VBxHfObMassKV8P7mrGOnvMa/YWsSlk= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Transfer-Encoding: Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Sender:Reply-To:Content-ID:Content-Description; bh=Z+c/vMVBxvVliRM5Ba7u5qi1BNZCmTnatXuCT2DSf3s=; b=Z0ceVbAZOy3oDx3Jzp0zWCkcEC 5+/Ux5Woml8GdpSfkIhVTxnoD/1Ma1995s/H+9SLhMV2WFdH9AnA9VE6AMi5lmgAUc/GeLJBH8dv8 E+M91T3jrx+/xDUjfEcpMkKP2yciCidFInvaEizsorLfYjYs4vSQqrO5c8ROi7216sQU8i31mcYAN tujVt5eFpXiIQNYSJqIuB4VKAotXXyXWuUkTHDWgreQsgQoRPqOcBBnTBM8tXQMMJZ9gn6FY62Phu Xf2fu73K0hPBw9c5br2aSuebLqlrVwLN+UclnVhjVRg3/Iu1SkfzhW56ODmF5CZeO5B9qaQwK9fRF +21HmNKA==; Received: from willy by casper.infradead.org with local (Exim 4.98.2 #2 (Red Hat Linux)) id 1uVBN9-0000000EQf9-17Tf; Fri, 27 Jun 2025 15:52:15 +0000 Date: Fri, 27 Jun 2025 16:52:15 +0100 From: Matthew Wilcox To: =?utf-8?B?6ZmI5rab5rab?= Taotao Chen Cc: "tytso@mit.edu" , "hch@infradead.org" , "adilger.kernel@dilger.ca" , "brauner@kernel.org" , "jani.nikula@linux.intel.com" , "rodrigo.vivi@intel.com" , "tursulin@ursulin.net" , "airlied@gmail.com" , "linux-fsdevel@vger.kernel.org" , "linux-ext4@vger.kernel.org" , "linux-block@vger.kernel.org" , "intel-gfx@lists.freedesktop.org" , "dri-devel@lists.freedesktop.org" , "linux-mm@kvack.org" , "linux-doc@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "chentao325@qq.com" , "frank.li@vivo.com" Subject: Re: [PATCH v3 3/4] fs: change write_begin/write_end interface to take struct kiocb * Message-ID: References: <20250627110257.1870826-1-chentaotao@didiglobal.com> <20250627110257.1870826-4-chentaotao@didiglobal.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20250627110257.1870826-4-chentaotao@didiglobal.com> X-Stat-Signature: dzuwd4ufhaem1sg76gsjzapifz3eze56 X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: E9E23100006 X-Rspam-User: X-HE-Tag: 1751039545-341164 X-HE-Meta: U2FsdGVkX1/L9h7BVi1V5mMs8ULUqwt7gkhFIcY2LBPmoli4Q+yOti0UD24n+zCLfisV7cVVtohRlgvyaXizxPd5hgjEVM7ILUbEMzq5g3nmGDDj7Nlg43umRbpUNpTumYNKqlmbQpFaLBw+waM0jReikwqreuAtWQj+rXlPBAFsZfRnrUhTR0PGpwxkH8hnhyclvNbegJWSf7r7/8uR0h2B6rNkJW8OTEjWjSqB7SmVtfXX+8FgTAg4koxpuffUKUD2gmM1mql3JsD7uj5hnMDwzDdBJ3296E/WBmthJCdKWe4ML8Fu57Rk4xhjyvvy0jZhYdTMmPzRKiGpcGbeCVBmxicFoERZVL7vH20pK9ybodSwD2wI7vkjHJ7uqX+piA/KCA39W86dpXAwbN29wiXoB9N2pPONnEa57XN6SFYt32CDci7x+g7VjbNsJddLzVJXfDldHrsRm/E5PkcbwJNwQt5ImUFs43VohPoCoyYIrSo67kMQiUdZdsuGyo250T1RRNnS3ANlZqhaD0pArLn7Np1Li7H/Pw/PsF8Hh7rxoS6nMANg0n/esiUr1SrIpgpfd6p4d5xLL4RLme9r9WQsRy406ifjlb4Ou3HDf4eG0b6FY83A/e+in/p1rvt41o+LmyhMgOuOKcD5t+xuMLFltGoqc/svxAJ9+VnHIORtyLZiBHQVFDBR89pvMxPYtSnZWWsJu/f3zvly4elfdh4vullsvYX7EPg4JrdNKBvY9ywtOPGNqSVqbN+str9828PHPKiMD2cogXIv13rpxPQb0znIQUA7oIAKtccF2ZZWAMZnVJ9gFfpFEpcHsv2G9+l06Tacpe04lvp0L48lJBq+WCJodZEcBq9jlp0F7SVcDVdGKr7WGXS0cmh0549YBN1df9VYDR6OeUgc2GBrGfCTjDWk9uo8L2sqqbAhVK4iWixjoc4FCxvcSENHY5DrbhNC2X90itLS5a8Ekgv SAw9awhZ /5cdmnLvEGUfAF+paZEQM13D49L92RDL1TtjAngSXz7XM3kcErPhyEBhHyd5ICT98jANrSftvBsViyUb1KMK0FmfOBqL8gnlYG7b1JgT0kj43enga80Nqqy59SCW4GWqtitKmF55y96qMDOULOfbYw5wTXerVsZomxZZldC3hmiU2Ef7NasUquvUq/OJrWum2zGCtpOQbWZfQtb/DtWDO+4G+h55XPKBW8gnVn0rGDfQqhQc6WfPjXgCHMA+CQz1/7JceIR+V1Gd8jVirEjjMabWIR2jUA3OJimVD X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Jun 27, 2025 at 11:03:11AM +0000, 陈涛涛 Taotao Chen wrote: > @@ -1399,13 +1400,10 @@ static int write_end_fn(handle_t *handle, struct inode *inode, > } > > /* > - * We need to pick up the new inode size which generic_commit_write gave us > - * `file' can be NULL - eg, when called from page_symlink(). > - * Why delete this? It seems still true to me, other than s/file/iocb/ > * ext4 never places buffers on inode->i_mapping->i_private_list. metadata > * buffers are managed internally. > */ > -static int ext4_write_end(struct file *file, > +static int ext4_write_end(const struct kiocb *iocb, > struct address_space *mapping, > loff_t pos, unsigned len, unsigned copied, > struct folio *folio, void *fsdata)