From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 73A2DC7EE33 for ; Thu, 26 Jun 2025 18:28:37 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BB6718D000C; Thu, 26 Jun 2025 14:28:36 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B8D928D0001; Thu, 26 Jun 2025 14:28:36 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AA4A88D000C; Thu, 26 Jun 2025 14:28:36 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 988638D0001 for ; Thu, 26 Jun 2025 14:28:36 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 42A1B588B3 for ; Thu, 26 Jun 2025 18:28:36 +0000 (UTC) X-FDA: 83598387432.23.21069D5 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf06.hostedemail.com (Postfix) with ESMTP id F07D3180004 for ; Thu, 26 Jun 2025 18:28:33 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="RWIWqK/Q"; spf=pass (imf06.hostedemail.com: domain of peterx@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750962514; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=/Ov4Qfp9MektJ9nsSeT7fzwz52P8rVreuDPUuWKEhKo=; b=BIXIL8PCgZ5TBlDxthoFol5gsgR0H3u51lid4Zl77orMA36ygfxvBXTS1ibakslKtP5jDX bsoutN/eN6cNtmDhaQJsdHHs1DrygVh28qVps1oX4VymRC9pG9CmUe1SvsQeJAET455m+Y J3BnX6y37LpkspRTZ0EhAG9XablPb3A= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="RWIWqK/Q"; spf=pass (imf06.hostedemail.com: domain of peterx@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1750962514; a=rsa-sha256; cv=none; b=JorhxN1iUGG09qbBBNSFBiwzBSTDSsETTFqctnGtlYr4siRTt/OiSDTxjwjvHIZI7ggOyo ItR3g9aB+GYiTdDl3kA+lYVYKypW5AvZK2QVSZslJadEy0Hnyg3OygeKKBAh92DcYi9s0a e7B8ZQ/z9tUcDf+7ikg/JmDVBjXStk4= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1750962513; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/Ov4Qfp9MektJ9nsSeT7fzwz52P8rVreuDPUuWKEhKo=; b=RWIWqK/Qz6JE5afFDIhBGq4VNjQltF23Psoa8HzASUQX6kZIiMZpvrBC00Kc4i3nPstoPK N/vB3X+yrunGwr3DLj+ET3/5ng/1LCAMEvIajQ9uir4yO15aCX2hSsCanmD42IrvD+/A9m nOPNHYVEgASWFrQPOo8O1+SNjTwS7BM= Received: from mail-qv1-f70.google.com (mail-qv1-f70.google.com [209.85.219.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-381-xdCLAfkcNnKsm7ETf8MICw-1; Thu, 26 Jun 2025 14:28:32 -0400 X-MC-Unique: xdCLAfkcNnKsm7ETf8MICw-1 X-Mimecast-MFC-AGG-ID: xdCLAfkcNnKsm7ETf8MICw_1750962511 Received: by mail-qv1-f70.google.com with SMTP id 6a1803df08f44-6fb5664c771so35839936d6.0 for ; Thu, 26 Jun 2025 11:28:32 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750962511; x=1751567311; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=/Ov4Qfp9MektJ9nsSeT7fzwz52P8rVreuDPUuWKEhKo=; b=nim7rTEoilNAJiBgqJQalknAAgBQMWlei20LfV9p/O3rPAPyGJz6EiL9MUGFnRJlGx p8bLbOTEjhjzyoiN3Vo3BDLC+EbysQ6bZIOxEMr3IXjudhGE3Q0rDfSKAX70kJI6VGgs jttjqJtzjvTU4ZkZMrKoSmKRRsvArx98EwEvybTSepeoZEFYXqB/srHcknB08NrU3tZZ wZrl+dkGBkVivkFdW8vaFasNzA2/A3DlUchGyydKBk5jUTueZWKi/T7a6Buxw6e99r5e Joan17dFb/GACUTRxEMQPiseedrByEEzm7xZa6qyfqakejodkFdrBRve6bovWPioFqfp rsXg== X-Forwarded-Encrypted: i=1; AJvYcCW6KOJbsAqEPXtqgy2RbdoXnYUKRSpR5QuHZNhcRGN8SLanIAkGK6EmfvX2RaTkXYDYX+Bu8bt2dw==@kvack.org X-Gm-Message-State: AOJu0Yyokz8DLS6JqZZ5NEpZgk9UGyXzmUCzN3OqKCZhyj4uSVtFufdn wwOBsJdB5KgFvb7q+NFvEyKSL1gtsFkoL77vTkG5lPpcwbhe5UCTphHId/UCnkI0rWoJmOrHJNW h1CYNGdOZJ+IipV3su1MwxN6XGY4oLURJjGP2Ilv/M+TNYE2DOw5BahDQW0Ny X-Gm-Gg: ASbGncsKQ1RXZuMtt29vVz7F4j0ca6ScHLn58B+YEB5tmGid62tSvQtdlt6fnX6wKKD 1KaUXIfP2JWwZFMUmepQODCAcj9zcJhpYnyJDOTKlOcg0Qru39efg7GidjyMSUhb2QEOfTxDqSa MVZm51gEv4NKiF7T67VdCOa+JespSRNzdqUmBLfPdEutAk3h+MTBYnTkimmUeQJk7k0onStu0w0 U18bgd0Jw5Myql3Njy+wMXGlOv5gFckCzp6/8KGm6lbGu3IoEG4xGdz0lqGTkVJIEqc0v0mBEnN +XKLiLFU6EQzLQ== X-Received: by 2002:ad4:5ba1:0:b0:6fa:fb7d:6e4c with SMTP id 6a1803df08f44-70002152d40mr9739116d6.25.1750962511071; Thu, 26 Jun 2025 11:28:31 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFV+2skYgdvy+Y9xdfWy6mAPgCBWnYkgHMsns9U7YqlRGI3AQZf37a5W8SXZBpDauurnthQFA== X-Received: by 2002:ad4:5ba1:0:b0:6fa:fb7d:6e4c with SMTP id 6a1803df08f44-70002152d40mr9738656d6.25.1750962510377; Thu, 26 Jun 2025 11:28:30 -0700 (PDT) Received: from x1.local ([85.131.185.92]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6fd7718e0afsm10507856d6.13.2025.06.26.11.28.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Jun 2025 11:28:29 -0700 (PDT) Date: Thu, 26 Jun 2025 14:28:26 -0400 From: Peter Xu To: Axel Rasmussen Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Andrew Morton , Ujwal Kundur , David Hildenbrand , shuah@kernel.org, jackmanb@google.com Subject: Re: [PATCH] selftests/mm: Reduce uffd-unit-test poison test to minimum Message-ID: References: <20250620150058.1729489-1-peterx@redhat.com> MIME-Version: 1.0 In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: UcTVKEOlrPkvU5XKCooYXaXx58jj3JsRH0_ZVkMTtH8_1750962511 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam11 X-Rspam-User: X-Rspamd-Queue-Id: F07D3180004 X-Stat-Signature: ztd9khemofoagd59xa4kprxh8c8hwzwy X-HE-Tag: 1750962513-592152 X-HE-Meta: U2FsdGVkX1+Vsw/NA+LvXcd6pWF4JdD7KaX6Xe+NIIXiDNz8jluM0lixBrVDOIix4Y8rwcFAkYNJVCcyQGLDbeBrCHJP6IpPiaGfIiEYcfOt+tAoz5w0p3hOFXRt2nRmxImuf0qg2TsuPOrpdbX0rdjoFQntpaNKObVAWPUKMENkXz86KfslsvGgQeklCZplvwbjWscwWDUzyfpwbVpfkXf31F4bjGl30nfHA/N6CNoZLKsy95pmvIRlzIy/oGuvVPRbPK9be1RF7LswIFwU7K5T0xj+3OaahS6iiRRw6jUDilM1Xpj/vTCD0Ut6hlcE9+K4FNcIHu1Hu05rdoYKcJtU+4Mwon733sMOyTm/zHJ8g8R4M6hAH1EJs1/D5MXTeOr6ac8C0Ucp7h4/TSIWCBqBiYpGvFNDRx2i1qqHy6zC8vnieLqsVQ7rbm416U7q1YZ5C/o59PzS7CFSdkLrujHdtzeSwmlTBYXOgaTgSzsNxKrnH+t71xwT0eunTNbdHgUEcr1oUeRTr8Q5YaSubL7CjVdvuESsa29V7RZ5OIRUgndudhBHpribWR6tqq0dKsscK20DF8SXaOEvnk/a5olYx54O1C4uH/3hc9lyro9AN4/loYU2l1kqwVs38CCexe9OnSxUOtjFoyx6nWnURpgj4LMRwfvSA4s05Ll9dvc7TD6h4rqrYQ7qVBHPKocnRcyQu453KU1gjnnF7UiLZGe4bvzqO944MQzki4soqVaZ+Ztakw0biXE6bXL1tNcEWoVAHXJ8OZ1zcmapYN+0njpOail6NHwSR4ZqbTc01Om1p6lyVJ28/7KF5gArg2aqkw7PCisr1GE22xkFcZ49nG3AOk/FnYHtWYaYT+IAVZbrSc5V1QIDY+uXxRGBAMa8i1chatHPgMG5YVhXpFvRfSuKQRL+xFOoB18UTtnfBNmC+9H19zVGkQHXmp04wSXNu7EE8EZJSdvoYiGSrJ1 LQ0fRQBL pWoJKNUNIZmfX3hne7cl2/mYg/NJDgyIT4SK1oKe68Ai7scqUNz9uInpMnOaW7PelPKxBwskuoSpEtq8IS4Psp4WQbIcdqF0AgIZ2vaSZki1ChAwKxM7IyKaX44yA+mqpFL+MHXzasQaZ9siNc5WIutTxKPvg5g7jYfbY5Ahq/wO0MvwyM89L7AaW3w/rytmFgvoB9I0BhfMeqUCEpQ6UMy+bvjTTArNJK0BwkHo5KUnJVGUBiLRseUh9x6N9GUi91blqo/YX8ecPfDp07jowOw1Gg+cBCb8iA8+ZJ1W4lMirfi7V5+hlz5SwX59KQpwUaoaSsRBlkk35EJnViXk0i+OG8e5iintyAWjJDmwcikxfhKx5r2RThzUAEe3Le8e9seehNm4RplPG84BoBB2aHVnuTcEFlW8Q7ONX5mLo6vdcZYQGIKjDCtlbNDuTymMzr52J5JcppqyDLdE0psOv1oi7USydVH9KD3vH X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Jun 26, 2025 at 10:32:20AM -0700, Axel Rasmussen wrote: > On Fri, Jun 20, 2025 at 8:01 AM Peter Xu wrote: > > > > The test will still generate quite some unwanted MCE error messages to > > syslog. There was old proposal ratelimiting the MCE messages from kernel, > > but that has risk of hiding real useful information on production systems. > > > > We can at least reduce the test to minimum to not over-pollute dmesg, > > however trying to not lose its coverage too much. > > > > Cc: Axel Rasmussen > > Signed-off-by: Peter Xu > > Besides a small nitpick you can take: > > Reviewed-by: Axel Rasmussen Thanks, Axel. > > Making the functional tests small makes sense to me, especially for > poisoning. Only reason to use a huge number of pages is if we're > trying to stress racy bugs or so, but really for that you'd want even > more pages / more threads / run for a longer time. It makes sense to > separate that use case out / maybe not run it by default, and leave > the functional tests small + fast. IIUC the major complain from others are the pollutions in the dmesg. And yes, it's also slow and IIUC it's because of the messages piped, at least when I ran it in VMs with a serial console. > > > --- > > tools/testing/selftests/mm/uffd-unit-tests.c | 20 ++++++++++++++------ > > 1 file changed, 14 insertions(+), 6 deletions(-) > > > > diff --git a/tools/testing/selftests/mm/uffd-unit-tests.c b/tools/testing/selftests/mm/uffd-unit-tests.c > > index c73fd5d455c8..39b3fd1b7bf2 100644 > > --- a/tools/testing/selftests/mm/uffd-unit-tests.c > > +++ b/tools/testing/selftests/mm/uffd-unit-tests.c > > @@ -1027,6 +1027,9 @@ static void uffd_poison_handle_fault( > > do_uffdio_poison(uffd, offset); > > } > > > > +/* Make sure to cover odd/even, and minimum duplications */ > > +#define UFFD_POISON_TEST_NPAGES 4 > > + > > static void uffd_poison_test(uffd_test_args_t *targs) > > { > > pthread_t uffd_mon; > > @@ -1034,12 +1037,17 @@ static void uffd_poison_test(uffd_test_args_t *targs) > > struct uffd_args args = { 0 }; > > struct sigaction act = { 0 }; > > unsigned long nr_sigbus = 0; > > - unsigned long nr; > > + unsigned long nr, poison_pages = UFFD_POISON_TEST_NPAGES; > > + > > + if (nr_pages < poison_pages) { > > + uffd_test_skip("Too less pages for POISON test"); > > I think "Too few pages for POISON test" is more grammatically correct. Right.. This is currently in mm-unstable. Andrew, would you mind take below as a fixup? TIA! ===8<=== commit 810f5674e1b990775600ffca533dbf75505adbef (HEAD -> test-poison) Author: Peter Xu Date: Thu Jun 26 14:22:21 2025 -0400 fixup! selftests/mm: reduce uffd-unit-test poison test to minimum Signed-off-by: Peter Xu --- tools/testing/selftests/mm/uffd-unit-tests.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/testing/selftests/mm/uffd-unit-tests.c b/tools/testing/selftests/mm/uffd-unit-tests.c index 39b3fd1b7bf2..50501b38e34e 100644 --- a/tools/testing/selftests/mm/uffd-unit-tests.c +++ b/tools/testing/selftests/mm/uffd-unit-tests.c @@ -1040,7 +1040,7 @@ static void uffd_poison_test(uffd_test_args_t *targs) unsigned long nr, poison_pages = UFFD_POISON_TEST_NPAGES; if (nr_pages < poison_pages) { - uffd_test_skip("Too less pages for POISON test"); + uffd_test_skip("Too few pages for POISON test"); return; } -- Peter Xu