From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 91B87C71148 for ; Fri, 13 Jun 2025 18:33:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0CAB06B008A; Fri, 13 Jun 2025 14:33:46 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0A2E36B008C; Fri, 13 Jun 2025 14:33:46 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EFB2D6B0092; Fri, 13 Jun 2025 14:33:45 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id CE2EE6B008A for ; Fri, 13 Jun 2025 14:33:45 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 6A3C480798 for ; Fri, 13 Jun 2025 18:33:45 +0000 (UTC) X-FDA: 83551226010.01.D57048F Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf06.hostedemail.com (Postfix) with ESMTP id 0572C180006 for ; Fri, 13 Jun 2025 18:33:42 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=WS7L82d3; spf=pass (imf06.hostedemail.com: domain of peterx@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1749839623; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=e+HeKj0oPbKzFuBluChGm7JvkbynPMItuuvMTMriiCQ=; b=YWWIIHKKPiUdp+tEg2GYUsZaGo5Soh6Y6y0axDuq2/ymonSshb76G8aBt40NZZb9TQ3Asq HQEnWwqbt2H3zh/McgKUw0gqcxL0SbyvUKuKx4P7zu8n4iEMF8LkB7DkGFpEqLDLi52QT6 YZmsrt8HD25eKCTaxiIC8iBwbm/yrA4= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=WS7L82d3; spf=pass (imf06.hostedemail.com: domain of peterx@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1749839623; a=rsa-sha256; cv=none; b=N4iKuddrsRk3kGKPQFcoy13PCAGj0mHqkMT2/xTSAawzfKeC8cAOZE3Fe8mp5+MA2X1zDE 7Kn2VrownuUPQ1/pQf5jyAIM2aeQMiKTHVqo7z+sNQBM5yZcz/aIA4b5Vk/0iQam9GY7pL Tv7QWKNfVavCqar0EZtk5882KV8vEvo= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1749839622; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=e+HeKj0oPbKzFuBluChGm7JvkbynPMItuuvMTMriiCQ=; b=WS7L82d3cQXGyXKDtv+4PZFBfBAmOVr/jdyFGS6VnDJXY5BCUcCFDYsc3Bzr0Zv1Xyvi9+ Dmy6FGS65hbzsLM58zORal2XZpFFGESq2eawqvsvIoTabtInzsXzmXxFf2Xzj2xRnPrAov QcO/Ifu+6oYKhQswmbVTh7e+u9PXrbw= Received: from mail-qv1-f72.google.com (mail-qv1-f72.google.com [209.85.219.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-624-QfBR9g-UNfqDauNOkbDK0g-1; Fri, 13 Jun 2025 14:33:41 -0400 X-MC-Unique: QfBR9g-UNfqDauNOkbDK0g-1 X-Mimecast-MFC-AGG-ID: QfBR9g-UNfqDauNOkbDK0g_1749839621 Received: by mail-qv1-f72.google.com with SMTP id 6a1803df08f44-6fb1be925fbso40093886d6.1 for ; Fri, 13 Jun 2025 11:33:41 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749839620; x=1750444420; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=e+HeKj0oPbKzFuBluChGm7JvkbynPMItuuvMTMriiCQ=; b=ilsd28OtfRFy23OqfXJXjJXqHEXDSfOamIwzSwHOw4xMCsnBNnb7Cs3+zcAQUYBGIZ sjE2JbmunzN3pr5we1fOM85b0q56Z3V6oxyarsbn1R9YVPPVntC0WQnqgVD6NaD5gcG7 oc8QYZfrGb+vsbUQ/QkrPN4M+wSdrBDuIsgQEt+6P11+8wcoRamb8QB75ijWQVc/uhB6 WaotJ8RKkNZXFF0vYFd3HMWvUYdHZj0Iu1AJjtPv3XNqVoa3gNLZIFWyopJmw1A02hex XZrOOE1MsXtDvji/6fx2YSATq8f81buZBneiWuZfVNr0x2+gPuuRv3ytn7ZXSD6dG4jS nk4A== X-Forwarded-Encrypted: i=1; AJvYcCU0r5QZCzXvVSsbM614I/WQDWXTB3IEO/EmwglBb0bpY7TkZ4oMgDtK6irAdp42utA/WeaPETG0Vw==@kvack.org X-Gm-Message-State: AOJu0YwD+Okek7m+G4hYswPSed67QjwTmkHA6sVKm8GEYPXUrsQGcE4Z VOh09z3Oqeda27EGdRz6KZMj1ZiyXW61ztJRXoQ1Yp6EDnO6+ZoVnu6EZuTFqwPdVrNfrOOzT2P an2VPZsIoY+lFI+rnHaKZCABQuW2VJvYQ0zeSfEDYqutwQYBq7hi8 X-Gm-Gg: ASbGnct18rpIhuJVwD9OqyFwnPRmAjYJIwCzejqwbWh/ApmtA/Y1wi71aYr08s4AE9b Tyx8Ip5pHTSEKpUxeqYbkcVgbSjdcESrTO5x57YNaaTwFSMBbNNFBsYzSuOxsr//QhGQsvPluZU BZbKSO6HkmCIi0lJpaThcnZMo4MaybJANz/WeIkh3fp4iC30TEsR2eQUzNN4/4Y5N4lVB27Lkf/ wzRw4j+1wdWdzjaqUk5/D+O57gvGINgPY7QT+y9hj/i0tRcfSQ2SpXO1zBpCWvfliQNZA5N6uDa zNj2qQ/ul8EFGQ== X-Received: by 2002:a05:6214:501a:b0:6e8:9086:261 with SMTP id 6a1803df08f44-6fb47735b76mr7441036d6.3.1749839620708; Fri, 13 Jun 2025 11:33:40 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFaWsfn6vwDb+V9X/y8MAjOX4XGXG/TuLNUm9j1qtPaErCuoGm23yBpEJIBRHMnqiYA3mkp6Q== X-Received: by 2002:a05:6214:501a:b0:6e8:9086:261 with SMTP id 6a1803df08f44-6fb47735b76mr7440706d6.3.1749839620374; Fri, 13 Jun 2025 11:33:40 -0700 (PDT) Received: from x1.local ([85.131.185.92]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6fb35c8662esm24512436d6.115.2025.06.13.11.33.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 Jun 2025 11:33:39 -0700 (PDT) Date: Fri, 13 Jun 2025 14:33:36 -0400 From: Peter Xu To: Zi Yan Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, kvm@vger.kernel.org, Andrew Morton , Alex Williamson , Jason Gunthorpe , Alex Mastro , David Hildenbrand , Nico Pache , Baolin Wang , Lorenzo Stoakes , "Liam R. Howlett" , Ryan Roberts , Dev Jain , Barry Song Subject: Re: [PATCH 3/5] mm: Rename __thp_get_unmapped_area to mm_get_unmapped_area_aligned Message-ID: References: <20250613134111.469884-1-peterx@redhat.com> <20250613134111.469884-4-peterx@redhat.com> MIME-Version: 1.0 In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: BHXNqkJFUw4y4FXsQ7s9gXJqpFzKrqVhEtGGe5pIjxw_1749839621 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 0572C180006 X-Stat-Signature: 1ry5tf9fs4xkfah3dp9rfwzxf7hqccr8 X-Rspam-User: X-HE-Tag: 1749839622-776291 X-HE-Meta: U2FsdGVkX1/QgDZiF5XkF/Uzu++HA/lhW1KXe7XyRinz2BFrt19DgLFiBL9B94+G/0Lz/8tlbrRBjwCCw97s8gK2DSkOs2YA+3CNDAfvhXWDvAd+WCDa5Vd6e8G7d6Ot7u2LPxMKgK7kG/Z5yILSi3+QvyuL+jkHl/laCnRBQ+CmL9RM8oDxmcozOyD/NhTsJ3K01B/KboZ7cS3Jv92RmnhsueFdzvnCPwqZBt4Hf2pV/cAFVzbNcb4XTLimjFWEm0Po1CIJ/6sFK39ByBGqxDwqMiNhczmgu0VGyRCU4tXAO55Tmfz1s8xEBroTqAfziHJfDbKYK+Ixh8Vl/P368mqdjmv69OzGZ7TaCvSjXmaIPedvD6mV8NXk3NskKP7Sj5cIm6kddhAhc44qE0cVOWp1rw0smsNI5Tqj/43ISTQgxFVEobtp2jusm2m+vdm4kHyFdMikF2yE+9iy+QHzhm9o3liEpzL5KgJmqn2RRsF/+EvB68ohBTXi+FekUG58UEiQGWtZqXw9IO+6oIJY2vRnM/dIScI/PqLZpjP1jR7meKyDJrkDWFMrBKx1bq+srTCIUBESOKZZT2WYP4VeFljCWYYSc4TrsuKBltrjvzlxe1hMF4a189olofMAoWva6XpWPrFQOM9MDuRdQii8BRsXoqDqKeMX536cZTjt23P1Ug4JiYFN01J4LSSshK5sOrAzVDFQOubGzzRqAIWMI/lqOMgh3YzpSwA7yhXGTcuS1gGf4/zHn6yBBZUZPKgEvj74vAKhdSudmE4bMIfVUD9lBeF4XR69GSRV6fyJZmrBaCjl8ymTrH3yIY362QgTHAGGyfTR9Xd2/czc6Kwugc+24q9GT5reR+f6VWqRZPVB4BkkfdBsfrNRUhc/heXUnS+VhyAUHzSEcCT3ueW8vG4dtdO+myt55Mi8phhyY1b+VPwtZcvlOqJiL0Rmy7hArWV+ICeLMx8hFaQW+zd F+q4ayHc xO7mnWhfPbbglOEDvDZErSxsGxWDC6P5Inx4sZjcZkZG7RZ8YOOuUznGCQiqrt5QxnzdsiDufw7Oi2LpSVYhIN81UDJDhXseoo7OyjWfDhS7XruQBe7rDLbdXeM433npUtWyBvmRInrOn6o1q5lt3agoDPBctvvcALLalCDxopLNI5x5z4wBl4MOyDomTHLPirDsbi3yOQUVsJExBoi/2+NyjKrfYE7bCREczlBsDg3/yq46Y8o4D2vVvmRcms4ooj35fvQP77Z22iIwxCdLjDnhU9EQ0pe3uUqkt515HGdLySQprCPpbfGpJdl9AEGA4gWUUOZmdUlVYKMIdTEmUJlZLMiLQGyCsCyd7kW+jBMLnxBPFumIl/UTiqRXmyVeM4UPQbfN/hGJXTvIS1NPHg2X+BSsdMizNfAMg X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Jun 13, 2025 at 11:19:30AM -0400, Zi Yan wrote: > > -static unsigned long __thp_get_unmapped_area(struct file *filp, > > +unsigned long mm_get_unmapped_area_aligned(struct file *filp, > > unsigned long addr, unsigned long len, > > loff_t off, unsigned long flags, unsigned long size, > > Since you added aligned suffix, renaming size to alignment might > help improve readability. I'll use "align" per Jason's suggestion, assuming it's ok and shorter. > > Otherwise, Reviewed-by: Zi Yan I'll take this though, thanks Zi. -- Peter Xu