From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A8081C71148 for ; Fri, 13 Jun 2025 14:02:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4C5826B007B; Fri, 13 Jun 2025 10:02:03 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4485E6B0089; Fri, 13 Jun 2025 10:02:03 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 35DCC6B0095; Fri, 13 Jun 2025 10:02:03 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 191E06B007B for ; Fri, 13 Jun 2025 10:02:03 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 8B5B81A08DA for ; Fri, 13 Jun 2025 14:02:02 +0000 (UTC) X-FDA: 83550541284.23.8F7095D Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf29.hostedemail.com (Postfix) with ESMTP id 5AF36120009 for ; Fri, 13 Jun 2025 14:02:00 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=a+gtUUKX; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b="p/i6C4yv"; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=a+gtUUKX; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b="p/i6C4yv"; dmarc=pass (policy=none) header.from=suse.de; spf=pass (imf29.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.131 as permitted sender) smtp.mailfrom=osalvador@suse.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1749823320; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=sUQdDRyXbbonvF49JKMmGXX6X7F0bhUgdCeb2Z1yoa8=; b=6xX/ImnK/rTwiJ19sZBaIhrSv2WMoQB20kiKlOH535/ZtUJkwbpLKH+5wC15jtMaumHYue J5YXEJWOxxD1yG27xfrp5qgcjqhba51jsKXCcLNKVV3zmnIjnfpSbUTHwJYwafCXIzxN+8 C456+a61A4HWw/UCzgu3YY3WXhWS7UI= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1749823320; a=rsa-sha256; cv=none; b=irzqDm4ScCKdWKq33Yrea61nRi5JEaypZ6rbTs3pOdIhkLLUw8Ly3CX+Zsl+oJLMMIljJk yWM3bGSq4yHDir5o/+PRpCAihslZU5p9zlDQnYfRHAwIzwhfCyDbZYKwsm/0RzPVFfx8Ge 0TUNLrFq357De+d+IC++ZqgNANi9/ug= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=a+gtUUKX; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b="p/i6C4yv"; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=a+gtUUKX; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b="p/i6C4yv"; dmarc=pass (policy=none) header.from=suse.de; spf=pass (imf29.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.131 as permitted sender) smtp.mailfrom=osalvador@suse.de Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id AD5011F397; Fri, 13 Jun 2025 14:01:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1749823318; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=sUQdDRyXbbonvF49JKMmGXX6X7F0bhUgdCeb2Z1yoa8=; b=a+gtUUKX1GxiEQEETg09fq+vFbA2xh0JXaMO21oAQd4BMYCHM4tTrW8SwXKGDeCc2WaK8r Lz4lRJA705z2cSt/3PJKYG26yi7gekO7Q/aB1pCc1P6hFU+aQN8yf4zaDStAZOF1GdT78i JAnNF8p3ygUEkNOrOIhcJVe8KBwsBvE= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1749823318; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=sUQdDRyXbbonvF49JKMmGXX6X7F0bhUgdCeb2Z1yoa8=; b=p/i6C4yvNf3Er50JSOwIpxt2kEKqZd1b3g55zMH6Kl+VbWagR80cUwZLIN+iv6cajIGLbd x6aolSjbSvHLCVAg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1749823318; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=sUQdDRyXbbonvF49JKMmGXX6X7F0bhUgdCeb2Z1yoa8=; b=a+gtUUKX1GxiEQEETg09fq+vFbA2xh0JXaMO21oAQd4BMYCHM4tTrW8SwXKGDeCc2WaK8r Lz4lRJA705z2cSt/3PJKYG26yi7gekO7Q/aB1pCc1P6hFU+aQN8yf4zaDStAZOF1GdT78i JAnNF8p3ygUEkNOrOIhcJVe8KBwsBvE= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1749823318; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=sUQdDRyXbbonvF49JKMmGXX6X7F0bhUgdCeb2Z1yoa8=; b=p/i6C4yvNf3Er50JSOwIpxt2kEKqZd1b3g55zMH6Kl+VbWagR80cUwZLIN+iv6cajIGLbd x6aolSjbSvHLCVAg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id A9FDE137FE; Fri, 13 Jun 2025 14:01:57 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id W9rjJlUvTGinDgAAD6G6ig (envelope-from ); Fri, 13 Jun 2025 14:01:57 +0000 Date: Fri, 13 Jun 2025 16:01:47 +0200 From: Oscar Salvador To: David Hildenbrand Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, nvdimm@lists.linux.dev, linux-cxl@vger.kernel.org, Andrew Morton , Alistair Popple , Lorenzo Stoakes , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Zi Yan , Baolin Wang , Nico Pache , Ryan Roberts , Dev Jain , Dan Williams , Jason Gunthorpe Subject: Re: [PATCH v3 3/3] mm/huge_memory: don't mark refcounted folios special in vmf_insert_folio_pud() Message-ID: References: <20250613092702.1943533-1-david@redhat.com> <20250613092702.1943533-4-david@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250613092702.1943533-4-david@redhat.com> X-Stat-Signature: yfpyuiywjdad567h1g3i9urs89891ku6 X-Rspamd-Queue-Id: 5AF36120009 X-Rspam-User: X-Rspamd-Server: rspam06 X-HE-Tag: 1749823320-366267 X-HE-Meta: U2FsdGVkX18SPyi6eT7VL3sXamUoaxb3+zBvFZogK192roYQFT5j4kBksqfFCZ513aW7HGKQeMZuy88aw9R/Ib61PZSqd4GyoOUE9PbvblevKIfmDx5YzwY0KxfrwOeSOZ1+CkYSFozBtKD0AVxfYTLHvvQIQ/Q8CA/6B3yQRfea7hko+kMGM6TwjOeskCxaJMsyAEnEbOJs9EQXo98zk9416Jw5Abj0FfNHJJJyS0Qn9d8pTOzcXNXzWMl2U9kVZqSWkjn5kk438i9Ma6vZ7lWRDMOA2zzOuCgW/eUpLlB16kz5xzX40/Q1G7TtPY8SoZeWvf82pfEmCamBSwOIMVcAaLVvDjJe42c70sXf1OYAyQjiAB3CVXnrXw+yGIQuAOluCDD3LjSr9QVoYKJlW9MFnaXOL21zj/X8zq7icgEci3mbF+k648keO0ziVrwpw/FzA2WxKuexwVhxFFvivWlGqb+hQY4YEUJrvZe8KGbse7kLUGuvk/4KgC/NSrwGOZ42EDPkfWtedqanBq5CDigrBbeIV2ctWAwFTdgnFAPTP5G97hDiwhvwWvwk6CqQsyXrTbFYxSFONE0oppDa/aklwtwiklRhWthQO2naDWalEatrqNBSEqjr2+Ql2vGMZy/DlsHXBc/flgxE7ua1hp1FoIf6YJcLJSVjtSI8X4CMhMjQkn4Zqszo3Nyu7HSPxzxKDNz438+qNwwexstcOEjojz+It++ikIC7z8hQd1pfirSb4FCNLVHkpqMTVj453NlYAuxXACLMfenY/WhdIE5Od/l1VzWWZMpvvxljqVU6CJZNNXsGiSJ2XCLtHfd9niVPaayLc6eHQzIWkfz+l7Uhn7KR6Cwp+m0mgVC0BrYpCrTN40AfInqTi+Tus6GnHsxgOsJCdZ7TmWSVG0zEgQzMmBYgF6hheJKEoEZ2P4qW0Feesrxg1RRE3L32QTigNcsRdCzD/AYGTwdeirc G0CtLImD TIaePqsNiQzKMm01XJnJh5oKkVoWsNqLu1y8AS5iPgduDsqTA5EfjHxks8cjPbuWEA6Z27VkEWp3CVLGAXMaH4Cput0JwTHzjQB5EElgOYm+jRnD+gymhIXI2cU/u4hYnZ/HEBtI7zetmUtSee+VCHKrL0OfGun+/4ElFucOQnkEK/DyF3rLlsb52enSoJ4918ATHPreWWp3ugxE1Ik85xijdWdWp7lbIYcPjm5eSPLOQrTyv8zoHLB6ptlGeZgAIJN5qPZmpuecydhxoSdytogEnOiQVqHlxzJzniGkTtfhlG9vbnUXPHJqh3KSQNuC0pdp9KyTPjPG+QO4uP5VCJgN1pEtQb+RB5+ii0Y/SqoaEB/i7ZBT4nmV25XYQN9RYNH5xZCSYrbjSTZwalIxSsCoZlg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Jun 13, 2025 at 11:27:02AM +0200, David Hildenbrand wrote: > Marking PUDs that map a "normal" refcounted folios as special is > against our rules documented for vm_normal_page(). normal (refcounted) > folios shall never have the page table mapping marked as special. > > Fortunately, there are not that many pud_special() check that can be > mislead and are right now rather harmless: e.g., none so far > bases decisions whether to grab a folio reference on that decision. > > Well, and GUP-fast will fallback to GUP-slow. All in all, so far no big > implications as it seems. > > Getting this right will get more important as we introduce > folio_normal_page_pud() and start using it in more place where we > currently special-case based on other VMA flags. > > Fix it just like we fixed vmf_insert_folio_pmd(). > > Add folio_mk_pud() to mimic what we do with folio_mk_pmd(). > > Fixes: dbe54153296d ("mm/huge_memory: add vmf_insert_folio_pud()") > Reviewed-by: Dan Williams > Reviewed-by: Lorenzo Stoakes > Reviewed-by: Jason Gunthorpe > Tested-by: Dan Williams > Signed-off-by: David Hildenbrand Reviewed-by: Oscar Salvador -- Oscar Salvador SUSE Labs