From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 64238C71136 for ; Fri, 13 Jun 2025 13:34:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 74B4A6B007B; Fri, 13 Jun 2025 09:34:57 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6D5FF6B0089; Fri, 13 Jun 2025 09:34:57 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 59F816B008A; Fri, 13 Jun 2025 09:34:57 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 3A6886B007B for ; Fri, 13 Jun 2025 09:34:57 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 8C94E1606B9 for ; Fri, 13 Jun 2025 13:34:56 +0000 (UTC) X-FDA: 83550472992.22.551D8DC Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf26.hostedemail.com (Postfix) with ESMTP id 4412A140005 for ; Fri, 13 Jun 2025 13:34:54 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=eL3wz9D5; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=SO8FJIhD; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=eL3wz9D5; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=SO8FJIhD; dmarc=pass (policy=none) header.from=suse.de; spf=pass (imf26.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=osalvador@suse.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1749821694; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=K+MrFWmai8pF8/h/UUDqJNHotxCxTwja1uE2TOdFPFM=; b=Kujprzqb/ISBYh7T/Ld6OsCFVCynZPOn8n6OoICzvUCUl526hHY/FBizqx/OtYcsYKxx6J jopMIblVFEUhhxNGS2VLLCOdjuTrPgXNkT4CB+I08Q3C8Kj78PPAWFtWUZHNL6+/6rImxX 53GSu8cWGGJugosN2isPYS8dTky0npk= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1749821694; a=rsa-sha256; cv=none; b=q0Ldhnozktt8Z3Hz7ZtlvLzaFCRPJsLjM5+e+7rof/qQwwBguZ+fsh8aKEK61Wc0S7M0oy +AvxUehoqjOOSyWYjXcHO+TVFYzb+ixMVEAfihE0v5vzNLIfgXNVKwpX2hYVW80RlHk9D1 Av5mGMCwB9KCeyXVhwpRwHWCch9poug= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=eL3wz9D5; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=SO8FJIhD; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=eL3wz9D5; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=SO8FJIhD; dmarc=pass (policy=none) header.from=suse.de; spf=pass (imf26.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=osalvador@suse.de Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 432F0219A0; Fri, 13 Jun 2025 13:34:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1749821692; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=K+MrFWmai8pF8/h/UUDqJNHotxCxTwja1uE2TOdFPFM=; b=eL3wz9D5ii5Ei5uDLcHOPf4maC4NKWyq+v5ZIW/z1Zfi+EgE15vu1FYk1DlsmXBxag6t88 LYLEFGLxsmMSG3Uog3RrHhpfehL1OhWnHmuZRsNxoP+YMFZu3oGoERKO8dqMxFfTqTclQw qyQX4xxjvaPq1bI3Ko7Voqy28ZPaUlc= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1749821692; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=K+MrFWmai8pF8/h/UUDqJNHotxCxTwja1uE2TOdFPFM=; b=SO8FJIhD43ThSBxjsd6jBeWR4lGQuk18SStUlxOe9zTNwbstyBn97n5geQUSi8WpAH3PLm UV2Ufd68xxtC52AA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1749821692; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=K+MrFWmai8pF8/h/UUDqJNHotxCxTwja1uE2TOdFPFM=; b=eL3wz9D5ii5Ei5uDLcHOPf4maC4NKWyq+v5ZIW/z1Zfi+EgE15vu1FYk1DlsmXBxag6t88 LYLEFGLxsmMSG3Uog3RrHhpfehL1OhWnHmuZRsNxoP+YMFZu3oGoERKO8dqMxFfTqTclQw qyQX4xxjvaPq1bI3Ko7Voqy28ZPaUlc= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1749821692; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=K+MrFWmai8pF8/h/UUDqJNHotxCxTwja1uE2TOdFPFM=; b=SO8FJIhD43ThSBxjsd6jBeWR4lGQuk18SStUlxOe9zTNwbstyBn97n5geQUSi8WpAH3PLm UV2Ufd68xxtC52AA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 36BA8137FE; Fri, 13 Jun 2025 13:34:51 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id DcdzCvsoTGjsBgAAD6G6ig (envelope-from ); Fri, 13 Jun 2025 13:34:51 +0000 Date: Fri, 13 Jun 2025 15:34:45 +0200 From: Oscar Salvador To: David Hildenbrand Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, nvdimm@lists.linux.dev, linux-cxl@vger.kernel.org, Andrew Morton , Alistair Popple , Lorenzo Stoakes , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Zi Yan , Baolin Wang , Nico Pache , Ryan Roberts , Dev Jain , Dan Williams , Jason Gunthorpe , stable@vger.kernel.org Subject: Re: [PATCH v3 1/3] mm/huge_memory: don't ignore queried cachemode in vmf_insert_pfn_pud() Message-ID: References: <20250613092702.1943533-1-david@redhat.com> <20250613092702.1943533-2-david@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250613092702.1943533-2-david@redhat.com> X-Rspamd-Action: no action X-Stat-Signature: kmm3b4kjfn6kw66fbczyqzwdx8zs155j X-Rspamd-Queue-Id: 4412A140005 X-Rspam-User: X-Rspamd-Server: rspam06 X-HE-Tag: 1749821694-664423 X-HE-Meta: U2FsdGVkX19BjmUPnKBRqAnvipU2jq5JSuAtyCeB99hsH3wef0ik61uMavNKBxXmXsKi0szsj2rY0yAuYu8QGHHF1WPe2CdhhTDy/ttUlagtNj+Fs7hCvy82btuY8W60z2XIeiNTG/5LNpLRC9V/etMh7kVxuXcOUxPyPEGBkqrVGtFJwpVZ9FC7Gn2r8DvzGtSxViq3rnbsmUL3P9Wn6ACNbGQGNGfDxgUwCs73TZDFASPidTlLzVEUaGUHLpabGhsGuKJgr0Oi3lsy2xDmp3sihhgu/0fW8bOTHANe0H5zcmv/ZaJ0jXQ4D49x/lqLf28zQEKhguDEJO3ne9HLxgoPXKPOA+GTST9p/c71OxBn6eh/r9KENpo7dDlyg6a5kcCIfqZX4XcYsDxW0mYNXEhAsjcQLwr/SbLzrKgsoQ2GiXu0JGRxk1o0L2oDcVgSCDqU4spxJ6+26EDp61qj2245/AyPaFHowIwIVleQgJk3Y/aB0s7s8zCn+2iO+zJOJZ+FEYR4NTWanhCxzkz+9EtXMiulg0QFZ3ryBVz73NwrOvQH9/vgUmHcvfcrYHauYPEoRtj5XNEQCNeA1JpMTtZB86fHJCsgb30niUwsZRqFe0UrqOSiEj1Ti+47yM8JyljmW9PhyiM06JE2iVevRfK8yj6LBY1PdIk7pR0fnXUT3NNzJv8GVmUBJLOjRu64VK4/6MXDgal6zHV4GmW3rjQhbP1f3G0Su0mbhJOVheXLaC8FZf+VJ855tM+z0HhCUvYEXCMYs8wnyNFGozb9hNeNYNapScpbNa7xuIYon52J+5wGECpxqQng///w/QEcN2d2dholBgj6I6SGVYs7z6cPbMtOmA1ImeibwYMco57yxMDPMQG8tPCJgS1HHDrQgzxllb3kVN1vpd2rs/aCPTTIyYJaWbnNhA2D1dXjB6OHgG5sPEKAy3zKyGlBT2avlNyciLUxVcpR/TeeGxs Zx4YmNZs +bf91RSGT7JJlvSYMQRzmgV+vOiut40Yw7hc1LgDcCJvkEC0alkfxL+iejL/2EzGjZPsxWH/cJGxpSpYnNjTe7kClxW4zkCPELlvhdmXtNcZNs75LWXIk5vUuLHjRralkfSsqL9LpSTmJQzNo+fl2KlL91NzzHhmfamJCJyC+fHAwYuZrGzAc4YxzEEp26/Nn6sqw+YzYFP6z5YIJX61i7aoZmxIbTUN1bujLiQIYmWMXPWrHCrzirDh/Rj/+drdmZL4UDNWRl+98XZrhx4L3i75Rpu3tssVqAcRJzJGEsNXHwfZhg5o4/zKFnZ0AOu+7SwSmyhHJcLTCR/mkUGcm3pyQpowsqkgbogwVB5uK6jXnAx52gpVP87Honcqirm2nio6ojAhvwMKr9AR59sVcScTMwC5Ztc7x16Ha+31NO/2fHTE= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Jun 13, 2025 at 11:27:00AM +0200, David Hildenbrand wrote: > We setup the cache mode but ... don't forward the updated pgprot to > insert_pfn_pud(). > > Only a problem on x86-64 PAT when mapping PFNs using PUDs that > require a special cachemode. > > Fix it by using the proper pgprot where the cachemode was setup. > > It is unclear in which configurations we would get the cachemode wrong: > through vfio seems possible. Getting cachemodes wrong is usually ... bad. > As the fix is easy, let's backport it to stable. > > Identified by code inspection. > > Fixes: 7b806d229ef1 ("mm: remove vmf_insert_pfn_xxx_prot() for huge page-table entries") > Reviewed-by: Dan Williams > Reviewed-by: Lorenzo Stoakes > Reviewed-by: Jason Gunthorpe > Tested-by: Dan Williams > Cc: > Signed-off-by: David Hildenbrand Reviewed-by: Oscar Salvador -- Oscar Salvador SUSE Labs