From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 07385C61CE7 for ; Wed, 11 Jun 2025 03:55:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 96A666B007B; Tue, 10 Jun 2025 23:55:14 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 91A876B0088; Tue, 10 Jun 2025 23:55:14 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 832A16B0089; Tue, 10 Jun 2025 23:55:14 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 639E86B007B for ; Tue, 10 Jun 2025 23:55:14 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 04E90102197 for ; Wed, 11 Jun 2025 03:55:13 +0000 (UTC) X-FDA: 83541754548.23.0DAC05A Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf09.hostedemail.com (Postfix) with ESMTP id 49659140009 for ; Wed, 11 Jun 2025 03:55:12 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b="ifP/tEIL"; spf=none (imf09.hostedemail.com: domain of BATV+d633bb5ca9b5c368f99c+7962+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+d633bb5ca9b5c368f99c+7962+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1749614112; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=xQRZH3iFrE2LE+t6ZGsdx1okE6DXb7IDqLisMb96/sQ=; b=cMN0CyjLILNlXs1u3mPcumWu6YkCgkVMRwBojoYdGnKLRM6TMTFAMu1XsUgBhN/FeOYJL8 Ok+ErQYnJV5FmfQL71ZbcPyTmSZHxXlp19zFK3u7S9kTPnihnOlaOwdc2BADyMqSZes5Cl WpHPRl1zj/+CUX0oygWY7NU6TcR6LVc= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b="ifP/tEIL"; spf=none (imf09.hostedemail.com: domain of BATV+d633bb5ca9b5c368f99c+7962+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+d633bb5ca9b5c368f99c+7962+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1749614112; a=rsa-sha256; cv=none; b=ixfLoMFhFYyNXAte6zeLlIFeb5t2xOyAhLiz8SYmTtW9EXETvboz47lTXFEPxoehyDZTup a5RiraEgmqChX+0ZLByiG/URWIBa8VBryZVIX8PvCPCHJVyDph3J8/79GUstVKy4kdpQ3W Npcozx9rUjOQVSAYNOItnv4Y9B5giFY= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=xQRZH3iFrE2LE+t6ZGsdx1okE6DXb7IDqLisMb96/sQ=; b=ifP/tEILXZu3HzF6rA7EBJjZKp G6Li6yP4WOR/l8MATctF/95nyZlMFaOTE5DUpBedrCkSJvDOjlkvZX1pFE9fWwVMZqSt9ORcJSI+4 xR1ih03zttjqhZ7pfnzXVx6Qu+lCJuymnNakr9Cv2/TBabUFqGnprSXZlwtviL8io95nVIOBK4n6V AYMkliu59MZQ/WO1soVCRfAla6jr1CaDqZipcmYxirkZVyynaXVtEl2dm0Blj2WrOhxixf2MXa52I rlxTICUsNp9rQ5Bqnr35r2BED7ir7A89yXzpC9GF/hwR5zOighRz8wo4gtmwmOgTaIG9fCCBjke29 o5+10JaA==; Received: from hch by bombadil.infradead.org with local (Exim 4.98.2 #2 (Red Hat Linux)) id 1uPCYQ-00000008myP-2PWG; Wed, 11 Jun 2025 03:55:10 +0000 Date: Tue, 10 Jun 2025 20:55:10 -0700 From: Christoph Hellwig To: "Darrick J. Wong" Cc: Brian Foster , linux-fsdevel@vger.kernel.org, linux-xfs@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 3/7] iomap: optional zero range dirty folio processing Message-ID: References: <20250605173357.579720-1-bfoster@redhat.com> <20250605173357.579720-4-bfoster@redhat.com> <20250609160420.GC6156@frogsfrogsfrogs> <20250610145552.GM6156@frogsfrogsfrogs> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250610145552.GM6156@frogsfrogsfrogs> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Stat-Signature: 9bdfbfnwj3k8cs6fuza4uhrf7nmwuggx X-Rspamd-Queue-Id: 49659140009 X-Rspam-User: X-Rspamd-Server: rspam09 X-HE-Tag: 1749614112-368257 X-HE-Meta: U2FsdGVkX1+erELqcX/daQVFAW9qh5h5MQTh4AKEdrZsWGuKrxtZWpPxli6Z+879Ou/DTqR2hzkpNrf8CssIrbmkkF6pv3CewZ4YTN5kt7jTqkuO5jW3qw+awrqd5VEZcmsw+H2SM2glAspBI4KslDna3A9JoniRW3MPBG901f3VntuwQpYOE4+37M1OO6z6YoIoI6k1xbzO5IW619BOXLMwtfoLuHymA9uFrVhJEGrwumyX7uDBOzA0x9AJVq5O3Ba8vv8XOEtZy5MqmsAkxOnkeiYfQM3CZa0hwfoZyfW2CaY6oP2t6G9SSprCze1vN60Ks366TY3e6i15+j1e+FIpZtjkSoL81qMyLHdVg0ESD4L8EhIS57uvT0gsj7gl4rQcTsjqdtGr57WrkdHC/1T3UnARo9bjjBW0eVY7u48ijg7qvN1OieSD/nhw3HIwkzZQWAQBa6CcNh1B3xY4Fl4XFBEUSpJeqYqJLcKoZizOrpmhq6a/+HGf25W+YLGURcqYgCdT+sD8xfloi1rfq3oNJmrNGCgV0qXCBuw81OOxUf+vbKbtc3UbGvAA688wNgWA6G+pHOWHxJGVVYYutGKSxGe70SDs1vTqmqw8klyZgxMlANiAtdfd021qrsnahgobFqLTw0nW+BYzL3bTTWhp9sQ8r6zRaC+bsVt/hh06YHogPzoPY1EJZOMEB0fh0jwyIP3x/2HM4mIq51DCKFdRgbj6GN1Swk2LT0gN3xZOLHMq54pM6mOmD5sepIsh222enhYMqw7/ysSApmz3Qgszw3wcvhhmRcvofByKEPJHJVZaNm5ww5OROuwEMbIG78pHbJfzKaeGg/2IXUxwntk2djsJEmPnOzGtKTClbZFuxuXW1Lrx+eKo7WRPOjxNO/SqtPf45VRMSNgXjEElwWg6CejTz+p3YKElyHINiONEp7zhNTP6Zbba48B61oAD/YyP6Cdzz4Q5YcNQM3M BcR8tEe6 bX4MwHZm1INzXmRpc+bgn9NKLHTsrBB8VH9v9b4qCfXdqcH6hY/7CE7WEjZ6D4wpWdSNqjbS7zIdOQscmoVVBMFpzcaw7/0R/n+1vZZtfqanxrbUFHWhpR9KksjeXMk8ztqCHKv8sWrhc2JSDxjVFfcq+3M9/VC96HOdiBkrz2xlk7O5qbzWN58ovO/05TmuFvcllMIQKtWkgP51UK8t98i8aWbmA6FMP9IHZ5yk/QgMaFMKJIZttVhIvlyl8779myFkMQXnw9DKcVf9Cm23geOL/XoW4k15IOdy7CbEkRSbD0DqCvk+lQR2fiExjv2HM6GUzKDqMuOgpo3jam656PZYiPPN9G5JZjk2fJ/0NcxIMBmCQUv+LOdHwsePCOp7p70sbUipql/hCO0hjLEJoQZY04MpXcb94JY3V0IdMFW1acSHtDBbAmPtSa2Phson1Iql+DeKS+Wmb0wXwOdFlQsBlrlOg88xNyepk X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Jun 10, 2025 at 07:55:52AM -0700, Darrick J. Wong wrote: > Hrmm. On closer examination, at least for xfs we've taken i_rwsem and > the invalidate_lock so I think it should be the case that you don't need > to revalidate. I think the same locks are held for iomap_unshare_range > (mentioned elsewhere in this thread) though it doesn't apply to regular > pagecache writes. We should document these assumptions, preferable using (lockdep) asserts.