From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1DF47C677C4 for ; Tue, 10 Jun 2025 17:16:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A160A6B0089; Tue, 10 Jun 2025 13:16:18 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9ED676B008C; Tue, 10 Jun 2025 13:16:18 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 92BCB6B0092; Tue, 10 Jun 2025 13:16:18 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 75FBB6B0089 for ; Tue, 10 Jun 2025 13:16:18 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id EBC2C16097D for ; Tue, 10 Jun 2025 17:16:17 +0000 (UTC) X-FDA: 83540144394.12.96B1BEE Received: from tor.source.kernel.org (tor.source.kernel.org [172.105.4.254]) by imf04.hostedemail.com (Postfix) with ESMTP id 6443940010 for ; Tue, 10 Jun 2025 17:16:16 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=c2zKLg5K; spf=pass (imf04.hostedemail.com: domain of rppt@kernel.org designates 172.105.4.254 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1749575776; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=3GCBPgeOQlrmHYLrdqTpTLnRNoOZpvpGrBhJxXSTuHE=; b=D6JoSINZoJXbHkiYl5D+6Difz9z0rpKXJrni6ThAzy9kv+CDGaz7Lii8YEVG4FYRNDZbPn w8fXPXwxFJdsIwSB1i947yLRyxlZ4kVpC3zIN4WLUns6zyekHV77ORDrqNWkBjc0eLvaKE mdGg+AN+3mp63PAlozE6rhUaUKnjHN8= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1749575776; a=rsa-sha256; cv=none; b=wgPjr4+B1YHC+SKd97K8p2LBjo5Qd1ck4Hy+XBeMqtvMtQIp85SlfQy0rzRhdOhnNs/fag n20MBk4L81YAcjY9hhXpIjP2WBh/NTs50DgRiWjowfdMjRRCgXhZvdOnKCC+5Q3H4PrWQ7 PJnCT0wnv8XLAkEqqhbtm5kswp1pNvE= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=c2zKLg5K; spf=pass (imf04.hostedemail.com: domain of rppt@kernel.org designates 172.105.4.254 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by tor.source.kernel.org (Postfix) with ESMTP id 8EF086112E; Tue, 10 Jun 2025 17:16:15 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 30406C4CEED; Tue, 10 Jun 2025 17:16:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1749575775; bh=55+RaM6BdEkpfdOTQyijX7TveBZCvrjRknaE/fwutoA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=c2zKLg5KKQ1hBezRVOupzHaNocG57d803thXInhwPM+26e+OgK+eZ4iZa0c9XGK78 xMquwBHKK22kE672T/pEyEtq4Xpt1z8ldkt1+eIUfrMzR6Ev65F9sEwh0QAds4EGyv muXQuxmEHRTA1EjJco8KdUDQOrtG+hzuYQorPGJMOmsznKDZBYOpnKtzsrkydyCVlX r04Uw1P5b07DHiQbKnHnN7gx8u0HsB1drqTR+P2KdnlgZqUoxpcSUgGfQ0JYFz/aP5 qTa/ygvxEkhIb+knrCk6S53TB0zQrHvASD+DDVr4siexj/ZF8T6u6Fgjk8qBTxd6t9 t2QvhkRD82JpA== Date: Tue, 10 Jun 2025 20:16:09 +0300 From: Mike Rapoport To: Mark Brown Cc: Andrew Morton , Shuah Khan , linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] selftests/mm: Check for YAMA ptrace_scope configuraiton before modifying it Message-ID: References: <20250610-selftest-mm-enable-yama-v1-1-0097b6713116@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250610-selftest-mm-enable-yama-v1-1-0097b6713116@kernel.org> X-Rspam-User: X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: 6443940010 X-Stat-Signature: 4ka19exbot9aee45rxmss19w5frfw655 X-HE-Tag: 1749575776-536889 X-HE-Meta: U2FsdGVkX18cKLktoGVbCKpaQbzZa57M1ARZ2VnDDOXnNwI7t6+KUTw3RRghwDKanYX2ovMr+O0cIuVdCygos4Kw2W3Dx2pV+cEHVhgAMLDFie5Tiyi45z5MgTGqMXgtSx0uH9k5wyeK9FAAA2Rqz0Uw5wTRzqr6/YXaldOaHFS1Opin2h7BR4/kBPcQ+kUx89iHN8TtyEK+AR3s2oA5AoChOpqisdbObCsU6K+PpccswzEKNhU6Pwy7zX05BH3vd31qlv5heivzxphSmZLM6yXbDTocD/pchwmXAiG8TlmyPQ7cIver1+FRz9rLzd2Ly4NBLQ3FG4fzL0IIpi+0Bsw1/WQfEyxITlQQ/ApsnlN4Xav9Br1UfTls8ZPbBk8PnWgWqfQ9DJtR6t2teEeBWJ8gaBq4SP4YioZUNxykOfTbPwkqjWAuSR3sCjSOWk1gNic301tHI+ddsPat8bKwA1Kk1XvNjDAnqIOxo15Q+3gi5iSZXVTYaupLyyVi193Qbwdjc0+WNK8ZeSav2spdlV6PIenn83sgz/Bq3eJNuCNr2ZTzxfgy8v3t7YFSHdi/CV4sBl00f9GinEltiBVq43lTi44F6g8XoOCBdGuqqbRE04wO41lcHI9eDRKx9Wr5MTUhQRozu2JyhulvV2pZKNjtig+dJvHKcAJEZPbyt0MiKngyHv+KKbqA+xA7VDkDTSeOZYjYhB31i6SzwyZtOgJYmCMfwyKn/+Cnpx2Aew5eSVkOxTh5F8yf0ymPUm6iYM9aPeupC4LL1qtp3vx4fFsdPo2PbXq4KooBIVQ97NOhTBnGfMhcn6DXxVpixtd7tRnKDJ6brs+AomBCChq0EyIJjwJrA284rhpJPnllaG8Apw/wtHAjuN0lCLhxAjejJnSa5aRE2g2gNB8y7arMxOx+FoBTHm9KSOzuPTQzdrDnQ1Bz2ooxWgVd1+aFKJy1JX0Svm6t6DSscyBSfB9 qOyCA9rK Wo6JGSQJCb69XVU+peFhlkG+7jPe75tChJO0v2edp0xd/GTVsErdYmJhkutPmnSIoJMxdMEEDJZN33RMAXGWnlTmUIsvXPcaEka0ciIlZvJjg0wb1oqPqCIS7N4zDFBI2B6rd6cckn0WP6I5nxX4ERqCQ+PG4ukNpkDOWhFfeUjC/YczVySKQzuu5Rb4l56ZVOa5KmoON6gLUe8kZ8QGwOJPHEZAfB+1oPP/DGC/ibKGULkWmo5odlKx8kTeTfWOfNlgRgpH2bazRSZmDnxHwTFCZt6218Zj1bR4oMlwBfJmksF424XGnuyTPScclaspRBXqb X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Jun 10, 2025 at 03:07:44PM +0100, Mark Brown wrote: > When running the memfd_secret test run_vmtests.sh unconditionally tries > to confgiure the YAMA LSM's ptrace_scope configuration, leading to an error > if YAMA is not in the running kernel: > > # ./run_vmtests.sh: line 432: /proc/sys/kernel/yama/ptrace_scope: No such file or directory > # # ---------------------- > # # running ./memfd_secret > # # ---------------------- > > Check that this file is present before trying to write to it. > > The indentation here is a bit odd, and it doesn't seem great that we > configure but don't restore ptrace_scope. > > Signed-off-by: Mark Brown Acked-by: Mike Rapoport (Microsoft) > --- > tools/testing/selftests/mm/run_vmtests.sh | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/tools/testing/selftests/mm/run_vmtests.sh b/tools/testing/selftests/mm/run_vmtests.sh > index dddd1dd8af14..33fc7fafa8f9 100755 > --- a/tools/testing/selftests/mm/run_vmtests.sh > +++ b/tools/testing/selftests/mm/run_vmtests.sh > @@ -429,7 +429,9 @@ CATEGORY="vma_merge" run_test ./merge > > if [ -x ./memfd_secret ] > then > -(echo 0 > /proc/sys/kernel/yama/ptrace_scope 2>&1) | tap_prefix > +if [ -f /proc/sys/kernel/yama/ptrace_scope ]; then > + (echo 0 > /proc/sys/kernel/yama/ptrace_scope 2>&1) | tap_prefix > +fi > CATEGORY="memfd_secret" run_test ./memfd_secret > fi > > > --- > base-commit: 19272b37aa4f83ca52bdf9c16d5d81bdd1354494 > change-id: 20250605-selftest-mm-enable-yama-1541c2d2ddcd > > Best regards, > -- > Mark Brown > -- Sincerely yours, Mike.