From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 57D53C5B543 for ; Tue, 10 Jun 2025 15:57:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DA3086B0092; Tue, 10 Jun 2025 11:57:53 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D524E6B0093; Tue, 10 Jun 2025 11:57:53 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C40DA6B0095; Tue, 10 Jun 2025 11:57:53 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id A44296B0092 for ; Tue, 10 Jun 2025 11:57:53 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 268D31A0836 for ; Tue, 10 Jun 2025 15:57:53 +0000 (UTC) X-FDA: 83539946826.13.9798A13 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf29.hostedemail.com (Postfix) with ESMTP id AE5B9120009 for ; Tue, 10 Jun 2025 15:57:50 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="fWvNns/j"; spf=pass (imf29.hostedemail.com: domain of peterx@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1749571071; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=uOjCSskmNbeaSFJy6FGRwxS46o+v7MvRvYHyqSTJRjo=; b=dEkhrOqbYxqVpdYTg+aeshT+tY3S4uYGZXsqqFPpuBhuK0A2K6zwFcFUF16xzClM6EKy3l 4JWTwY1wtKpB4o2d2YdZ9bNdkIGVyw/ztTma0lBb2/4tj5pRD+x6IzOD7Jnslc0Jy5Gk4J QD/XBvpAQ5KPCFh8y/FAsIGx3C7ZCfc= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="fWvNns/j"; spf=pass (imf29.hostedemail.com: domain of peterx@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1749571071; a=rsa-sha256; cv=none; b=6JiUusD0fMTR6hyLxSvFqGIos6ynTqTctWpXeBFZC95IRBFmydUt6xaqH8K696P1WWqzT0 3O/JMZ7I0UErXZj7Ui+BOn6+KYEH5KmKwFUT1gKvenOBM76BEWq7wCIzUUhjkTSBoLQHjN zju2B2aOZKNXIovrqQANiQ4S6MSnLb4= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1749571070; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=uOjCSskmNbeaSFJy6FGRwxS46o+v7MvRvYHyqSTJRjo=; b=fWvNns/joWEKM3kbQBXY4VqGkjh6Xk/31YlQuY3T56LphDt+fbFNKNyqki9LGv58hc/w1l ZvAz6+ejTW21BjoVsDU7e2VXVr32SE+ZIKG6a1UG4PikAPaac6kmlGtLbXTGZNxagGBDdd weuHSpLPGPtu+Tfu3YC3O53lHjNL56s= Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-227-BNmBogxgMYO2jZ805U2Caw-1; Tue, 10 Jun 2025 11:57:46 -0400 X-MC-Unique: BNmBogxgMYO2jZ805U2Caw-1 X-Mimecast-MFC-AGG-ID: BNmBogxgMYO2jZ805U2Caw_1749571066 Received: by mail-qt1-f199.google.com with SMTP id d75a77b69052e-4a58bbd1848so95803721cf.3 for ; Tue, 10 Jun 2025 08:57:46 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749571066; x=1750175866; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=uOjCSskmNbeaSFJy6FGRwxS46o+v7MvRvYHyqSTJRjo=; b=P8qriMEvn18KLGUK5AaePGRKLylhndi+1I9eTtdzqGfCYaQRQa+IqnhSUr46B8y8Bh 2EQrW/eHqzfz6LkOzKYXPi/3ruTiQsH5etI7R7scbYF3O5ut0NE5RN5Ov4ns5FGNczYs QztsKMOxFTYM8MMLwU7Jospx+c+LVv0DpCOOCFEayyMh6pS1F0Ph4jL3NXXW8MLi7uYc aPmCP5JwA87FWo3O7NvdqsCQN9uQldLhPFjmxjfA5gV/1rqrkWrfJ1pkZGrb1UtY+2gO mJl2Bx4Rnlh88rzc4Ev2tobA9SlRmAy2xvCShwQx3pmjSDjQRLza+4+BteKlKYlPXyRB FLaQ== X-Forwarded-Encrypted: i=1; AJvYcCVzUFbSow5V3ELCMiueg2JrdiFSMzKX3c8Hmk19+hV+RyJkg+9x/SxpZlA7pH5JAJmciC88Vpdktw==@kvack.org X-Gm-Message-State: AOJu0Yxuy25yCi+YJil8MhpStSa9xgRyiTZ19KnV1lOmGiYP+3YeSXSL SUkBgc3aiMS2ogMbVUQc2JesF9J5vyrEcS2DrFAOk+TrsbX8QBYnq1XelkOFVz7q4Yeef9ZFeEU wXStr1FZKvKidghX4MnWlZKg6FQr1OYRbEwvKSM6iK4EAsck2VfE5 X-Gm-Gg: ASbGncsn3fQB7aIw6DA0l8LJtjzFvzSb/AXnmn120j7YUaKI62PUhj22VBvu8VA1bmK yzFjk40GcipE/W9IYdnDm9CmnppacQkUu58JqJP9WfPwiIToPsrdYDmkIBsfSpW3hZNuDVEUdqz sQBtbcOsph4A0L8eJHCp8DUx6AJ6UB7VFbPJvqrr6gh7k/QgL31bz7ljQwlvePX6D8KyPm/b61b JY+wipliUa9fcXJrDTX0+o+rIXHTxDtszjz5p6xYRqiZPyKNj5jhWWPqLlVqnLGmnLyPhhzAJmD pl0BdKlFwT8g2Q== X-Received: by 2002:a05:622a:5a14:b0:494:aca0:1116 with SMTP id d75a77b69052e-4a5b9d80efemr293979641cf.38.1749571066050; Tue, 10 Jun 2025 08:57:46 -0700 (PDT) X-Google-Smtp-Source: AGHT+IE6B8UunFSKuMgPqWUZeL52U7fzg9fDDYw+dG6q9S4c1KPZ9vYbGvQ7lVhUS9pC7GX6BgcfBA== X-Received: by 2002:a05:622a:5a14:b0:494:aca0:1116 with SMTP id d75a77b69052e-4a5b9d80efemr293979411cf.38.1749571065724; Tue, 10 Jun 2025 08:57:45 -0700 (PDT) Received: from x1.local ([85.131.185.92]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-4a61115048fsm72814851cf.9.2025.06.10.08.57.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Jun 2025 08:57:45 -0700 (PDT) Date: Tue, 10 Jun 2025 11:57:41 -0400 From: Peter Xu To: Oscar Salvador Cc: Andrew Morton , Muchun Song , David Hildenbrand , James Houghton , Gavin Guo , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH 1/3] mm, hugetlb: Clean up locking in hugetlb_fault and hugetlb_wp Message-ID: References: <20250602141610.173698-1-osalvador@suse.de> <20250602141610.173698-2-osalvador@suse.de> MIME-Version: 1.0 In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: b4IDxFnbkhyiMtBsi8awDPCew2QwBMDpU_2UogEmpNI_1749571066 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Rspamd-Queue-Id: AE5B9120009 X-Rspamd-Server: rspam03 X-Rspam-User: X-Stat-Signature: 5n99ps96okhmwkq5mbekmm6ediyjxjbn X-HE-Tag: 1749571070-64342 X-HE-Meta: U2FsdGVkX1+baKVQubexfW0pGDHOAcvHYvMj8YXr9iiJWj6EzgmC5q/F7Ci1xjEfCN7CxtT6jkeX3VS/mQ/CPOqBfRX3zSnOLdh3SbA5H34SI/7MtH64EZnq7fVvtlCVhayUMF5xspS3TeCjRElKn/hCT06ObKLEOnAibS1btaNPjkamDL8zVRF9/8/uA+TprOO5pW+XfrTySTsKlPLWRZiWrDTL25m5/kIV3MUaS7x4ksbOSa6YgRsI/ixSUAm5Y1bZjUsNjdKiPPrEOKBUZDhfVOyS2HfB9kOoFkY3XZ7KG8lmhw/G25p///Jba2FEhbPj0GS3GZ5u6YyRQwNEx3RTmMv0F7OlByMQpTgdFKeMdqe19DxjGoJ2hxZ8ZiXc7BNnsoxYtmM1xBKRJAPifb33/4PeVDPNByYPN1+le9DiYhxu+JnIPXFX98HxUNUWn/1REVmVBJvNAAzg6uPLzMP82wN6iVI1tXBW2RrVQQRlXoc+ClCk9TGm4fQkPxTdTox4tygyBcjWNGf0Ps0EzqB9zrAS/jWFtBk5+kj5qS//qN5uZvkR83cr12z5k53V6Zdq35XzstDabEKJ/Pawszcq4D3viPeYgwVKsQ+4d1fddBgFrKtwNI59DcAqPnaWq/RPnC/cBBsaJgk18lO5+2ufJ6rhug8SaZ/oP4G0oJXPp9Nz/1jqFKyFXi6qplg/O9uZwWN5v5Tlf62z0oeeA+pvxaG0vZIT/u6AI2QMpwxMYTQGe6gmuiMceglIk2Nsv22RHD9TPKbs65MSaIa4C3qbxLgphxZJmT/jsRuc7TlkT+8zJc8rUeRRLYR6F3OcQ02zRYSZkW1yENnSPLJGhr53dgSfbap4lmU4T3Q6aMg3xqasymRWm7BiS1iwmuFASUQaflgNTJBbhNrgot2E9QB4y9sIa5wQ7sJxwygOl4nVWS5kYSQjRy5MY7ronRoGiTRGcpgQfGx3NMHQz/a I8B8a5qF Nfu+g54E6KCQe3lpJUN+8dxEO3lI7/eh5YjbNifmmujRI8PCY7hfuFay4iJ/iup5Gu1D6+Dnv5wuUze7XVjefyB6IIy4BG0csnAtBiSufgRP1JEjC80UxG+pXgTbtFb+L4wtBBeB11Fuqmvd19Y1agK2YZhxPDtz9OLER+TQ23443dQc/KcIkJBpe29Efp/KpxlEMcus2Ek7wD5nUXppbsXSIRDCwLP4wOOI0fENHma++zj/9M4OLlvPPwXhl6QsP+GeEKVYMA/R0EJLsITT4xhk8XZqJWJBoUttsEZ7j8tyVHP2f0i1bM9Zx1SAhDVB8I5n8GNr4yI+Shxx+5tgDlAl01t89CtNMtoQanaoVvgfGz9r/qxxsEUuYzZhINUfX3L/O7xQE0zj8dJSMQeFUzToW49jIJTLOg3xIHNF9ghdyZaezeWkfXf6kTQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Jun 10, 2025 at 04:13:45PM +0200, Oscar Salvador wrote: > [1] https://github.com/leberus/linux/commit/b8e10b854fc3e427fd69d61d065798c7f31ebd55 Two trivial comments on the change: (1) maybe you want to still mention the trylock -> lock change for the folio in the commit log. Looks like it was only needed when we need to lock two folios to avoid deadlock (even though I don't know whether it could happen in any real reproducer..). (2) you can also drop need_wait_lock var now. The change looks all good otherwise to me, thanks! -- Peter Xu