From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C9051C5B543 for ; Tue, 10 Jun 2025 13:30:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 670EC6B007B; Tue, 10 Jun 2025 09:30:32 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 622FA6B0093; Tue, 10 Jun 2025 09:30:32 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 512006B0098; Tue, 10 Jun 2025 09:30:32 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 3445F6B007B for ; Tue, 10 Jun 2025 09:30:32 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id C351EC026E for ; Tue, 10 Jun 2025 13:30:31 +0000 (UTC) X-FDA: 83539575462.14.7BDF6A5 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf21.hostedemail.com (Postfix) with ESMTP id 28C411C0019 for ; Tue, 10 Jun 2025 13:30:29 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=rerNKwhY; spf=none (imf21.hostedemail.com: domain of BATV+631296521f62fa6b3e9f+7961+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+631296521f62fa6b3e9f+7961+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1749562230; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=GcbjZKDHfWzF4Hztsbds8tFXOAXOwUhPwJriLCPNAsA=; b=drGDrKxkbagwAQs2XpvC+YIjN0RracrQfqXQ60KlPfO4/MCJYXTrqVR8KXbdibgBuzjiUr VlVMF6XtfYDOFuAPn96hfH3rS6nvbY/TTk/YxHhPcQ0/VEsh2ldM1POYwSYCPzafT3zdri JgKGUUH9H0DHaXCL4V5oat0mbdmG6W8= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=rerNKwhY; spf=none (imf21.hostedemail.com: domain of BATV+631296521f62fa6b3e9f+7961+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+631296521f62fa6b3e9f+7961+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1749562230; a=rsa-sha256; cv=none; b=Bpr4LS+or5WuwMfG3CLfAUwCTZEkQxqwH/t6Qa5IEKTgfgSjWKJQQZ+6EnZml5QIRtz0Tl zea+02tJv1K/pwZCH/Pik16UVmXpJ17m7bO4Jf6ZrfY8AXGJQvtdx0s5cl/LZeht3dN9l7 uFaE5Z/+uNfcPHcEkzBRzex6obgGWME= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=GcbjZKDHfWzF4Hztsbds8tFXOAXOwUhPwJriLCPNAsA=; b=rerNKwhY6cYVBgVq/mcdEaviHF T9VsFX+uRspOI7OnRjqZgfBd7m4bKGvsbou3oaDt+D/0AaycXXsIkRa9KXeXjunGpQqyrMQtI5ZYS 116OQpYPMbfiBB4CMqR9FWiP+pdMPQQi7VR8e7jb6VwYwV1TkSBXrCG0+1EHom6o0kw6zI9z8bPbW 47vTBzs6vNbvM+Vju65uUPUMEEOK75kYSxXox+V8nXWy5bB7ki/GGUkIom76kW46SEUQFZ0RkhpbS gPiHlQGjnLygStCc1PKNEeiKQDjob7VrrAVOwuaO2OzfnStz3IEUqE2n+4gM1a0qpSPzWaGF2/xGC ZLFrdfOg==; Received: from hch by bombadil.infradead.org with local (Exim 4.98.2 #2 (Red Hat Linux)) id 1uOz3d-00000006ySA-1UMn; Tue, 10 Jun 2025 13:30:29 +0000 Date: Tue, 10 Jun 2025 06:30:29 -0700 From: Christoph Hellwig To: Brian Foster Cc: Christoph Hellwig , linux-fsdevel@vger.kernel.org, linux-xfs@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH RFC 7/7] xfs: error tag to force zeroing on debug kernels Message-ID: References: <20250605173357.579720-1-bfoster@redhat.com> <20250605173357.579720-8-bfoster@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 28C411C0019 X-Stat-Signature: iwn38mw9psf84bbkajpsx6kshewczzmb X-Rspam-User: X-HE-Tag: 1749562229-146317 X-HE-Meta: U2FsdGVkX1/Lem8kTHhIE4caFz5tAp/3tmXFQ5rCkfsNxy6j5bbDJENz34qxu6w8o3g6h5hL5H1R6giMNlJxO4DcamXXEnBeGf4NsOQQ1Fl+GJXg2GTsOzwxCj0ShDnU99iqe3OyGNvkAfqd/KITgGaZony9hJFDKcdCGK3qyTd3qVnN8agbgUiwWEf4m13XF0NyaosAQQkPKT1iAKYgEAMD5jPkDMFa7uGJsToQQ5FE3xw9Y1qNIPbfRSa5CM5qdLKMno0loRaUj6PcyBBs8XOCglKptLMiijDdcekqNcsNJ64WYOyCnTWabAW+4loi6QFupEeDedUWGjB1fY+mUrwv0LN2P2C1mUp6ghZff/S9z5MiR1UBkC5S5Nf0e3Glow27Pp/JJ4PNVXoALXeBMwm61obXbdxBTdwPIw3Sfp8Jhd0aUADPfwJPMIHewG7fYSINI3w07pIMO5xwq9620Scvpd3AE8AJYrW/ISwoYP4oOpFetemV52CTa/5RBIzFp6Y8JKZmA9QzcRufj7RAi0Y1ryunh8nSIUWniTAmu4EI+hkFqWUPMz5PNfDSR7IaF2sz/i6MVn6fiyi3aWABCYlMGQR7DBM1CXAmHBxB1aeLAATpA2LSFyxKaoPHNfkSc84iWCE5nT36Slfm/DxwxkcXTmpGHAJRfJ59DEz3B9q8JcjfFrFQTaNIn4v7xBuJaZU2k4KHP1+yP/xQ7ZY1CGCtbgaFJIWL97FOlKPykl6Aa74NQ1mvEzWtcv0PQvxORSK6IvZYxkm7bmShSPzSPX+Ek/oeMPwhFDtrgpgOPTT7Ucqj8RS3Ybw6vpAcOhKbFKVpFjCckCdQpQ9KF67ILFG9tjXbq9NpJNPdBFB5EaabgG094g3JSbCElumDXvlrEc/RMHTljBOslQPNbOpC/+BfHiGIuzvJIAWPUWP7QJKWcWl5AaZ2nTN+HJAuKm/g47CPKwnFHtbo889B29S K8w1mxdB KvBXL+mqxsGv2WTiWhKqvWLFesOtWdHeZxN5zU/K3DrPojbgbT/tUZsFvP9z22jMG2X3PVjcF0YaK8VPD17/uZnrU3v380hHafDiJLjzMkg4RjRNPRwDWFNo2WALzxdpxK48VClsomN3gNRiCByNhOD/rNiaSlVpu8/49OzWB8Hxzbbk3rb5tj1RwWg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Jun 10, 2025 at 08:26:45AM -0400, Brian Foster wrote: > Well that is kind of the question.. ;) My preference was to either add > something to fstests to enable select errortags by default on every > mount (or do the same in-kernel via XFS_DEBUG[_ERRTAGS] or some such) > over just creating a one-off test that runs fsx or whatever with this > error tag turned on. [1]. > > That said, I wouldn't be opposed to just doing both if folks prefer > that. It just bugs me to add yet another test that only runs a specific > fsx test when we get much more coverage by running the full suite of > tests. IOW, whenever somebody is testing a kernel that would actually > run a custom test (XFS_DEBUG plus specific errortag support), we could > in theory be running the whole suite with the same errortag turned on > (albeit perhaps at a lesser frequency than a custom test would use). So > from that perspective I'm not sure it makes a whole lot of sense to do > both. > > So any thoughts from anyone on a custom test vs. enabling errortag > defaults (via fstests or kernel) vs. some combination of both? I definitively like a targeted test to exercise it. If you want additional knows to turn on error tags that's probably fine if it works out. I'm worried about adding more flags to xfstests because it makes it really hard to figure out what runs are need for good test coverage.