From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 51951C5B552 for ; Tue, 10 Jun 2025 13:18:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DFA266B0089; Tue, 10 Jun 2025 09:18:32 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D83F16B0093; Tue, 10 Jun 2025 09:18:32 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C73036B0095; Tue, 10 Jun 2025 09:18:32 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id A90FC6B0089 for ; Tue, 10 Jun 2025 09:18:32 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 51D7DBFD0F for ; Tue, 10 Jun 2025 13:18:32 +0000 (UTC) X-FDA: 83539545264.06.2220242 Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by imf28.hostedemail.com (Postfix) with ESMTP id CBAE7C000C for ; Tue, 10 Jun 2025 13:18:28 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2025-04-25 header.b=E681Z1sk; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=DgZDoV0f; arc=pass ("microsoft.com:s=arcselector10001:i=1"); dmarc=pass (policy=reject) header.from=oracle.com; spf=pass (imf28.hostedemail.com: domain of harry.yoo@oracle.com designates 205.220.177.32 as permitted sender) smtp.mailfrom=harry.yoo@oracle.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1749561509; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=LCfH/iYBHb3zCK5ukjQb/SAJuYesL5z8rA5Gcc9Dnec=; b=7VYtVxQHEZZv3Zx7QJzpmzqsa0HTmo9Eevqzd2HaBcFvOHEqsW4N7Yroz7IY/jhpFLsDu1 O2xVtcULzTypCyvGmHed6szuzvp8eBLCnK+zGSXgWastuY/z+z9FX4/s7aELZXXXsKAdrb bnSfD6NVhT11d4VWXMhI9/fbsuuNnO4= ARC-Authentication-Results: i=2; imf28.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2025-04-25 header.b=E681Z1sk; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=DgZDoV0f; arc=pass ("microsoft.com:s=arcselector10001:i=1"); dmarc=pass (policy=reject) header.from=oracle.com; spf=pass (imf28.hostedemail.com: domain of harry.yoo@oracle.com designates 205.220.177.32 as permitted sender) smtp.mailfrom=harry.yoo@oracle.com ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1749561509; a=rsa-sha256; cv=pass; b=52Cr5Qj8okgZ+g2Mf//T0s/EWyDWpDG1hrNGB2aSeg71bKkbipYEIGxokdQHmgmMavujyF RaApVvv7Qk4bbY70REZEwxp2W2B22KPo1i02W7gpdZu0YH3NBVrJ331nlnTvVddvCtCWVP PH46ZF0gn+dUJanklBre3n9TSSzA7Ak= Received: from pps.filterd (m0246632.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 55ADBwPU002486; Tue, 10 Jun 2025 13:18:23 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=cc :content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=corp-2025-04-25; bh=LCfH/iYBHb3zCK5ukj Qb/SAJuYesL5z8rA5Gcc9Dnec=; b=E681Z1sktY39HfMila840L1CugUoRcNq1V MikYM+8m/XIrJiRUBLA1VipFySUAWOYD+w1noUSj5oVjlp1I7v4mYJVcamO25Wdd 1RcUr8vSoxDv+El1LeatEN/jkrkHuuvHU1iLQzCk9ruOh/H9Qas7gw4DjOiQyzMU 9KiqnQADSrGzL0nFKzL5LeLIw8dlJTJfW7ZkbEmuDPmDDYOxGzNrhuNTEaOr/yZD LZLemXmSE0eknQGllriNUFEGOJxgLqSTdMOIAwvuNQL8Nv/UJhDOuKMF8VBsIfgr JwkSvSLwqcdfHDyVwCNA3OrjV+zfCu6E12tjo7cvdXMa0kHer3Jw== Received: from iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta03.appoci.oracle.com [130.35.103.27]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 474d1v48aa-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 10 Jun 2025 13:18:23 +0000 (GMT) Received: from pps.filterd (iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (8.18.1.2/8.18.1.2) with ESMTP id 55ABt9Zw020939; Tue, 10 Jun 2025 13:18:22 GMT Received: from nam10-dm6-obe.outbound.protection.outlook.com (mail-dm6nam10on2069.outbound.protection.outlook.com [40.107.93.69]) by iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 474bveyjdy-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 10 Jun 2025 13:18:22 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=k9NVRMJcypMqbBB/liDswoqEpUVTeqoEmE/BZKqXJU2W5efdwHi5QZIdQS9LaYFUXJwl1XTQyhneJEmNsyvQM5ZD2vmmUswBxxkzPKA88ymCIOuTikHuvzQUes2iia9QO3ofjiv5zKp9/aNb74odVDuU0ZQB3bnB+r7c2oOjWvlOwzrfqf8PEpLO8p809k1p5YeDFUIJ8/R54+CqgL3hfL0Iet2duiJdUOx9N8C6y1sul6spwxAq2PG470hHx4LEsF9/WMu17y9uRdN/BGkh9qP6vUWWhTumce0rnSU2WSS+oKFxzXJnXvgtk3SyIvJYvzxfPLUD2nk9HPL1Oyj5yg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=LCfH/iYBHb3zCK5ukjQb/SAJuYesL5z8rA5Gcc9Dnec=; b=rNyJN9OFjHJuvX7TYdEB45kelpv5FSqAU5gqKFFujhDcZ8gCfPoig/4gGcOmNx2LS2zeYTJFFObwNPac5dORTfmosPjrliBDTQ1Cf032IhotxCfoN3bUP38msNFHzLTqhj+kfnyGpXHvBlqpqYKRoCiVxeps4e0y3GZ/vQy1ZAcaVFM8nmWdTTiui7/sYKLgwHHLldhp/nBPyi7H5gR9c6cTONwJWWPQorULn42LRxIkqGMHtqhX6xxoV0bzT/e/fpNjsGXHGPSDJBCRzdLsWGgG4LSSurvXraGwKe1z7oF2eGuY+sqzusEiD0mrk4WnCHUZod4MOTsj1Nze4OQLGQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LCfH/iYBHb3zCK5ukjQb/SAJuYesL5z8rA5Gcc9Dnec=; b=DgZDoV0fEJg/x4f5+/wx/4kzZ9rV8YG99PxU7EL+ZWV9hvVgXoCoQ6YHH3Vakc4fXJhmJXq3Yzpk1WKf3nvv1w0eQtoPDRqki2DzvwzTupWVAS2iS288j4wtu/dbDmcTy3lbnMulV5JeH7TAVMkc+okIotyMLR6xIIq49ZCSWzY= Received: from CH3PR10MB7329.namprd10.prod.outlook.com (2603:10b6:610:12c::16) by CH0PR10MB4954.namprd10.prod.outlook.com (2603:10b6:610:ca::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8835.19; Tue, 10 Jun 2025 13:18:19 +0000 Received: from CH3PR10MB7329.namprd10.prod.outlook.com ([fe80::f238:6143:104c:da23]) by CH3PR10MB7329.namprd10.prod.outlook.com ([fe80::f238:6143:104c:da23%4]) with mapi id 15.20.8813.022; Tue, 10 Jun 2025 13:18:19 +0000 Date: Tue, 10 Jun 2025 22:17:57 +0900 From: Harry Yoo To: Vlastimil Babka Cc: rientjes@google.com, cl@gentwo.org, akpm@linux-foundation.org, roman.gushchin@linux.dev, willy@infradead.org, linux-mm@kvack.org Subject: Re: [PATCH] mm/slab: fix folio_test_{anon,ksm}() false positive on slabs Message-ID: References: <20250609132723.13118-1-harry.yoo@oracle.com> <83e262c2-419d-42cf-84db-b4ea2befbb72@suse.cz> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <83e262c2-419d-42cf-84db-b4ea2befbb72@suse.cz> X-ClientProxiedBy: SE2P216CA0054.KORP216.PROD.OUTLOOK.COM (2603:1096:101:115::19) To CH3PR10MB7329.namprd10.prod.outlook.com (2603:10b6:610:12c::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH3PR10MB7329:EE_|CH0PR10MB4954:EE_ X-MS-Office365-Filtering-Correlation-Id: b40a92a3-510f-4f03-ee64-08dda8214480 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|376014|1800799024; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?mX0bmlJPR3NAf3auRXalGFbdw1+OkaWGGHd/xQYTeMqHdHtvrGSJv0sVIeFm?= =?us-ascii?Q?Zhh+x+FWhGAVJIXw6/wQiIRO8yLfOOkZKRYehaqCVaXEAjXjipcftMUvVFA6?= =?us-ascii?Q?AZXzPVpoXQiPNhX+W6Uk3h0AEE9am6Mh1KvwyuKGwuyUzTJ9jHw+9C+UVW+L?= =?us-ascii?Q?AwI5muR7dxZaTKOgB6sB0dCn+ZBiN+LC1K3+Wh1tlUkTvvOQ74Cq9TPxOMYL?= =?us-ascii?Q?ud0nC4uGHMtdwKllq/3WkfhuLxBKeLA6jYKyefALnRRs+SHnlEpkq7UeH1gn?= =?us-ascii?Q?RFeq5xK4C/uoK5T1MKBPKL6iLKF2dddSzZ5KeSaDaAQsvhIVNd/8JfbwIH9Z?= =?us-ascii?Q?OA70za8GIAtRr7UdltXFbVCfh4CxsY2gFU/BgwcZuTW2e/cEF6DKOp5MWi7X?= =?us-ascii?Q?RNvUNtpdmYJpax9xUT2octnnx/7Ml9Zxdu9qP8frR2griGYFVzV/imyvlxw2?= =?us-ascii?Q?6wW0sGwfM9n3G5NG6oVqkIIpVOhMcNAZy9n1Ui7CGpltX5/Y+X5KrPceYUo0?= =?us-ascii?Q?M3uXWW1GhsLspX0qYLyITBalDGByRxd/ilwsOUCMyZRC1GzxyNaY+bun1/86?= =?us-ascii?Q?CpL8vWPnHZc/ap2Vq31FkvfdGbU+rOAQIffwzWC4At8RI2pLKfhHBLPimYoN?= =?us-ascii?Q?WJG0mgZe0XeJFWC0cF11OqvMGuXIchnwo9gfKR3OdQfSnuMcWzWDmDvJg/WT?= =?us-ascii?Q?YpG8P6OsyXuFWnIvacazCP2EXWmwlk4Y1g0x5cbFgFtFLrkgFz6BLamgtTHg?= =?us-ascii?Q?rbvp5AgEfJPA2DXotVgvz8xtJMFL/FmyBpNbY1hSMhABECW6eVeXFVOL+p3R?= =?us-ascii?Q?FqVLoiH8iU72C+YC+sgZ3F/grcsxT+LTf7VtT8bdccKyWeWSUrUnoAECkEQI?= =?us-ascii?Q?NineKQc3UaUg6zKVDAnE7CddutBTAYL5oOF0gwCifPXUjrvSxZPb/56++G7V?= =?us-ascii?Q?Mt0x4Vdlhwkeh3uYZ5+JCYYfnuoHk6/9uuFscPCuaXOXCnb7RL+Mqd5sk4A2?= =?us-ascii?Q?JwYyqq+mIiMKYLLnvbgW5R2ZsqQE5SKY3XbaFTaBcLAsofiNmU/pzDiwRvYA?= =?us-ascii?Q?gD5O4EqEnvkPgTWPLDh9tI+phBIWIBlw3tx9GtrG/lb6tj5BwZNuuGfLW0la?= =?us-ascii?Q?xrzWLFuyLD8oZY4LFZXByUQqG0jbetodzIM07GBnRbRPzcvalVYD+sNVnUf6?= =?us-ascii?Q?ierEVo4/xgsJKy2yGOZp93IKIhcWnmTIWgVqt5Xs8KIA2gd63OMoOlaXefVI?= =?us-ascii?Q?HLYctp079W3M+6XhDz3IOX1Yd8qJvCv2UzhFH4Nq7Buv7b1cyke199jofAVQ?= =?us-ascii?Q?7jOwGd9dnW83U8cnbuhuUHGFqbGvUoCFAtXoCQniDBJ4vslxeYlxVXjOF2VL?= =?us-ascii?Q?ScaZTrgYn1gU+SYN5IgX4riQyhHUjG+uUIxlwD2Jdt9b+VA5yw7JbC3jU2Rv?= =?us-ascii?Q?Hc+R74lCBts=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CH3PR10MB7329.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(376014)(1800799024);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?VbX2hIQ5et1C5HV4k/0ia4Qq//X+pWF5HWhic+0ohyb3Eb2VQqgqyFc1MzpK?= =?us-ascii?Q?KfbNlvLscVQgMiDQxceqlHl4kjksKLuuslQDbCSEXSd27X3Enq4tDncOVUCR?= =?us-ascii?Q?bBPzMegknL0N7kjZevaXs9HFoJK7aa6GobJq4a+FLQb7tMJ8QGJ00xP9SLT4?= =?us-ascii?Q?FXdEfvSjqFxtWKx+7rzB0U6k4iK5XoQZ8lsX9IXPXQrahT4DbUL6EfYZ/l3M?= =?us-ascii?Q?peI+cG4Kpu5VYr7wREkaBw6bUzuhvgJXAHSepC+xkZ76YPF3xGfrUG78qEPZ?= =?us-ascii?Q?NmRrvPQ+x1zY9744sW2tF0J7XZWB+PN4md8zQYWfKcxo6mPROSAdZLiTYvCE?= =?us-ascii?Q?1t/wYhv5g2Bs23LNTQCv+8SWm54eDpl5PgYHx1uFI8k+n0a0QItmio0MCRC7?= =?us-ascii?Q?2O05LQBYjDXSugnXA2o3k+BoKDn3pO+NXHcQPEZSmKkWxU6t4rTe5nZOW3qx?= =?us-ascii?Q?uCW/YE2Z1Aa16c8SPUvFUkGvwxV9KiInfdjRqXPDUb50UO2codVMOI4uwbfF?= =?us-ascii?Q?9H6P3ba99clEtYK55CLmdLZtEzdW88xF0eP3omVAajJ6XtAk3qelacpYMPj/?= =?us-ascii?Q?kmTIb+qNVa9Evq+2Zup3vCspEvbFmMenNMUBJfj+eubu/JIvySyoc55SZzLP?= =?us-ascii?Q?4Gs7WtCzLsdO8/XARf+P/Uw+ymyHrVMOXXwSl90QMT9xOeJM39ky2Kb3W/uU?= =?us-ascii?Q?tO9SuB7aqKBF2QaeSgshElL8OKew43VEgG8OEY11RWS7EGsM2VoXvJW3V4Xq?= =?us-ascii?Q?syFUVqMECt8ZjM/pGH7YLjfTswlLj2ZRNRHjXRLu72mmxMtO+IxRj+H+guL1?= =?us-ascii?Q?W7rZvgXpaSJHHLftzpfUJxuynMkSwIlKnHFln4f0cZ5gqTSxFOjWrztNHCAi?= =?us-ascii?Q?w/JF+sA7u6LH1vaKHxGEs4HXKcXQy2hDG3H1mptnjdqVIqWeFA4qYcvF91TK?= =?us-ascii?Q?1nS6UJd3fLi3A/pH7Js3KsmH1rWjmhHJBJYuuOFt5xQ84HKp/al3tEPhj9be?= =?us-ascii?Q?2pJuXXvpG/LyGE5REaHSZtCNq2b/GjftHk8hbz5olKQdIIP/84qSTSdTEAGm?= =?us-ascii?Q?QRZd4km+nB8FMZ2FVgPgV2Ch29Nc/gI/Gigw4CUvdHaGR3BdUKqxRzUahITz?= =?us-ascii?Q?I6h8CRf9GllvLMWyXBj6663nnd32QrpmR1zppQ9blEffs8BXJN+5aFL+RknP?= =?us-ascii?Q?d4pb7lfvyjzyVVve7NdbjIO5yYye0UuBz8UWcuYDUAFMoQxjS82UluAQbl9i?= =?us-ascii?Q?FnVRPfrHYqU2U2fQ4tlM6tMM66QUF+1ptsbPV5Lpwd1IJp+531hYdmQtQMmD?= =?us-ascii?Q?QwzRKbgJTVJA2q3rZ/frUo5x054nxDkRaNcVZbojBvhYGlm+feb8wsAusKPg?= =?us-ascii?Q?WyPANuktUSKTH1J+BjVDnm0J9ZqBPiB3x9P6WoHMV6TnQXt9YDpzjGQte3wP?= =?us-ascii?Q?noeMlT3hp3FUpHaWa0QNaURWoTqhKGKoQCyjt0Ih/WHfaTWFYJ+A7i0AuVuJ?= =?us-ascii?Q?ugoXbBBVRPLJc0VB3UZQbM03uirfOjCYjjy4kiSUEiZIdMPn2ld0Zh0bLLg9?= =?us-ascii?Q?OTr2G8BAQ+ftKbobbnSLgwwEOhblvWclZhFaVjpy?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: PdcmJbhCbj676CgSgcj2uYX7xHorpp1GmBsfQkjL/uj+9xzxZUoxAOPbqm6/Yyjfjnd1nU88cwKdY7PokPb1WVLgWMKja2+NF8rcEJhuYVLA2CaixzTa9tG4AfO4lpJwYAbeE0YELw/oYdGtnLKZY80tZamNCYRFLhbU3N1IB4sJKmaPSERdERzbizjE3GT+AOXv2PLdocvCNm1YAwZnACTXpIpyySL6lcCqbJhEGkIU9zTZ90SQ7UwBi30Obwdsr9Cn55lzvZZRHiqxJFdNRMAGzdy7kGBJZU2Oc/Rja/ggeKa68TRIP/NVQsPHFVTyU9WIYVXsISEvffIWhU+qE676T3TJRiC9iWkOUwrX6XMNwklvvptvbzJUZcLhVHUxdPuUGlOWCchGOe9N/gQectiH2n3gBUIhiLY8oO1wUgFps7FQjZd6+H+CvR/Mcgt6O1ZOFQRbwJpngXiYGSDXsQJlsiMOhc8v1rYcS0LDi7/mKmNg/6xV4CV6YZVExHEWcJeSyxlDjaZd0IKk/GeQ2HN8wvdhjdGvCjjD34ecguoD9Iy9jGoUKH+obigMj5SuL+9C/xNeJyz5ohVSPKJjzydp0VJxe+ua7VEBa8I6ub8= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: b40a92a3-510f-4f03-ee64-08dda8214480 X-MS-Exchange-CrossTenant-AuthSource: CH3PR10MB7329.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Jun 2025 13:18:19.6548 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: zinm4u+39XfjKTRc3afNodQGm2ul2YcaB+apvCnoq2kJUocZ+954F2SSoVrE1dXjPfEB9ng+tgvF7EAgAzE9sw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR10MB4954 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.0.736,FMLib:17.12.80.40 definitions=2025-06-10_05,2025-06-10_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 mlxscore=0 mlxlogscore=999 bulkscore=0 adultscore=0 suspectscore=0 malwarescore=0 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2505160000 definitions=main-2506100104 X-Proofpoint-GUID: K4-Jq2JnUc_WVhOhJjs1budYXTHTLfPK X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNjEwMDEwNCBTYWx0ZWRfX9PE2CojQh+A/ gpcejGR1QHW82fYSRIFtSFN/1juQurq68XXNgwRvW4xVxuEAyCkzd5Q24a4b5ue7NnGfaVpiIQI ZJG2AV/xGxO/c4zFgpEhOgQ/hrScFfntAErHiCFVNN8IgIDeogxkpeGwp7UaKgHMCx9UYpJ0TVt 9zqqnbGmVqn2Zx2/Zq/o8SEb/nvRQFK7bMX9HPrDOtHWDhgLGN8U1ccYU4BAHM/h+zovRWOZd1F AA9M871FRdlZ9rzTFuxXqQEGT5OaKtOzmJcGrYl1GSf2Z6Hegmi9KgKMNyGpAIT5+Mj7z0ifdt4 TcLbNXDu0XfZazXep5bbjikiccBcRAvFkXxYlHamUQsPDfRHf6vYmlZ7r7YmTSazv6Flv/Wp/VC JtqpzgXZHdJJATxdCylOgFheAP4yhA1yHODY4oH6oPmZ1bqgg025fWYqPRrkT4d9526ewbrk X-Proofpoint-ORIG-GUID: K4-Jq2JnUc_WVhOhJjs1budYXTHTLfPK X-Authority-Analysis: v=2.4 cv=d731yQjE c=1 sm=1 tr=0 ts=6848309f b=1 cx=c_pps a=qoll8+KPOyaMroiJ2sR5sw==:117 a=qoll8+KPOyaMroiJ2sR5sw==:17 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=lCpzRmAYbLLaTzLvsPZ7Mbvzbb8=:19 a=wKuvFiaSGQ0qltdbU6+NXLB8nM8=:19 a=Ol13hO9ccFRV9qXi2t6ftBPywas=:19 a=xqWC_Br6kY4A:10 a=kj9zAlcOel0A:10 a=6IFa9wvqVegA:10 a=GoEa3M9JfhUA:10 a=yPCof4ZbAAAA:8 a=0EAfbLFM9MJhkNqvil8A:9 a=CjuIK1q_8ugA:10 cc=ntf awl=host:13207 X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: CBAE7C000C X-Stat-Signature: g9147a7rob98ra818nc93f556j3nqjd6 X-Rspam-User: X-HE-Tag: 1749561508-831186 X-HE-Meta: U2FsdGVkX1+gVJjC9mzQl1eiUvAM1MCGSxEcdkl4Xf28KSQpG+Skbf15YCovpAfGuaO1UKWD1/5G6qn7ip7g5JCrJlRC28Iwk+MQe0Q1GzFut2moO95LDQAd1yDBpc6fGVNbwfAkcX46i4qeOq6vDejWMUfD1cZLN60E/6UITYWM5XzMnglHZw9Q1HWROCh9IL9OaldC5YC/HGmeSg3P0/3Fg7p1QCNTC0NbSPLReIjRulv2FnACHnj7PbCPSUO7exON8ePNpRaDXEbKu0t/QZsSRuFuCqTxKwJLVGDzgER6lx8T0moY4zVO81xHBE9/Kmyzlsr+e2ACFbJav/eJd4OqS/fZsCXdS1UOnEqPUV5ez910vDWFzSqZBAKXFZ8RBXHP9S8LMJxYQWRaLDO9TfFpYNdDS/mMJRaYR6ccYdUqou57AVQyE2zcPF7gc3IO258GNBK+gFsfBO6LqJJsQds8EyZNJ0PZMN9xK7o4hmgCyQ+peRZeEQs6xeI2bxkJ1puZY8RKkDgVvAj/QC3zitho2G61w+hSLCcDRJRL3jLb6kUI1cBQ/aVgXW700Nvl9qVRcOXAK0FV7dkZSocLdD0MzHvE0ImAHU9+9m79SBkRLunOvaOqbqb/nBLAw09wRUzoN7J4rEHxckTNcp3p2aX+7+hcNK1yqzHeqd5c6+X4EMG4VpgI1ZNWVQyaIkCSUIXijpFwAmgEM+T1jEWSUBdfGUUGcUfXElkufh7GY6E5MJkRCDHsKGLN+p6zevYdHuFcIYUjIryceNQ4b9YhScEBUeB+vnwNr957OoMO0kI1WVzcZ8NYrLMXT7knL5iUgkeANeiCJp6znNT1lT6OCdbe8Vy7ubaRTuI/PWfXUNegQb8NJQ6O4tX2LNBlfmsnXCc657Gd9gqht6LgcqBHrp2F5ZfmxZr2RO94/bWF8QDOGKrEjxeFwdR/H+88IWzYIAJOyPjX3Kw5DtRUaMJ MJPeM2eX D+HTfaXoAK5RCezZkkhwgf2+qtxqro0lHrIo3vqEvdfE/Mq3SnU67GlGpC2QCGmZoIMr2gJETPbvcPzcyztCXc5UDiXYsW7eoucylXsSixHei1ynzLUDI8IUT+IDuS7nAP9haDZzGtnZCWMoDy9opVPfGoNGsxNwqsAIX6E9PxnYgX/8YpG30b6Kbf8cIoZ/t6wrFbhp5omaLx12tKLPGHx6cYvPoV6i2TJi0+CQZRjKUL1kpRBBABfGpgKCggGP6013m+EsVJNz/BmCfi9gHZ4Z1AyRf6EM5MlbtQc8/ExO/v9t4u2PVdsN8K8ImH2CBUry1DEdDv+jesaNems9sYe7OZxjjE+huWa0UVMotrVtNymPaBA97Mj9lFrM4RFGzHDkjbhjCW5DvexocOFxSN0K7T4YRdIQVDQWVg8/3HeOdup+2PAu2avh89Br83ac2Jt9ZafOlEGisuddLjzvyNrwoG6bwraEcXCQsNpBmOiAnxNNZvshX+Lp1a0VSeLB40GiOaDMXEqcRfdINORilrOwi0hopkKztqR8rnYbWpN7r+L17AkdEP/vkYOJxB6K8H9PI8WiLO+/T0WhfAf3JsqUz6uaAbgwSflXtKyLZl6KqDMxW6zinZRvxKn5xziOtHY4OyToWAvbORbeec14qsiEp7jvh9lpiVYdw3ASkGGiIoh5iyRueFay6t2CjHKA0Wz5ttPBJQOw0A3ZJ3+1c8Ho2Hs2amzSqZcBzqThG0Xi+HPnBak9NAlNrzv1vqKUaUfqPjcbvk7FP56AdNfZLP3cf2uaX8gKcnWCR X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Jun 10, 2025 at 03:03:12PM +0200, Vlastimil Babka wrote: > On 6/10/25 14:38, Harry Yoo wrote: > > On Mon, Jun 09, 2025 at 04:22:01PM +0200, Vlastimil Babka wrote: > >> > With the change, the nonsense slab pages disappear: > >> > > >> > $ sudo ./page-types | grep slab > >> > _______S___________________________________ slab > >> > > >> > Fixes: 130d4df57390 ("mm/sl[au]b: rearrange struct slab fields to allow larger rcu_head") > >> > Signed-off-by: Harry Yoo > >> > --- > >> > > >> > No Cc: stable because we don't usually check folio_test_anon() on slabs. > >> > >> Hmm maybe we could just make the code generating /proc/kpageflags stop > >> testing/reporting those "flags" for slab pages? > >> > >> It could be even more future proof code for when struct slab is separated. > > > > Not sure if I follow. When struct slab is separated, checking if a memdesc > > refers to slab or not will not have false positives, and thus no need for > > "must check folio_test_slab() before checking folio_test_anon()" rule? > > Not sure I follow either. I mean today we can add code testing > folio_test_slab() and only evaluating the mapping flags (ksm, anon) if it's > not slab. Once we convert to memdescs, that code will stay logically the > same even the testing functions will be named differently, no? Ah, I thought you were saying it is unnecessary to fix folio_test_slab() false positives as long as we always check folio_test_slab() before folio_test_anon(). Changing /proc/kpageflags in that direction will work and will be future proof. Will do that. -- Cheers, Harry / Hyeonggon > > Of course, to fix false positive completely, I think we need to add > > something like: > > > > __aligned(4) or __aligned(CONFIG_FUNCTION_ALIGNMENT) (whichever alignment is bigger) > > > > to rcu_free_slab(). > > OK. > > >> I mean there's even a comment above PAGE_MAPPING_ANON: > >> > >> * For slab pages, since slab reuses the bits in struct page to store its > >> * internal states, the folio->mapping does not exist as such, nor do > >> * these flags below. So in order to avoid testing non-existent bits, > >> * please make sure that folio_test_slab(folio) actually evaluates to > >> * false before calling the following functions (e.g., folio_test_anon). > >> * See mm/slab.h. > > > > That comment was added because it was a hard lesson learned from > > false positive. > > >