From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 42DF2C5B552 for ; Tue, 10 Jun 2025 14:16:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CBA346B008A; Tue, 10 Jun 2025 10:16:10 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C6B1C6B008C; Tue, 10 Jun 2025 10:16:10 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B81046B0092; Tue, 10 Jun 2025 10:16:10 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 98FC16B008A for ; Tue, 10 Jun 2025 10:16:10 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id E67E91CCC53 for ; Tue, 10 Jun 2025 14:16:09 +0000 (UTC) X-FDA: 83539690458.10.7ECBECD Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf13.hostedemail.com (Postfix) with ESMTP id E87292001F for ; Tue, 10 Jun 2025 14:16:07 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=JjJCp49V; spf=pass (imf13.hostedemail.com: domain of bfoster@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=bfoster@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1749564968; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ckEtXaJDkq/vPCJoXtoHzuYpOtdz098DwOjgA2RlsqE=; b=FlArIAEdDklUe11lAYNX1jT+jVs851gCLopnTYJw7bvRIysqW4kogizxcNejkId5pZSc7U 8XFbfdbecTFRC/KfpALX5R/BtpfmsJrUK1uhYbdF2TcRvHxAH/JS7Io1Ki6duZL8WTa2j2 eSJdAFn2tTWAkbzg6mxsbqstv8WdVTg= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=JjJCp49V; spf=pass (imf13.hostedemail.com: domain of bfoster@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=bfoster@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1749564968; a=rsa-sha256; cv=none; b=Ui10/nByE6P1xkrKt25n72x4Mn+CT+I+aYibDFP+n2oGPhf+mKOasdidqiMnEd2kRdX0Bt suHq8s1PshwabtnjAWaJ19EMmw6L9FWsZHyZePTrG61rDSR7huIfROzuj4I8d2UoQx8KOZ aMd6q++F+p3il61L8JrC+DWlio2yPyU= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1749564967; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ckEtXaJDkq/vPCJoXtoHzuYpOtdz098DwOjgA2RlsqE=; b=JjJCp49VkDJpWmzw3It6Y70Noie3wf0JIfBt/ewkkvKkVTJfEyEK61+fuSXYmupDCtmRge jKcyN3L+g3Yh4/9k/5YVoAxfWQrsEv1GzJEffwvI9DWqEZEswehZYQq1ir7eHXxJsCaCX5 JyGdOGTmL6K712qHFJQ/WQQn3o6eu2k= Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-223-0-dAorxrPJiRa1APmCi7lw-1; Tue, 10 Jun 2025 10:16:04 -0400 X-MC-Unique: 0-dAorxrPJiRa1APmCi7lw-1 X-Mimecast-MFC-AGG-ID: 0-dAorxrPJiRa1APmCi7lw_1749564962 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id E89A419560BA; Tue, 10 Jun 2025 14:16:01 +0000 (UTC) Received: from bfoster (unknown [10.22.80.100]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id DE2B5180035C; Tue, 10 Jun 2025 14:16:00 +0000 (UTC) Date: Tue, 10 Jun 2025 10:19:35 -0400 From: Brian Foster To: Christoph Hellwig Cc: "Darrick J. Wong" , linux-fsdevel@vger.kernel.org, linux-xfs@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 3/7] iomap: optional zero range dirty folio processing Message-ID: References: <20250605173357.579720-1-bfoster@redhat.com> <20250605173357.579720-4-bfoster@redhat.com> <20250609160420.GC6156@frogsfrogsfrogs> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: E87292001F X-Stat-Signature: rdiofxw1yj6fhqsbrkzhrt4mkyt98nao X-Rspam-User: X-HE-Tag: 1749564967-127138 X-HE-Meta: U2FsdGVkX18Ajj19Fiim0nbBdLffrkVXMDMwiwDua/kV2o7BTwBt9hRjju/z3Yua/igyqDcZyusM/kaR4v5hrvoO49sHNBs/HnyQ77Vz/7CDtoQoMuWvMBivu6WwFOSmG5dqqQNhZ96+ZJtr/E27ZC7Bb6t1JIcVvWJP/5O7vBRA7/H6/S3ye8zopCQccUik2gWcKv/JHbOPRGq5JcV9PjhPbmRB5pQbWeyrwSF0nGVE5tlXu/tncsto2scRzcLhwLq31l/eXamduBJ3FgpGPVXmAwmDNVjfYUeXAgTK3w6Esrj1YwzZtcagb4NXPIjHk5BLS9euDrHpduSpqtd7E9CkRsvxPyku164I4TfDSJNqJyrWsKny0uD8fl+SqBRsRNMpzUkSyPDY+KrM6a1ra2qfpGAueCtWSyroa/Vw/Mrd4uNhKFWwRCsqVmsOufMhyoJKQp8z2S7Vauh2tzxy03Emye+ak8c94c+VkND65Te7sf2SMUJW5ud8aSzZUhmrALKiPYYHaj7tlSanERu7uP7ylIeFJzH2mSzGv4UXIdeRnSKBcviJIVZevuHrF4XxfdvQrtTolYW7bOMqsPSQFMGMWoP9rFFC6jCcHm+d2r4RemDXUEq+ipypOpkt//Wb5s1liRtNI+pn0vkYdORluSt8gg2aBIo1F4oNfVAcplC/0GBIqt7n0Krw9X/4h86qVYpKfmR3WQFlTGZGk3UhFMR6c3wpN1uvnzgRiEaoctzKHXzGOQWqr2XrWVsVFJQgZ2Cuk8le89m6mzYYpaIZxUFD3hgBucgyaCHDpo4Jcx+jNtaWrkcpdlfzuy/+C9abdOgy9fWNho5TAauPZhSVrEl+TFGWoDiiAVY2WJG8Ge0i7Ayst6eUS+yuhnL0HtyMPmGXp9EysU3kU6XkaDfp7gVlxCH0VmRI8Vguy3P42nSurXYsHM2ayTTCRbGC+Xzsz39QePsM/c2+Oup+3Sr Y/yLnh1n kCAMEhYxTLqs60H9XNXbumGhwu+IktLfkXOm2XSLYS+MYlv1ODI49IA98OxA8r6HCil3AjUBzxfagcI3G14/ICZDXnNVAwQ0Qk1cltoR2SIIJhtodJCM2tT0Sfh8b/6kR9hyaBXImZyMct61GgGWeyLfqGPlHmV6v5C3BFIjHPVpVcOFMnlMs0ve0mSmmxjtrH1R5jlT9AVa8xxgDWK79QjOrOdHZaFD7suabATcLgqMkMWmsuFaMW8wPwDAmFDhpCDGRRDQCVPQpuIVXI0CVsDgvpxzpEfqjJv90ECLo/xCF8HIlmqLWP7BveKoYNdcaMpQLooXF5Esx5DTCWdHeiXzm1QWHBwCg64KgfOrGhBVHXF0= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Jun 10, 2025 at 06:29:10AM -0700, Christoph Hellwig wrote: > On Tue, Jun 10, 2025 at 08:21:06AM -0400, Brian Foster wrote: > > Yes.. but I'm not totally sure wrt impact on the fbatch checks quite > > yet. The next thing I wanted to look at is addressing the same unwritten > > mapping vs. dirty folios issue in the seek data/hole path. It's been a > > little while since I last investigated there (and that was also before > > the whole granular advance approach was devised), but IIRC it would look > > rather similar to what this is doing for zero range. That may or may > > not justify just making the batch required for both operations and > > potentially simplifying this logic further. I'll keep that in mind when > > I get to it.. > > On thing that the batch would be extremely useful for is making > iomap_file_unshare not totally suck by reading in all folios for a > range (not just the dirty ones) similar to the filemap_read path > instead of synchronously reading one block at a time. > I can add it to the list to look into. On a quick look though any reason we wouldn't want to just invoke readahead or something somewhere in that loop, particularly if that is mainly a performance issue..? Brian