From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A6676C5B543 for ; Tue, 10 Jun 2025 08:03:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 38E2B6B0096; Tue, 10 Jun 2025 04:03:05 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 366F56B0098; Tue, 10 Jun 2025 04:03:05 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2762C6B0099; Tue, 10 Jun 2025 04:03:04 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id BB2BB6B0096 for ; Tue, 10 Jun 2025 04:03:02 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 2C6741215CF for ; Tue, 10 Jun 2025 08:03:02 +0000 (UTC) X-FDA: 83538750204.15.2F21C10 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf15.hostedemail.com (Postfix) with ESMTP id 05067A0008 for ; Tue, 10 Jun 2025 08:02:59 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=dJp4aQou; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b="/YTlastB"; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=dJp4aQou; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b="/YTlastB"; spf=pass (imf15.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=osalvador@suse.de; dmarc=pass (policy=none) header.from=suse.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1749542580; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=7O/Y7vxGEJ8azXIqfy5bhZNskz1ZctXO2NByaQBrfMA=; b=TW3D8idwDsRE6su6br7MzYhvaufuv/VfMgLKWYO0PbDt4CxRnhyggKhNZJJNHl5BC3ggTg rKveAf+RWSZqVMXtP4yBQUFjOM+kExOspsT9TqffgHPzyOjoVIktZ1NU/P4UqyQ8bh5JRo XzucvZ68I9zUJsHXbFjaBX6Ebr7bKVs= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=dJp4aQou; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b="/YTlastB"; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=dJp4aQou; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b="/YTlastB"; spf=pass (imf15.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=osalvador@suse.de; dmarc=pass (policy=none) header.from=suse.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1749542580; a=rsa-sha256; cv=none; b=JIgUfn24RTTPAn5KPoOyd3RZDStT7/eE82hLR6NMNRHhJwsv/xX6sR2HgluYp7SgSrXhzD 7R8ZHK1987/ruqqGz54suddYJH3skey4rN0np0m3AqiNg2/ABK1HDdWfLPA2ZBsMOW1x3z JV6Ryv/22SI6G64lRC+C5/CKAd7yr+M= Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 666B02118A; Tue, 10 Jun 2025 08:02:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1749542578; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=7O/Y7vxGEJ8azXIqfy5bhZNskz1ZctXO2NByaQBrfMA=; b=dJp4aQoukHMXwmzqTgAr3LBn6k0Sai3WyC6l/KXL3By+5cUsBaDeKdgA7LZlvxScmGYNpg sYbvwpDYKLPzTxNGeYxHz6tPfLOoqjBXT6AghNH+16DLOFhB6rrlNutixb0cfAXXbSN4cq OR8GjMFVYS3rkpeBRlTmwSXHZal89ws= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1749542578; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=7O/Y7vxGEJ8azXIqfy5bhZNskz1ZctXO2NByaQBrfMA=; b=/YTlastBYkqNpOwhysEkxURyq+2W0V7QeYwIokXBXvGKdrlNJadvd++wvPdU4Wmvje+59c 7bS57L4+EPa13/Cw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1749542578; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=7O/Y7vxGEJ8azXIqfy5bhZNskz1ZctXO2NByaQBrfMA=; b=dJp4aQoukHMXwmzqTgAr3LBn6k0Sai3WyC6l/KXL3By+5cUsBaDeKdgA7LZlvxScmGYNpg sYbvwpDYKLPzTxNGeYxHz6tPfLOoqjBXT6AghNH+16DLOFhB6rrlNutixb0cfAXXbSN4cq OR8GjMFVYS3rkpeBRlTmwSXHZal89ws= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1749542578; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=7O/Y7vxGEJ8azXIqfy5bhZNskz1ZctXO2NByaQBrfMA=; b=/YTlastBYkqNpOwhysEkxURyq+2W0V7QeYwIokXBXvGKdrlNJadvd++wvPdU4Wmvje+59c 7bS57L4+EPa13/Cw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id D4216139E2; Tue, 10 Jun 2025 08:02:57 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id t1MoMbHmR2hzDwAAD6G6ig (envelope-from ); Tue, 10 Jun 2025 08:02:57 +0000 Date: Tue, 10 Jun 2025 10:02:56 +0200 From: Oscar Salvador To: David Hildenbrand Cc: Andrew Morton , Vlastimil Babka , Jonathan Cameron , Harry Yoo , Rakie Kim , Hyeonggon Yoo <42.hyeyoo@gmail.com>, Joshua Hahn , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v6 10/10] mm,memory_hotplug: Drop status_change_nid parameter from memory_notify Message-ID: References: <20250609092149.312114-1-osalvador@suse.de> <20250609092149.312114-11-osalvador@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 05067A0008 X-Stat-Signature: kqttrqx5dnr4yp9o548n8o66ifak6bih X-Rspam-User: X-HE-Tag: 1749542579-130363 X-HE-Meta: U2FsdGVkX18OJAp0P+X23+DlgaZc41nw2GUkmNm2scGnpub1Roks3GYQbxr1xYgQKzzEf6R9mIygSPtVqBR49/NPJ//vDfNA94PWn7Y0W4eiBHHNJytxeJW7D4TH7hCGBXu82mwSka/xJYZOZZ+hYzf4LD3zzHhdHovzgQLLXXRamyFYEjZqHxe/bNNgfQeHxoue5dCmwYGHcLN1wYw+LmnXuAsLkXWsm5YTpxafo3jM6E+pCFJKborxgGPFn7SFbL9S16Mn+EsEYEWlSBrjAENZOjv/qROmdYWs5rMM1JoRB29oxyP1Yf5jdvUY/RZdwgYLYnOReHmF5o9HzgBw4xPElLD8QVTh89ohAb6n04Uy8tRoklx+kQe7KK2k+zqq4B2aQRHw5WNAI32OR/NH5wiuc7dXSPfVPDOlJNUdd7taUFx4oX8Ea1RSOpM6/kHN9o8dt18KplGqlrrKcrOcaT+3bd8j3aI8ku28TSCxKUyvDjdpl2IMWTgg6gqyehXMsK5XxQoiF5g2zYUmpXfM/vB/bJrn4x+5QTFTB1OgiCCSCFitxRuNNGy2SLIOdM0dLD0m/hDd//fkG784gvHlG58+BCzNgtl1tE+ECu1SIlc/GfrX/svz3xC+zGGZLO4/dGW9W5Lc1u7dLDZpxwjosbadCEi/FoKxAWqge5wubZq993dF+E7r7cXf5INhDxbplb6QfyccE1SZ5c2hey6wij4JnDNzP4xGgFILitC/JK/lMO7THV4tYX9p3aF6CbSPK5buGIjZ3Gqnp7SyQw1ZYx335kz2opLLCuSt0OHdFq9NuIJYlxjLymZ1vvlxL2l6bj1XH/rXiX+0PTBoynEm8nGc7G+kOe9FgS4wG8AhvX6lM7P79XQtvtLAjeppKHj7uPtfLDkLb9lkVU8/i+8snJzKPfs6cmMJQ7p2RVZN9fVb4i/HFgU2jheY9S/gCRQnngZ4TmADzSlqT1bQq1w QqMdQcTy YYfVRtuK8kochoinRyj+4dggWKokGCeF1B8+fJA3c4DaaDwrz31aEUL7pGwZ10dcuqDD2qrqeWvZrx+A8X9woajKSzehyaSjLN9DKNRKWd9XjVnyp4bzh9NTTiPb8T+mN6gkg4Po6uQ6o7QnC7oizUYD2oNmurWybVDm7PS5iDv6eod6B17pg7mMA625kczHgH9xXPVBAnCSP4SpNcAOYpys8WHoKR+LLWEiETE1qugdE9f+ivKNM5kM4cZBLzLqiUc8iEzMW5ngxSdoocGxQT15icb0iiwPHfOwWEsZ9fBDfo0UPpQmS/IqHYxuHYenBtQWSzivIxYX70a5/DeUcagwOqFtK0/XWwk8fgjj4iXRZIBfuPClDoWs+Bj2O+cl+NyZw8fFfUMyUkNrve3vs0S5LJrTz4Q3lg5VZRkyG0AiGeggt0s1RhllI4A== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Jun 10, 2025 at 09:55:27AM +0200, David Hildenbrand wrote: > > --- a/mm/page_ext.c > > +++ b/mm/page_ext.c > > @@ -369,25 +369,15 @@ static void __invalidate_page_ext(unsigned long pfn) > > } > > static int __meminit online_page_ext(unsigned long start_pfn, > > - unsigned long nr_pages, > > - int nid) > > + unsigned long nr_pages) > > { > > unsigned long start, end, pfn; > > int fail = 0; > > + int nid = pfn_to_nid(start_pfn); > > Nit: Keep reverse xmas tree :) Boh, I tend to, I guess this one slipped through the cracks :-( > > @@ -436,7 +426,7 @@ static int __meminit page_ext_callback(struct notifier_block *self, > > switch (action) { > > case MEM_GOING_ONLINE: > > ret = online_page_ext(mn->start_pfn, > > - mn->nr_pages, mn->status_change_nid); > > + mn->nr_pages); > > break; > > case MEM_OFFLINE: > > offline_page_ext(mn->start_pfn, > > I would have moved the page_ext stuff into a separate patch, including > documenting why that is fine (e.g., memmap initialized before GOING_ONLINE > call). I guess I misunderstood you during the previous feedback. I mean, there is no hurry so I can do another respin and split page_ext stuff from this one if you think that is worth and will add clarity. > Acked-by: David Hildenbrand thanks man! -- Oscar Salvador SUSE Labs