From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2C8A5C5B552 for ; Tue, 10 Jun 2025 04:20:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A348B6B007B; Tue, 10 Jun 2025 00:20:55 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9BDAE6B0089; Tue, 10 Jun 2025 00:20:55 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8ADF56B008A; Tue, 10 Jun 2025 00:20:55 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 67B276B007B for ; Tue, 10 Jun 2025 00:20:55 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 03E341A04B8 for ; Tue, 10 Jun 2025 04:20:54 +0000 (UTC) X-FDA: 83538190470.24.D4284DD Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf12.hostedemail.com (Postfix) with ESMTP id E85D34000E for ; Tue, 10 Jun 2025 04:20:52 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=k4DwGwOc; spf=none (imf12.hostedemail.com: domain of BATV+631296521f62fa6b3e9f+7961+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+631296521f62fa6b3e9f+7961+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1749529253; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=zrJJXWsieR0MemyzwvlFmPTI8u6JRbG1FAK5LcmPD6U=; b=rjB2/rbB/oJs8/hfvzyp7x/Ocg4ZQxAr1u/MqwkizD8OSCYpYNE9/JGyXB16HcqNV7vyod aXT8xtDeTkzzpCAHIcwgpnbeWvbbdChC/QpCjJGZ/6Rm8wIIkuinbptHy3VU26FtP0o5rb V3iVWS6hfI2bt9TNd1LXbCAWurULm38= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=k4DwGwOc; spf=none (imf12.hostedemail.com: domain of BATV+631296521f62fa6b3e9f+7961+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+631296521f62fa6b3e9f+7961+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1749529253; a=rsa-sha256; cv=none; b=mGpkbBWUcWBx6xLbW1p5TnctVE9SbsXoCKELG2VSyZYqN9jipttOIusDQ5L7SFgh5pBo2+ kF+HS6YxAaWNNehLt8mqxN94hb/yJPl/XkdqdAPcOflUb+zh5+aKJB+9yHaM3S6V4K0OWy GaziIE482Lv9/2hcwATEfhv00WDzj4Q= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=zrJJXWsieR0MemyzwvlFmPTI8u6JRbG1FAK5LcmPD6U=; b=k4DwGwOcY/0Rc2f5K/4iy/Am7w 6ZBElmx8ADsvH7aKUBfARXuu19vB10Vq65xtANWkORdPlVDzU5SDa23k2SwwKDSJu1SPRc+zrOERW fmieZvW3ctuSbf9d7GMCImMjmtidQffzq1kpiO1jZnh1VyPwsz44A/cfdI+28D5q75HRLhlJiKU4M rRzyXROpCi80QTlE300hbcNpYLoXijijKi2tIa9eZGlsUQcxxJDjbQEPYBzTCTAG+C28KjTyTrhQ3 d6NTY3400vGwm4ha2p+jPWq4+QWp4tOWb506nLIXnJ+URKuXjQ/QL1vM6KMKq+qMF/HisovDM3MSd /r7si5sw==; Received: from hch by bombadil.infradead.org with local (Exim 4.98.2 #2 (Red Hat Linux)) id 1uOqTj-00000005jxb-3M4Q; Tue, 10 Jun 2025 04:20:51 +0000 Date: Mon, 9 Jun 2025 21:20:51 -0700 From: Christoph Hellwig To: "Darrick J. Wong" Cc: Brian Foster , linux-fsdevel@vger.kernel.org, linux-xfs@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 1/7] iomap: move pos+len BUG_ON() to after folio lookup Message-ID: References: <20250605173357.579720-1-bfoster@redhat.com> <20250605173357.579720-2-bfoster@redhat.com> <20250609161649.GF6156@frogsfrogsfrogs> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250609161649.GF6156@frogsfrogsfrogs> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Rspam-User: X-Stat-Signature: tk9rtes9styecdwksf5gnd4cdq845f3c X-Rspamd-Queue-Id: E85D34000E X-Rspamd-Server: rspam11 X-HE-Tag: 1749529252-791929 X-HE-Meta: U2FsdGVkX1+OMc/rSiKT9JYn38uyM0SPJs/1hnefp7PVnCbtsk4onTOoi5oIVq6GAmj/RhUsDMTU8KPT5/srAlhLqGJOu9e1k0UhpkVpbzAA0SinQwSU+svkxvd58BzV8nCwb26c3NhofTBGQ7EAUrQlUN4yDBZ5DKq+BiVZ0uIPTC8XZwVKYUb89tHmufLAbkcn/kvEz21qReRHqeuEcdGwD3m/ctEvu8/YEQ2KOsjXzVbl5hSEVJJUFeyW5cuWKaxhrKOWcytCU19RqMUINb0hKcl0zyNrUkQHXyfMOK2etWVqUPymWxYN1BRlSeZqbaoUty8tvS7MEGN65bDVttq7YIwikpD6Rh/UsfDsRdYwjeNORnSvnLRAmMIQiPKnALH9LaF8/+TeXiB3GgbZ1DXsPaU93P2yD5EbdVEl1gprB13wQ4rmTUxGuU74jGctFTjhean6WQ08/rbD1TcCPyna1gZz30xNoR0IoH9zhNT5fM2NI3qLC9zbRJAoregHCVaWZIukyS3WsO9P+3VYaIfHIpQ/7IkffSHNTm7bJ5XmJo0yyiJfU8QZ/SMxDG0c8sXS+U8WiNKVTzEjj7vDMk3fd3FwV2dV0/HdP6xfWkgZFC0CTEWOZllL5Axxlp/1Ka4+CzRBfn+b3AziLgaRbIecbQIUyWdzEugWPoP+4vHbndFZl2wiPwxM3Ln3PMhOWny3jwwjYxGT7x8aLXxeltWRUL4immKsz+wvKTgHeZX8QUIhahX55fCrbNyfbul/lsf9GqHqCWGNlogpMeqBNNA4hzv9KND9S/CUiu00/+SWUxksWWH0nWtj3xj6N3tzgacBbdUtRVZmLO5L55bhTNfqN8ro9gOpwp460R0MxCfreKeIQmOzCUAM84g4mGi/7msIp94AmlRJi0GgqecC4xvrbfO8Q4zRJiTwVuVBwGazPLEQ0N4aFi59Vcp4u7Ssi8Gp/s4BnrlgwqkM8wU Z83lZmKX p9+TnAHsguCXzn/2zM1Y4nZ4qoUnHNd5gb7o8V8FDXHYd9iid11n4hqu8IRGLwJAAo5Pq1jYmT7rcAcbXXAfrbI2XXfdd8h+Fcy4S4dcA/RSmU1Ppg1r6KUM4zPS0JuEZbHyCsKRv1Cno7J6nIWth7v7wWvNobln2WvnYhIsv0n93IHjDDspG6cO/vH/h0JTgtzdsZaTkeU0bVvrDpVCkZqkjTv6O7MoglxRY X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Jun 09, 2025 at 09:16:49AM -0700, Darrick J. Wong wrote: > Hmm. Do we even /need/ these checks? > > len is already basically just min(SIZE_MAX, iter->len, > iomap->offset + iomap->length, srcmap->offset + srcmap->length) > > So by definition they should never trigger, right? Yes, now that it is after the range trim it feels pretty pointless. So count me in for just removing it.