From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5E60CC5B543 for ; Tue, 10 Jun 2025 04:33:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EE1DC6B0089; Tue, 10 Jun 2025 00:33:40 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EB8746B008A; Tue, 10 Jun 2025 00:33:40 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DF6C36B008C; Tue, 10 Jun 2025 00:33:40 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id C1CF86B0089 for ; Tue, 10 Jun 2025 00:33:40 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 6351FBE7A3 for ; Tue, 10 Jun 2025 04:33:40 +0000 (UTC) X-FDA: 83538222600.04.79CB167 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf25.hostedemail.com (Postfix) with ESMTP id BE377A000E for ; Tue, 10 Jun 2025 04:33:38 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=Jfv8ECEl; spf=none (imf25.hostedemail.com: domain of BATV+631296521f62fa6b3e9f+7961+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+631296521f62fa6b3e9f+7961+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1749530018; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Bhq2uAvmwXciN4wckjAT0jx5pVXgwcgkUjPtu3OFJH0=; b=mNMx8S5sEWnyaBzlSFUMyv+63spjPDoqyLF9YOEGtA6X+DKxji+3H3twwfT3mtsjxzcQOa sxhu1LvSexTetZ83Oqhtq16crwNpZC0rlMZgKZLmSBttx8VNWvy31NxYKUnIY8COxLq8sl sdbfVNoPuqxuth6/dDytbRG2//Gi8/4= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=Jfv8ECEl; spf=none (imf25.hostedemail.com: domain of BATV+631296521f62fa6b3e9f+7961+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+631296521f62fa6b3e9f+7961+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1749530018; a=rsa-sha256; cv=none; b=q+JZ3qox3Z1yy5z6OD7nP36TqxkJz1BkccFMXoqBg5+/jDEi9nYwPzmqo9k/aizCregV11 jPbJ8vI/ASJT4b4sBU829g6TjxPp3+UOk+Rwgdn/tYq2KosKzeLcowuIse84U1au3ObHiL evvf1cPdrnnSnznhitl0xnDX0UbDACA= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=Bhq2uAvmwXciN4wckjAT0jx5pVXgwcgkUjPtu3OFJH0=; b=Jfv8ECElD21wKUw+n70c8bi9PW wWVZeWS62A7tVJjPKimwOrFmP/C+3XOFUPEssjLqow/KxdTbOvi9tMic0n8aF9a6NWB241oMqriZJ kNxOdTZv1Lt8FW8yaECJNAfq97E3uUzbPRze3JQ2S7fLmLL9FesmVCwPB00g64r5zZIOwRgkBRC0n q+slHldJS+D/D0dsjwSLbneXPqeHc5fp7RYj5XKcg3BqhgzFfiKM6hrslildSK8ofcz53OJnDQlhl sFNVJyt8BXS1PITYU1HMQk5Np9ZmRZheLpVYwcc26DMiyceC/mvbPjZ+Q4p+SNKLTm/znB8GYC5dr xjB6E+KQ==; Received: from hch by bombadil.infradead.org with local (Exim 4.98.2 #2 (Red Hat Linux)) id 1uOqg5-00000005l3x-3zGi; Tue, 10 Jun 2025 04:33:37 +0000 Date: Mon, 9 Jun 2025 21:33:37 -0700 From: Christoph Hellwig To: Brian Foster Cc: linux-fsdevel@vger.kernel.org, linux-xfs@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH RFC 7/7] xfs: error tag to force zeroing on debug kernels Message-ID: References: <20250605173357.579720-1-bfoster@redhat.com> <20250605173357.579720-8-bfoster@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250605173357.579720-8-bfoster@redhat.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Stat-Signature: k99k5qp7aji6unnc9d8kjpc784ykdjp7 X-Rspamd-Queue-Id: BE377A000E X-Rspam-User: X-Rspamd-Server: rspam02 X-HE-Tag: 1749530018-678854 X-HE-Meta: U2FsdGVkX1+59O3lP5tVtjuQej3dcfO49cnhb0o9A4zd+B8xR4NXlK3nYA8h2/TXawnNig7l9TH9bouqfncOlGcdewoffCCv170G433umgF2kBwBnnFI6vVsbOlGO9J7no3ySWODsmlYtA2kLyevaEwJrRrQoU1EEmNdHkAIWVZ7l3zECN75mrSpy1pdbCE3NJp5gdWorQV2oyRYTnSzCfN6+pObfVRfj8949dzUwTemu76fZ5SKJKvCgIhn6Hvdgu1zP1agBhtVeJE1P8Y1h0pZWhpwPdl9ut3fgNtNmO13io8YddmMAG6PH7sMHTrWS+mE3w+FV4pYWOmiLraW/FSsofQooOUjxLE0zqvc4iG9EX9aKdAs0QfhsNqVcW/q+GxrBru7dbmX/R7lCt/Z4YccE5L/XNg3XZ9tLM3LWqp5dMe2UCeF1VfNH7OipiCs0IhAOJm/zhIuwXfTMInz79yzrlXcE0p2Er54f/I2lj7bjd26UYCA9e/ZkKDFBGRVRTqShZu7XXXJxnP1q6Mq2OTheE5ElvbIbiXJnvq0lr+i2yxtkizruYXgiE6+ws9QdqZi2vmreiXmc7RGz4gejjA1oL2dKaSjEYH/0AlrTNnsIECm8pIaXqZLcb2zRQneuo6B4m2DpXkAHx9ZboJdUWR55f49HNyIesk2JRP+zoAQ9AMQ8J0Abl+UOMTkxnJJmfSlQ1lGh2Kbs4DUlQC7rjWDaasq+ZhxLVe4cLKz5DpLDV3kND6sAOqvihoClG7p0RHJSwQbL4yQDKGoNulsFZH+GwkCHUfQUfESEbIYUgyW/GVYM4okofb8OYJPVElL4PiR7TxEJTL8jP2T1hEPibCIUoJajbNyBLT1jfv+YQCzm3l+I8y4OcIq91MctJ54EOqQztyxcdz/RnyUODNTBMynZRmRSqFjC9B5NtdS9SA1A1GboVA50QsM5XdIrAbTZ9Gul0K4g8irR301xOT YAezZPjd YhoYBTB7Bv4/TbYLEM4MA7j7wUXGHtMn0ul2IUaT2gmejem9yhaXe/Eu9trlJHz4Z3DEkZRKaRc7FI62U3aE9UhP7F8JG1aJQ7q7Kde+A2yS2HnauDQFzcRcsyHeTwAjUt/bMyml6Y8fjvSbdBM3oQr/iFWerinToE41qf4sva2egtIWvGoRCPv6abSPl4B0B55s/XiKnLyR6S3cqk956Az2Vgfc60aU8irAl4EmKWbcZ9dxiE8ISei7QDEy2YWvLSVgiUXjRChB2dlt9/bvX/9SM8GXx2LJZ2XERzlGaRxF21BumfUH6tPCIQW5w2d7TqIgFq5uV+1hx6gZaafYI3kDnEQet2U5fBQaOu1fy0bYOEeT6HEK1WhxZv/i/RZNn6ehLiZExMfOEMa5YC0mlTNb7N9SoqtLTra4oDiRcvop8yvZmz3R9PzKBmnAz7wQ9FL8NoPJjwAkywyXrU4cNcAtieu9e2E+9cQLq X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Jun 05, 2025 at 01:33:57PM -0400, Brian Foster wrote: > iomap_zero_range() has to cover various corner cases that are > difficult to test on production kernels because it is used in fairly > limited use cases. For example, it is currently only used by XFS and > mostly only in partial block zeroing cases. > > While it's possible to test most of these functional cases, we can > provide more robust test coverage by co-opting fallocate zero range > to invoke zeroing of the entire range instead of the more efficient > block punch/allocate sequence. Add an errortag to occasionally > invoke forced zeroing. I like this, having an easy way to improve code coverage using the existing fallocate and errtag interfaces is always a good thing. Can I assume you plan to add a testcase using the errtag to xfstests?