From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2B4B0C5B552 for ; Tue, 10 Jun 2025 04:31:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B333F6B007B; Tue, 10 Jun 2025 00:31:22 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AE46E6B0089; Tue, 10 Jun 2025 00:31:22 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9FC096B008A; Tue, 10 Jun 2025 00:31:22 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 7FC046B007B for ; Tue, 10 Jun 2025 00:31:22 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id ECD50140305 for ; Tue, 10 Jun 2025 04:31:21 +0000 (UTC) X-FDA: 83538216762.15.2786198 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf17.hostedemail.com (Postfix) with ESMTP id 602E04000B for ; Tue, 10 Jun 2025 04:31:20 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=BdbHXxgR; spf=none (imf17.hostedemail.com: domain of BATV+631296521f62fa6b3e9f+7961+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+631296521f62fa6b3e9f+7961+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1749529880; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=uEr7ULSTI9eswgFIakWh6oqioYdlLPwadRvhn0Fstjg=; b=nEOBDqWVazg4VXH0OUhAIW6xOB3ODq9nwVJLuSVAo0Kc391hMRkbOJ16XJJJFIHvvcT5PL sYQFFIYuWqDEYGaHALnNMk4oW3AQR/4hJyK9f/ot4lnngM+VZVM/EOTT68Kpn4UOCtmcgh SiE9OsTXgLaHybZ8w10bGViNqjyWX98= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=BdbHXxgR; spf=none (imf17.hostedemail.com: domain of BATV+631296521f62fa6b3e9f+7961+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+631296521f62fa6b3e9f+7961+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1749529880; a=rsa-sha256; cv=none; b=dr/pDmbaQlKplINXzwtjS5hQQgxjSJbEYjFrOq0KoigD6NMRklTWhjjTfjbUYPfYGCZt/P Qy28FXTvK8P0bIeHn2gP4lYfYQLBNh0pKFyVNEahS46gVot5/1emAsGWJuQxyyo484sgm8 nM9BIFFpgpVox7jt+3yG0vPq9bH5XZw= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=uEr7ULSTI9eswgFIakWh6oqioYdlLPwadRvhn0Fstjg=; b=BdbHXxgRvE5bl7y4fE3ilxl+uC Y6pdEwlBltQ1Z6qdOda8iuz10pHyTQ7MPI+0bVjUSuNNUd2S4DBvHsT+YH4rVNAv3BIr9qALrgK3G moFrlIaRcaYtkqbchAVzF9ZSNRtHLwDHvOStOM1hph9NkHTe2EL7ykJf6VXnVh7H1yhB/XKspA2Yq CCIybyMH/k8+8sCScdE5ikMUn/8Sm8FAwG082ESbxIhSGs+RetiGj/Re+jdbdNfvQ+TpkRRw/80dO /biShgLbwTSfLxKuFPlFPm1Fn/PEjMbrfzA71L4wGHXwFkCviZKCikNtDnTWbVY1mUhlf1u4FWwZ4 AZhtDtXw==; Received: from hch by bombadil.infradead.org with local (Exim 4.98.2 #2 (Red Hat Linux)) id 1uOqdr-00000005krI-0vsc; Tue, 10 Jun 2025 04:31:19 +0000 Date: Mon, 9 Jun 2025 21:31:19 -0700 From: Christoph Hellwig To: "Darrick J. Wong" Cc: Brian Foster , linux-fsdevel@vger.kernel.org, linux-xfs@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 5/7] xfs: fill dirty folios on zero range of unwritten mappings Message-ID: References: <20250605173357.579720-1-bfoster@redhat.com> <20250605173357.579720-6-bfoster@redhat.com> <20250609161219.GE6156@frogsfrogsfrogs> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250609161219.GE6156@frogsfrogsfrogs> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 602E04000B X-Stat-Signature: fkreigsxwqijuqtsd8tz1ob637euhcfj X-Rspam-User: X-HE-Tag: 1749529880-345403 X-HE-Meta: U2FsdGVkX18kVx0a7nX6EP23iKLH6lROECJzY6HsADeX6ga4oDcdZPKjhSW5cU+u4aHI06ffMTQv9EbnfxMeuKw5I/0JGqayeIQG4dlsE8kwTOUKDHCX9ccQXZpY3rSAvbYwTE69OLX+j3hmFcHebrwOPofDhpfSmZ6E5CcQCVWGaGcLJLljm69HugURUy9jmDTReTSKy15cwhgzM1NXtKiQVSi6ubbAQGv5eR5b3ffqV0zf4KA8zp3AQC0tSawCCAyWh90bF8IiU3rwci9wPz5gdh0ET32AtlTIkJKMlgg6FrTNoA4MPrrjm3Jm6Nzqti+cmnAMP58lu5SdAP50Yb73vY5tnotjhZd6pwlMSGfjGFTl9he4rNIVm9cEFdRezQXgwoiLD98bCoTuG+PFJ1/KnQ96TNI+65g/mh/kEiHdmE5lqOiBEbmvGzJGmmcy1UaQC5WFzUJ0O4XPDOeARIKN85eR3Xf7rUmKjYxkfIlJJMeRvXyeRz0rmGIpr+sqHe0KMBbaYgY9HSmwIrqvLM8fJKWJJiL3n5QnG05gY+BbdLxp8aoxhmVjvdii2kVpZIdv0pX8Vp7eG+nl0RepjNikxc6P79lHO20twotFJ1sPrEh3Vo40uApUoyFkwxz6YQlfdtz+ZxRMUP/RHcQITjF6EB0IDK0oSR3tv3RB2UtMNHCUWLlbJXV/rRr8WlatSaWloUafc/8x9KAKo3JThtK1x+Emlsuxy0dtU4jmfucAnWRdU2+4RNVN5LW8SxCEMZ7STjxKYcmK8xj44oeP6ufLamY3ocCc4KYaZmkeFEwqbbUO0jHRnGd2eomD46Qq1WNkozRW6K1PMXbTTI/9JW35DXT2JpPn0E1v1FmVtwj+rEakGutxH3Y48q6Z8TYKu/IRzykLcF0YzL3SI+dfE96RpRK6z0GUAwst2HnVZG3MHyuPtR43tupGO3wZOxYKuFPirOy3GnDKOKs+qPN SNeab0mY i56FzQNvBgmP0fsEPI2MgVky85jLjVhRF4LQGMj+dhQz+civAvCPSG/6VZVrmirSg2S9J7rwOYPt2aX39bx90Y3kfJ08rykozNkTK8jsGdo4i2aKBbclwFmsEU6e7WuygQCR7tNWwyPdlxVJ2o9bvuTZf/5evzC30KHxqNGTeGHm2NM2cTsBSoaP5XGIC8kkZ+mJRkzeWWFE3dykhPP+G9ZbeczO/8B/Plb1g2Wp4NKDMcdr7XEMLCyhGArkarOplMomkoR/qDOY9DqQiHGhCpv+XCVu9/0dv19Me8CDUiTLuXzwZV0xlC4EQ5xUAx8F/nvJFkJi7sZwqYmm0pmW+46JaSrlgmPvzNnD19MAFKujC9scjLiXJs7ORFPK6ys83H4yueR11wxRXFU7Wx1CK6DT9A1FWn+PtOH/YagK4rDSLo0LbHVwBua42PZ3HxbUUwrbKvQxS/Z6USIVOpKuKXgQonaaAR/fnCc+05tzAoMjwSHcMopwBvRFZow== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Jun 09, 2025 at 09:12:19AM -0700, Darrick J. Wong wrote: > > + struct iomap_iter *iter = container_of(iomap, struct iomap_iter, > > + iomap); > > /me has been wondering more and more if we should just pass the iter > directly to iomap_begin rather than make them play these container_of > tricks... OTOH I think the whole point of this: > > ret = ops->iomap_begin(iter->inode, iter->pos, iter->len, iter->flags, > &iter->iomap, &iter->srcmap); > > is to "avoid" allowing the iomap users to mess with the internals of the > iomap iter... No, the reason is that the ->iomap_begin interface predates struct iomap_iter. I delayed changing the prototype because I thought I'd get to the second step of willy's iterization idea and kill these methods in favor of a real iterator, but that just doesn't keep happening.