From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id ACBD6C61CE8 for ; Mon, 9 Jun 2025 19:51:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4568E6B008A; Mon, 9 Jun 2025 15:51:11 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 407426B008C; Mon, 9 Jun 2025 15:51:11 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 31CBF6B0092; Mon, 9 Jun 2025 15:51:11 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 152016B008A for ; Mon, 9 Jun 2025 15:51:11 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id AF2F2100300 for ; Mon, 9 Jun 2025 19:51:10 +0000 (UTC) X-FDA: 83536905900.16.B9B90D5 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf28.hostedemail.com (Postfix) with ESMTP id DDBD9C0007 for ; Mon, 9 Jun 2025 19:51:08 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=NPDd4RJx; spf=none (imf28.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1749498669; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=85TAzXXcGObkIpSOMC2VeDSg1VAoupbTgbj/ahVWIVM=; b=rwyGn4hGHCcLjOwKU/+xghx73+bpEcteFSlkvur94tsz2OIM0lwaQTXr7rMSvAylLQPFki FZl9Um0dJfRG7XYfXA9TdHXcGLBjW35b2tY+ITdChxl8/3LroYeYOzj4HlDAKx9mKxdW+3 EnRU5XzFyrOHsRgJ+rgFij6/XXvylYA= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1749498669; a=rsa-sha256; cv=none; b=r2mxFAketndYWjvItEOKhj2ApOvRSLZ9e+i7CmuxUltheM4PMsBYHeYjPCin7yNTnYmc4F 2lBh/NLgk2R9w6/tYFXuLNsTCbsJbNuiRbyGAjiaMQ+9Z6mOrhtm7S443zU/C+/w7LiIRm 5RQqlhJkdwaHYc4lEczP3hlEHlSbMnY= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=NPDd4RJx; spf=none (imf28.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=85TAzXXcGObkIpSOMC2VeDSg1VAoupbTgbj/ahVWIVM=; b=NPDd4RJxANb9b7Jo+/f8FU7asW 9KTgylLu9Lp2yPzwLdKaOgApaomKnGXLZ5XP5KdylzCGEAuug+Xt0F0Bnzu/Vur83Ta5P/SAU2tYY 2nt6jIIgb4s70PWKmxxfDOe9IniTTZJkOhEdsJMjAuxDKz8ki5e0xtxBIdNlGCaD4wZQ/pPI/IWEp Zo6PQly2y6Id7o8ZUo/V3vBUIgGO5n3UeOqt6TsTMi9tVrNf2c6zS95p+2vGCnhkqsf3glNz0uaGQ 2pcbP1Y6c5b59lAPSRpjFuqMa2I4+d0Xdef1a0i9DKpj+1Kfj0CjC4jfvbJO2tXg1zKOGmSL+WhtM yH7S3wwQ==; Received: from willy by casper.infradead.org with local (Exim 4.98.2 #2 (Red Hat Linux)) id 1uOiWK-00000008aqX-1C8K; Mon, 09 Jun 2025 19:51:00 +0000 Date: Mon, 9 Jun 2025 20:51:00 +0100 From: Matthew Wilcox To: Steven Rostedt Cc: Shivank Garg , mhiramat@kernel.org, oleg@redhat.com, peterz@infradead.org, mingo@redhat.com, acme@kernel.org, namhyung@kernel.org, mark.rutland@arm.com, alexander.shishkin@linux.intel.com, jolsa@kernel.org, irogers@google.com, adrian.hunter@intel.com, kan.liang@linux.intel.com, david@redhat.com, akpm@linux-foundation.org, linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, linux-mm@kvack.org Subject: Re: [RFC] mm: use folio_expected_ref_count() helper for reference counting Message-ID: References: <20250609170806.447302-2-shivankg@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: DDBD9C0007 X-Stat-Signature: bt5xwhm3angk66b4sj41a58349opsx7g X-Rspam-User: X-HE-Tag: 1749498668-430441 X-HE-Meta: U2FsdGVkX1/HnW/ml58PelVpasv2THZWQEkvrOhpF5vlo+zn7K4b6igtQ3tX3AqW9HdGrIl/dDwoC4kU9zXnQWzoOp1vG0TsFGWF1GPeDxNlNp27KhCL7yFo8ya6FXr3bOY4pwSIohE/nvFHQcu5LFaehm4SYVZw5ftEV+4/7DkeOcSxPvRm0A8RSpjoXux7UqmU9pbkm+LZLpmyYA9LFmw0ZTR7+M1T4NPMlMKjMfXmG5awfa+WwA/Ru1T6s3dm0k2Y75DGPIVWVHlfS2zCavAC5nqRMj2eqvVH/ir5+Ma4C0C81B48Q9Uzv37FKOVgbpR4IRewcbjNVC4LWl6lLmZSv4KikAXpQpG3+SWFeJXww8TPCTSHpH2ZKopX810FjfLLz9tI3Eiz7L9+Ext0Q9rI8YOvKznC1h8A50dvCdDGcnNrJDIGj/pTYZrx7g6Y8UcCj1X8SVXOr7OICXfLdKCHXk+iAHi6rbPppT5SWH7CyAKAdkYXOPjYyKj5TT0lqoCEOExlOrhJH/xpq/j2WQXgQ+ZscAh8pUru7Gg5fIsrFW3HtY0qS7FrnI/yoROk5uPFlejBJKZKELNi64Sq4QS/ScLAhwrjxLB9jJlmQHyLgEWqdCw9oT+cliyZe4a61QaqivR5sWXnx9KqpBjY7zRBl7bbw5bjjnM+/BOQTnOV2K+4V2LQ0bv0Y+LXoCcHZR3dsGWDGHChYKm3JVBTFwjPVEUJfvUZR77RrBNjzgpRZ/k398iQb2qR6PCGP6mLCsD0ycW4YgAMg8XOi4hBSzOlnP141I8FFzSlQq7a6ws+yFMyQBaR4xlMHKJEac58LiL+5CvA/EQwppGTv0GA8Nc9CiWdJcXIakvg9jeTSuFxmFNn0h7A93FCc7itcXt11Aea668fEgU03869nCxsGB1ItUSpDBJSCZAIQQNp+VjNdsQEXghBx/yfIGfisXypkDUATgwlxedVYpe/HwB eBzHELCo CyNAxn4UL7RzFDNRAcBWlZcvdgRCxtF0HxvtaTLDJpXJ0f11kYkNiDNw6gOez19m5NF3/5Mjcw0IbfZZ5hIRHTn4q5Yd91RPMVrM2N/GeOAHHBWEovKV+Y/a95SlNJKK0TZudPn22LwDu6xG/fNe5XUsxt/sOYIzZBtv4DAkvey5gcFXnAHUvn9nl1wIXHD7WxOwK+nECEja10+dG3c539pjnDKWqOVjs8m90WMBpNCkIbidC+vECrAOD/QYtLxPXI0oSfUF1rzmU/swaouywys0pwPMied5DN7+iBNdf/V8F57hXHO6VK7k0TQtUTn4BbbZmw1HSdTohqeSlGNpXYdcTFA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Jun 09, 2025 at 03:31:40PM -0400, Steven Rostedt wrote: > > > On June 9, 2025 3:21:20 PM EDT, Matthew Wilcox wrote: > >On Mon, Jun 09, 2025 at 05:08:07PM +0000, Shivank Garg wrote: > >> Replace open-coded folio reference count calculations with the > >> folio_expected_ref_count() helper to improve code maintainability > >> and reduce duplication. > > > >If it needs this much additional commentary, perhaps it's not actually > >clearer? > > I don't know. I tend to over explain as I rather make it totally obvious what is happening. I wouldn't say excessive commentary is necessarily a sign that it's not clearer. That was a Socratic question, not for you to answer. My opinion is that the extra commentary is obfuscatory and should be removed.