From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7998DC5B552 for ; Mon, 9 Jun 2025 19:21:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B99836B007B; Mon, 9 Jun 2025 15:21:37 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B70C56B0089; Mon, 9 Jun 2025 15:21:37 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A87936B008A; Mon, 9 Jun 2025 15:21:37 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 893516B007B for ; Mon, 9 Jun 2025 15:21:37 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 2A8A280E19 for ; Mon, 9 Jun 2025 19:21:37 +0000 (UTC) X-FDA: 83536831434.28.FB23659 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf30.hostedemail.com (Postfix) with ESMTP id F0E0680011 for ; Mon, 9 Jun 2025 19:21:34 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=bNX3b5nw; spf=none (imf30.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1749496895; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=EmHLi+WIDwMTitqB8Wtmq6J7R6/P0VzWwAE4IwfHS8c=; b=V/svZkCyLVN7jeB6V8meJp+sZp/M0hQxAus6kfJbqZZ9gR2BzLu8xTBaZQ3kOQ8GLWYRfL C84wKHRuQrP8pMmlKCQlezBYCPz+RJ1Ztb+/vY2RTtAPXIwt7gCNi28Ncx8lcNc3/UcNTg xe8+6Nw+whzaAV2cGYgjtjgKYxrfuPE= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=bNX3b5nw; spf=none (imf30.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1749496895; a=rsa-sha256; cv=none; b=dX9hx/gHtnOLM/MtnfgcjFbJnz45POgTBI5O78dZu009UsHxApd0iLnsv/1dajuZv0rxOo RAayC/jM4kZZxRvm2QOBp5Uoh33c2EmWs4rN3SC4hVDU43Osw908wP8dgG74LBUH7T1D70 pn0hxIppNel/kirW836qJViwqfj3FPI= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=EmHLi+WIDwMTitqB8Wtmq6J7R6/P0VzWwAE4IwfHS8c=; b=bNX3b5nwxTn5n0yNcF2QKjEpQq qgqnwyxlpoPvZVuxK7Uf2SrgH15tnzfsi70JqF7/9CD2D9OdpxSfOUwsAyGIDKhkpfgFtwOgbhtGd aA8FavFlGjCA8U/iv/KHNCpO5c3VV+PG/wztGdr7icXUXEKk/8wWtYOaWKnCpVkmuvXs2hu5va/Tq fBL/BJvJwKN9+/N1dNTkGod5t5eK6kPtdxIv5wYUiyvLd/zyMFogfkbXnz7gpI9b9p2xzxAryRw2K NepI4bi4dvzqyKcRfHpBthddaYKPxvOOkwtDPKEF5xOe+lxOGwz/kxf1sms2PXTW2OhTwY7Lpudx0 K42Sndvw==; Received: from willy by casper.infradead.org with local (Exim 4.98.2 #2 (Red Hat Linux)) id 1uOi3c-00000008ZNe-1Ru4; Mon, 09 Jun 2025 19:21:20 +0000 Date: Mon, 9 Jun 2025 20:21:20 +0100 From: Matthew Wilcox To: Shivank Garg Cc: mhiramat@kernel.org, oleg@redhat.com, peterz@infradead.org, mingo@redhat.com, acme@kernel.org, namhyung@kernel.org, mark.rutland@arm.com, alexander.shishkin@linux.intel.com, jolsa@kernel.org, irogers@google.com, adrian.hunter@intel.com, kan.liang@linux.intel.com, david@redhat.com, akpm@linux-foundation.org, linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, linux-mm@kvack.org Subject: Re: [RFC] mm: use folio_expected_ref_count() helper for reference counting Message-ID: References: <20250609170806.447302-2-shivankg@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250609170806.447302-2-shivankg@amd.com> X-Rspamd-Queue-Id: F0E0680011 X-Stat-Signature: 8ao51oqhaeypx63u61ueaohbhnb66wdn X-Rspam-User: X-Rspamd-Server: rspam04 X-HE-Tag: 1749496894-371086 X-HE-Meta: U2FsdGVkX1+ive5x/pBsVMj2Fv/mSb09O80dbJECYE1hrf5otOP2qjf36BNnBItEFLUXxfxXCf68OzztVHK7iYliLqkjLSrUJsRSskLkBUJiaMXks3t4mTR903eIdgDUrQRiA2r5o6UIV0at+f1DjrQTyFFV/u5OzcYIkYhqp/WPzrWzuAc42ZqtzQYQrJm4wjLLH68ldky4HxzeOpxLoVMTM3RHC2qm38TMkSeVcTetvG8YpQH+nqE5AngQbFsk4L/qRUBIojOMmQ3DZdhnNTHmYT181BlJ5MRxUpHMyEGxPNAcFlIWijd+YD8hMFXNwS98B5l19X6MZi5WOz6b3xL8DHwvXylURLy4Qx+vHp90WTwPcx7/yC/xamy00ejgLfKHTPs4KjRCFFuoxFif4rRAWZ3YC/gqOiua1Y+XMFE54A0XQHpfolSc0jqRY+sjUmcN9zLq7h2V8DgwrCSljcQ/+zzJZPXAvU1WDiUSso/jIVAP/BAvA+LS39AwHa4MjcI15YNEKL6eXO8a9OnIC7b1Q5ZmQle4ZLI227w0Pgw8zVouqSCxl6VOe8Yea/RKZBY/Nh12+Pyexf92n3Dp0ESGs+jWENdm0RPQ81fZK6aY4/nujADxbeaNF2wC7XQFD+XYh8XrSYVZIprKuWPq28SWxNCObyOqIv6w3FXtCd2excjL7DWL9fUBJ9jVCVYnyxsF4qJijUfvYVFzt8UmsTDYPB0b9XjbwXuccmrtVe512DCcrcj3NaYDKFewZTdbzhjl8//COLgc3+yE1dbOJplRKIzb4BmYi4F3X14jAUrMEQ/FvJF8ZrRgMgGwPlW9uU0pgUtfWrQfogi8k/UNuGIbCGMhrZ2GsM01/Oqfotdzueoc8/wGcY7lctLB49LYJkfaA84T2qxgI915m18RzVkIOFQu9L83+UIjpBs13GnKtnxX7DkCir5sYqi2hSxORcr5iEphM8jtbPClrt3 hdb75Ief v7dXG0OKujkBUSnXa4A4b+L7etkb1LAhamht4850d+vwBSPsWJeQEBfXnS6hGZoI2JbbW5dBektj/OlquA5QgfE9dvwcK4HgHEtNK5s5V89KnhMBQqi4px/TbWXsZzAOqSO04JQcerfCuOk95yiJyabbUA88R5W/vmwAK/kFx6dABkSor39rvf9AthgZfyPsAm5s6D/F4FCuD5rztmYm3/p9uRtH6hggp2RfsFaYPcxtFu9lWDr7hQ3YNkKMfKi0ncRU86e+BC2hpbXRRyZpACjTGwQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Jun 09, 2025 at 05:08:07PM +0000, Shivank Garg wrote: > Replace open-coded folio reference count calculations with the > folio_expected_ref_count() helper to improve code maintainability > and reduce duplication. If it needs this much additional commentary, perhaps it's not actually clearer?