From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 95BA3C61CE8 for ; Mon, 9 Jun 2025 14:39:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 31AE26B008C; Mon, 9 Jun 2025 10:39:56 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2CB9C6B009E; Mon, 9 Jun 2025 10:39:56 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1BB726B00A1; Mon, 9 Jun 2025 10:39:56 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id E9F106B009E for ; Mon, 9 Jun 2025 10:39:55 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 6904180399 for ; Mon, 9 Jun 2025 14:39:55 +0000 (UTC) X-FDA: 83536121550.25.52F74C0 Received: from mail-wr1-f42.google.com (mail-wr1-f42.google.com [209.85.221.42]) by imf04.hostedemail.com (Postfix) with ESMTP id 53BDF4000A for ; Mon, 9 Jun 2025 14:39:53 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=suse.com header.s=google header.b=FZya1v3j; dmarc=pass (policy=quarantine) header.from=suse.com; spf=pass (imf04.hostedemail.com: domain of pmladek@suse.com designates 209.85.221.42 as permitted sender) smtp.mailfrom=pmladek@suse.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1749479993; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=TBUyMfCvEgObXbMHMtHUW0hbnDDnIuTip1OX215Qd8E=; b=4LxszgmNh4yjf0Jcs6u4CdP2oBFGLAlGo/XqmllNHZmeJizEyjLE6lgt5VMImkqrcVUmuj pX8VHuivje+qtxnJAH8hMkV5RrlP9l25Ked5TP6F3yl8suoG5cNaVSlJmxm19ilFyXFUny 7RvjfLBW60iUWFmBOEsEYJkrtwRI1UM= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=suse.com header.s=google header.b=FZya1v3j; dmarc=pass (policy=quarantine) header.from=suse.com; spf=pass (imf04.hostedemail.com: domain of pmladek@suse.com designates 209.85.221.42 as permitted sender) smtp.mailfrom=pmladek@suse.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1749479993; a=rsa-sha256; cv=none; b=RuD4oq04HgqmoiElPmpC/WAatG2VAYPv62kK1V5MuTcHRKNwpegIUsxfWIShdL6QqUduu/ sfRw2cCfx4I+3rnnm9mnlEI1taEYabw9nThd+FtuT7GBKIQW1teT9FPP4aUgeyWMIgwKCJ cmgCtD+aRS8T7soi27T2DkLZudqDslI= Received: by mail-wr1-f42.google.com with SMTP id ffacd0b85a97d-3a365a6804eso2739470f8f.3 for ; Mon, 09 Jun 2025 07:39:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1749479992; x=1750084792; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=TBUyMfCvEgObXbMHMtHUW0hbnDDnIuTip1OX215Qd8E=; b=FZya1v3jBSEXfshjWSooPUm/EfB63aorEVKm7mCk6X9Mwcx2LxQarDIHGJ9G2a8QAC FBI9Y12VwET5f8k/xPiirQZj5Xdxs/j5Qvcahk6DwhiggguVuXxHzYyvbEQz69muhtdm BP5oiKxpK24kSoMjLfF5vqDrxRFyMAidW7FDUvHyDylAKUqT9LAy5Q/mTcEzx93LbvWx 8IR1yi8o7iQceSBCiRI4IWZKGbJwH+82MNUnoHqSx0rIRu4CjJh/Go3BbiZV7lmDassM Nf4grXpOJKoSNd6CDq5vLfqiySE9ugr1E1tF8hJ088InxjhxJUvNCfHxm/9UQlS6U137 T/nQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749479992; x=1750084792; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=TBUyMfCvEgObXbMHMtHUW0hbnDDnIuTip1OX215Qd8E=; b=c6vjWf60i7QRFbkj5QzoEg0jtR23fnG9EvV1PwsarPhxhEIWfh5tHxkrlSOeWoTOkB qNvQks2qK37M5pWb5WrhaMzYI4TAM0q77tSjfY0X5f5OX4jIS4UCMHMqnKfIYSc7k7ZG B7diVOP/RDxglBj0UaiiLcoiZcyDQNoJY1b9GHMEt1o8lcVan+L5VsKcSCvUiloSAnLG dcNXoeN/M9lX/GXRzZy8H3W+4WNVvb/QQ8PEN/xfgWgnAmIig10zReNBpgHiZGoaYPvB 2Lc5LxRaRqDdnwO0wKr3hW3g+YKVnvtyplniTyZD0299MEG6AXEN9U+D0J4bsHGAtsw+ Yb+A== X-Forwarded-Encrypted: i=1; AJvYcCWQ/u9mRpMOh3PJWKbsj7+Hv4aE2fZ87Dfo7CRapIjQV/UxG3H96wxmUw5JMLlL6ffTRjrQCrJg6g==@kvack.org X-Gm-Message-State: AOJu0YynlrkNQ7hyblJuODzWPE/AmMr/WK/tGRFdhlomPrn72Hxipz0i hUKhFzB6Qfx7v2Em6PoQmfbYj5QpJN3fXUvb8f0ku+XFXFSms5zJbRgPS3hkt4CILzk= X-Gm-Gg: ASbGnctFx+wcnBWWcgYAliiUY9roLGZjDJDtevTFaPqeoZxJ7KglNSC7Oja7nfIQV2g YTd/5UEPOCLWqL9A3rzekakHouuAYUTIoDlFSU5/EjDm8s2i/iJKJ7eXPrxOqHEEwA8FnH+rHnK GVH9oQxN+pCUnaVIU+mL+fm3qowmWBFqOWI4Dqu3BTzJRl8/ruGhcH/W4/G+uSnSpOVW6Z+/OE4 q+8AA2JzW8uAjzCm2UYt4icb6Ir86N/qdammXBJOhNVcvGcWrqPTy84s2cDpbueG5T8SgjAxdah 63ldr5zg0U8IB5acZesmAwNisAJv0xWQ0m275osJvUhQ+5SMryAaVvQDJzJ49d9g X-Google-Smtp-Source: AGHT+IHQ9WnlIb2N+Qu2oqWlSl1QrWztkyTzn0RfuZ+Bgd3cAwyVXJ521y5E6cUICXCtVhbSAJCdMQ== X-Received: by 2002:a5d:5846:0:b0:3a5:2b75:56b3 with SMTP id ffacd0b85a97d-3a531cae8d7mr10675904f8f.24.1749479991728; Mon, 09 Jun 2025 07:39:51 -0700 (PDT) Received: from pathway.suse.cz ([176.114.240.130]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-23603092635sm55068605ad.81.2025.06.09.07.39.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Jun 2025 07:39:50 -0700 (PDT) Date: Mon, 9 Jun 2025 16:39:25 +0200 From: Petr Mladek To: Kees Cook Cc: Sergio Perez Gonzalez , Vlastimil Babka , David Rientjes , Bagas Sanjaya , Jonathan Corbet , Steven Rostedt , Andy Shevchenko , Rasmus Villemoes , Sergey Senozhatsky , Andrew Morton , Christoph Lameter , Pekka Enberg , Joonsoo Kim , Roman Gushchin , Harry Yoo , "Paul E. McKenney" , Randy Dunlap , Tamir Duberstein , Miguel Ojeda , Alice Ryhl , linux-doc@vger.kernel.org, linux-mm@kvack.org, Thomas Huth , "Borislav Petkov (AMD)" , Ard Biesheuvel , Greg Kroah-Hartman , Andreas Hindborg , Stephen Boyd , linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org Subject: Re: [PATCH v2] slab: Decouple slab_debug and no_hash_pointers Message-ID: References: <20250415170232.it.467-kees@kernel.org> <202506051314.D6EDFA91D@keescook> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <202506051314.D6EDFA91D@keescook> X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 53BDF4000A X-Stat-Signature: gkrstjgeynsku1d4darexkskxhepjkb3 X-Rspam-User: X-HE-Tag: 1749479993-126335 X-HE-Meta: U2FsdGVkX19K1AxHZc0UeKfLLRHWz2APtBeNn4LEoLnUZA/FCrKZ+ZmTcwmso3cErBiulICOFgV0MPGhuUqfKQo6ELblY1mKWkCm9AcjSyZs/ZAXr/2QRi9XXbe0JElz4in7EeSdy9suPKN8STpKKOu6HH4VhALQrAmcdUjyAOXawZlTN+YHjud6uWBsKpKUa24NxHARpG32iR6jbwXSAJzl4X9PGFmTfU962QpbI7mNkUAyrgqpZc91dL/GGT2XSVTmtvZfgGaDmuuzQQ+PiCPsls91NV+4aTgS7qcO/H3e2Djp9TOZj5PWd6POWSd9J0viNqRAUH/Cef2ZfmrnsOZiFQWivJsyQAfSybDSatt7e/cEPPKZcU28yrCeq+FOn8QawfAewX0FxphihaYB/GMAZgvIc1TdU+gTs11KXJ5VCfJ0Tn1eme0MGDjXQR04d5QGsOPRpuqGYZ+Gla+shEjr8OK5MMWnGPMPdtHRKCTmi4+IH0IWejL7S1y34CxG3wNMbwG2z7jmBKcZA/3Q2aRehzigHoxTOY5BLI03An2gEs+ESMlkuxp8cc7a2LEmf+tHHgcPikwyf9/ZeDd9BIjaJHkDpVcwXmrfKJVoRI9yGh+slYSg51wulH3nXXiH80/CL5/jXQkie+ZM/k1Hbc+2+uH9iuHoDeS50IKBRnnXZzi2aGM1R+vrf8cCdASlmlV1uhBUARAn9YhrwjdAL0vaTbdRdO3WwWpJHBX37P7+IXYmsLGfF9RMqZx5FfY5NQATy+k/nfQRe9kDG2adU6Hgnubd6o2p7D4UR2KwdHNjyxjCit/6jdjWW3MBHFdh466mgtlNMA7GDKbQdUXZEM7aE8lcXc08VYTeDOxZ2XQATBVb1q3RDeQijOVGAupGUguXBJ8lcFuGXaTsWMkf8dzFDzTBxT4hq84HctOeigzThCW1XG78LIUli/sBqJe/dew329yfA3vdMIlAsY7 OdqNxA2v zJ0EjVQB698cCkWfW7qFlc9c7ItqOv6M8NBE09dAAgcKZBHMLF4sB5pjlRmMK7GcErVaA2A9GQj90kB5FzadoNMVx9kFKGU9egc41LmRRRzaHTBJBsadPmNVkxksQwiYpKXJLE1sbNMIwc9uxTnF+msseyvTRV1EOdbiTfBcco31YwT0+TN5NCPmljw3Pz1e+/T8RFZ9OPfQVPm8NV57XGe0JUUw3QZdw98AlfPntLa4aEIKI8tODdO+ceUFV+NG6JkaZBQL5PI3YztQ0/0a/LYf4fgxmMry2gnhQhOz8K2mbQdVWtoV6f3PDv1QusOy07DcMHcpBvJP+1zsqRqnj20TnyliXZYi2R9iA/k2OU1D4mT9KoK/QNmsJPNETJJ/Je1JT5JLSswInqrxGMczkTpxr0ggT30268N8mU+tXMhph20fmLisb6udLFiKbFTYewb/jdQWO06PQI/bMjBiZF9cE5Q== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu 2025-06-05 13:15:32, Kees Cook wrote: > On Wed, Apr 16, 2025 at 02:06:21PM +0200, Petr Mladek wrote: > > On Tue 2025-04-15 10:02:33, Kees Cook wrote: > > > Some system owners use slab_debug=FPZ (or similar) as a hardening option, > > > but do not want to be forced into having kernel addresses exposed due > > > to the implicit "no_hash_pointers" boot param setting.[1] > > > > > > Introduce the "hash_pointers" boot param, which defaults to "auto" > > > (the current behavior), but also includes "always" (forcing on hashing > > > even when "slab_debug=..." is defined), and "never". The existing > > > "no_hash_pointers" boot param becomes an alias for "hash_pointers=never". > > > > > > This makes it possible to boot with "slab_debug=FPZ hash_pointers=always". > > > > > > Link: https://github.com/KSPP/linux/issues/368 [1] > > > Fixes: 792702911f58 ("slub: force on no_hash_pointers when slub_debug is enabled") > > > Co-developed-by: Sergio Perez Gonzalez > > > Signed-off-by: Sergio Perez Gonzalez > > > Acked-by: Vlastimil Babka > > > Acked-by: David Rientjes > > > Reviewed-by: Bagas Sanjaya > > > Signed-off-by: Kees Cook > > > > Tested-by: Petr Mladek > > Reviewed-by: Petr Mladek > > > > I am going to wait few more days for a potential feedback. > > I'll queue it for 6.16 unless anyone complains. > > Hi, > > Is this still planned for 6.16? I just noticed it wasn't in -next, and > we're almost to the end of the merge window... I am terribly sorry. I have forgot this patch... I have just pushed it into printk/linux.git, branch for-6.17-hash_pointers. Also I updated the documentation, aka applied the diff from https://lore.kernel.org/r/202504181307.254F81843@keescook See https://web.git.kernel.org/pub/scm/linux/kernel/git/printk/linux.git/commit/?h=for-6.17-hash_pointers&id=de1c831a7898f164c1c2703c6b2b9e4fb4bebefc As the branch name suggests, I am going to push it for 6.17. If it is too late for you then please let me know. Best Regards, Petr