From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B3A23C5B552 for ; Mon, 9 Jun 2025 15:03:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 172226B0096; Mon, 9 Jun 2025 11:03:08 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 14A916B0099; Mon, 9 Jun 2025 11:03:08 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0605E6B00A1; Mon, 9 Jun 2025 11:03:07 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id D83956B0096 for ; Mon, 9 Jun 2025 11:03:07 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 5C00A100AA2 for ; Mon, 9 Jun 2025 15:03:07 +0000 (UTC) X-FDA: 83536180014.10.C0A4F1A Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf25.hostedemail.com (Postfix) with ESMTP id EF879A0015 for ; Mon, 9 Jun 2025 15:03:04 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=cISdoLgm; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf25.hostedemail.com: domain of peterx@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=peterx@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1749481385; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=JNcpH+bcZai1yfLZlLefAAm7I6glTiPKEZc98aEB9ag=; b=Uxs1U5SlG7cJO0A9m5q5TFt/ytsc4Iai9Ae90bmgy7z35H/lj2ihkquVlLAcavmFGck1TB vdk/SnVFLJdIu5kEN4bHmG+VddEURx7Z2QPId+LcPhO+M7AmgFcc6fHe0bF6Hv3RNT1jD6 6cBMQtWOBKWvLvPR7rTdGDIeQeUhHfE= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1749481385; a=rsa-sha256; cv=none; b=hVjPed8VwmT5dcIZsDZRXLdWJY+jWjrxi43W8fGxGOH+u8e/jcxqf+HQ4TGw8Ss5aAufl8 99zAjJnECClvdHecyffRbbLs/vcTlw58zTo/gR+dPdRcP2imogn/TY4EdGLsRNgBiwEeqN 2ZZN+Qa+B+ifPZDSWUWU0BiENatWTDs= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=cISdoLgm; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf25.hostedemail.com: domain of peterx@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=peterx@redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1749481384; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=JNcpH+bcZai1yfLZlLefAAm7I6glTiPKEZc98aEB9ag=; b=cISdoLgm0LnyIYyvNABpesbp2rMXdNdGKjZC3yA2VIce1fpqOfTpZuvdgvY7e/2YDO1Is0 +pfu7nIcSTSzI6XlFXwJfqP25DyEGhbKz+hu4d+zaznOnFjNSpPtaJhb4Tyl95XU0Gu4HU KrJb6dLnKWt1ixyKKqGQgDzzsrNIDR4= Received: from mail-qv1-f70.google.com (mail-qv1-f70.google.com [209.85.219.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-439-U_uxM6IMPZmItx18xJQ4Ew-1; Mon, 09 Jun 2025 11:03:02 -0400 X-MC-Unique: U_uxM6IMPZmItx18xJQ4Ew-1 X-Mimecast-MFC-AGG-ID: U_uxM6IMPZmItx18xJQ4Ew_1749481382 Received: by mail-qv1-f70.google.com with SMTP id 6a1803df08f44-6faca0f2677so125828246d6.1 for ; Mon, 09 Jun 2025 08:03:02 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749481382; x=1750086182; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=JNcpH+bcZai1yfLZlLefAAm7I6glTiPKEZc98aEB9ag=; b=DmGKH//qc/U6oPnz2dXjlalvT83utNwzilWxVF8pjw8lvHvy/cJOiygC+kE/pSWJp3 UJzhU1bUVrN4EG8MHHqvZ0LvuXI+c+aBH8GxK7dVmZs+KsATi1PcJjLp3KRr6m6/JX8T sfVa5T9TWic0AZMwXw6RWN1UOwZZe1OfJdqz1dKT0WJJSdVobL5a1sgO9++aG/zC7PVo eWIneFkc7RmjCZkFn1i8Zclqs20bG2qPNkkLNwsX7MftEDHIfMkJy8+lD7DUsoiTdjKd c/k1xLKgkmY7zhdJdF/IWDaeYK0sEkINRnFBxVUv+wusCKqOBD6yYTVwWkrMrJbdqyEt vXCg== X-Forwarded-Encrypted: i=1; AJvYcCWEcOx2vPgQLZKpL6uGj3NsymHDuusto5E6dso9KX9rB5PIClVgtAAaaXYXLe3tuGDxxy8QWngZRw==@kvack.org X-Gm-Message-State: AOJu0YzGWlt4b2ias1Rmtl6Yi3iZp9rE4xrLAKLLdP6wYZtowRseNTmx Kz607ehkDNavk5eEJ2P0r7fIsnFbWaA5g+PG4zmF4MEpzIGiDufPpN4RcSRmDLy7DCrUgBak719 Bs78YUavatlKRO65fSLZPuZQH2tuVT5Ivi3Rbf00pURDNW6lnK0ju X-Gm-Gg: ASbGncsWYisRZdxUvAYDciAraguqeI30zcVkSjmvRenwpSHy0H+usp+WZCrunHDyLxw 6DuYxQq9Vrxv7/edSzRASLjYoDbmvbuavtwGwWxeWTznU8X9UinjIefjlfKbRm+6DZUxI/76a/6 plqqHY9rs5ygBx3yyK+SyiW1/rIVM3GItSrGm7dYTTO7MxKz69ff6lYou6Rj0OTDyVFKG8d6iuM xKZaKNlfSQV5WeUUDbbaaR89eopIFq31A5a6cBR+7C0NVKjIzP8WNmpF6g3yWlsFCs/VxJ0AMOV qeBcbirt0DuEdQ== X-Received: by 2002:a05:6214:c68:b0:6fa:ca81:4121 with SMTP id 6a1803df08f44-6fb0905b95fmr182520696d6.44.1749481382010; Mon, 09 Jun 2025 08:03:02 -0700 (PDT) X-Google-Smtp-Source: AGHT+IG31IbS/tH29+tac1BfQOs8d7QAQpKa2+wtvwN79ZFd1EW+t9uEZUIMv1somHhXHI9x3fa1xA== X-Received: by 2002:a05:6214:c68:b0:6fa:ca81:4121 with SMTP id 6a1803df08f44-6fb0905b95fmr182520316d6.44.1749481381607; Mon, 09 Jun 2025 08:03:01 -0700 (PDT) Received: from x1.local ([85.131.185.92]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6fb09b29fbdsm52483506d6.89.2025.06.09.08.03.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Jun 2025 08:03:01 -0700 (PDT) Date: Mon, 9 Jun 2025 11:02:57 -0400 From: Peter Xu To: Andrew Morton Cc: Tal Zussman , "Jason A. Donenfeld" , David Hildenbrand , Alexander Viro , Christian Brauner , Jan Kara , Andrea Arcangeli , linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH v2 1/4] userfaultfd: correctly prevent registering VM_DROPPABLE regions Message-ID: References: <20250607-uffd-fixes-v2-0-339dafe9a2fe@columbia.edu> <20250607-uffd-fixes-v2-1-339dafe9a2fe@columbia.edu> <20250607150438.4439e19f74693445212d93df@linux-foundation.org> MIME-Version: 1.0 In-Reply-To: <20250607150438.4439e19f74693445212d93df@linux-foundation.org> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: _RyVxoXC5h6Bpr_EM_sesZVUkgmlMZop0dU5CSFxJ0c_1749481382 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: EF879A0015 X-Stat-Signature: daffsmue4xsqx49y19wgu3fiogpwinnz X-Rspam-User: X-HE-Tag: 1749481384-48637 X-HE-Meta: U2FsdGVkX1/qQTu5SPAS/16Mm3q/LF3k/opv5SYjggYPoaGWfrL06LCCtkNalaBltrK76xORVz2gnuqH2rXzIkkox19dlYZfnHf5aARtSkrfmjL6ogDFrM+bM9omLKsup/J3KEPq6nFlECfrVpbZG9UGX9rkRf/RgQ/1S5Lz+Ne4t57wli357Dm2S5irdeWc8bAdyvSnMKbx0BY1aOPVCQ5I4/iNVKvICAqXT5TXacCdH61BDXedYTeehkwygNFbi7wiBcCmHxsTFKRUockD3xiyHUtetic99kj9ux4URlJT+KZuQd+XyXlaxKm6VNmIF7FKRKT0eYsd9zEKWKCfsTaFk9t11Y6KryAebFdtN8FURAfV4yb21daZGd9Bcr5mX+ZKqzCPmJCIs+dPKfLYQeHvMolvwiq++NIugsPFPebikdR+ufB8J3jqXtLRlUJsE2uYMamiYO+iuoc1kQzAeH0JtINWAew6i4r6LmmQ0w1QFd/SFB/gTAzjYooQGOhUzWDk8Jt7kd2Kt3WhAZd1hq7a2S9noJiDSIRMYx7hOuGjCeIQDG+eNgPTokRqfR/yoRv1S71tzxsuBREhx4Dzl60CRAZRMJP9clxFsRQjDHHLFMdQ7Bzq5QvspzidJa0n6mo9q8aR+jAFsDZzA+jOueyiI9oJBVE97lVmvBEQYTW+r5pyzM8AW6Pq0EXzfgfizUuPwNDTaG6VCznbiicZMacKkA/W65DuIRL7W42TOiCcyCcq3l0rOhrtXfyeiewLsCuFLY56B2D4eNk4iPHtLrLsSZR/2XFtOfbUnPYxhKYi3EfiRgOef9cxuTQviwVssVROFWWMCL1sCQXJbeK86VXTY2tmUWtDueuIRRCv/YGChQbXK0v90uWftXKbF0rJ5He5tJDE9zMhZiBRaLTeUg/FaIge0/IT5jb6RLFlD6YJMrhQs9IGj+doTOenUKnolLRqk2X2t4eku98pcrO doCBKXaw bAi8po1HLXoh9rnoxLcWuwdzCAkdk7/L65vF2CyrNswXqv4HCX/BxP+HtbIVCS2ExXbfxzGm1+DIKWxSXTeWKqhBP3r2PL+3VrE1vozqxCGiC2SIiCh4E3R9VnKzhsgpbAL29qe2AR0qT085pOVEIBaMcJDLdmJwNiCNc6fCaS8Yqu2P7Y7tdw9N3FWMv75qFa+VwJ6Qb6NKBjlfvWeDNTKvzGQyiEFbuAQA9e/zM7ku27gAeDhM05kVN9LzJKldBhoBcKzg30irocNv1Y92dG8aEvZHXz2lG7AZIrnxd9RbIOmdpf+NRt/ZTD+BPPaYSuFB1kwn+gEc7U8jklsF5w/bKHAfJRgGlZ3XvbK+U24AiaTfa1x6xPqQQHe4+DwqMKx56 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sat, Jun 07, 2025 at 03:04:38PM -0700, Andrew Morton wrote: > On Sat, 07 Jun 2025 02:40:00 -0400 Tal Zussman wrote: > > > vma_can_userfault() masks off non-userfaultfd VM flags from vm_flags. > > The vm_flags & VM_DROPPABLE test will then always be false, incorrectly > > allowing VM_DROPPABLE regions to be registered with userfaultfd. > > > > Additionally, vm_flags is not guaranteed to correspond to the actual > > VMA's flags. Fix this test by checking the VMA's flags directly. > > Wondering if we should backport this. afaict we don't know the > userspace impact of this because nobody has tried it! Yes that's fair question. Per my limited understanding of MAP_DROPPABLE (even if as a generic flag), I'd be surprised if someone tries to enable userfaultfd on it, being succeeded or not.. or requiring that to properly fail on any stable branches. AFAIU that's the only possible effect we can expect from a backport. IMHO for this case we can avoid backporting until anyone requested with an explicit use case. Thanks, -- Peter Xu