From: Harry Yoo <harry.yoo@oracle.com>
To: "Matthew Wilcox (Oracle)" <willy@infradead.org>
Cc: Vlastimil Babka <vbabka@suse.cz>,
Christoph Lameter <cl@gentwo.org>,
David Rientjes <rientjes@google.com>,
linux-mm@kvack.org
Subject: Re: [PATCH 01/10] doc: Move SLUB documentation to the admin guide
Date: Mon, 9 Jun 2025 10:42:36 +0900 [thread overview]
Message-ID: <aEY8DGIzpF_zdKR2@hyeyoo> (raw)
In-Reply-To: <20250606222214.1395799-2-willy@infradead.org>
On Fri, Jun 06, 2025 at 11:22:03PM +0100, Matthew Wilcox (Oracle) wrote:
> This section is supposed to be for internal documentation, while the
> document is advice for sysadmins. Move it to the appropriate place.
>
> Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>
> ---
Acked-by: Harry Yoo <harry.yoo@oracle.com>
With a nit below:
> Documentation/ABI/testing/sysfs-kernel-slab | 4 ++--
> Documentation/admin-guide/kernel-parameters.txt | 12 +++++++-----
> Documentation/admin-guide/mm/index.rst | 1 +
> .../{mm/slub.rst => admin-guide/mm/slab.rst} | 6 ++----
> Documentation/mm/index.rst | 1 -
> 5 files changed, 12 insertions(+), 12 deletions(-)
> rename Documentation/{mm/slub.rst => admin-guide/mm/slab.rst} (98%)
>
> diff --git a/Documentation/admin-guide/mm/index.rst b/Documentation/admin-guide/mm/index.rst
> index 2d2f6c222308..ebc83ca20fdc 100644
> --- a/Documentation/admin-guide/mm/index.rst
> +++ b/Documentation/admin-guide/mm/index.rst
> @@ -37,6 +37,7 @@ the Linux memory management.
> numaperf
> pagemap
> shrinker_debugfs
> + slab
> soft-dirty
> swap_numa
> transhuge
> diff --git a/Documentation/mm/slub.rst b/Documentation/admin-guide/mm/slab.rst
> similarity index 98%
> rename from Documentation/mm/slub.rst
> rename to Documentation/admin-guide/mm/slab.rst
> index 84ca1dc94e5e..16933b7b3377 100644
> --- a/Documentation/mm/slub.rst
> +++ b/Documentation/admin-guide/mm/slab.rst
> @@ -1,10 +1,8 @@
> ==========================
> -Short users guide for SLUB
> +Short users guide for SLAB
nit: Maybe keep the word "SLUB" or use "Slab" instead?
We've never used "SLAB" to refer to SLUB allocator before—it might be
confusing. We're not resurrecting the old SLAB allocator ;-)
--
Cheers,
Harry / Hyeonggon
next prev parent reply other threads:[~2025-06-09 1:43 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-06 22:22 [PATCH 00/10] Various slab improvements Matthew Wilcox (Oracle)
2025-06-06 22:22 ` [PATCH 01/10] doc: Move SLUB documentation to the admin guide Matthew Wilcox (Oracle)
2025-06-09 1:42 ` Harry Yoo [this message]
2025-06-09 12:13 ` Vlastimil Babka
2025-06-06 22:22 ` [PATCH 02/10] slab: Rename slab->__page_flags to slab->flags Matthew Wilcox (Oracle)
2025-06-09 2:15 ` Harry Yoo
2025-06-09 12:45 ` Matthew Wilcox
2025-06-09 13:12 ` Vlastimil Babka
2025-06-06 22:22 ` [PATCH 03/10] slab: Add SL_private flag Matthew Wilcox (Oracle)
2025-06-09 2:25 ` Harry Yoo
2025-06-06 22:22 ` [PATCH 04/10] slab: Add SL_pfmemalloc flag Matthew Wilcox (Oracle)
2025-06-09 2:27 ` Harry Yoo
2025-06-06 22:22 ` [PATCH 05/10] doc: Add slab internal kernel-doc Matthew Wilcox (Oracle)
2025-06-09 2:37 ` Harry Yoo
2025-06-09 15:22 ` Matthew Wilcox
2025-06-06 22:22 ` [PATCH 06/10] vmcoreinfo: Remove documentation of PG_slab and PG_hugetlb Matthew Wilcox (Oracle)
2025-06-09 2:44 ` Harry Yoo
2025-06-06 22:22 ` [PATCH 07/10] proc: Remove mention of PG_slab Matthew Wilcox (Oracle)
2025-06-06 22:22 ` [PATCH 08/10] kfence: " Matthew Wilcox (Oracle)
2025-06-09 3:42 ` Harry Yoo
2025-06-09 13:33 ` Vlastimil Babka
2025-06-09 15:02 ` Matthew Wilcox
2025-06-10 13:23 ` Marco Elver
2025-06-06 22:22 ` [PATCH 09/10] memcg_slabinfo: Fix use " Matthew Wilcox (Oracle)
2025-06-09 3:08 ` Harry Yoo
2025-06-06 22:22 ` [PATCH 10/10] slab: Fix MAINTAINERS entry Matthew Wilcox (Oracle)
2025-06-09 3:21 ` Harry Yoo
2025-06-09 13:38 ` Vlastimil Babka
2025-06-09 13:59 ` Lorenzo Stoakes
2025-06-09 16:42 ` Christoph Lameter (Ampere)
2025-06-09 17:44 ` Matthew Wilcox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aEY8DGIzpF_zdKR2@hyeyoo \
--to=harry.yoo@oracle.com \
--cc=cl@gentwo.org \
--cc=linux-mm@kvack.org \
--cc=rientjes@google.com \
--cc=vbabka@suse.cz \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox