From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 39ABFC5AD49 for ; Fri, 6 Jun 2025 12:28:57 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C0DAB6B007B; Fri, 6 Jun 2025 08:28:56 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B96C96B0088; Fri, 6 Jun 2025 08:28:56 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A5E6A6B0089; Fri, 6 Jun 2025 08:28:56 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 83CEF6B007B for ; Fri, 6 Jun 2025 08:28:56 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 307C614010B for ; Fri, 6 Jun 2025 12:28:56 +0000 (UTC) X-FDA: 83524905072.26.C7AF78C Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf24.hostedemail.com (Postfix) with ESMTP id E0EDE18000E for ; Fri, 6 Jun 2025 12:28:53 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=m0Tqyx7l; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=TupEVE61; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=m0Tqyx7l; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=TupEVE61; spf=pass (imf24.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=osalvador@suse.de; dmarc=pass (policy=none) header.from=suse.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1749212934; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=DqICevuKoP0IJLpCka+29EYHI1p+jaoZS/6X28IIxdU=; b=kxLiMmiiOEM3zuQv0fSA4ER77B4w/PS/ba0N0jhsxkrRR5u0/+W3viXvCFPNSHHqDO6st8 ryH7hTAxmiAkhVHgrLvLxoCEoC9cKj/Jhd9my4iIuAokbp080wz/5d5uwTNZLXe5kABC0T aBz10JZ34LpTGjcuvM3NIjdMJ0GtUJk= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=m0Tqyx7l; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=TupEVE61; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=m0Tqyx7l; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=TupEVE61; spf=pass (imf24.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=osalvador@suse.de; dmarc=pass (policy=none) header.from=suse.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1749212934; a=rsa-sha256; cv=none; b=dPEOjFWrbi1i2uw9JeCH6sEjC+Zdmf6vUzJO0t7dPRNep2s6FbED3uf0pxRru+AYe7jr8d sn8YV2ch029EMAOlMQA50Q5moUnjcCJiZYF7FMV6IknlT+p+rCb1YoWJ4232bGid2UOhta ZrUIlUqQ+kvCVmlC1Rb495HyRrXMcm4= Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 7123321114; Fri, 6 Jun 2025 12:28:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1749212932; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=DqICevuKoP0IJLpCka+29EYHI1p+jaoZS/6X28IIxdU=; b=m0Tqyx7lrrlQgV4nYGpP1zIy5aYr8pdM7BZbJIMBFDW/0ldzBITpicmeCTtoT+wULeWu94 LsjTCIfhAF6/IzKqHC5OFGDdeDnSO7qdUCPH04DBgzukifaXTrB4Lyun7eOb3Cf3twLSlU FM+l/7mya7GOStvYJkxM4HwHwov9eqc= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1749212932; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=DqICevuKoP0IJLpCka+29EYHI1p+jaoZS/6X28IIxdU=; b=TupEVE61L1YpQIEe5C8YHYMwU4SKGD6E0FgkwkiMdTnKNF9+1eDiAjv9oZMVAl6R71fumJ noODCVmyuCdo7jAg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1749212932; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=DqICevuKoP0IJLpCka+29EYHI1p+jaoZS/6X28IIxdU=; b=m0Tqyx7lrrlQgV4nYGpP1zIy5aYr8pdM7BZbJIMBFDW/0ldzBITpicmeCTtoT+wULeWu94 LsjTCIfhAF6/IzKqHC5OFGDdeDnSO7qdUCPH04DBgzukifaXTrB4Lyun7eOb3Cf3twLSlU FM+l/7mya7GOStvYJkxM4HwHwov9eqc= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1749212932; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=DqICevuKoP0IJLpCka+29EYHI1p+jaoZS/6X28IIxdU=; b=TupEVE61L1YpQIEe5C8YHYMwU4SKGD6E0FgkwkiMdTnKNF9+1eDiAjv9oZMVAl6R71fumJ noODCVmyuCdo7jAg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id E11E31369F; Fri, 6 Jun 2025 12:28:51 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id ei86NAPfQmicYwAAD6G6ig (envelope-from ); Fri, 06 Jun 2025 12:28:51 +0000 Date: Fri, 6 Jun 2025 14:28:50 +0200 From: Oscar Salvador To: David Hildenbrand Cc: Andrew Morton , Vlastimil Babka , Jonathan Cameron , Harry Yoo , Rakie Kim , Hyeonggon Yoo <42.hyeyoo@gmail.com>, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v5 04/10] mm,slub: Use node-notifier instead of memory-notifier Message-ID: References: <20250605142305.244465-1-osalvador@suse.de> <20250605142305.244465-5-osalvador@suse.de> <0ca963af-8dc9-4cb4-9142-04497c359b81@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <0ca963af-8dc9-4cb4-9142-04497c359b81@redhat.com> X-Rspamd-Queue-Id: E0EDE18000E X-Stat-Signature: 866w8hrpuhunmk56er5kkidcyigesbda X-Rspam-User: X-Rspamd-Server: rspam07 X-HE-Tag: 1749212933-258636 X-HE-Meta: U2FsdGVkX1/XKUz/syi0nTKWtRD7pf67NIgMNwU9omwzrfVLHIygrRWlni1xrCVkwCnd5mKAs2N4SJFgaQagWGk1k5sC70FF9I7MkECXFFm21I+5q6Oz3T/m3FkAmKyLf3V8AZGdRBk3kioIVBC2dMT5hoQvHR/FY4I0DcD0AOBoN1pEyDKH+9jyHfLjTzI52AnSQkQUI9xbxEIwjW0Qhvu2ryqQSqxk/8xBFsgfDj/4926IfZyzIA6XyG+79j2jQbAaOkbKbOqhDunJ01A5lSCeV7QUxkuF0JeNLUJoW5i3FjAk+p3nYAUNtCmek0/54JQGBwjjLupuRb5vqMZOm0nFJayxkQf9OiExPmsjDncmvnhKDINrKTRr5oofxTINpucyQWcoN3b3JTz873L+5ZWb+pQJmGcFe+IX9Mw5d1dzuBb7AnNhI4qidf8jOKdPfgpTAFqEoKb0SPKLcVBySxf9iND/vi2cLGIYuMPhmkwLu+QdZMPogQtP4U/75pc6070Gjvh7UeuNXF/aUHm7doZAvkP0x2iulmMdKCjDjfelroFstk0UBxtZFL3GlkIR1xEfZtaqSfeGAGH7ZWsaCjvCaQaPE4ZBzG1cFdotiAUgqUSokmJL/tk3dIZ3cjv+ciNoPeUl3dgjJsMZnTsl/pEBRFj8dEIuhUXyGuMUn96a12jIAKPgYugz30lTF/kaNOnJ98EF3xnJM98qKqVlNV4uux2M206TOTg7N/6tOc7nmhNZgLM/582txJoA338t0lxnBoH99OvgRDDcxhSZFfecPzKlE/Cc6ekL+Ji2sRQy3RF7fY2Z0MtLBSfa9fYnuKAObdieeXrKTg2HDKsZHYkXFUnM96n407WURyGrAcdhK6BRr3yxqSmOArRyn37t42BkdSf4yThOwGhh8ZaoP6viz9/jNPH9D/raIXlAK5upqLNBTIK4PUrjZWSS5FqB9izEmfUsgFWloZDRuUI C6rnDQRR huKUoTa15wueCMXD8EtICt2YlxTMnw6tWX5S/3sBeXQp8qhhQlUJ3XVgk0R2QOO51QgeAuugoI3H7THiS8dxTU7LANZ8Xp+rcos4o/gJoMYzK9ROY6RNKlkGgXT4SOV6x4oslCrNvnrcvU6+E31EfZi4GQC2HGT6iRx3FshEu9b2Iy/lHyoYPLuA2xtthbJ4Fy2blqgAWFEGW951UVT+GCrjKnTSJzNjniRes1G1Qjg9ZxSnPOfqYb05bOpGL8rUHjfv0aNPb+woRKupvaGH+QrUmMbfnfpUTrqu+XbtssrHzgOw9BcsfwSrhOlo1mGUqAZaaQpnx446bjyM= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Jun 06, 2025 at 01:56:15PM +0200, David Hildenbrand wrote: > > @@ -6217,15 +6217,12 @@ static int slab_memory_callback(struct notifier_block *self, > > int ret = 0; > > switch (action) { > > - case MEM_GOING_ONLINE: > > + case NODE_ADDING_FIRST_MEMORY: > > ret = slab_mem_going_online_callback(arg); > > In slab_mem_going_online_callback we will cast arg to "struct > memory_notify", no? Uhm... not sure if I understood this correctly but slab_mem_going_online_callback looks like this: static int slab_mem_going_online_callback(void *arg) { struct kmem_cache_node *n; struct kmem_cache *s; struct node_notify *narg = arg; int nid = narg->nid; int ret = 0; > Probably needs to get fixed. > > ... and probably best to pass marg directly. You mean to cast it directly in slab_memory_callback and pass 'narg' to slab_mem_going_online_callback? > > break; > > - case MEM_GOING_OFFLINE: > > + case NODE_REMOVING_LAST_MEMORY: > > ret = slab_mem_going_offline_callback(arg); > > slab_mem_going_offline_callback() doesn't even look at arg, so likely we can > drop that parameter? Sure. Thanks for the feedback! -- Oscar Salvador SUSE Labs