From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 084B8C61CE8 for ; Fri, 6 Jun 2025 10:28:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 90B6C6B008A; Fri, 6 Jun 2025 06:28:37 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8947F6B008C; Fri, 6 Jun 2025 06:28:37 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 70D4B6B0092; Fri, 6 Jun 2025 06:28:37 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 501BC6B008A for ; Fri, 6 Jun 2025 06:28:37 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 0A4FD100C2F for ; Fri, 6 Jun 2025 10:28:37 +0000 (UTC) X-FDA: 83524601874.05.FFC965B Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48]) by imf23.hostedemail.com (Postfix) with ESMTP id 1C2F3140003 for ; Fri, 6 Jun 2025 10:28:34 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=suse.com header.s=google header.b=fxkFAmJo; spf=pass (imf23.hostedemail.com: domain of mhocko@suse.com designates 209.85.128.48 as permitted sender) smtp.mailfrom=mhocko@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1749205715; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=0y7ijdQypxqLTvbk+opJt5eDnn2DOdTCBFw/PW90tvs=; b=4cqJ6We1Uio6tuUWYuj2ZBE4S9DbJySonJ7mwklisfOsNszuW8pZQVcqB+yKY7OS7torL4 mSzAbHRd3Wo9ynZ2S/u9HIeMyZmmsp1xpvi0Djcr7DxrwPxLWfRSTOH8LPrnt/5ElB7KrY YXCXErkGZy3BxJFpgNOmU/gkwwNLRKk= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=suse.com header.s=google header.b=fxkFAmJo; spf=pass (imf23.hostedemail.com: domain of mhocko@suse.com designates 209.85.128.48 as permitted sender) smtp.mailfrom=mhocko@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1749205715; a=rsa-sha256; cv=none; b=SMJyevAkBhBibED0xnRIQwTFiWvJVraspr3zmu6vezJ8MuyE3p65Ip6A3RcRASfFRUs3Hc E7pF4v+ZMkIkZuSFsImVH/JePID4PGa5lbBOIIQkorMIUZ0S0gKbgij2BK4fLCM6MzEojQ KxduTNuhBiC+ALNEH+ZlBnsO+evmafY= Received: by mail-wm1-f48.google.com with SMTP id 5b1f17b1804b1-450ce3a2dd5so17056085e9.3 for ; Fri, 06 Jun 2025 03:28:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1749205713; x=1749810513; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=0y7ijdQypxqLTvbk+opJt5eDnn2DOdTCBFw/PW90tvs=; b=fxkFAmJo5BwjH7mNcXqjTtbm8dUmlYPOlZxGpL+pPFO/+4/5DGYbwiAc7A5ucOp/wZ 8V3cMSlfBK/WUY5hi43UiMzHCOZS5fvFd4zyXOgSyaHe9y1hH/ASyz2mMNX2ueKtuSvm zMDRvtoVcuMHQmJsvBc/zRzjcOuOyZfEBiSiZHTOUOoXl4hLIpFmGECmm9cKSZwColXH o3/omZcOPS/cffaTjm0MZpZkmNBJ8/3fgF1MgKJsKnHxDcJgI8tXckIg7cuBP/o3qPt3 6iejVKXWEBmCP8DSMXIi+ySYpyjoW4ud+An2XCLMxi8FPfn8PnnYAN59iGFPzgvzwD8z oYUw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749205713; x=1749810513; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=0y7ijdQypxqLTvbk+opJt5eDnn2DOdTCBFw/PW90tvs=; b=hYCLZ4baG/4RNMtMy/aVoZrB9+pJs+RDdwWKxPawOfCDnxnQCdGMuSbpFAOYNTZUV2 NPNuTLATvPn+LFHMsf1gDNQEgM0KhdtM5P/izKAVgtdO78rBY6ydvTGKdHl0QE675TZF ODyd5g8kHP8evNXGCi453SM+ImW+h08D7W1aR5ZD5H2HkB1GkJFF7kvCCuI9/RZ4PcCb 0+O+EEwBFe2OSjLz+Ig8OtLEZeENbjPMmZSkJgxkpbx7/DAnTRRfgNwb0hbUS63bk2NI GgrUnFF8w5rrxB2CmCYayAKaVrz05dEC1GCYPNQ/t/xJODWUFTqrNdlWH0jmCeBHHnvT jRAA== X-Forwarded-Encrypted: i=1; AJvYcCV8Xtf//4ijjrLt5mq4EfPUQYpVC/eEkcVVcHgjFKiPsN1orhYPL4KeU9RKrax9Sov1jkGa64Wfwg==@kvack.org X-Gm-Message-State: AOJu0YxxkQGGwyAUR8IB2L1RKdVV2OJZGZPEptuIwq5rIdFhhIxqWqIu 5JwpXaVFrYbLfXMF1V4fj9jHAAHtY5k3QmqqIS0y4xZk0lIe3nD28t27ELgqhukZiew= X-Gm-Gg: ASbGnctRbkX9XuLIcXc7hE5ynDtEAScpDiOzHHeP4XYXsSDJ45VwacMFTPeeiVQcNnb bqpHo1TeR/PVF7LsQP/ojoBRcER6eMqNPz3p3rjcWqhh7FVnYFhi2CeKXKiV3+8qOrIg98uLVNe 4/KZrQV4SnWgBhg5TDm/52O7oHDghh/YuoEIP+44+g81zJZhReoAB1hpW9Xy9RB0P/tCDafIWS5 X+RbLSV1H/J99irP59AtJzm4forf+8EgY+6ZamdSPsPBSXxNjpMRwqax8rNw1u2xTL1i8gYY0OK 7i/cLEAx6zIzZNftmGdiGZANkx++B0rr0J6gbTPTE6r7+HVIsDzCLnu3wughdfd4jpkNQ0J9apA = X-Google-Smtp-Source: AGHT+IGCtW3+HsBx2trqj05+wy5vuf0bHkM0mnvh4NmRgCfrhoDGHG+3c937IQeNhCYs4Lgn9vMx7Q== X-Received: by 2002:a05:600c:8b72:b0:43d:9f2:6274 with SMTP id 5b1f17b1804b1-45201360d06mr30369075e9.14.1749205713596; Fri, 06 Jun 2025 03:28:33 -0700 (PDT) Received: from localhost (109-81-91-107.rct.o2.cz. [109.81.91.107]) by smtp.gmail.com with UTF8SMTPSA id ffacd0b85a97d-3a53229ddebsm1474197f8f.17.2025.06.06.03.28.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Jun 2025 03:28:33 -0700 (PDT) Date: Fri, 6 Jun 2025 12:28:32 +0200 From: Michal Hocko To: Lorenzo Stoakes Cc: David Hildenbrand , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Andrew Morton , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Jason Gunthorpe , John Hubbard , Peter Xu Subject: Re: [PATCH v1] mm/gup: remove (VM_)BUG_ONs Message-ID: References: <20250604140544.688711-1-david@redhat.com> <1a65d0e6-6088-4a15-9c19-537203fe655c@redhat.com> <50ff9149-2824-4e57-8d74-d8d0c063c87e@lucifer.local> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <50ff9149-2824-4e57-8d74-d8d0c063c87e@lucifer.local> X-Stat-Signature: wbu9ddbyor459rxuwrzcawk7ip475a8j X-Rspamd-Queue-Id: 1C2F3140003 X-Rspam-User: X-Rspamd-Server: rspam02 X-HE-Tag: 1749205714-744618 X-HE-Meta: U2FsdGVkX1+NaAvEvAT01M3+F3bJrDUxLoE8k2e2+5tvUZwY50JJEma5wiAHc52ACrX/HPRxtDmgkyNd56IorXmQCpIkHa/fOUuGt9+aktZXMz2C4DEHsWkP9UeYCskj/tct3VCRwV3GMUSqx7er9p1c5Ht214DRudG1yB5P6jvlKKTzHTDQEYqQPtW9kdgEWaoVoWa6R11F3+XbahMAURTij/whWdE3xWCmv8KiFkcKntlq3L78ErnQGG0UB3K63cC9RBzB+MZ6BzFcFFB0xRKhRCDAcjuJRvindEh4n3G1NA0B+5Ki9OTbGUjXF51LVAVbyDFSfwxmxBV/gg+G2hMKkCk8uIKwUFj2myeeOxjUimfV/V9w135IIZCg5VyOgKzzgDTclWHqTVhdk7eCmYRaR3iXalsuMqYTsc8IgGL5iz+IPaYZNPL+/fFClPiX/5434NGtV6kAnhZGq4VrgWcCDeXBsLcskArrZ8XTMZ9lzKMs2Ra/UNF6Xr4swMctcKUMGB5V6WCZGywpWln8gdkxtAFyeckLKyugulxXKSalm4oVH6+xiwSDa5OzdW6ug7TCS410g37UlsZEhpZaYlU2RUWdxeLJ96H3pZ1rTju4kqwOGp/7upPXMU4TBiMZlfwrEbeERnUausAqo6/coqmK1Uj3BiKyf1dvyL7bzXd87Zca9iW2bL6ahC/Y725QNPRJTPY8+rhx2S2wgnLNhqYtleEmJqkr8i3JjiQMXAio7hLroDnpX8FAXuz8y043WCENQ7/r4CLzzpSjlAsOaoFTkM7xsPZhX0MBx0QvlXy0u6Ozkv4EGqnINEpOxZwLjFevR9Guwdl6QUcvJztRXkavTTrDaS6QYEI7Ll06eJFRQnxOVIrwdn+UXC7Q531Ilif307FWM1etyjD/+RH1d/rstJj8jUWoGcPeX64qqZDSrK3NHfk5wDn8uQvs6d2bJRvOd54PlUvRVv9XSvW H1P4bgPB f8kxLdaImTZ7rop3KB28WgwPX9F6MxbUFpUTIOvP8CG6X/xJ+WBqB+77VlCXgt8+WrfvWd5qIa+pvnDlU1fyi2/w+V9cdKFSRh1OVQSpL/vZSlQLZKFuvRapcfJ5m6ft15hzguXWkcTfYjf021L+KSUSa2t/GfvXP0xRVbpaFcgq+mm4SV53bWQgEQV12bZBYcJzojeVhUrNwXaJjbQc5jWtAcBFX+X1X/BUrgPTYObbtSRHdOTHGUULD6w/dUO7j6hwhYRRUz25iyKJT7E6Zkg4EUJQ4OhkfIKNwg80dbM5xq3OXm7u/NdsRADq2WwOv4N/EZMZ1K1rbrqY= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri 06-06-25 11:19:28, Lorenzo Stoakes wrote: > As the "king of churn" (TM) you'll not be surprised to hear that I'm in favour > of us just doing a big patch and convert all VM_BUG_ON() -> VM_WARN_ON_ONCE() > and remove VM_BUG_ON*(). Yes please! I really think this is the most viable way to get rid of VM_BUG_ON which I believe is a generally agreed way to go. Thanks and let there be a force with your boldness. -- Michal Hocko SUSE Labs