From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8A0D1C5B549 for ; Fri, 6 Jun 2025 08:31:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F31916B007B; Fri, 6 Jun 2025 04:31:13 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EE22A6B0088; Fri, 6 Jun 2025 04:31:13 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E1F2D6B0089; Fri, 6 Jun 2025 04:31:13 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id C1C216B007B for ; Fri, 6 Jun 2025 04:31:13 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 558411A03E4 for ; Fri, 6 Jun 2025 08:31:13 +0000 (UTC) X-FDA: 83524306026.11.7E5DCD5 Received: from mail-wr1-f43.google.com (mail-wr1-f43.google.com [209.85.221.43]) by imf12.hostedemail.com (Postfix) with ESMTP id 26F4E40013 for ; Fri, 6 Jun 2025 08:31:10 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=suse.com header.s=google header.b=WtLrRftK; dmarc=pass (policy=quarantine) header.from=suse.com; spf=pass (imf12.hostedemail.com: domain of mhocko@suse.com designates 209.85.221.43 as permitted sender) smtp.mailfrom=mhocko@suse.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1749198671; a=rsa-sha256; cv=none; b=dHHvbry17FKmkSGXFz/q2qc6iCJtw4zsyUx3rFuyUyBm9AfXsNje6v6Fp+AWrtxyl7W9X/ VgoiT2EuJFTXnD5qOiZjjZl2gTu0rzyYi3bQxqCsanQ9HMpPOdh/sq5qnJCG4u7SCMyr+d B1EA72Ydd86ALji6AtoaCzMkoVC6W4g= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=suse.com header.s=google header.b=WtLrRftK; dmarc=pass (policy=quarantine) header.from=suse.com; spf=pass (imf12.hostedemail.com: domain of mhocko@suse.com designates 209.85.221.43 as permitted sender) smtp.mailfrom=mhocko@suse.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1749198671; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=qYieY4lInWZq9QdI1taw9gd0hMVkfJQ+4I1ApVM6Qgk=; b=qbzdMOHdnZN06n24G3Tz8Z0jUpGWrOUlA3HTuYGgMxPLYXmdiG9VGcD9L5F0WqC+IVY4Yj lFlOLU3EnSkHC4j54MQft6+mV69IJ0nHGkRaXH2DMP92e5AY4SE1NQQZHbNS/iZ/Ye90V2 erg7+Tslk+6uic+liBmSZ2gu7bTUSZ4= Received: by mail-wr1-f43.google.com with SMTP id ffacd0b85a97d-3a4fd1ba177so1344479f8f.0 for ; Fri, 06 Jun 2025 01:31:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1749198669; x=1749803469; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=qYieY4lInWZq9QdI1taw9gd0hMVkfJQ+4I1ApVM6Qgk=; b=WtLrRftK7SH5fjSyl1eq/2nxA7Zh2nbIbPkeZ+71vOYpuC7LLFdYrq5tChZuKj6DY9 xV1QKS9mHh1jRTIfeiwgpdtKOf6NEjuEAxcytxm+4qAQVnMDN7LopSEUroFK3dCPzXju 4kGkSxNYf/sHO6N0YuMdYJshYB66NvsZ4zsjg2sFrXI5VNCAo5IX7z0JfBE2/xfwl5gc ikpSRbhEuKUV19Tc5Hj9mmdfm/vFIszAa9jGEG6rzVIY46lcq9mGrCNRyG61DIAFMhI6 b7hihwWxfTkCBJ7KIdpDxyLReE04LoogJhLUVjM0EhAfFF3MsIkuriUgJD6IX7x0HfFN 47JA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749198669; x=1749803469; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=qYieY4lInWZq9QdI1taw9gd0hMVkfJQ+4I1ApVM6Qgk=; b=MnJfwcpDMTRPjJb56ZuVv//IipFaB9URxeB8lG5JlhcE1VijmkDV8FmG3LU2VPwdpV P7RR+V4lwFM5DgECkBBG9cvXFnoSwaDD0kNs9jVgUrEk3ROYnGbkszVvOoG2TFI4uD5a sOXRk+j+cJZd58PpK1xsn11ykxjtsLOF6AC7arOGw58J3RUWdoTiMbdMucXXCGB4hvsT acK4gR/uOnwgxtg3yS31Vd9J3PAfHLFxLyySMdvdeFNlU2wWkGC5Hr/FZJznOfVwgYEJ 8HMwVLn9mvUUTBbP1Sd1T2L3oB1PDXdNeFyYTdXtMogc0xHLYFVzcitUH/BRzOUvA85E SE3A== X-Forwarded-Encrypted: i=1; AJvYcCX2WmdSXjpsWHI4Oy0XCpPbnv2dJ1fYereV0fHsPsQJAw36CLby+jm/dxB3FHQW+QqwjcdhOfmEWQ==@kvack.org X-Gm-Message-State: AOJu0YxXswyUA+pixm4dTkpxi4i7iwiNjPMTw0WJ+6gRFSeStV6XsBw7 ohMY8JgEKV4LJBG26f+/IlJO2Rv+1r0dsFPKCTQtSO3kXhJ7CFlINq8SxLndrXnqQgA= X-Gm-Gg: ASbGncvmMpG4U4UMBGFQ2I52/fd7tknA8Y3lXuDDXaA4r1iJSe+SKy8hFsloNaFefx4 mayEydfzZqO9eT2AQQsPhKjNkL2rXmxV7V4DsXHqY5mvqhUAmWQB0X2wsMPH2xdRaHlU2BDAF/i IjT4WcG7vgcHDzA9WQg5B932bSzRvi3GJ2ONo50lsGu662VpduIj4GHlWI2DsQgKEzu5/RzZFre ay+NPuuCMamXwT2PNs6dhpgNXLKf2oqjgXoAHvykkeTGtTnjIwlPbGuBeBR4pBpTcSGxoXlMZhT wqPYpMQkQByy+GArYG2ncWesk1Y8Cz2M6q/C9AwsxardzuKp/Brpwwf4DC3kPHpS X-Google-Smtp-Source: AGHT+IGuXhVMkjZYWAnukrSJQreEhdk2NYQVPbB5PfaHi1nXUEKZ/69yyHXplK7ArfVdwh3ZYP03Vg== X-Received: by 2002:a05:6000:4202:b0:3a4:e63d:2f2d with SMTP id ffacd0b85a97d-3a5313155d0mr2420403f8f.6.1749198669407; Fri, 06 Jun 2025 01:31:09 -0700 (PDT) Received: from localhost (109-81-91-107.rct.o2.cz. [109.81.91.107]) by smtp.gmail.com with UTF8SMTPSA id ffacd0b85a97d-3a53244fceasm1163645f8f.82.2025.06.06.01.31.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Jun 2025 01:31:08 -0700 (PDT) Date: Fri, 6 Jun 2025 10:31:07 +0200 From: Michal Hocko To: David Hildenbrand Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Andrew Morton , Lorenzo Stoakes , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Jason Gunthorpe , John Hubbard , Peter Xu Subject: Re: [PATCH v1] mm/gup: remove (VM_)BUG_ONs Message-ID: References: <20250604140544.688711-1-david@redhat.com> <1a65d0e6-6088-4a15-9c19-537203fe655c@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1a65d0e6-6088-4a15-9c19-537203fe655c@redhat.com> X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 26F4E40013 X-Stat-Signature: x7yc4br4eqec1kwuqw71iybenp6435fs X-Rspam-User: X-HE-Tag: 1749198670-20709 X-HE-Meta: U2FsdGVkX1/HRPaLF4iw3zS6I3R3R/S+8CN3ROiBH2z8GG6Dz1xr+UCBLmzx07YSgOXAHxU/gP+HrQlZSsKVkVZXkHkZyZ9fqizU/djw7bQB/FRxX6FXnTSgdY8Jytb8SMQyrUsvyeW/sLxyNxK5zx/35t10aFurOVkAI1vImh/jWyavdKmBvVZ2OOfCFRyTl4854v8YKByK7y3U2Mc6V0t9uiAKvRUHrjkp9E3S+GPhDsvcSskd7pGHw8WIKAPtaIwugJ4P5hb9uaZZzmnJDY0LwUU+wykt0EUCJaw5vaTMo3zjDt1fTOI41qixv8Q/XbOy2JGBNmz+IZyVwL51Q7wDfTbcDrey+tvKsHI3TvAbNutQlvgyBSYVJRdD1qt6u5hxzLLPOIYvY7l/r/9gUbGEF83s8ciqedJ5io/TrIZWLR5rgccl+Sg5ogK/AkOib0BTweGFLlO//t1O3YTB7Awx9DPY6yVxnpqJAxLINn1z7bTUm9C/NWpl6w6T0EIAUYDIrqtqM/wybq989ONx3bm5tK/4kAI9aaMXDjtBKMhPzfDHzKBRBiePMr9YGgzkPseblcO3973beQ2Ln5P5J5Hvw2DomzJSsiPCJJe1mpcg8lRf0Tg7FL4ucRfaH0dl+qoYa+LvvMYxTJccvJshpsU7OmpZ9DYGEmjATCXq9jSm9BBc3Wy245cYRwg2Go6AD/cmsGn5f219rvn+Eb9rYQwQi0vX3+otpKMFg+GIn8vgfYUdrAChzWA6UWIJe9FV5CebhQLgXgobG59iPk8fGJozjTiwWSO0mU36mV10SB0WDcw/h+x+gphte1WxT41m/mx29Vfk/CU7Pz3o8o8C9tj5VY+Axp3uwYaX0e/3u2lovCLiStg/Wi1j+2IkgBZhaTMDfKr1tZNuXH1NKgVj6PAZawwYO0bTCodQih00q2cEn9X/e4aybI+8krgW5W0CGbNtZTydIzwtT6w6GBj litAhR/0 BZoagUG3eb6vf9/XQNj2ge6qV7Y8RneZOc9rWO87QP97lkVBl0TgxDCaEpUMXxJZ94u7TMfOE3JTscLLUpcIHhTzLCF56WMt45U4cOi6O0xyHFQNCf5tj3GkvLgOEkSXKac0tsyyVsoNlZbzDlm9yENwhjNjVzTrs9t5PSEeb2JMTDUudTFnvT/1bX3IRZ/d655MvD1hC5FEclpKWXrKD4pfD+eYMln0e7K5W3QdGRLRlPU7z3QjEL2YR8KB9GXQQevR1lDiJtErFsY67WlUbWlJ9EWznMJFFz+PdTYObS9dR+27qA32TIiNCAUsa4RwrEHKPYPUQusYkAm1Z2UCd40vyP9FbsqFITEnJ1Ip3QZQyj+A= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri 06-06-25 10:10:14, David Hildenbrand wrote: > On 05.06.25 09:10, Michal Hocko wrote: > > On Wed 04-06-25 16:05:44, David Hildenbrand wrote: > > > Especially once we hit one of the assertions in > > > sanity_check_pinned_pages(), observing follow-up assertions failing > > > in other code can give good clues about what went wrong, so use > > > VM_WARN_ON_ONCE instead. > > > > > > While at it, let's just convert all VM_BUG_ON to VM_WARN_ON_ONCE as > > > well. Add one comment for the pfn_valid() check. > > > > > > We have to introduce VM_WARN_ON_ONCE_VMA() to make that fly. > > > > > > Drop the BUG_ON after mmap_read_lock_killable(), if that ever returns > > > something > 0 we're in bigger trouble. Convert the other BUG_ON's into > > > VM_WARN_ON_ONCE as well, they are in a similar domain "should never > > > happen", but more reasonable to check for during early testing. > > > > The patch itself makes sense and I think it is good time to revisit old > > discussion [1] and finally drop VM_BUG_ON altogether and replace it by > > VM_WARN_ON which could be still a useful debugging aid. > > Yes. I think we should check all cases if they are really relevant (and are > clear), and also handle BUG_ON on the way. There are more than 600 VM_BUG_ON instances. I am not sure it is feasible to review single one of them. Turning them into VM_WARN_ON should be reasonably safe as they are not enabled in production environment anyway so we cannot really rely on those. Having them in WARN form would be still useful for debugging and those that really need a crash dump while debugging can achieve the same result. So while I agree that many of them could be dropped or made more clear those could be dealt with after a mass move. An advantage of this would be that we can drop VM_BUG_ON* and stop new instances from being added. Just my 2cents -- Michal Hocko SUSE Labs