From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A3A5EC5AD49 for ; Fri, 6 Jun 2025 08:28:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 36BB26B0096; Fri, 6 Jun 2025 04:28:01 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 343FA6B0098; Fri, 6 Jun 2025 04:28:01 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2328F6B0099; Fri, 6 Jun 2025 04:28:01 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 03F9A6B0096 for ; Fri, 6 Jun 2025 04:28:00 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 7A872140765 for ; Fri, 6 Jun 2025 08:28:00 +0000 (UTC) X-FDA: 83524297920.27.0E3E277 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf04.hostedemail.com (Postfix) with ESMTP id 4B10F40005 for ; Fri, 6 Jun 2025 08:27:58 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=KOF1jKI2; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=AR6NHLpV; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=WPxQ79t0; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=Eexde3bT; spf=pass (imf04.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=osalvador@suse.de; dmarc=pass (policy=none) header.from=suse.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1749198478; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=DwzFtLoAJF6LpFfXdB3aqnEfVul/lrSEoNcvLPxWOR4=; b=lvFaSSwcWVZazyRcRW7KAtnH05EPUDXlj00oVEe0erqNl/Ze2waRKSSaiN2cmjnM6oXvPJ QdbpR83rAtuRPytclpe8oLUu7JSLIe4/LhIW6FEmfzfb4WW6hGShLxFxn60tUlVO0KG/co TIUwdV/JxL/OGjOR4RUOBHMIy3NHdcA= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=KOF1jKI2; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=AR6NHLpV; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=WPxQ79t0; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=Eexde3bT; spf=pass (imf04.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=osalvador@suse.de; dmarc=pass (policy=none) header.from=suse.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1749198478; a=rsa-sha256; cv=none; b=vw3rCLIuHzhDbNau2ggML5+RJjfMldjA9wCC52RYYhNVYorJcsFAMPIo/jYKjzoVYiTDoS SbKXaN55rv1srhWtMERVLIHG4GIyKm1ems8RqHV8m8RyGj93FTdUwiZeGdfy/cXFU/cmgO 6kC6f1syY+bZlj2fyazjPzXTxwsyrGY= Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id D8A9A33891; Fri, 6 Jun 2025 08:27:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1749198477; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=DwzFtLoAJF6LpFfXdB3aqnEfVul/lrSEoNcvLPxWOR4=; b=KOF1jKI2gHjfP3lAzs4XdafSN5r//4FT9CH2yZb1SeGzbiBgvK1fEPYJ73EVQNtDzpB8nK nj29N2a6kOnU32RqGRjiIxqKs9OyZb8JUpxTbbG6IdOg64IxVXPGU1ECvcg3FC2fHe+JM4 3vvFpm4p6l1mK63UX+Wlo0b4CclhufY= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1749198477; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=DwzFtLoAJF6LpFfXdB3aqnEfVul/lrSEoNcvLPxWOR4=; b=AR6NHLpVXaal8rWTDncnWHccF5IWUPTfv0c5VrVyDQZmryLFXVmkjeW841HFLq0eBBzvNX vGXjGbd4+suMzuDQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1749198476; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=DwzFtLoAJF6LpFfXdB3aqnEfVul/lrSEoNcvLPxWOR4=; b=WPxQ79t0iVA0bJuYeOc6PWTQs7j2Ou3UF1bCN28JThmtwkJRlY3y8agQdemGgXsmBFK7fn YnshLE8EWNaJ39vuhkIUGHVWoO4MS5VPS2vmO/4BgeawXmXMFk92YTNSu18CgyBDa8/CAF nqtmQsEa2znGnVBckDnjrA3hUpSGEAg= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1749198476; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=DwzFtLoAJF6LpFfXdB3aqnEfVul/lrSEoNcvLPxWOR4=; b=Eexde3bTxa1egIHClBT0y3eyFsVnhvrfHQDX2GO8fqyXMir9clNOrqKM21Dou6DsJsKxOe erfmSONNOWmLFWDQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id C2FF31369F; Fri, 6 Jun 2025 08:27:55 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id AEbsLIumQminBgAAD6G6ig (envelope-from ); Fri, 06 Jun 2025 08:27:55 +0000 Date: Fri, 6 Jun 2025 10:27:54 +0200 From: Oscar Salvador To: David Hildenbrand Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, nvdimm@lists.linux.dev, linux-cxl@vger.kernel.org, Andrew Morton , Alistair Popple , Lorenzo Stoakes , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Zi Yan , Baolin Wang , Nico Pache , Ryan Roberts , Dev Jain , Dan Williams Subject: Re: [PATCH v1 2/2] mm/huge_memory: don't mark refcounted pages special in vmf_insert_folio_pud() Message-ID: References: <20250603211634.2925015-1-david@redhat.com> <20250603211634.2925015-3-david@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250603211634.2925015-3-david@redhat.com> X-Rspamd-Action: no action X-Rspam-User: X-Stat-Signature: h71ohi37rqibgneqxpjkwu6oshehritc X-Rspamd-Queue-Id: 4B10F40005 X-Rspamd-Server: rspam11 X-HE-Tag: 1749198478-841813 X-HE-Meta: U2FsdGVkX1/JKK6XE29g8w6qqSik/DHwL2kVhfvyF5Z72+e54/DHfyral5bObshPcScG5W8lxyYZmdIyn4Xgd/ywS+dUHfz6oZ95ABgzbVoQlVKvT4D+vQNaZ0mUHfhRiPetW/+k6cn+OytUnkJU7m44JjZGhng2LwGqbm1fhFhomMJLZEpXzaAHJ1wnX44lopIbLRN/+HPpa8tB1B8cguIdimweyIsHqyrn31u7dw6RQ4ProfGTq7Yh4WEySKLQv/Y9JcjEYCTNPaFzPUefIjRspyr9+DIpJGsi7aiSDu3EUdTdwSrgRjoabTkVv1bIXIzz+OKR0Oeu+Zgx/CqFR0v6odTHhIvR2CNiI9B9x05pZW73eq04GVAnvjyS+kKy4nDTP5vinQ2B/qIiqlcR/9ypi7kEGNe00kYFGassS8Ohb6XqUgehoRKAtFx5pQl7fFyO0ScmG17YnIej4R8IFsxMTnTIyNUUylo+c5kJx1A9laVSYrQbLDLWkRBhvXOCzxJ1MZVPfLpwJBxOeLaIXZa4TUwe1UdGt0Ag0IN1douL7gk+q3o4r8fvFOr4VUh3Bo9Nw9Ea7qO+ISlat6G6b2sQcxaCj28YOKBl0/G/Mpe6Y+S1JLsbxMFjxH+ecpqUiHjy1fsCbP7TuekGrT1GPgqX4SvouPkh7krVktdgQdCoc1B5q00mUPmi11rkkIlg8poyK85S6OSzrn8H+fdUAv+sujpgxE5V/WWFQbYD6O/TQaFrQBQu04LhZmdJwPHB/wzO2q/bKTlqNzIimxZF22VtRsP0dpiVvB2EMcmuRxsppMlYFKMEvF/cAeKeNYs10ZjdJcSsDfm03HVDtBbsP7vUQ389XdnbqEbHl5hJ5SMN+dLVzjSaRWaX1vz+2QjWFdAqZos5/ZEuZxFxogG4YrtMPDng+0SBwWfE63bOJyDSRIObK3HqgcIxwUAGia01eTTYipOHdgsJn7P5UoI Bsaf36JL WlukfkWDVnCRH+WvSFAZvaE1gYTqMxpIML3ApG4X3WM5Yyo/QgnJCRpWZyWmpERiItEd5g86d/3zB6Z5TpYlTtmgnM33+SDao1nZgr1QBe2ovxVGZd8+ppqf0BrL1NW5TRnmBanJOZXmG6c3n1t7ZaHfTxkkVZ4Lnb8yWLa4+0WsqurH0aTb/3euP/88P9oIPpoAEuAn0lyrQDbaC2ViKHqLbszjOGE6KG2Mh8I2bqrbYSeiFJFGTOPLsKwabs32MWHtNtSvn/J1+Ms47tJZ1898bWlUYqjdH183CV7dV2XaMt6vIKL7OvG5WOTjiucJIbcr+wYnUfD8xFws= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Jun 03, 2025 at 11:16:34PM +0200, David Hildenbrand wrote: > Marking PUDs that map a "normal" refcounted folios as special is > against our rules documented for vm_normal_page(). > > Fortunately, there are not that many pud_special() check that can be > mislead and are right now rather harmless: e.g., none so far > bases decisions whether to grab a folio reference on that decision. > > Well, and GUP-fast will fallback to GUP-slow. All in all, so far no big > implications as it seems. > > Getting this right will get more important as we introduce > folio_normal_page_pud() and start using it in more place where we > currently special-case based on other VMA flags. > > Fix it by just inlining the relevant code, making the whole > pud_none() handling cleaner. > > Add folio_mk_pud() to mimic what we do with folio_mk_pmd(). > > While at it, make sure that the pud that is non-none is actually present > before comparing PFNs. > > Fixes: dbe54153296d ("mm/huge_memory: add vmf_insert_folio_pud()") > Signed-off-by: David Hildenbrand Reviewed-by: Oscar Salvador -- Oscar Salvador SUSE Labs