From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A7D72C5AD49 for ; Fri, 6 Jun 2025 08:27:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 258F56B007B; Fri, 6 Jun 2025 04:27:16 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 230A76B0093; Fri, 6 Jun 2025 04:27:16 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 14E466B007B; Fri, 6 Jun 2025 04:27:16 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id EABD06B007B for ; Fri, 6 Jun 2025 04:27:15 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 8A92BC0590 for ; Fri, 6 Jun 2025 08:27:15 +0000 (UTC) X-FDA: 83524296030.07.BD62B58 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf16.hostedemail.com (Postfix) with ESMTP id 8C7F5180005 for ; Fri, 6 Jun 2025 08:27:13 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=wO3P6wlX; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=97BLMfZJ; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=wO3P6wlX; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=97BLMfZJ; spf=pass (imf16.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.131 as permitted sender) smtp.mailfrom=osalvador@suse.de; dmarc=pass (policy=none) header.from=suse.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1749198433; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=AbHdt3R0Dg9obxm/5Tz1H6QEtuLCv5Q1f/9X9tztXsM=; b=LFa60+hBQ4Z7BaaQWNY6F4dset/BSACJm5JBuKD8AZ2VbX51nS66N/9RezF4n1pOUeW4eG TwlZNFgnG4Ne3l86w9TKi8qiacRaPVKNVSRqLiVLrm7zmDtgVrmOgBjn0iiCVM3YQjXoMd IC3+8tjJTwyw3Y4+otGFKElkkfUyD8M= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1749198433; a=rsa-sha256; cv=none; b=zNvhYgIoevauaZsv2F2fGGCYCvRF/5ikbG6JPJrT/pwuYI8ZOfefUI3y12g9fqZOwj9wEI UYw3BrABVjx+KMHllb12hzsut4Wb5wYTETvLqihPRlACLAtBHDp0N1uz9I/+xJ39/pwenX /uw6jPgnLC410bx3QI/ucMTrEFqLKlQ= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=wO3P6wlX; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=97BLMfZJ; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=wO3P6wlX; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=97BLMfZJ; spf=pass (imf16.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.131 as permitted sender) smtp.mailfrom=osalvador@suse.de; dmarc=pass (policy=none) header.from=suse.de Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id F202E1F46E; Fri, 6 Jun 2025 08:27:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1749198432; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=AbHdt3R0Dg9obxm/5Tz1H6QEtuLCv5Q1f/9X9tztXsM=; b=wO3P6wlXjt+W2MXDO5dpFJQtBoEA+cO0kTABzo8wu0ZgsP/GIND4cEv9ird8Jj3G8dfomz 0apDkoEosXdlMJ2mO5i7mrUL9GnYJW5IqmKRwDyENFT/OwpIxt5NBae9DUe8WuxUhVmEji WIb+diNAClLe+73zzJUpkfbtp+bmNjo= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1749198432; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=AbHdt3R0Dg9obxm/5Tz1H6QEtuLCv5Q1f/9X9tztXsM=; b=97BLMfZJ9qD0GtqMNCwjkDm9sNoMwU91m0fym1mB+cyV4t8UjT2cKTAwWqQyv6JCtK13qN dXD9J2eP/h35eYCw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1749198432; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=AbHdt3R0Dg9obxm/5Tz1H6QEtuLCv5Q1f/9X9tztXsM=; b=wO3P6wlXjt+W2MXDO5dpFJQtBoEA+cO0kTABzo8wu0ZgsP/GIND4cEv9ird8Jj3G8dfomz 0apDkoEosXdlMJ2mO5i7mrUL9GnYJW5IqmKRwDyENFT/OwpIxt5NBae9DUe8WuxUhVmEji WIb+diNAClLe+73zzJUpkfbtp+bmNjo= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1749198432; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=AbHdt3R0Dg9obxm/5Tz1H6QEtuLCv5Q1f/9X9tztXsM=; b=97BLMfZJ9qD0GtqMNCwjkDm9sNoMwU91m0fym1mB+cyV4t8UjT2cKTAwWqQyv6JCtK13qN dXD9J2eP/h35eYCw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id E88001369F; Fri, 6 Jun 2025 08:27:10 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id zkcMNl6mQmhgBgAAD6G6ig (envelope-from ); Fri, 06 Jun 2025 08:27:10 +0000 Date: Fri, 6 Jun 2025 10:27:09 +0200 From: Oscar Salvador To: David Hildenbrand Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, nvdimm@lists.linux.dev, linux-cxl@vger.kernel.org, Andrew Morton , Alistair Popple , Lorenzo Stoakes , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Zi Yan , Baolin Wang , Nico Pache , Ryan Roberts , Dev Jain , Dan Williams Subject: Re: [PATCH v1 1/2] mm/huge_memory: don't mark refcounted pages special in vmf_insert_folio_pmd() Message-ID: References: <20250603211634.2925015-1-david@redhat.com> <20250603211634.2925015-2-david@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250603211634.2925015-2-david@redhat.com> X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 8C7F5180005 X-Stat-Signature: 9aafarx4ckfwpces6ubr4pwb8djzjhrf X-Rspam-User: X-HE-Tag: 1749198433-421012 X-HE-Meta: U2FsdGVkX1+cPk6i09KWV2pH4iCbImeeUYSKZe2WpT+I8WhxuEnEVAA8kgnYmRSiz/lXh2qf3l4womz/OQBWcdQWAMVAOAU5uHrfv7a4W1U2WgPu0WurKwsEatK2VER5/TrHPpc1LAQ4Ch9sxqmhrl5Mf+OvUcbaJpVue11ewZvutswr5Vik68WhRU9PsW2Q1mQTuK/ytE1awTuetm+vVPqbX2+QUzZVmK5J/96D4YuHVm7+cMpduvV8n/FveWLnWO7srVHRlvtI1akNWM4ZMoLBlCkJKRfiCc8WJVAr8DgjHAlKvc61l3FxV9Ki9ZFfnMW695A/s3PHxj1V7qeprWo3+vzT5T2s4PPK25J1o9FM1lmeUdrBBg2PHg49GxN7VYKxojNyvB2dG5uHTZuMPNcY64PQ44w5CczLM80RBeDvg2C0Y6nEwkV5SNan3ng8iSCG4J+6SMO9MFJ1N92JmM7WFPoK1GDnTLHFihoIR2SbBHGYDKQbgAkOUj5kQwHHueblNhxyLBIcSOkqPyX9EiEQT/sCzWIEWKExT3zXNLM5r18KhwETugaIiL/jJpgjKZmNJHCXhB/JZRhOBnpf6uctvu9ECnHIR8HVbAlrnFlIObTca9ShVc+0jfivpzVo/Av3V1BIDIXE6XpdNdw7SPg4sXT54iWtgaGkPTSRm/w+Cv13jdY1O+28LHwM7yH82zni8TjyYyeI9F0oxlvrTlj+ttY5EeJ+oDoc7/T1HmR7HrBPD2EDLkwAkEnqUgu2K9LIy79zrOUSxZxVnnbLof4antkT7m1GdvlTPSbSPb0r3kKAlKrbu7YDw12H0jdvRB85m/QwbTsosrukqBAtMKpBFoF+MIgIeafV2FGZCGBQZSWWQnMjLHyiEucCoCD5c+ZrdWCqhx0QHaAsU1lpeNO8IIQMpjsSEFYJklETsdZE29fKjXiM2YnPy6XDZAacQiv4N4tqdDpP3fcIDQK CJA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Jun 03, 2025 at 11:16:33PM +0200, David Hildenbrand wrote: > Marking PMDs that map a "normal" refcounted folios as special is > against our rules documented for vm_normal_page(). > > Fortunately, there are not that many pmd_special() check that can be > mislead, and most vm_normal_page_pmd()/vm_normal_folio_pmd() users that > would get this wrong right now are rather harmless: e.g., none so far > bases decisions whether to grab a folio reference on that decision. > > Well, and GUP-fast will fallback to GUP-slow. All in all, so far no big > implications as it seems. > > Getting this right will get more important as we use > folio_normal_page_pmd() in more places. > > Fix it by just inlining the relevant code, making the whole > pmd_none() handling cleaner. We can now use folio_mk_pmd(). > > While at it, make sure that a pmd that is not-none is actually present > before comparing PFNs. > > Fixes: 6c88f72691f8 ("mm/huge_memory: add vmf_insert_folio_pmd()") > Signed-off-by: David Hildenbrand Reviewed-by: Oscar Salvador -- Oscar Salvador SUSE Labs