From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0BEE6C5B543 for ; Thu, 5 Jun 2025 05:18:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8899A6B0166; Thu, 5 Jun 2025 01:18:51 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 839066B0167; Thu, 5 Jun 2025 01:18:51 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6D9DD6B0168; Thu, 5 Jun 2025 01:18:51 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 4D3E96B0166 for ; Thu, 5 Jun 2025 01:18:51 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id CF5B6161510 for ; Thu, 5 Jun 2025 05:18:50 +0000 (UTC) X-FDA: 83520192420.01.176E3DD Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf09.hostedemail.com (Postfix) with ESMTP id 9DC9914000D for ; Thu, 5 Jun 2025 05:18:48 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=dFUSSWg0; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=OQLhnjrn; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=dFUSSWg0; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=OQLhnjrn; spf=pass (imf09.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.131 as permitted sender) smtp.mailfrom=osalvador@suse.de; dmarc=pass (policy=none) header.from=suse.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1749100728; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=M6YRlTArp4mKb+ynUhlVeCQIiNcQ2GjLBI82fuvz7Dg=; b=wjv2rg7T83Zz2TI3DH0upZLJxUJ0kM9IqxxH837sn0ito/pPTM0jduq9+K/I8O8sx50t6G d+EaYBr0FJjmSWSZUbFb41BpHMUl0+T9IZLdjagJr7cpZAlDgnWDOJaOWydpXeLvL4bToz hTPlu2l1p/zjPdIoKq646BxM4XoDNs8= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=dFUSSWg0; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=OQLhnjrn; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=dFUSSWg0; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=OQLhnjrn; spf=pass (imf09.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.131 as permitted sender) smtp.mailfrom=osalvador@suse.de; dmarc=pass (policy=none) header.from=suse.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1749100728; a=rsa-sha256; cv=none; b=sxueodXx049J+2rLV9+mt+bmmopgS3xkUG68QFrZ8Ss8N7/peSRWzuVJodZOgwUnBzvHGE 82dsAc45/WrBeFRNbST0lOmSsP3ijuu0YXb/bMwAK3pI0lrWWG8BKoHOgqm8K1Xl4j/p1e fUQwPS5pYeA8fLlyGK+nmk55UC2uhCY= Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 7660720F07; Thu, 5 Jun 2025 05:18:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1749100725; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=M6YRlTArp4mKb+ynUhlVeCQIiNcQ2GjLBI82fuvz7Dg=; b=dFUSSWg0RDbwBWjqUo9TH6r8OztgXCb17cqSLW8r4VbUN+ZfjQIpebtVUVXYedkhgbmtX9 4jWTfAbCK+4CSu7aiZdfYgULU7Op/ZW/OV/5Uz9agVgsQyfBUC0RRh40Tcig8VqbdqDwm7 Yd3tS58Sq/cRU+EMFF/8vnQOOejORFM= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1749100725; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=M6YRlTArp4mKb+ynUhlVeCQIiNcQ2GjLBI82fuvz7Dg=; b=OQLhnjrnknf+r7qx5geJLQmlPSmBVTStq5ukqgvTYm6eQIcZlEVRA1mmDxAjWOyrbfXV32 FOBDdvVbKWEHyNBQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1749100725; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=M6YRlTArp4mKb+ynUhlVeCQIiNcQ2GjLBI82fuvz7Dg=; b=dFUSSWg0RDbwBWjqUo9TH6r8OztgXCb17cqSLW8r4VbUN+ZfjQIpebtVUVXYedkhgbmtX9 4jWTfAbCK+4CSu7aiZdfYgULU7Op/ZW/OV/5Uz9agVgsQyfBUC0RRh40Tcig8VqbdqDwm7 Yd3tS58Sq/cRU+EMFF/8vnQOOejORFM= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1749100725; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=M6YRlTArp4mKb+ynUhlVeCQIiNcQ2GjLBI82fuvz7Dg=; b=OQLhnjrnknf+r7qx5geJLQmlPSmBVTStq5ukqgvTYm6eQIcZlEVRA1mmDxAjWOyrbfXV32 FOBDdvVbKWEHyNBQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id D3B6713A1D; Thu, 5 Jun 2025 05:18:44 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id EsXDMLQoQWjyBAAAD6G6ig (envelope-from ); Thu, 05 Jun 2025 05:18:44 +0000 Date: Thu, 5 Jun 2025 07:18:43 +0200 From: Oscar Salvador To: David Hildenbrand Cc: Andrew Morton , Vlastimil Babka , Jonathan Cameron , Harry Yoo , Rakie Kim , Hyeonggon Yoo <42.hyeyoo@gmail.com>, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 2/3] mm,memory_hotplug: Implement numa node notifier Message-ID: References: <20250603110850.192912-1-osalvador@suse.de> <20250603110850.192912-3-osalvador@suse.de> <9a845c21-5cfb-4535-97bd-0b02f5852457@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <9a845c21-5cfb-4535-97bd-0b02f5852457@redhat.com> X-Rspamd-Action: no action X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 9DC9914000D X-Stat-Signature: 4rg8838irxoqxz8ibdgft6h1j3mg3han X-Rspam-User: X-HE-Tag: 1749100728-200469 X-HE-Meta: U2FsdGVkX188bbItRgRu+5AxfmaNo12CV7Bz7/sGNmzN9m21jURYcW4NT168+IFJJ8fwglgOvEoF/hngP01bjybi+R6sGTKF/P3kHqoneyphiEML7B/lqn6Wx8TT37XbU2VaFbTNR66IdOMxf10rgdGLRdP+YXFbSqA5PQbI9y8TIhG48iGzKDlPhA81Lx0NQg4A4+896siHgTqSznWdk8C2N1d+oBIzNVdij790MKzCVmXLdeJxbtS1Cu9Mep0+qDPdl90Jr9nKjBOfGWPOEOX7eXFCGfT4cFT5bGVzftfqWOQuA6+oup86lFRBCzWPbG67GQTm2FrQ5s1A8wjAr3KiFfdJXccgah+O+gwP94Y1BAWuClqm8RGJF966ilyD1CZNNO8PtR2tTaq+VKVDOIE+L6bitflfmfFcofNnPjmjK2gtP3f0nEaR0EI6O2qUp50RKEDEPmZunpxtPC/adW91idC/noKCKAryiaoGozNs/2+9vBhOciGDVnWR+YkOkEPFFqY9HW/utHt+6jwbnHnmdBl0XhAq7YQyJ/zGRVAXG0hJ/mkfJOP62sevKdOlefJCiNpgwJgJknmj+mrm1DE85nhcTFMYLiVfqAC06uSSha92VrbMrokxnXYVvp9mvL4HOLD74ljryWNnAC1AW3T7ACLyU/xriWPP2HmyLDHFQU4Cfg4QmzcNZ1pVbTB8+ooMylgBIiKYpx2ZxmE6Aj4ufBT9l4YdFY6i6EytCR+jKeJKVoW+n1U3z7ZFa18Cc9rH8ICbRzXk0513pvRGMR8+fVOn1Gaikp9qt0yA/qDyATmQw6iIWStS1NOWNE2UpMrW37KXx1OGxBbihbL7ZfUbtW+43jjOVOZP+mdN+NQlxnb30Ey0eCwIOo7WwpjJtV62qJP0sAJnbRVCQpeiQz29xzJOKXOAobHlvRfVaQJSHrFxbtFdIXvGXmRUU+yHeMnLlelRaSqsuv9Zs1Z wz8F5mIS lJ1qKRM0FSnsKwb0s8gtpJY/RHW9275JdWLtmPF9ZN+DCv+tGtByLnZBRIS/hOxeF4mGEO+DmNr4hAl5dvOK99aZ6RC9X/64j8yiBR38jyV/ECLTunhd/rFDup6YONCCSAb9jRtIrzTi2Ui4/OlnqAt9/O1TwOC/kwqu0s0JWJMqBz17da6sZdNzZK3UUqns+udxxNl5H4KlWdm0WqEAPN503sgwL+YVGTgGbYI1wb2udHPSg/ONE8rgO4tHjoTWSjAHRqQ8cMGxjY3ZB8RBFcWyi7kPxYAI0iQOcnegOvjTbENAoHs/FZUwOzoNfTN8qxUzPqE5GoITEjeWmKlDDE1gLWb6gnlg0waoyTml0vF8SGG4+GCMmbE56Elw3onMQaKV/ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Jun 04, 2025 at 02:47:28PM +0200, David Hildenbrand wrote: > Just to clarify, these were the 3 notifiers each that belong together. I was > not sure about NODE_CANCEL_ADDING_FIRST_MEMORY vs. > NODE_NOT_ADDED_FIRST_MEMORY. I started working on the new respin and the moment came to make a decision about this. I think I'd go with NODE_CANCEL_ADDING_FIRST_MEMORY, for two reasons. One is that memory notifier also uses that therminology, so I'd use that one for the node notifier to keep it consistent. Someone could argue whether we are perpetuating a bad decision naming though :-). The other reason is that to me, it sounds more natural as the way I see it, we are canceling an ongoing operation (memory-hotplug). Now, I can also see the point in the NODE_NOT_ADDED because the memory could "not be added in the end", but at the end of the way only one can be picked :-D. -- Oscar Salvador SUSE Labs