From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4AE2EC5B549 for ; Wed, 4 Jun 2025 12:38:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D90B96B0554; Wed, 4 Jun 2025 08:38:09 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D40FB6B0555; Wed, 4 Jun 2025 08:38:09 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C09A26B0556; Wed, 4 Jun 2025 08:38:09 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id A20326B0554 for ; Wed, 4 Jun 2025 08:38:09 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 49EE1813A1 for ; Wed, 4 Jun 2025 12:38:09 +0000 (UTC) X-FDA: 83517670698.09.7B0265A Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf22.hostedemail.com (Postfix) with ESMTP id 03A53C0004 for ; Wed, 4 Jun 2025 12:38:06 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=2PCQSYk1; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=e2Iho95T; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=2PCQSYk1; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=e2Iho95T; spf=pass (imf22.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=osalvador@suse.de; dmarc=pass (policy=none) header.from=suse.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1749040687; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=sK4fJiQQfbJ0KUB/pSNHrTq2CqbwKDdWTRAtN+ykQpA=; b=tlSSZxiCrv2JpYqaQe6WyKS81Ey6U56tJ+4hHJtikUv7zN/hjEcVoX+COuGHigjyM3/6Cs xGx6lmSf+soEjOupWb4kg/67DpuLdDFtQvT11dPCtwuGcBPv2MAolKUoyqv2BNGk54Zbqc P5UmuYCPgOyAkTpng73wVn3gdeulKzs= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1749040687; a=rsa-sha256; cv=none; b=o0Y9y+M1Kc3FLzkDh5vVoBQFNJxEnK0RI1h0u4STg5I5uV6PN3JJuLbK+Gf0OeZd57wBEJ cjEDtBoWw6HPi+wwRLTtKxLIa9hNXQrdUWW4PtyAQqB/gBP4XL47+JE9l8+9/pXMXD6xDa fE3SQ9d8dQWL+zU5XtPgoBqKu2uO7mY= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=2PCQSYk1; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=e2Iho95T; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=2PCQSYk1; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=e2Iho95T; spf=pass (imf22.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=osalvador@suse.de; dmarc=pass (policy=none) header.from=suse.de Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 8569A21170; Wed, 4 Jun 2025 12:38:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1749040685; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=sK4fJiQQfbJ0KUB/pSNHrTq2CqbwKDdWTRAtN+ykQpA=; b=2PCQSYk1LNb4l1OOxs1xP5+n7ldYg4wxBW1dAXAU+3OS0O2EmleGpgnTxuJ+bxMibjDhv/ xHpQW09cr1Vni0yzpse18LqWze9w1lXNYfZDJEmA2X04UTKEIiGl7EK8yPcYkc0+wbD6lQ Dg6eVYaNI6Dec3G33SPq9lH90i4gf8g= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1749040685; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=sK4fJiQQfbJ0KUB/pSNHrTq2CqbwKDdWTRAtN+ykQpA=; b=e2Iho95T/pGji/VS2o+oHEEtFSYBe9KEQFwfJn9Q85g6hpg+hSscz7klso4Q7oPd0El25+ +iOMKu1EvJx6VuDw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1749040685; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=sK4fJiQQfbJ0KUB/pSNHrTq2CqbwKDdWTRAtN+ykQpA=; b=2PCQSYk1LNb4l1OOxs1xP5+n7ldYg4wxBW1dAXAU+3OS0O2EmleGpgnTxuJ+bxMibjDhv/ xHpQW09cr1Vni0yzpse18LqWze9w1lXNYfZDJEmA2X04UTKEIiGl7EK8yPcYkc0+wbD6lQ Dg6eVYaNI6Dec3G33SPq9lH90i4gf8g= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1749040685; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=sK4fJiQQfbJ0KUB/pSNHrTq2CqbwKDdWTRAtN+ykQpA=; b=e2Iho95T/pGji/VS2o+oHEEtFSYBe9KEQFwfJn9Q85g6hpg+hSscz7klso4Q7oPd0El25+ +iOMKu1EvJx6VuDw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id EF70F13A63; Wed, 4 Jun 2025 12:38:04 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id K6e8Nyw+QGjuUQAAD6G6ig (envelope-from ); Wed, 04 Jun 2025 12:38:04 +0000 Date: Wed, 4 Jun 2025 14:38:03 +0200 From: Oscar Salvador To: David Hildenbrand Cc: Andrew Morton , Vlastimil Babka , Jonathan Cameron , Harry Yoo , Rakie Kim , Hyeonggon Yoo <42.hyeyoo@gmail.com>, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 2/3] mm,memory_hotplug: Implement numa node notifier Message-ID: References: <20250603110850.192912-1-osalvador@suse.de> <20250603110850.192912-3-osalvador@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Action: no action X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 03A53C0004 X-Stat-Signature: 4nbbxdsw5u1eykbb1jmnod9wd3bfdqe8 X-Rspam-User: X-HE-Tag: 1749040686-811455 X-HE-Meta: U2FsdGVkX1/IL127ViiSxEyjRJs3ZKn/16EUF9TTNpg3vW0CtDLJN6B9R2cgWnw/YKfiA17PaCDeRIrs4Iywh6Y6KmNtGHe4bRi35IUTZHjHYyG2Lu2faQt3hYAXveoWdVvmqwdmew4dIjtqHwQOG3Bi+z9HCNudN/LzjhtydBbIC6ttapIQieuvFlZ/FQHw4V3QRI9Buyn7awLABEe/gmNLT7aZRgXidLYpRYWR10mzGijjy2CnbdFrw9CZQhQNN7MynQA/5MTfEAhL23beKb4K/JfJHKyTUtJZ4pxFFK+3xHZoDg6wNa8Vmsnwu+sPvf6Xp1UQLEnBncZnoTwNXK3YjvvlAxlCMbo+sBPnZP78IMw8tkiKIV5FHLaSXhjYOzZAodGimOqkPFenZDfol+AxnsK1p6XG4TwE3l4enCM7ToCtLBPEdbmg3mQvso4znV7c/UnCb8pDPZFHtZYHlgM48feFEsNHGWCy+tCoHX3csLZhAfuFkrrsfhfFIdoNZvTxdbtIUAzYLl/q3O4AcfpntL0cEe0vmJhqv6kh1502lzmYohAKCssVnS1mAnxg8xNuSrT+74yEYqivm8t0Se/eaj/73qX9q8WMGoXbvKPCcL8R4BM2uhaWyL6FA6Rf+esEvmPpjR2YGCfQperIqcaX47sdPY6OTWm8WnkYjXIIgaXWqmc6hbYP7/8YMFKcGj2jFIJdUuJ2kLaML4TZBOM/vhdsIRUnlFjOHZ19VNI9wS2XBxzcW8Yk/GD8sCTd3UOfR9qaHGRK3XbMCN0XPrgXNFoY2eafGEiGqVHdmW8t62mYqo7dg/JmyCe2IFVwpMg2HkJZbHDdyDnNiraTCeET+1yXXlNMcXMx7N4CzmPKMBZHJMY+CwWbn1/+7JiCJladsqJTFTT54YbXmDs9DC4JibrUeXCc834OWogf4RymVbqSPJLtSlDQxLRONs2unudSKvyTba3X+u9hH3C Oh2Htzuf JxVPxpDLMmbVNnPgHApNCC55pGVyJ9IEZChVl4s0iB6MQP6HLDaVsBeXH4zuiwKXLUYL+Kf9+4xC9uEXtYP8W/Fo/RILNjzNSP3LlSuzKlEfT8oQE24hgqzei9clA00SC1fJJdRqJCUmhtJvZdEsd82VaouaJGjVSoyu3DsdkEL1/gWHOK9o/2q1XCOo+ZiXoxD/Cr9RqgJV8dJRFwammGltQ3mE0oxnZx/+3PBYPQ72mFSQpOKOiDoSqLMhjcSUyRszwPslKLvGzSUBKi7sRIa6C5rRyQv6mnBt6PWikfFyMFx88cQ08gkf/KDLkRTfMEosRpmhnktrT7qzVRFbN+QETBXHc9nEggXirGJ30ABEAczJiOhToVV2izOXjpXcy62m7 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Jun 04, 2025 at 02:03:23PM +0200, David Hildenbrand wrote: > > diff --git a/include/linux/memory.h b/include/linux/memory.h > > index 5ec4e6d209b9..8c5c88eaffb3 100644 > > --- a/include/linux/memory.h > > +++ b/include/linux/memory.h > > @@ -99,6 +99,14 @@ int set_memory_block_size_order(unsigned int order); > > #define MEM_PREPARE_ONLINE (1<<6) > > #define MEM_FINISH_OFFLINE (1<<7) > > +/* These states are used for numa node notifiers */ > > +#define NODE_BECOMING_MEM_AWARE (1<<0) > > +#define NODE_BECAME_MEM_AWARE (1<<1) > > +#define NODE_BECOMING_MEMORYLESS (1<<2) > > +#define NODE_BECAME_MEMORYLESS (1<<3) > > +#define NODE_CANCEL_MEM_AWARE (1<<4) > > +#define NODE_CANCEL_MEMORYLESS (1<<5) > > Very nitpicky: MEM vs. MEMORY inconsistency. Also, I am not sure about > "MEMORYLESS vs. MEMORY AWARE" terminology (opposite of aware is not less) > and "BECOMING" vs. "CANCEL" ... Heh, that is why I'm not in the marketing field :-) > There must be something better ... but what is it. :) > > NODE_ADDING_FIRST_MEMORY > NODE_ADDED_FIRST_MEMORY > NODE_CANCEL_ADDING_FIRST_MEMORY > > NODE_REMOVING_LAST_MEMORY > NODE_REMOVED_LAST_MEMORY > NODE_CANCEL_REMOVING_LAST_MEMORY > > Maybe something like that? I still don't quite like the "CANCEL" stuff. > > NODE_ADDING_FIRST_MEMORY > NODE_ADDED_FIRST_MEMORY > NODE_NOT_ADDED_FIRST_MEMORY > > NODE_REMOVING_LAST_MEMORY > NODE_REMOVED_LAST_MEMORY > NODE_NOT_REMOVED_LAST_MEMORY If I were to pick one, I'd go with NODE_ADDING_FIRST_MEMORY/NODE_REMOVING_LAST_MEMORY. I think those make it easier to grasp. > Hm ... > > > + > > struct memory_notify { > > /* > > * The altmap_start_pfn and altmap_nr_pages fields are designated for > > @@ -109,7 +117,10 @@ struct memory_notify { > > unsigned long altmap_nr_pages; > > unsigned long start_pfn; > > unsigned long nr_pages; > > - int status_change_nid_normal; > > + int status_change_nid; > > +}; > > Could/should that be a separate patch after patch #1 removed the last user? > > Also, I think the sequence should be (this patch is getting hard to review > for me due to the size): > > #1 existing patch 1 > #2 remove status_change_nid_normal > #3 introduce node notifier > #4-#X: convert individual users to node notifier > #X+1: change status_change_nid to always just indicate the nid, renaming > it on the way (incl current patch #3) When you say #4-#X, you mean a separate patch per converting user? So, one for memtier, one for cxl, one for hmat, etc.? > > + > > +struct node_notify { > > int status_change_nid; > > This should be called "nid" right from the start. Copy that. > > @@ -157,15 +168,34 @@ static inline unsigned long memory_block_advised_max_size(void) > > { > > return 0; > > } > > + > > [...] > > > * {on,off}lining is constrained to full memory sections (or more > > @@ -1194,11 +1172,22 @@ int online_pages(unsigned long pfn, unsigned long nr_pages, > > /* associate pfn range with the zone */ > > move_pfn_range_to_zone(zone, pfn, nr_pages, NULL, MIGRATE_ISOLATE); > > - arg.start_pfn = pfn; > > - arg.nr_pages = nr_pages; > > - node_states_check_changes_online(nr_pages, zone, &arg); > > + node_arg.status_change_nid = NUMA_NO_NODE; > > + if (!node_state(nid, N_MEMORY)) { > > + /* Node is becoming memory aware. Notify consumers */ > > + cancel_node_notifier_on_err = true; > > + node_arg.status_change_nid = nid; > > + ret = node_notify(NODE_BECOMING_MEM_AWARE, &node_arg); > > + ret = notifier_to_errno(ret); > > + if (ret) > > + goto failed_addition; > > + } > > I assume without NUMA, that code would never trigger? I mean, the whole > notifier doesn't make sense without CONFIG_NUMA :) So, glad you asked because it forced me to look again. And I think we might have some divergences there, so I will sort it out in the next respin. Thanks for the feedback ;-) -- Oscar Salvador SUSE Labs