From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 89FCCC71150 for ; Sun, 15 Jun 2025 07:25:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 11C1D6B0088; Sun, 15 Jun 2025 03:25:50 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0A6156B0089; Sun, 15 Jun 2025 03:25:50 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id ED6DE6B008A; Sun, 15 Jun 2025 03:25:49 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id DB1BC6B0088 for ; Sun, 15 Jun 2025 03:25:49 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 623AE1402F3 for ; Sun, 15 Jun 2025 07:25:49 +0000 (UTC) X-FDA: 83556800418.10.A952BC3 Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf09.hostedemail.com (Postfix) with ESMTP id C64DF14000C for ; Sun, 15 Jun 2025 07:25:47 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=Izn5Svm4; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf09.hostedemail.com: domain of rppt@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=rppt@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1749972347; a=rsa-sha256; cv=none; b=q9hdv73mt1wPO2YkLNwCg4Mx33vY9GgjrNBXUW+g9oQ3wN8NAOg57gNFu5qtZLA8YJwL3l U32pC16Wa08Y702srW5mAbmPkE6dUmOfQnLHEM+6j6v9t9ZDSq4ZO0/taGXCoTzRYoEvD+ yI2zmk+eAowas6NjhmhxpLNmu+9xl+I= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=Izn5Svm4; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf09.hostedemail.com: domain of rppt@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=rppt@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1749972347; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=COHyn3noyy+9mpewcG/m4dROPi5yIhHvzGEpw5P9N4g=; b=wz5TTocHEfcCmHRdKCrf36+KBk3RrFAWt39x8UXckZDmTmgJPWFU04xheV5x6vBicWtSFZ cLsoRIL6GdlkF1XTbrtTRFfgsJ8QmGT7WbJMRTWECU/9EEHr1MTRvuX80aqCyGhxslIZSt cNT166kLOl5m3mue8d47ClhG5QCQ+Xo= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 0A761A4F3C0; Sun, 15 Jun 2025 07:25:47 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 13A78C4CEE3; Sun, 15 Jun 2025 07:25:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1749972346; bh=6cIF3HC7Qqqk3h3DoiQY6F1IwQazmnD9Dck+AwtI0Uk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Izn5Svm4EyUjcCMMj3b6iP2iPb0CELuwckgtijOcXPE0EzlddcecPR7rUGT5Gy36+ 3iK3QiDUx3sMZ+jpgMq9vwnqU8iAPpcqz5bFsy96dhjTDbhld2G9NEWyIKSTkDR325 4JiQOoWevaGOnBEpIScQH0h3XDGh1wpfpbiFbHh+Ed8ktv7XKwz9m/2SudDhBukf4a sPs9yUcfWGv5qQH9kvjWGACmla1pb0Asd5fbsIBeJODSEg4+FnHjmVif5pSCBKQrsx boL27DlkfUVA/KaABcckqxYbzBoeK7Yru9l2jECsA7Uz+jBvJTcFxG02iorZ8Rioiq I6v6brWxsY4xg== Date: Sun, 15 Jun 2025 10:25:37 +0300 From: Mike Rapoport To: Lorenzo Stoakes Cc: Dev Jain , akpm@linux-foundation.org, david@redhat.com, catalin.marinas@arm.com, will@kernel.org, Liam.Howlett@oracle.com, vbabka@suse.cz, surenb@google.com, mhocko@suse.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, suzuki.poulose@arm.com, steven.price@arm.com, gshan@redhat.com, linux-arm-kernel@lists.infradead.org, yang@os.amperecomputing.com, ryan.roberts@arm.com, anshuman.khandual@arm.com Subject: Re: [PATCH v3 1/2] arm64: pageattr: Use pagewalk API to change memory permissions Message-ID: References: <20250613134352.65994-1-dev.jain@arm.com> <20250613134352.65994-2-dev.jain@arm.com> <8077b321-8953-46aa-b06d-95c91823e6ce@lucifer.local> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8077b321-8953-46aa-b06d-95c91823e6ce@lucifer.local> X-Rspamd-Server: rspam01 X-Stat-Signature: dyhewp3tahruern655sk3bwjhinqbotd X-Rspamd-Queue-Id: C64DF14000C X-Rspam-User: X-HE-Tag: 1749972347-232078 X-HE-Meta: U2FsdGVkX1+9k+OeNb/RYu15NxHKZas1UZqyGo232Y7y1Y0lXaCzrSsgpOB9U7fXwzW8a/1YSstd21TTIeFIe5oB1nU9EH2C+/ThZdeeg8rfq3jFQe4urverZk2/kQs+zPau/6kty3xlhHE7MddStfj3ptdCssHKy94OdJdfQlyw8hVNqLWZKyhyiQKjcZamSfKnn8zJTFOiVmJvUh8ET7pZLUPZhde63yiZab4VweUlUFRBeAgYUDeTg3NO5LhizfweCPLafydCz0+sZLiGniwJICbuowU7rWwTfJeD5/G0AbCCHmi2TuOz5v5HuruNegfyzlYXyaG040kqI+fjpkhCnKrOqSvyeLzG0lr5VTUXeulZwKTF/H3N5P7JHcmPqnEoKpG/Y3JYBOhAAB3UDfAMu0tgPXXiRsuGlW3h9SYYBmZfgYlxINQVUY7gCOMKjzpmV58W7uUjQMlyghuaFxDGbP7Ej5Nsf8wIGerE4GpVOGgIjtGuglNVBXExTagnYMl94f/S+yjpS6Wq1hYUR6hM72tbOhlLmV+BXE23oDzdMJ8EYk8+ODt1/xIb2e3G8NLckx68E+slUYLkN8Y0uzJ7JEr0gx5jOMpgBonKROmSGYNiOHWhi8nUQEN25prqoYLbPdXigTeND5JFp4Sq4iadKU/KoI50kPAFLfUdIDpN0hhAYzOT1LtdePrzkd4OZ2Akbk2ND0aCJSSp7mXbWRpwetWnP8PC4NC/5sE9hyeoV7Rzo2stuUDj5aiC5Sdtif6gcVg9lK2PBI3rYee7xGX5vcG1QRoCr2cB/EXmZegd9iM5ubMnrfnpAobAu8DASxW1zMq8+xW3KU1PxwN84Vz8FjtTaaB2c9QMAeW4B8Tx2Nh3oaGhcWScJxLvVHGmMeEzFAfYuyhnHvI/4qVraiCBmisnUTMIxjg5fzF39kFBSv8JwiDBiEt8R/XT5v8PfWb0xMgHnXOf0G21lnn YB8ZtL/p RJJ22/f625uiVSzSXwJfuFlcoHGHZuLteigZLJzOS64QikbkzNCayKyNxitYHd8aQvqkTsv2g8/ozeWJt6WVQ7ATHl/ERVDduxQWMf9t0N/iQALopP3WjE5+tUWfnxLjo9lqZX9uRkScEuvpVg+ZfVePu+DgDFQEVcdKsVwDSmu18zSnKjbcMoh4tM19h4UBVFli+g6vS2C8K5DGcQgvuaEySW857rqNq8gApDzg/fx4AZy4pZxpgcXo9L/dkGKoAiT87 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Jun 13, 2025 at 05:27:27PM +0100, Lorenzo Stoakes wrote: > On Fri, Jun 13, 2025 at 07:13:51PM +0530, Dev Jain wrote: > > -/* > > - * This function assumes that the range is mapped with PAGE_SIZE pages. > > - */ > > -static int __change_memory_common(unsigned long start, unsigned long size, > > +static int ___change_memory_common(unsigned long start, unsigned long size, > > pgprot_t set_mask, pgprot_t clear_mask) > > I wouldn't presume to comment on conventions in arm64 arch code, but that's > a lot of underscores :P > > I wonder if this is the best name for it as you're not only invoking it > from __change_memory_common()? Could update_range_pgport() work? > And yes this is a pedantic comment, I realise :) > -- Sincerely yours, Mike.