From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 800F8C54FB3 for ; Thu, 29 May 2025 12:26:37 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 06A466B015F; Thu, 29 May 2025 08:26:37 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id F35D36B0160; Thu, 29 May 2025 08:26:36 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E24AA6B0161; Thu, 29 May 2025 08:26:36 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id C1D3C6B015F for ; Thu, 29 May 2025 08:26:36 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id E384480362 for ; Thu, 29 May 2025 12:26:35 +0000 (UTC) X-FDA: 83495868750.29.1170F01 Received: from mail-wm1-f41.google.com (mail-wm1-f41.google.com [209.85.128.41]) by imf08.hostedemail.com (Postfix) with ESMTP id EF65B16000D for ; Thu, 29 May 2025 12:26:33 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=suse.com header.s=google header.b=HreOsd4u; spf=pass (imf08.hostedemail.com: domain of mhocko@suse.com designates 209.85.128.41 as permitted sender) smtp.mailfrom=mhocko@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1748521594; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=iawn1vCo/HSjOc7UESxgkG0YCsSSV1rH3zlvPOdpZLI=; b=y5sILdqa7aYRb2gjFzw+xDIpWCxQPO3kwKY8aZt/3tDMtNNwWngYB1kXKtKpS1TVGSx3vS aa9XNIJtiIQVeje6VpoRS6XvYlJY2G32KjrQR6ttnHEzr1m8XgFwaYknl6KCehtZ88P2lH cuPQ2cuICn2PvMOfnoRDCFvg/zIQyWk= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=suse.com header.s=google header.b=HreOsd4u; spf=pass (imf08.hostedemail.com: domain of mhocko@suse.com designates 209.85.128.41 as permitted sender) smtp.mailfrom=mhocko@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1748521594; a=rsa-sha256; cv=none; b=pyQ0H0QVS+21A4PcVTg9wiWQgrZ+lKMYl4xVAS1GOSQ60893Ag1t1Y8HVJhpoQFY93P0Ai RkmKOKwQs5+aiCtRmBHa+aXEZ74q7vnW/hU/dV9A18OAjkEaP6ZlX4Pb8vHG3Mmtl6aOyP Tsd0N7WPPTisg+199aoVFPt3ek5qQhs= Received: by mail-wm1-f41.google.com with SMTP id 5b1f17b1804b1-43ce71582e9so7055845e9.1 for ; Thu, 29 May 2025 05:26:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1748521592; x=1749126392; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=iawn1vCo/HSjOc7UESxgkG0YCsSSV1rH3zlvPOdpZLI=; b=HreOsd4u+CwriQUR6TTUqJagChqg8WHFuPhPwAX34LAKGVFCyAAVvdHOwMiYE1J4O8 Hpb7SpdkDW+YqbT8FXuknyi+Mb1MsiNamhv2e50cfwy5orPuswc5E+J5UltHtE0E35QK Bk3Pdp3RDF8g4g9GIeHO9z+sjlCU/52gcl/bYn4HeicqpYHoE8CYZgvQr5h6AesgQVFK XJx+0kYZGZ/MUuykD5s18E5U3yYtPjOgxXRZvpJPsE0RGSBeGuuYpdNdZY4UOMC93CFS +8X1iglidDe8ebtbbL3+bnLyWcpI1istdUTc4PdArfxivEU4f2VZ5J1BnreEgGBOI4Y6 qXYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1748521592; x=1749126392; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=iawn1vCo/HSjOc7UESxgkG0YCsSSV1rH3zlvPOdpZLI=; b=UWlTgUNFSnjU/7zAVZlGxMbQgkyJTPJz2wadzixgjM1arYFibWC7h4A9nY2tupYQBa h3chutBK3Pgfa590ogvNZpZtPYDlRWQYgvKUNW7+WJbS7m/RPYZeI7wAdlOK5l/t+5Sk TI3CtuKuiUOEUDLkpAETeFIeDr2QPQAIQnKSLXvdXTbs01fSOO+l1/NWHVlsfVBzaJ2I LiSsGBpzCzPexX3iN6NQTaYQxUyyklAfD9/Q5RMGHwQcdXdYdsMHZm5elUUn0lqIH6fT 3C7Bs5ppoNgQ0nsSGMQt7Mhp57TV8WEgzLjh+ttCWSYJCC1mhdODtiQxkOY+7Mb1s59Z RosA== X-Forwarded-Encrypted: i=1; AJvYcCUhF8Z6gqKSS5FzHi8xmQToC40o7BWcIgbd7UnfZZUywK/h61HL9ZT9z5A3Pz6YspuQaSDhajj65w==@kvack.org X-Gm-Message-State: AOJu0Yy+LtR8Smlep7X6kw1c0MtZ7KsexEIJ0N0c4oyKTcZ3qzanCGO+ H8CcZfLoanp20y5S5NbcZGUvAVCYgsiGleZCXHKpWwgIL3vBhcP1kAgVYMO9InqCp2M= X-Gm-Gg: ASbGncuyX1FIKRBBWEm2WqTH4/zxuX/pEy5o5pWp/l9CK3AP9bz/C2fF1Fc9y5fkI4V HO8AtqNyEgNeLKKnQYpJJzgYJ33uCBmx7jiCKfMi4pkcipcuSLG4SZIa9AP5QurAXY15ZOPc2Qf o2+f91ndFBuvPp3XYn6SVqMmz5lDCZf0/NC7/OS9+VOVtZLoG+2riIF2qJmT78FE3pVDbhfvCnV hnPK3i70V4EvuMGzrvU7/XoIA/sE0WO1HyxTXt8t2/ZLiC6DGWysC9gMOoOUTfp0Gp2RIr9rRQX F49pZyKjrGq1piNR+vX7o7PQ9+sflx46XmUjNXLvMqfCjPH3Jb1kw+vrfCFnVqD1AgC5TOIZpj4 = X-Google-Smtp-Source: AGHT+IHXrBW9wsWcyYeTvN6V5sLeEne3uGLtPZraC+YCMYBnXf21jqTUKNAyRc5UNx5R4SMvt/BHHg== X-Received: by 2002:a05:600c:1d28:b0:43d:abd:ad1c with SMTP id 5b1f17b1804b1-44c9141d817mr185395945e9.6.1748521592539; Thu, 29 May 2025 05:26:32 -0700 (PDT) Received: from localhost (109-81-89-112.rct.o2.cz. [109.81.89.112]) by smtp.gmail.com with UTF8SMTPSA id 5b1f17b1804b1-450cfbf42c1sm19208575e9.3.2025.05.29.05.26.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 May 2025 05:26:32 -0700 (PDT) Date: Thu, 29 May 2025 14:26:31 +0200 From: Michal Hocko To: "Kirill A. Shutemov" Cc: Andrew Morton , David Hildenbrand , lorenzo.stoakes@oracle.com, Liam.Howlett@oracle.com, vbabka@suse.cz, rppt@kernel.org, surenb@google.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Konstantin Khlebnikov Subject: Re: [PATCH] mm: Strictly check vmstat_text array size Message-ID: References: <20250529110541.2960330-1-kirill.shutemov@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250529110541.2960330-1-kirill.shutemov@linux.intel.com> X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: EF65B16000D X-Stat-Signature: zcpxjfej9w97ge8yjccsh1dn74g5pgaa X-Rspam-User: X-HE-Tag: 1748521593-464687 X-HE-Meta: U2FsdGVkX1/j8Mf9RihBgHwo9CJRUA4RHBWeQq6zvJVp9weYRNEFHsNslCwmIi5HolobeTQF9LJ4ORaHjyWzEnMK4U5hrUW3mD8RW+fI4V7YmDtHf4+fpOpZCXwKPMGYSDvE3dRQnKg+fWlxS2RgYFPg5k8KK1ZrGMOzUZqiqLi1Tb61jJ4s8WrUaqBhGArLmbhTCKMz9iRLUncIEOreXSc45EWBAoiZROdO0CIRloOnyAqjCf2QINwfWUWPVr+7Gif/F7Eb+cJYzeeqrR2ySghI8L6XdN9APQE43beFBEldCucL+OCyd0KIG3bE5C52q6e6I0x2nB9MFDwXjQTk1e595Veyn3mavsaLPbUHaNPl3av1X5qrjUtkOTIRANO2aIBEcKnyG3UEhgHJ8ST0ciJdCaKdGITKNHw43/sa2H2q7jP6DA9a6zZMDNrmmcRFtsz3q4VyKykfBae0NEii8d5v3JOf+gYG1weyfkpn6pqhyKWIFkwY3qCYsd1jkKDbCqVesI+MABe06W6bOcC7+SyVdZFpuGjFFj3vqsgZIoHdu9mbVXPaD8aptrRv0R0Na86UK1gmi53xLkeHQotduZMYzzZqbXEeEtNAHLjS0GkdMDhIzkzKxR7GNZRPu1EjnFJLA7IR0Gr7uOhd/348d7Scvd7cFYbCLIoRcYbmcF2xRl29f/F6xxElv0Z0x4C783wa2xbJDK+OWa+o4dT7CqhuNyLkB1H6xkzcirkGIeSkNo7kySEOiDVQIQ3uMQrmECzBpZjPeCsUD+Ipe9xiSTJ5vw0tu4Kx3Xy+3ViMgmCOwadN0NDbJ7tPbOh5eRmKKNlcltfxQaXF5wxlyPMOk/d5y1cXbSreNU9e+qa58xhxHKwouB0Wy0TK6OnUscDFahTt6aykfdo06EfRPRGKtuyeJjXsShHFPUm3Wt78xvvBuBEeODQafEW+2VvYzauQ2TUt93vC99Sn53Sd0bY MLmDgcaS bDd3mp3yg2foh7GOUagZ3NuKKFVm4yne7dy/w4yWJ1044QmOnwzN7XGnLRPCXNbaxdGYYLSD42YjKRnlGyJlSzg9i3h76q9tapzaxV4dqWrhAQoxQaYp9LRBsKAMxLc7Km3v8ue1ds9uK2K1V4iyDDmi4WBfKBWTka1mkDcLmMC5nrWxQcaka117ugP9yVSYpIHX6GWDF5j3bBxY2ChakKQ/QKVreecB42D4nksZsa/UvgLPhB4c4cutd5oVwyttiZjhCFwTyjdQqGeAen9odmQRTz2tN1VPlQXq/uETviu08gaYnmlTPFwYKEmY0KgA4DCQ3gYXRBV7dwnyplee5HhNTjWMyfaqUlD2dU01MkTZ102/WIEJSkhBImtMUWOqo27dlpmaCS8VRN2d/jCNLFmkglCJwcr26mUqHff6i4oySyZXNosYUaM80ab+EsQUWmDlbKPhaHrbgBD86+6Rq7iBwbg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu 29-05-25 14:05:41, Kirill A. Shutemov wrote: > The /proc/vmstat displays counters from various sources. It is easy to > forget to add or remove a label when a new counter is added or removed. > > There is a BUILD_BUG_ON() function that catches missing labels. However, > for some reason, it ignores extra labels. > > Let's make the check strict. This would help to catch issues when > a counter is removed. > > Signed-off-by: Kirill A. Shutemov > Cc: Konstantin Khlebnikov LGTM Acked-by: Michal Hocko Not sure why we have gone with the current check TBH. > --- > mm/vmstat.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/vmstat.c b/mm/vmstat.c > index ae9882063d89..0903adace423 100644 > --- a/mm/vmstat.c > +++ b/mm/vmstat.c > @@ -1867,7 +1867,7 @@ static void *vmstat_start(struct seq_file *m, loff_t *pos) > if (*pos >= NR_VMSTAT_ITEMS) > return NULL; > > - BUILD_BUG_ON(ARRAY_SIZE(vmstat_text) < NR_VMSTAT_ITEMS); > + BUILD_BUG_ON(ARRAY_SIZE(vmstat_text) != NR_VMSTAT_ITEMS); > fold_vm_numa_events(); > v = kmalloc_array(NR_VMSTAT_ITEMS, sizeof(unsigned long), GFP_KERNEL); > m->private = v; > -- > 2.47.2 -- Michal Hocko SUSE Labs