From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4FA19C5AD49 for ; Thu, 29 May 2025 12:22:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CE4716B00A2; Thu, 29 May 2025 08:22:14 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CBBC26B00AB; Thu, 29 May 2025 08:22:14 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BD1616B00CE; Thu, 29 May 2025 08:22:14 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 9E9F66B00A2 for ; Thu, 29 May 2025 08:22:14 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 4F2031CE1CE for ; Thu, 29 May 2025 12:22:14 +0000 (UTC) X-FDA: 83495857788.10.801652B Received: from mail-wm1-f51.google.com (mail-wm1-f51.google.com [209.85.128.51]) by imf30.hostedemail.com (Postfix) with ESMTP id 46CC58000A for ; Thu, 29 May 2025 12:22:12 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=suse.com header.s=google header.b=QeQDvLCf; spf=pass (imf30.hostedemail.com: domain of mhocko@suse.com designates 209.85.128.51 as permitted sender) smtp.mailfrom=mhocko@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1748521332; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=al8287RxjgUX+nRH6wDLFLDnBZ/mAzEmTjClCtJoDew=; b=hbBdDvfHvo+ZbiXzFB+RoqCyW2w40ESpb4j52pdGx/bebIEB+L7Mg+K4HnM/aagssb9M8P 2TuCKcQL5Dk/FD4FqSe+CSfF8BumM9QiUj7ZdcZm86gFC/KO9Yq2O833MmXor8vNnvavRT xXRsQ/+YeIWiceTMN2dMcEkUopX00EQ= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=suse.com header.s=google header.b=QeQDvLCf; spf=pass (imf30.hostedemail.com: domain of mhocko@suse.com designates 209.85.128.51 as permitted sender) smtp.mailfrom=mhocko@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1748521332; a=rsa-sha256; cv=none; b=6JCmMo9/OIW96Yb7/a/si/FRQCoGBui282LQcH90eR5/AvarSl7W8lQML1PqBLx0v/bIZl EjuE9FSyIdKTDsxAmYoEPtDZJ94EqZOLvxj/+59AeLC34F3sG8PcMYjLPBzqIK3/SgghPl MofxyTfHjLBHK//ACXeq73iBC5+LzGo= Received: by mail-wm1-f51.google.com with SMTP id 5b1f17b1804b1-441c99459e9so6011675e9.3 for ; Thu, 29 May 2025 05:22:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1748521330; x=1749126130; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=al8287RxjgUX+nRH6wDLFLDnBZ/mAzEmTjClCtJoDew=; b=QeQDvLCf3IlLpIH3LpWkqZN3PMj46GZxAVxgSEspPQxKqQKjD88uCS9CZeKBdPzxfC S7KgZsagbLoVTTs4ywt14Os4bjNNhhmo5C10WHzD+ZAskbgQtgHqh1ADy3U6dlKByjT3 8+R8TbVvv4S09/JC04npF8VDExi8D6dQBqVNoC3eAaccTpsFjG7NxKtcGtf71Y/uYxEh c9Z1jJzSVf5BapR9SHSbgnATA5JgmPkx+z+w3GMm63v1rrg6v1Qlss5VDAa9TKFz3cqP 8AaLvkOC1/zEwyHEA3CMCY2a/7oGVDpV5PepMnJ5L46aw/GePvFAsC0pHVWmtPrpcVGY 245w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1748521330; x=1749126130; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=al8287RxjgUX+nRH6wDLFLDnBZ/mAzEmTjClCtJoDew=; b=XlmCIwVPdBBDVxC2PriqCeiO7tcaJcazkqZMkM3SQ/rto7hLyvrg0oEdiSknbmb6vX qn8NL6E+qUmx3w5JatjVECqyR+NdAKaeHtV2tygkmSTEEOGOGDdHcue70mJSee+Idnny hRQEwCasxy3MeBJjaQguZIr9UysLqXfZmudHqEoC/6g1xPfUk5kypxKJpb6b2Nr+H7x3 wa6xhp06Fr+8z3z0dfXBnQfhN2lp4P1LE/SE/5OtkoOIEyFFq87558trnS31fST7x9Wg 61s1fb36uWZE+k3E8JSh9vixwIzVO0xpyPeIvz9Uq2f3ByOeTTg7zfryYkIDmtWCx0Ox NzOA== X-Forwarded-Encrypted: i=1; AJvYcCVjPoPR7rIdJb5pXp0IVRJfc1MVA46Wo83lZZJ4VPt/nl4YEmzeaGAZbaPgY9+eAIGxAjEuG9WzRg==@kvack.org X-Gm-Message-State: AOJu0Yx93fwuJPb3HgTabvRJ99g81xQNwTqUQ8zwBpYQOd4kzJvx+zR5 L4smR1RzGfOqaD4SjWbZS8Iw9N4vtoE4Akoh3plxjWbMlRY6EUxFlAfFT9TVGqZLmKA= X-Gm-Gg: ASbGncsq+GJUJhEQKKw7WxcDPyZJ8AU2ZBCBPR5p/5/1a72iCDXBcpFMdTgmVEM21f4 n3zduspRhyJm5lNK6E5fGOB6naSKlCjTVKAwukpZ2bty1yAxx3NBJpuuIbxTUoZJSCfh7haqSmI ud1H7ymRZ0UhsYpGvELWGBcwAivc26L6ul8XGoaNPOR6lFTgmEfIzqJUIoAHihAnHSczL5gZMTI avqNPlfEL1chWSSRgs6tDfLJPacp+6zZKEFghagSG49koYx5zWQJxwZWOdn3X1tU797OJPDsezD Adh+YdHoV+Jvmj3xgCsNiisKi6k9Vf6IcY4rh5HTEtja2KHY92skcbJdPt7gdB7k X-Google-Smtp-Source: AGHT+IEi5QGaE/L2kia77TwpAy38jFwnSSaQnSkGGXHD3NLBpfAk7antH461TuYl2AZ2tzXQyeDH2w== X-Received: by 2002:a05:600c:a00e:b0:43b:cc42:c54f with SMTP id 5b1f17b1804b1-45072553bb3mr59385965e9.14.1748521330468; Thu, 29 May 2025 05:22:10 -0700 (PDT) Received: from localhost (109-81-89-112.rct.o2.cz. [109.81.89.112]) by smtp.gmail.com with UTF8SMTPSA id 5b1f17b1804b1-450cfc16275sm18627795e9.22.2025.05.29.05.22.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 May 2025 05:22:10 -0700 (PDT) Date: Thu, 29 May 2025 14:22:09 +0200 From: Michal Hocko To: "Kirill A. Shutemov" Cc: Andrew Morton , David Hildenbrand , lorenzo.stoakes@oracle.com, Liam.Howlett@oracle.com, vbabka@suse.cz, rppt@kernel.org, surenb@google.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Hongyu Ning , stable@vger.kernel.org, Christoph Hellwig , Hannes Reinecke , Johannes Thumshirn , Jens Axboe Subject: Re: [PATCH] mm: Fix vmstat after removing NR_BOUNCE Message-ID: References: <20250529103832.2937460-1-kirill.shutemov@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250529103832.2937460-1-kirill.shutemov@linux.intel.com> X-Rspamd-Queue-Id: 46CC58000A X-Stat-Signature: opqggr7tqyf96wc8rxzmypbttctye4gx X-Rspam-User: X-Rspamd-Server: rspam07 X-HE-Tag: 1748521332-723094 X-HE-Meta: U2FsdGVkX19pA4qguFONUTUEr0WOFwpXNXpzjr136AVjQBNJ4at0uVz0z/o7aq26nAgKgEdR0w97eA32jfSAQ6oqNWSuHy5m6o+Bv/CGcu6HfKvY1V1zyejZreQHZEVv/dD1opppKZLvK1NsoQe10K1zDk7hMNETlBdTUiO4X39zbTENnj26nALLS3UGs7OvFTQPoPtcWL+DD+vjqzMuGMBCtBSSyCzYu5qmo8PJDXyfkX1kpbQRpxYK+J3ec9knXTwHl2hhUF3gbrSx2ZezLxevrjL7dOwqkpf/JUKWGw1qeOQVg8sUmU6Ap+Ua9YgStksO75dVqXD6IQO8zUi4DxSfbEReY49RkPjrjsP+lP+Jl62bh/ahjRX0WDyRI9rtuzmVtn0UmqPBv4lziWUCYLCKrdqS+L5VOmcxKn97FZeLB1TroeMM6KljsHQYTGw7/Y+oTOaAxMJOIiFztF0UZNEYjpkGt2xVWxYyNYbdk2onFL9+WG67ameqjsLX1CNnaEBkwysXRA1HbBCjLVOAZa2WN5+caoS/o8raJg/D0lMdUJtU0Lb6iiLd16rBUwkJuRen2vvETWo9uhAsZOs+8RuiCqE7idxGtk6Gr5wwGbX3nXEsW2+IzoiITogAmwDXNtQJqKlTeGE2jPXnoHCvcHlocRR1nCzvo0iLXRHQxDsnWMpgNFbYdImthD3bcJatHiPgiyRcKCSDbXynXPv118lJr7vO+doS3S0Nr4M29XkdgAwbgML79UjxGhJ0cfIrV4Q3qlDHtobdiV9AspecjOnsRf2ZG3/g/qez6wg+RTpV6ounEe7th8bgq0dYqiOrR821ubC2LrxGnxgDi7pikw2+5AMf36ahJVV4ptNarMexkyuSzNY+t0g+A/5n5Y/TR8zPYBveuTggvkF15M0b2zFrYfJPkboube1YxAfUAhTxs2HNCQQ+COqZfO/j3cTDbEkR8FuT6TZPuiERo6+ LEUy0cfW hgaoPMKM06LBDafcFb7p1ih9v2sMX4TsEb9XBa0WaO3RXU+h48U9INKBgZ+zTcAsbxxiBZCYsQoeHoWSF0fpwJXr75i+uQKsosU3xpks9NDcBQf9NhGvddPV86ygzkGsmndqjTXWvqM3HHmGnKhdnfnKEodFnQfTtGPzVbd9pigDqdocqIuzF0WQzKYNdUbP6v9bS+JKsUFSHz+OGx8he9t1wcgdAkdVkDV5rlZ2GQNYU+8O4uuM7dnrW1TC8N7qIizePH5JjgAMYSINb1K0WS5NXySRDsRV0SmSX5ladvw89AYi6k87aWUAL9zWLkMlecl5CwcO6T8IHJSQd2uLBAGugvPICkFmLL5Vy1lWoPF8TRHc3PJbyu+xzhH/o15yhgL6uO6c95yNHMoa/+djsBXVpfnNlW3quGhi37lKedkqNpDmGeKbvkladRYxg6iPKbsAH3Oa55fbItjAavaGPYgA5tehTUKvA77Hy24dNKYAIvdtBmurWuEcA/J3BfCCipFeX/+aShiHMK2SzAK/zgghlBA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu 29-05-25 13:38:32, Kirill A. Shutemov wrote: > Hongyu noticed that the nr_unaccepted counter kept growing even in the > absence of unaccepted memory on the machine. > > This happens due to a commit that removed NR_BOUNCE: it removed the > counter from the enum zone_stat_item, but left it in the vmstat_text > array. > > As a result, all counters below nr_bounce in /proc/vmstat are > shifted by one line, causing the numa_hit counter to be labeled as > nr_unaccepted. > > To fix this issue, remove nr_bounce from the vmstat_text array. > > Signed-off-by: Kirill A. Shutemov > Reported-by: Hongyu Ning > Fixes: 194df9f66db8 ("mm: remove NR_BOUNCE zone stat") > Cc: stable@vger.kernel.org > Cc: Christoph Hellwig > Cc: Hannes Reinecke > Cc: Johannes Thumshirn > Cc: Jens Axboe Acked-by: Michal Hocko Unfortunatelly a common mistake to make. I have seen you have a followup fix with a stricter build time check. Will have a look. Thanks! > --- > mm/vmstat.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/mm/vmstat.c b/mm/vmstat.c > index 4c268ce39ff2..ae9882063d89 100644 > --- a/mm/vmstat.c > +++ b/mm/vmstat.c > @@ -1201,7 +1201,6 @@ const char * const vmstat_text[] = { > "nr_zone_unevictable", > "nr_zone_write_pending", > "nr_mlock", > - "nr_bounce", > #if IS_ENABLED(CONFIG_ZSMALLOC) > "nr_zspages", > #endif > -- > 2.47.2 -- Michal Hocko SUSE Labs