From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EBC6BC3ABB2 for ; Wed, 28 May 2025 22:56:24 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6421A6B009F; Wed, 28 May 2025 18:56:24 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5F29B6B00A0; Wed, 28 May 2025 18:56:24 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 52EFD6B00A1; Wed, 28 May 2025 18:56:24 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 346816B009F for ; Wed, 28 May 2025 18:56:24 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id E91321D47BB for ; Wed, 28 May 2025 22:56:23 +0000 (UTC) X-FDA: 83493827046.19.29D97A8 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf09.hostedemail.com (Postfix) with ESMTP id 80421140003 for ; Wed, 28 May 2025 22:56:20 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=ieCAWUje; spf=none (imf09.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1748472982; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=9mVYSomClwkuW9XSpB17kuYPC62FLZMq5IEqmVZkEdI=; b=Hnw42RUHnuRo7ML59maSfN+kUTM9vwTP9MXNleCuxjquPYQWAf1fGEZGX+ILYPlLnyuwJf Q+wt6F06zf8hhmny2cBEEyWvCnTuYWuxN6ptqimpPsCbJEleMtbk67K295YslaoLdNY6YW jC/zSERzCTgNd8zwwa6r5e7042IrCzo= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=ieCAWUje; spf=none (imf09.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1748472982; a=rsa-sha256; cv=none; b=spBsLm64ixCEM4vonRU/3Qpl6lh61Q1tRIfz8dadU3aC2kyrw/2sQdlNi8vNybMuw0LqIJ 6cJp0ba7w4cXvGWw1iU/F7IJ6QA71a0xbyoyz0eOLoMUwIbwBOe6GMWFDktjnYWNBg1aL3 1dRmnPDCns203aLSzw7qlq9rhsCaXYM= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=9mVYSomClwkuW9XSpB17kuYPC62FLZMq5IEqmVZkEdI=; b=ieCAWUjeGPxpBEAwBfSBWn4Hz4 d8GLRld0643srXL6C+PzeKx67BEsXCzM/8oaH+/IeQAcZ+HysNwvpq2iXqvVm8mCY2Qd4V7k4gk3t yTxy5ZBlFcZruXqFB1g4BenYXZrGziBXeck7ALUCErgWIJqPZk+1Rwq5sk/bngflVzSpvWHZZik8e KhhgvzAk1oAb2Rec1v1v7uXlKfzoyxaphiGcQelvSRT5260vFNmRlz3kRa4dtDobEcPV+imXdCUpi X+C1wtGRf87CwBk0ZAMAilDMWu+DPB/4/ivjp8ClGiOkmmhjmSOxTuhU9hyQOwXYkFxAuB94Sn0EC N25IX79w==; Received: from willy by casper.infradead.org with local (Exim 4.98.2 #2 (Red Hat Linux)) id 1uKPh2-0000000EAe7-3cB4; Wed, 28 May 2025 22:56:16 +0000 Date: Wed, 28 May 2025 23:56:16 +0100 From: Matthew Wilcox To: Sidhartha Kumar Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, akpm@linux-foundation.org, muchun.song@linux.dev, osalvador@suse.de Subject: Re: [PATCH] mm/hugetlb: convert hugetlb_change_protection() to folios Message-ID: References: <20250528192013.91130-1-sidhartha.kumar@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250528192013.91130-1-sidhartha.kumar@oracle.com> X-Rspamd-Queue-Id: 80421140003 X-Stat-Signature: gy8oqdpw7sgp6mck6uodut5mxgjkjwne X-Rspam-User: X-Rspamd-Server: rspam04 X-HE-Tag: 1748472980-363367 X-HE-Meta: U2FsdGVkX1/39njJOGCQn/yrBa10zRNtzNJt0Su5x0Ze5Dsn30wuLlcano20wwQm4wf9B1FgbqAz+us52QM5MhbIyQNmzgguE/rvqGx1Xt/3v2KNRUUIiuA+JgkBdIMtKWxEJAjQlP++FP2CMZ2+6dwb7Z8dXAwtdVf920ui/gqC3ZedKZAXtkYoWD/gkh1MrfMMbjaLLAA+1AekW1pcne+LuelRheMPGmQ7Zkhf3sUysfOhO52xBbbWXEQ3edCytKyDG54BK7mIXri5XBs6HL4y4Gqcj3u/Fl6foMBwNCLpmAWIT5W3XGgW7GDrYme61YO1RohUaXdHSvm81NxJ03rZ5J2GcNetsx74Zli4L8HB5XUFZSW5MJjjZL7hdzO0eyjdbaaiiGyvq7OL3EusaOiraa6ytJPRFLizXxzKiXNpwrvh5VIdkPom7KyXFiQ5qD3FQYDvbah3dsRxF68hzCdZe1jnH6+N2dJqQOEtPdR1bHuxVoXry/qK6ZC7uEyqgArVkgv5pP2otGW42C3IgTCCYfMEyDBjp1I91S5wLihPVoSxLFWS9KsOlfIzb4VOfEYc0jz2wx9N27pPTMdBEuEOsayueJPtzNA3zkrv1QTHzrRQElZvCybGIPDbb1Q6bLvzM2EhHjX8OHI9puOkTFNExw5H60L3fkxh3KO4BfhJ2l6v4Tl789cjOUXOAirFUYGULMQ8v8MWUa3OVqFEFF3fUwwhzk432jvVunx5KA5RHniGwBRSu/cr1b0rmXKx8hooKx/Hq9AAdeWdXKYZs7he5vIIMm7Ryahsu+qYi86p+SBrHXWwfd+y7y33xsYtBGclStVhd99v0I31rJE0Vxg7IKZ45/NAOFSUGmJ8BC3EzE2Gz/pHAzaYzoXbjMY5JlwkpC5tyjCRdrfsplPeTUqOqfnyneteNgE5e2zo+iH693+ilf7/SiMlyv5RjczSZWx3HVd2s/1TZ0tfxDk z7zdmyKB odqCxq8sYRyZX5NLwwXfub2qvwaZQW4GzxjFF3fvZksXGScLUcMLo3Rs4KQ4uGIgOPA/28+oQcdzs7WOqyT4YEmAuCeU1UNG9b+qEeY6i4hMa4GqiBxn0xMrLZr6w0RapfEcuw6kQKj2TYQxh92+vEAaQoSdjVZpVKQ6ILj++TdWsZm571z9ACcppGicgtVZDPhnhE30Suphp9ZCpJ5Q80bWo4zwC1pAEk4SxuC2VcSR6O2AX5WqCHxzBAO1ujvJTwuKYC10o8lKfQOXZGcvsvKpTmnwmhvumxahG4jDn30DS72ib9NmSMCFM/t6dWZNUONE5v2oLgjjzMCFni3R648NMayC67bOhXjsselUoWOO2lzU= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, May 28, 2025 at 03:20:13PM -0400, Sidhartha Kumar wrote: > The for loop inside hugetlb_change_protection() increments by the huge > page size: > > psize = huge_page_size(h); > for (; address < end; address += psize) > > so we are operating on the head page of the huge pages between address > and end. We can safely convert the struct page usage to struct folio. > > Signed-off-by: Sidhartha Kumar Reviewwd-by: Matthew Wilcox (Oracle)