From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DB725C3ABB2 for ; Wed, 28 May 2025 16:16:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 638416B008C; Wed, 28 May 2025 12:16:40 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 60FF76B0092; Wed, 28 May 2025 12:16:40 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 527576B0093; Wed, 28 May 2025 12:16:40 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 352646B008C for ; Wed, 28 May 2025 12:16:40 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id C8321E9C66 for ; Wed, 28 May 2025 16:16:39 +0000 (UTC) X-FDA: 83492819718.25.734591B Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf25.hostedemail.com (Postfix) with ESMTP id B9EB7A0014 for ; Wed, 28 May 2025 16:16:37 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=LYUs5Bhd; spf=pass (imf25.hostedemail.com: domain of peterx@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1748448997; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=2k2PY9MAHKt+UL2NC1MP+obMfgPvXhyJk5Kn5YL16Pc=; b=mXMAZcIsllrM8P+Kz3N7ZWSTObszTlUKf1UEABqE3qCMgp/7m2F25WGAlWa548LQaE0Fy1 jMZNt7W/2GPIJfeIDGGAlpsuEQoABmmrBlKaDNPrjNLNj8PcV9cp2A1JBLK71cKswIJoZ2 t9m2cEx2HlcGeQXCJZDc2OWxu88nI/Y= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=LYUs5Bhd; spf=pass (imf25.hostedemail.com: domain of peterx@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1748448997; a=rsa-sha256; cv=none; b=TEu9VD+ieE8z/VzjoLyvnOkL13EaL1Yo2vG08EnjBLpVfalQtHT8LmKDxkV1bmLoljcKMX QNVA+pWXEjR2ZWegzYOEyTwoFHYRlpyzeyOf4IFpaAnJMiEN75/HfsGHbQVq+7pC5M3bMf FI4HIsvNGPvBmJJhBiI4cFah+1JZ+UE= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1748448997; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=2k2PY9MAHKt+UL2NC1MP+obMfgPvXhyJk5Kn5YL16Pc=; b=LYUs5Bhd5uttkVpJLARuTyBTBhWl81escZMchCXLn4+BKxMTzq1ofQU+frNPVRTPKA+Cxi XcDO95gGfJuW5c8mrQSgt8WgUv4hNPEQ5yxXkue7RyPMWqL0uuCzxrdwBLhBEQ734AGjym eppktTyMfrEivxuSY+dI8rA/OrdGRH8= Received: from mail-qv1-f71.google.com (mail-qv1-f71.google.com [209.85.219.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-115-nRbOtdAWN42blWHGFKN4hg-1; Wed, 28 May 2025 12:16:35 -0400 X-MC-Unique: nRbOtdAWN42blWHGFKN4hg-1 X-Mimecast-MFC-AGG-ID: nRbOtdAWN42blWHGFKN4hg_1748448995 Received: by mail-qv1-f71.google.com with SMTP id 6a1803df08f44-6f8d0bdd023so853896d6.1 for ; Wed, 28 May 2025 09:16:35 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1748448995; x=1749053795; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=2k2PY9MAHKt+UL2NC1MP+obMfgPvXhyJk5Kn5YL16Pc=; b=o4AMCw09DtHICwr1URpdc+hMWAhBPQvzC3gSp+L7AYgfOjTPDNRaiw+aWiVApmhAZu F4JtNobcjouQTvRx/WsEFCZlZPh1r+oedLBpf5QGDT+sMpxJkiFou7ltZ5wNqRKD+6SH 2bNV+JjecVq2jKoUhHpTTjU/l9sA1SUWdwAOQaZTx/yKVqoeVR/jWj4PGrtBNSvx9r7C /dhAOqyTaVfEIe83m6D9IK/6TrvguFlagn3hWoiZ6TxWe6PU50LUkiVNWsppFfUF0/CX rPzybXr78Gafg0pijm2q0iTyB8ok/LEd19ALutsFGoJAfR1066EIcPssAZAG2W+7i+Om hKgw== X-Forwarded-Encrypted: i=1; AJvYcCWUU1Kas4ip0hoJA/XN2lvThXBu3qx+KohjYVpU0Cvr2DcHsZmONkvR/sOuqrJLqb3smvhff6yyAg==@kvack.org X-Gm-Message-State: AOJu0Yw1dxI005FH9Eg56rNF1C3oX+chUDf5Nhq6D2SR2cIfF8IE9Rp6 Z6JOC4qB+iufVph6XHGchFxKjHd1JdXztdfNMLiD29jjuBB+BCmy1jLNQ942v0Jvc/Amh8D0Y8W Dtr2+by/FWBCRELTOxiIn6zbzoeuXe6yM7lklqEUTDqQkl07FRP+3 X-Gm-Gg: ASbGnctuDIryllgav3IY46wHnadisHxHp6/70hdepsvm+lCWO5QilIuBTh+QRmod514 wyzq3oqViPYajJFcVBX1Aufb3JzBPrIYlpz2kuQF1MKXeXtb0ONh9Y1jOqFaVcieMH/DT+oN+Xy gvCrD3bbUGOfcrjnxrUsvXr6tVkLDtM+4bklPk9jWbrgVm9xYi08T3Navkqr+LSt9fDomTJZpzn nyceLRYTVwo6AvU6ZZCYXVraA7u3iS7xFVA/9aU6sj8UXlt1/vqXxD5Dmjq9BSwIvrPw9R/6Xng 7Bc= X-Received: by 2002:a05:6214:224a:b0:6fa:bb44:fde5 with SMTP id 6a1803df08f44-6fabb4512fcmr72527266d6.17.1748448995311; Wed, 28 May 2025 09:16:35 -0700 (PDT) X-Google-Smtp-Source: AGHT+IENfqhaMY+uKyU1t2Uqx80D80R06TLTQ2+Ckhg9TBWJtJ9d2fj3zGpcfKCZJVlZCQeNfczAMw== X-Received: by 2002:a05:6214:224a:b0:6fa:bb44:fde5 with SMTP id 6a1803df08f44-6fabb4512fcmr72526776d6.17.1748448994766; Wed, 28 May 2025 09:16:34 -0700 (PDT) Received: from x1.local ([85.131.185.92]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6fac0bca20asm7994226d6.110.2025.05.28.09.16.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 May 2025 09:16:34 -0700 (PDT) Date: Wed, 28 May 2025 12:16:31 -0400 From: Peter Xu To: Oscar Salvador Cc: David Hildenbrand , Gavin Guo , linux-mm@kvack.org, linux-kernel@vger.kernel.org, muchun.song@linux.dev, akpm@linux-foundation.org, mike.kravetz@oracle.com, kernel-dev@igalia.com, stable@vger.kernel.org, Hugh Dickins , Florent Revest , Gavin Shan Subject: Re: [PATCH v3] mm/hugetlb: fix a deadlock with pagecache_folio and hugetlb_fault_mutex_table Message-ID: References: <20250528023326.3499204-1-gavinguo@igalia.com> <629bb87e-c493-4069-866c-20e02c14ddcc@redhat.com> MIME-Version: 1.0 In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: nnb_RBqR5Sa0l-k5YkLngyZ5T37vHKFmySw4I5UVGL4_1748448995 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: B9EB7A0014 X-Stat-Signature: eno5e84yyxfy3r935x9m5dqtfrx3fwrw X-Rspam-User: X-HE-Tag: 1748448997-922550 X-HE-Meta: U2FsdGVkX1+vb7ysJ7MdpRj4Z2rCr+bv+SGK2qESoeDwWVBQPh4v4+iz1Oxwhx/F9S5PltKiLNQkJO+BL7RBKxFqDeJKroRr6fWpAuff4/CRdmZZsRt+jMphm1+JWNRQ/H05tFWvGs+3QLVDMJDxahI5gZstDCKVy3bCTD6oLOmYkAwNyyMB2DFOccF4Tj1uumFEaW6r5WaOz/O4XQWtrDp1zhyW4pLJP13RtmhbFwFJ5sunX853NbNdwSuwkfbXwZlVkRNbnJPbB7MAZ7P5jokQx99jF8lBdTkAx49VGh8yIP5udOx+FXwV3rQp/QvyHuTcumHn7Vng+PLlSsQChPlPWoYvgNDYdq4dFLyKxZHBmnoUqtF2FaLYiMHMz91Qc9mqot4jADvK5StRf/RI4OCZtgPUt2krcthX6leFvm5EbjCVGlMgqzB72/NxfLynWnN+xOPuJUvdqD4cYIWxJh6qdqXPC2t1UNXes1YzczSoExlHlJSofTj17E9xYwH1WvsJVWw51PZTnCLFNIR8XntrPFdwIyrzbHRrf2SF+GPG3mLlv8C74Z8yf1pzpyB4z8YHXdNtCWsa8wWkgXp/vc3dKLDPiPbTjw4mQBhyKLN6olMPUn9sS43q3aKabcc31hKLC9N8nWcZnQEClpiT7lVNDFU7852r3+Q3nQ0oaW+9hkZHsEdRGkeYF2mNXpLDY4JislQjWg0jMYlxeXNDVcynFzFobG9bZuwfrKhApKvqJLyVydQKL9bSjVAkZKqaPCU63xP6r8APUjsr13elGecl+A45oQ5nMtl4bf2UF8RoX4OHG+YO3XtXFJxP5tTb4OyCyXUusGyhpjl/XQ7938kYQE/ADf9uRkTrCEotkUdU3+XVP8L97mHtN5Y77fO6ia4el779Wq9iAE9WPHKEZt98QxpkhSdrbdjXsf0PWPe+LzX2ZQO6uj7N+yu3RddhXP8lOtF/2LQe45Wm4Bj RkHum+PR uqO9WM6cBfoWYq77T1E6uug3Lx2A3plFmDNeAv/KF3V5DGnY= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, May 28, 2025 at 05:45:42PM +0200, Oscar Salvador wrote: > I thought the main reason was because PageLock protects us against writes, > so when copying (in case of copying the underlying file), we want the > file to be stable throughout the copy? The folio can already been mapped writable in other VM_SHARED vmas.. which means the userspace is free to write whatever while kernel copying, right? IIUC there's no way to make sure the folio content is stable as long as it can be mapped, CoW should just happen and the result of the copied page is unpredictable if there're concurrent writes. IMHO it's the userspace's job if it wants to make sure the folio (when triggering CoW) copies a stable piece of content. That's also why I was thinking maybe we don't need the folio lock at all. We still will need a refcount though for the pagecache to make sure it wont' get freed concurrently. Thanks, -- Peter Xu