From: Peter Xu <peterx@redhat.com>
To: Oscar Salvador <osalvador@suse.de>
Cc: David Hildenbrand <david@redhat.com>,
Gavin Guo <gavinguo@igalia.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
muchun.song@linux.dev, akpm@linux-foundation.org,
mike.kravetz@oracle.com, kernel-dev@igalia.com,
stable@vger.kernel.org, Hugh Dickins <hughd@google.com>,
Florent Revest <revest@google.com>, Gavin Shan <gshan@redhat.com>
Subject: Re: [PATCH v3] mm/hugetlb: fix a deadlock with pagecache_folio and hugetlb_fault_mutex_table
Date: Wed, 28 May 2025 12:16:31 -0400 [thread overview]
Message-ID: <aDc23-d2fsQbdIKe@x1.local> (raw)
In-Reply-To: <aDcvplLNH0nGsLD1@localhost.localdomain>
On Wed, May 28, 2025 at 05:45:42PM +0200, Oscar Salvador wrote:
> I thought the main reason was because PageLock protects us against writes,
> so when copying (in case of copying the underlying file), we want the
> file to be stable throughout the copy?
The folio can already been mapped writable in other VM_SHARED vmas.. which
means the userspace is free to write whatever while kernel copying, right?
IIUC there's no way to make sure the folio content is stable as long as it
can be mapped, CoW should just happen and the result of the copied page is
unpredictable if there're concurrent writes.
IMHO it's the userspace's job if it wants to make sure the folio (when
triggering CoW) copies a stable piece of content.
That's also why I was thinking maybe we don't need the folio lock at all.
We still will need a refcount though for the pagecache to make sure it
wont' get freed concurrently.
Thanks,
--
Peter Xu
next prev parent reply other threads:[~2025-05-28 16:16 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-28 2:33 Gavin Guo
2025-05-28 9:27 ` Oscar Salvador
2025-05-28 15:03 ` Peter Xu
2025-05-28 15:09 ` David Hildenbrand
2025-05-28 15:45 ` Oscar Salvador
2025-05-28 16:14 ` James Houghton
2025-05-28 16:24 ` Peter Xu
2025-05-28 16:16 ` Peter Xu [this message]
2025-05-28 20:00 ` David Hildenbrand
2025-05-28 20:26 ` David Hildenbrand
2025-05-28 21:34 ` Oscar Salvador
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aDc23-d2fsQbdIKe@x1.local \
--to=peterx@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=david@redhat.com \
--cc=gavinguo@igalia.com \
--cc=gshan@redhat.com \
--cc=hughd@google.com \
--cc=kernel-dev@igalia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mike.kravetz@oracle.com \
--cc=muchun.song@linux.dev \
--cc=osalvador@suse.de \
--cc=revest@google.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox