From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 50853C3ABB2 for ; Wed, 28 May 2025 08:13:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 966A06B008C; Wed, 28 May 2025 04:13:53 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 93E056B0092; Wed, 28 May 2025 04:13:53 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 87A446B0093; Wed, 28 May 2025 04:13:53 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 6AF5F6B008C for ; Wed, 28 May 2025 04:13:53 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 0BB6EE7BEE for ; Wed, 28 May 2025 08:13:53 +0000 (UTC) X-FDA: 83491603146.11.45F4D74 Received: from mail-wm1-f41.google.com (mail-wm1-f41.google.com [209.85.128.41]) by imf30.hostedemail.com (Postfix) with ESMTP id 4F9C680005 for ; Wed, 28 May 2025 08:13:51 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=linaro.org header.s=google header.b=GllX4H53; spf=pass (imf30.hostedemail.com: domain of dan.carpenter@linaro.org designates 209.85.128.41 as permitted sender) smtp.mailfrom=dan.carpenter@linaro.org; dmarc=pass (policy=none) header.from=linaro.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1748420031; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding:in-reply-to: references:dkim-signature; bh=q0yiIdr8kiMktQtzAz6WMndkMTPinkFXHlilIDGPLcU=; b=CUEVs8t2Q5Fxp7QkSA/gboE4WVY+puS4bEwkqGsqRjz6on+58PkrSCLh29Xexv/84yrAIF JK5aIu0YwSYoLuJK81bVNqQi/aNtA8GUnhGnXaxIorc1WY72z8sMIGKRIzhfdXShn1FgFr ONZovdl4uDQuqzsWiaSSU0wqFiP7D/I= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=linaro.org header.s=google header.b=GllX4H53; spf=pass (imf30.hostedemail.com: domain of dan.carpenter@linaro.org designates 209.85.128.41 as permitted sender) smtp.mailfrom=dan.carpenter@linaro.org; dmarc=pass (policy=none) header.from=linaro.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1748420031; a=rsa-sha256; cv=none; b=wI8mKJYwWQKnZoTZT8goUppSxglacHqHT+7IT3y7S80VQsGDHvzItc88VMWfDeYEi+UW3k t/c9eFe0wGMEJMohyUF8w4g7+3RUDj/1zdpcPbv1+R4Hv0CBGfC3USl0l9rpVuS0Eyrsnz FtDSDCm0a/OsM4LIVqhgMhUx/y5/jRI= Received: by mail-wm1-f41.google.com with SMTP id 5b1f17b1804b1-43cfe63c592so54808465e9.2 for ; Wed, 28 May 2025 01:13:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1748420030; x=1749024830; darn=kvack.org; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=q0yiIdr8kiMktQtzAz6WMndkMTPinkFXHlilIDGPLcU=; b=GllX4H532S+0YVc1r4SIY1/3fy/sX/VD3s5uVKXPFG5yAAuXoCOHPKWytGKsmXNJsi LYLBffqGkCkwkfvvzGKXXVgBaIHI6w+AsqmI2YNDEmoJ/Dr7VaskRjbGIMwj65sR0mdX y4tjeIINjeBIUtc+kUavYPGHHPoMA4UsxUeQF1K0oh403CA2ewdDTTlqLdkVbnuzL6cg BkTIq+zCj/YzPsx/ZOYy20oM6RddiO+bEfB4iGGcvF62ebXVfhgK91DXuIPh7+1Vdumw 3OHPH+PttQADGCF8G8crcZQAnN9uAUVt2qd6Bv3Kqqw1KIPwKoxF1jqYQUFrQDvu6Buz qodw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1748420030; x=1749024830; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=q0yiIdr8kiMktQtzAz6WMndkMTPinkFXHlilIDGPLcU=; b=vKsw07m4m7GN4cL2iTYr4l8m3cCmvAbg+tKN2uabHzrBIxNKwMKXgx+VPfw8BFLgA2 k4YZR/D/z50WQH1uW5L3zoBI41FtiLGlFcM8Y9VlRlnAGy+Tbj9mr1KHKK5Ke5c59SiV Yu75HWchXL+MTWppjLcLxKdJiBie4A97/EAid3RlKUVImQqSAciEStmhCwp6rVnihTgh m6VaPBJVSLWMtplEvf2QXJXnrN/FM38kBnvkNetaup+mNa/7l7PJXnB9Hs+LtOz2EWh7 1fV24JbVX8lPv4GfSlbH23enMTDWNBtlNmPNy5JvD5tbj//gyOtLymgoh7hc7I0SRLc6 BfZg== X-Forwarded-Encrypted: i=1; AJvYcCXkpwOu7iV8euMa0c243zecAehYlOTuG3GgIuW3bNLR7akjPevgzDcaxfa5M+XeeJYZJuRWXNJQ+w==@kvack.org X-Gm-Message-State: AOJu0YzFYr7M+tn0blh8JTOmmnxYYDe6xMV/Az8l6LUTlOJSX0xRxbtP pEi06RHI193T8PNkvjEcekUfTR1SYBZnQkm5izR6PZkftzMqGHQWWlLT6WD2K/C6FXA= X-Gm-Gg: ASbGncs/wanV3MfkcK6iwJdxgnnJzAB4CvT14U7m9DnVyLhih4RNowP5bjqqO3Ng47p GbsqtCeFBzJdaJCnkzf+5JS7goovasymjpI9EmMWcP0cE2G339VYRvUAVDDtyPZH/Q1USP+kv/N K/03K0b3qBeLspwNZiIiMO53wEUBcH35x8R2szXUFDTViK8u6Yf5KEx0dmFCZktI43xffzuJ6zR kgOsxhwiL8XwciTSbkrzc1yNpnO5QKycc1firz1djpJ/30rJrKRWm2qfNbuxUNm7Pu3Pu4zZYwG bKOhe0CplgTJyj8RDmSwa7YS5g5lOETtg4JksWpZhPd6MTnmemkligd0 X-Google-Smtp-Source: AGHT+IHwxFIuBvvAastdxx+Kytl7VBX/kiaYR4D/z8QcwH+3DXyCV3M1g6v8ommXnYfifmpBZc7UkA== X-Received: by 2002:a05:600c:4683:b0:43c:fe5e:f03b with SMTP id 5b1f17b1804b1-44c932f9572mr154626255e9.30.1748420029682; Wed, 28 May 2025 01:13:49 -0700 (PDT) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with UTF8SMTPSA id 5b1f17b1804b1-45006499727sm13341795e9.3.2025.05.28.01.13.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 May 2025 01:13:49 -0700 (PDT) Date: Wed, 28 May 2025 11:13:45 +0300 From: Dan Carpenter To: Lorenzo Stoakes Cc: Andrew Morton , Shuah Khan , Yeoreum Yun , Wei Yang , linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: [PATCH next] tools/testing: Check correct variable in open_procmap() Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Mailer: git-send-email haha only kidding X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 4F9C680005 X-Stat-Signature: tgffdnz89mbrzryubntxfa4h61gydgxs X-Rspam-User: X-HE-Tag: 1748420031-527577 X-HE-Meta: U2FsdGVkX1/cuNpgNzrCh5gUorJy0sM6UlBnYClnfdT2J4ABXiebqhUCOGrWEFN8EyJlfLGOQbOxVJ45N+Kdyx1P+jC0dfrT5pfbmqR29MxDh8sWA8Z9N2Ys5eWb5FRJ+PlQ5obiOY6opIWxCMmOrk9Sc6i9HU/A8cl9Aksn8Uk6/QWcikX7sTIeMsdVTqLu3ys83Z8QYNgQH5b+udROPfg1XfYDKazVGHthOuxO1z+fIWADnFJ2i2qqZsev2qBtWHI80tful7G0dDaTBqLyfhPW9W1iTA0znRhYws/pKS79OIKirjXZCifzIMOy+aN0GniEHnOlo5AysdaMHO95rUTw/GUUFoLe8jCUVwT9Cz6zq40KxTe1zcBFFs8ph8NfPXDHymbiYUjfDCfglTmL0LUbVd6ykFHDl9VuPk2BrVZ/QWCHBrpf+4AYFqr2KIKqpLvpqJV6YsCJ71I7+3E+W1EVLCTg1gSKL0BgLK7MVWH/f/zJKmEI6TMs/MxndntkU6m3J2LhXbA0yWSv/lRKILuOV1NQO7Giy6CFS4gdwjMp/ObEZ5iASge9Ph4kYayNTwYWEZsyAxpdUgCouXL/TKy8dUCUCs2x9LRpyU0VriK0cbQeSec0xMmwkTklqRntnyjyFwh8KWCtJ1ptfFOAmYlnxx7deAekCm/8qwSh/FhUJKOm0YTp8jxax9w+S5TBCWLkXqdzgBwGKa1TTIohX/tjOx7/oULPFMQSJKv+jZTrIqGeSQP7sne5ij94Xw8AhP3yfXBLqbLH6EBjknZLL08+LpabZRl5bMx3j9ruvJvgcjNqWYemFNWAglqtYl6odXBzAYfozD0FF5OaBOQ7EnCqQCGul+P6CcKAZ9ekY1ZsJ6n+C6aXPsEZ6KRJo6ZyTWstADuQvXBphgqdha0KDU8kwVPkReQpZOFpHIj/4Ixmo6wrL7B+0YysWNwUyOxz2VKWAdGhmlaRkxU/C7Z Egqk2JuS tvQNZaj7KpCJ6pcPOHkbHl7QtSsF8s3lwwguTl4Xk5ZMzc3CVcN3MTcZbHGOIWIyV8F1tW9TkBzXY42gk2HgMUcW3H4vVhGD9PzQ9 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Check if "procmap_out->fd" is negative instead of "procmap_out" (which is a pointer). Fixes: bd23f293a0d5 ("tools/testing: add PROCMAP_QUERY helper functions in mm self tests") Signed-off-by: Dan Carpenter --- tools/testing/selftests/mm/vm_util.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/testing/selftests/mm/vm_util.c b/tools/testing/selftests/mm/vm_util.c index 1357e2d6a7b6..61d7bf1f8c62 100644 --- a/tools/testing/selftests/mm/vm_util.c +++ b/tools/testing/selftests/mm/vm_util.c @@ -439,7 +439,7 @@ int open_procmap(pid_t pid, struct procmap_fd *procmap_out) sprintf(path, "/proc/%d/maps", pid); procmap_out->query.size = sizeof(procmap_out->query); procmap_out->fd = open(path, O_RDONLY); - if (procmap_out < 0) + if (procmap_out->fd < 0) ret = -errno; return ret; -- 2.47.2