From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 940DCC5B552 for ; Wed, 4 Jun 2025 07:59:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3A2E96B05A4; Wed, 4 Jun 2025 03:59:46 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 37A8C6B05A6; Wed, 4 Jun 2025 03:59:46 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 290A76B05A7; Wed, 4 Jun 2025 03:59:46 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 10B356B05A4 for ; Wed, 4 Jun 2025 03:59:46 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id B92251D56C1 for ; Wed, 4 Jun 2025 07:59:45 +0000 (UTC) X-FDA: 83516969130.20.9E1C713 Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf26.hostedemail.com (Postfix) with ESMTP id 07A71140012 for ; Wed, 4 Jun 2025 07:59:43 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=fM14O1Vy; spf=pass (imf26.hostedemail.com: domain of rppt@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1749023984; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=msN9nw+fvn+O9Ato1laxFSJkAuKJHKgVgIG6Z3BThGs=; b=775ohXRoYXEL0zTFAFUUA7qxwEau7YyzzdK4kxCmStDgYIaMsgaG2BzD0IhVioVRktBIyl MyNq11gag3x6CM4oKLnoEtbmP2EZ0gNkKYEClvaWOawGI3sejZphAWJgA5uaFxzyOoK0OO 0kEer+dYsXFC4oBse53971UVmnokWtc= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=fM14O1Vy; spf=pass (imf26.hostedemail.com: domain of rppt@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1749023984; a=rsa-sha256; cv=none; b=1TSUvTqUrYRAL9Fw/Dp5SmreSQ6E/tBDImgsOG7UnLiBm01vk/9fD2KMbhlIlrmawkzTrQ LH8kyrJg8MuW6zioJxm2r8ldWmH27I7hBKkAq6hrPWpzJBuSDjVZbvzODS6bo3tPII+2V8 nlrU1593QR+L7ur3uNETt5+/8fgMmpQ= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 3663BA5022C; Wed, 4 Jun 2025 07:59:43 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D557FC4CEE7; Wed, 4 Jun 2025 07:59:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1749023982; bh=cM075RtYNtApE6hMLvBD71DnCdfNXCoBoA9hVqxEA7c=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=fM14O1VyGa217AmCOHG9SGUX7udL4TZjk7VZDuGwKSsgsWQdN1y460ldmuGEsd7Ym x+uW9eeelKeG+CjuuiWnWOP7XKFu7dDcJ/Tp0qiN9UnsDDnSOb8ia9qoJpj9TLbNE2 8R5ET6gd1w/m88Q1b0xKgGgOzkbRE2cWCyiUjqB1CSyZ2q/QnCxFknTVjkpoDYmSxF Q2SVdK9UQTITBK4Q6LXFjYpnAYI/z95qKGzZKR+6VqQ/rOtCR03n9+ubv6ZQchE1aS Sv1iEYv6FtPnoPJT+GUb4k5rbOVdJ/5tUP+Fg/UIImNFfMiHMDlxx1Z/etssMtN+LQ lFs6ynfLF4+OA== Date: Wed, 4 Jun 2025 10:59:11 +0300 From: Mike Rapoport To: Ackerley Tng Cc: kvm@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, x86@kernel.org, linux-fsdevel@vger.kernel.org, aik@amd.com, ajones@ventanamicro.com, akpm@linux-foundation.org, amoorthy@google.com, anthony.yznaga@oracle.com, anup@brainfault.org, aou@eecs.berkeley.edu, bfoster@redhat.com, binbin.wu@linux.intel.com, brauner@kernel.org, catalin.marinas@arm.com, chao.p.peng@intel.com, chenhuacai@kernel.org, dave.hansen@intel.com, david@redhat.com, dmatlack@google.com, dwmw@amazon.co.uk, erdemaktas@google.com, fan.du@intel.com, fvdl@google.com, graf@amazon.com, haibo1.xu@intel.com, hch@infradead.org, hughd@google.com, ira.weiny@intel.com, isaku.yamahata@intel.com, jack@suse.cz, james.morse@arm.com, jarkko@kernel.org, jgg@ziepe.ca, jgowans@amazon.com, jhubbard@nvidia.com, jroedel@suse.de, jthoughton@google.com, jun.miao@intel.com, kai.huang@intel.com, keirf@google.com, kent.overstreet@linux.dev, kirill.shutemov@intel.com, liam.merwick@oracle.com, maciej.wieczor-retman@intel.com, mail@maciej.szmigiero.name, maz@kernel.org, mic@digikod.net, michael.roth@amd.com, mpe@ellerman.id.au, muchun.song@linux.dev, nikunj@amd.com, nsaenz@amazon.es, oliver.upton@linux.dev, palmer@dabbelt.com, pankaj.gupta@amd.com, paul.walmsley@sifive.com, pbonzini@redhat.com, pdurrant@amazon.co.uk, peterx@redhat.com, pgonda@google.com, pvorel@suse.cz, qperret@google.com, quic_cvanscha@quicinc.com, quic_eberman@quicinc.com, quic_mnalajal@quicinc.com, quic_pderrin@quicinc.com, quic_pheragu@quicinc.com, quic_svaddagi@quicinc.com, quic_tsoni@quicinc.com, richard.weiyang@gmail.com, rick.p.edgecombe@intel.com, rientjes@google.com, roypat@amazon.co.uk, seanjc@google.com, shuah@kernel.org, steven.price@arm.com, steven.sistare@oracle.com, suzuki.poulose@arm.com, tabba@google.com, thomas.lendacky@amd.com, vannapurve@google.com, vbabka@suse.cz, viro@zeniv.linux.org.uk, vkuznets@redhat.com, wei.w.wang@intel.com, will@kernel.org, willy@infradead.org, xiaoyao.li@intel.com, yan.y.zhao@intel.com, yilun.xu@intel.com, yuzenghui@huawei.com, zhiquan1.li@intel.com, Paul Moore Subject: Re: [PATCH 1/2] fs: Provide function that allocates a secure anonymous inode Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspam-User: X-Rspamd-Queue-Id: 07A71140012 X-Rspamd-Server: rspam09 X-Stat-Signature: 8sptmxrqw1ohwwbbqfjz5mhwrb4zuuwb X-HE-Tag: 1749023983-874036 X-HE-Meta: U2FsdGVkX1/q1v57Q/X8+MzUF95a3FQmxICGoLJ2STehWLnMZPntNzcrnmYYO8/DHN7vkIMyZ0UzlW/8BC5EX45k4BtlGL5+8faGZkoUtTUk7oJWrK+L1k/14EBxOECnc6kUJ1koNDbYMRbnU67h+6/Iq40MahsJ7EiyaxY5yswoKgoE0SbYD/Aawr00S9o2eIKW8MF68BZISLq+y78tSQOYYu5ZQn2pHPbrWIGmO5UX2KYH/Cqh+tjMcZkc0lKhIFrYtBmywHHMn/f0JblmEAsROOLsszZ+m4G+mH0FRpIInbM42wAnYsWAlqYAD2HlzjgrR1yKOp4C1MdUDJCUmJkm0C2fdPQfVKZIvXhgQOomqQXVY6EVUiNzMtXsB0Nrhk3oaEEcWhaf1PilrUlvHhWUR80IniWwihwh0yjJWNTtGjFKdtAsp2+fvhS8lFKSYGABHnSlwefvBY7I+U8BVhcQJq2S7lHtV+w/RceOKpPtETon8Su+R2JbevHb3r4DSvhfbYQDOqanVw1xRdD948yUZ8rAgdImOZkQ0CS3Xe1bwQqarkKtes8Fm1usXjP+Oci1qww+b2tf5G9MTa7s0SISTSVzkEKsbHYVZgIK2UVv4vfSyOKsOUUXGhtOuGTHfpiyefHirktOlmQRjFH5Fii1u9k+Ws7Huzm8zzbWzKyOGPpwR7IXZugzxKNKEq6LZHYrZcdYwI26boMOtILr73jyB2445ofjfAdVjliuHqyW/YuoJ2I5SFWWRSWiggeDTLmUvtPfi/dD98iAw3GGYCn9dcXcJeBo639nzqr2grBi4WQQ/ZW/xQHHaN7CWDTxkKSYy5s4jDdULqw3SToschziUs4AZuZ/fKZc+F/kyril3hUG9ZpIkaqSGSkWmqMwyZonb422A0qVRU9+6DkN2ytKctxPswwYJgMo6axflGZVVwMR5UpQ/HAn0hiowqHVWKWXaiaSZy9ownde8zD sKpTgOnI PEW1vJvHiwNlN8o/0pzmy/4cjrs6VaM+Cfq6QpudL2emvefbNZA0z5rgpEx97cSjnm5u5Inhgr+MK/C8DsWf/9KQA5JgT8SHAqcuqntZxtSPTpXe0VHk3l/JVeZ5ELskFZQMSiL8Rm2AE9/XB6xbT8U7Vq7EgDM5I3jfVq1MnVn2iSCj2vR94gdzFFabXTblOB+IVbrvsPycAx35QXXiceN1s1ZyRb2mbiCBrKhZfm3sGTwHLwnPUpP/wNUDkekz/3EfmsbldSTcssxAoxDfARSZ1+AnwD2JBUWwVqDe6YSjK0s9/Ce0Jnr6X+jVD59iTAmv9S81/GrMF/I+ZlHSj4IJT6LhEDJNZdxsVK7fTWh/XGzAELcSuKckLqg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: (added Paul Moore for selinux bits) On Mon, Jun 02, 2025 at 12:17:54PM -0700, Ackerley Tng wrote: > The new function, alloc_anon_secure_inode(), returns an inode after > running checks in security_inode_init_security_anon(). > > Also refactor secretmem's file creation process to use the new > function. > > Suggested-by: David Hildenbrand > Signed-off-by: Ackerley Tng > --- > fs/anon_inodes.c | 22 ++++++++++++++++------ > include/linux/fs.h | 1 + > mm/secretmem.c | 9 +-------- > 3 files changed, 18 insertions(+), 14 deletions(-) > > diff --git a/fs/anon_inodes.c b/fs/anon_inodes.c > index 583ac81669c2..4c3110378647 100644 > --- a/fs/anon_inodes.c > +++ b/fs/anon_inodes.c > @@ -55,17 +55,20 @@ static struct file_system_type anon_inode_fs_type = { > .kill_sb = kill_anon_super, > }; > > -static struct inode *anon_inode_make_secure_inode( > - const char *name, > - const struct inode *context_inode) > +static struct inode *anon_inode_make_secure_inode(struct super_block *s, > + const char *name, const struct inode *context_inode, > + bool fs_internal) > { > struct inode *inode; > int error; > > - inode = alloc_anon_inode(anon_inode_mnt->mnt_sb); > + inode = alloc_anon_inode(s); > if (IS_ERR(inode)) > return inode; > - inode->i_flags &= ~S_PRIVATE; > + > + if (!fs_internal) > + inode->i_flags &= ~S_PRIVATE; > + > error = security_inode_init_security_anon(inode, &QSTR(name), > context_inode); > if (error) { > @@ -75,6 +78,12 @@ static struct inode *anon_inode_make_secure_inode( > return inode; > } > > +struct inode *alloc_anon_secure_inode(struct super_block *s, const char *name) > +{ > + return anon_inode_make_secure_inode(s, name, NULL, true); > +} > +EXPORT_SYMBOL_GPL(alloc_anon_secure_inode); > + > static struct file *__anon_inode_getfile(const char *name, > const struct file_operations *fops, > void *priv, int flags, > @@ -88,7 +97,8 @@ static struct file *__anon_inode_getfile(const char *name, > return ERR_PTR(-ENOENT); > > if (make_inode) { > - inode = anon_inode_make_secure_inode(name, context_inode); > + inode = anon_inode_make_secure_inode(anon_inode_mnt->mnt_sb, > + name, context_inode, false); > if (IS_ERR(inode)) { > file = ERR_CAST(inode); > goto err; > diff --git a/include/linux/fs.h b/include/linux/fs.h > index 016b0fe1536e..0fded2e3c661 100644 > --- a/include/linux/fs.h > +++ b/include/linux/fs.h > @@ -3550,6 +3550,7 @@ extern int simple_write_begin(struct file *file, struct address_space *mapping, > extern const struct address_space_operations ram_aops; > extern int always_delete_dentry(const struct dentry *); > extern struct inode *alloc_anon_inode(struct super_block *); > +extern struct inode *alloc_anon_secure_inode(struct super_block *, const char *); > extern int simple_nosetlease(struct file *, int, struct file_lease **, void **); > extern const struct dentry_operations simple_dentry_operations; > > diff --git a/mm/secretmem.c b/mm/secretmem.c > index 1b0a214ee558..c0e459e58cb6 100644 > --- a/mm/secretmem.c > +++ b/mm/secretmem.c > @@ -195,18 +195,11 @@ static struct file *secretmem_file_create(unsigned long flags) > struct file *file; > struct inode *inode; > const char *anon_name = "[secretmem]"; > - int err; > > - inode = alloc_anon_inode(secretmem_mnt->mnt_sb); > + inode = alloc_anon_secure_inode(secretmem_mnt->mnt_sb, anon_name); > if (IS_ERR(inode)) > return ERR_CAST(inode); I don't think we should not hide secretmem and guest_memfd inodes from selinux, so clearing S_PRIVATE for them is not needed and you can just drop fs_internal parameter in anon_inode_make_secure_inode() > > - err = security_inode_init_security_anon(inode, &QSTR(anon_name), NULL); > - if (err) { > - file = ERR_PTR(err); > - goto err_free_inode; > - } > - > file = alloc_file_pseudo(inode, secretmem_mnt, "secretmem", > O_RDWR, &secretmem_fops); > if (IS_ERR(file)) > -- > 2.49.0.1204.g71687c7c1d-goog -- Sincerely yours, Mike.