From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4B1E4C54FB3 for ; Mon, 26 May 2025 13:05:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B53E26B007B; Mon, 26 May 2025 09:05:39 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id ADE246B0082; Mon, 26 May 2025 09:05:39 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9CCA36B0083; Mon, 26 May 2025 09:05:39 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 79F916B007B for ; Mon, 26 May 2025 09:05:39 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 14628C037F for ; Mon, 26 May 2025 13:05:39 +0000 (UTC) X-FDA: 83485080798.23.2BC320A Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf01.hostedemail.com (Postfix) with ESMTP id E731440018 for ; Mon, 26 May 2025 13:05:36 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b="sc/Tn5ef"; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=1+oGpO6p; dkim=pass header.d=suse.de header.s=susede2_rsa header.b="sc/Tn5ef"; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=1+oGpO6p; spf=pass (imf01.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=osalvador@suse.de; dmarc=pass (policy=none) header.from=suse.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1748264737; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=J3tMyCqiSjE1kJCU79um7mmnKprlw8Ww67GaVrX9wMI=; b=arvsXwZZo4L1Q3Bm8KP5osGvt9fvP6BSn4M/8yH1JGBtINrpGvCIt4N6fgq/P10XqUh6ep /4DGUfW2nlwI6qJgKckMbUWhFxfM5mOWEU2fzMaSB4Uh+AOonimCyT7AD5LCQddILtDLnw sUpby6QFMJSXIGIiZvL/l808bxTMJSI= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1748264737; a=rsa-sha256; cv=none; b=0A+W1Wvy6dEEQly6z54VaKKOmnymZEXXm1UQRQRdwKefiay2zzR0pU2mIDPbtBcA9ZrFsA Vsp3ks+fTOHQEpaIKCH8tvpwdK0nG9J1Kh3s5azBtMNnkn3ds7o+MRttyAXkjE0dawcl/Z dxtVbVWM84FXSMmmWkx4W7P0eQhfDE0= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b="sc/Tn5ef"; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=1+oGpO6p; dkim=pass header.d=suse.de header.s=susede2_rsa header.b="sc/Tn5ef"; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=1+oGpO6p; spf=pass (imf01.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=osalvador@suse.de; dmarc=pass (policy=none) header.from=suse.de Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 3888221E64; Mon, 26 May 2025 13:05:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1748264735; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=J3tMyCqiSjE1kJCU79um7mmnKprlw8Ww67GaVrX9wMI=; b=sc/Tn5efiky60/oSmdURgugLyuiFyo/brtdhqTsiobxDIucfG2/wmxFSeDTOdk5mAeCjA3 ClZSAJLTSiy9PqUmEopksmhrs7CP0DA4zZrpZEsgHrhRrTyzF68BivNxB76ZE1hyCLDdGl s52tLw1HhyuYtYiVuu53iCK0xcw5epo= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1748264735; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=J3tMyCqiSjE1kJCU79um7mmnKprlw8Ww67GaVrX9wMI=; b=1+oGpO6p1fUgvv27Uv+IYq5LtKCly0vJGC++X4oMIJC/NE9MkjDSs8laUZuK1lBnGYzKKp e11xl7nHEkjmudCA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1748264735; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=J3tMyCqiSjE1kJCU79um7mmnKprlw8Ww67GaVrX9wMI=; b=sc/Tn5efiky60/oSmdURgugLyuiFyo/brtdhqTsiobxDIucfG2/wmxFSeDTOdk5mAeCjA3 ClZSAJLTSiy9PqUmEopksmhrs7CP0DA4zZrpZEsgHrhRrTyzF68BivNxB76ZE1hyCLDdGl s52tLw1HhyuYtYiVuu53iCK0xcw5epo= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1748264735; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=J3tMyCqiSjE1kJCU79um7mmnKprlw8Ww67GaVrX9wMI=; b=1+oGpO6p1fUgvv27Uv+IYq5LtKCly0vJGC++X4oMIJC/NE9MkjDSs8laUZuK1lBnGYzKKp e11xl7nHEkjmudCA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id A897013964; Mon, 26 May 2025 13:05:34 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id NShTJh5nNGjqMAAAD6G6ig (envelope-from ); Mon, 26 May 2025 13:05:34 +0000 Date: Mon, 26 May 2025 15:05:23 +0200 From: Oscar Salvador To: David Hildenbrand Cc: yangge1116@126.com, akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, 21cnbao@gmail.com, baolin.wang@linux.alibaba.com, muchun.song@linux.dev, liuzixing@hygon.cn Subject: Re: [PATCH] mm/hugetlb: remove redundant folio_test_hugetlb Message-ID: References: <1747987559-23082-1-git-send-email-yangge1116@126.com> <427043ca-ae91-4386-8ffd-aaf164773226@redhat.com> <347b3035-26fe-43af-8df4-b1610d305908@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <347b3035-26fe-43af-8df4-b1610d305908@redhat.com> X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: E731440018 X-Stat-Signature: krsdimk9fwu54i8r4ttr3wmf9d7dz1tj X-Rspam-User: X-HE-Tag: 1748264736-228502 X-HE-Meta: U2FsdGVkX18433cpxTqtGyHHr/9txvzkouTGornh8VPj+bkPqvx8jeyAXErsjUJzhibdlPf4hrxWLNwJKjjjsxwg1GfFHykL5A3V8kjz2Y63vS+sHhEfl5pp1/lgczG52jX2rymKkrILBFZzMoeeOBNcppsH9JkLlRCv9R+tXjE9BoSNR3adOJlmxvzmU5fIuih00za/HOYvInhGkK7xPWFPKB56fwveWdh3hzkT4iDWwnjCuMehXZesKOzL6CHC4Tb5FRA0J3EF17yvwzIHv7eN0gTZQJdojLDLNI7iAuFtwiamCoMQbOH8PAGTc1d1rGu3aagFVkfj+c0rkS80KYNLGOl7EYI+Ja8ruIk3BSws8Mr/qV7YNyh6QKfRKhFBe4aXwGvQlEjog0NmP1mZy+22mAB/FtwUscqH7E9vTc6vFnefiNpjF2rNJJerVdsskHHnG3BbCS1YouU8YXSvd5BUym+1DWXQe68IqR2v3KyAb2BIwrDQjVg8Y9sngm5GjN2NG/uHAcuIWFYCFw0OtQbWnkxjnLMDdrkO2EjDogHXyAl/DPYxJwN9OV5vuE1/5QhPe+7l8AZ29nVTfTboQK1NpjtrrG/eIgKZnpu2ryw6hBYuCd5m+KRnCTr8F7T0vGSPsVB1V/0xh5YvZz4OvH63kvbUdsxM3KOPVVq1AvyFv4xhUO928hbUsH0p8DVQvkT/Pkus+awoQfwYVYaDNrSkHg4E9eGz7eU/QTeibVjR+UKFIs/qFy0V0BjqRm2bk8iC0PCEyTSjrAlPoUCnIOJwGZSuyeTbLP7junKoUs/uxVK0FVWjco01iykZRAQ7/SWUCpBEfad6ZmbBqeQsSU9EulAhGOouo2lmr6Iouey8SK7ZKZ7BhBgLxoaZYpm0wOBOZX68A+sjYB+9xBDxfuqVdtQIZezNirNy9yGSrT7k21wE/A9L4nScfQfNrarF7ojvyI4Rf6MCgDphYYN HjyVAmG/ VZh1CSgSSBLABbeqJWNZsZd6ivf/O61wKEVL+W7YDIAHdokIp4a/+ycZvP2rvbTqrOF1Jw5VcR83YbhjigZsJkUPTiEd5E/yG15+VPSKhju+KrvP3vHT79prLDufnfcJ4Z7UuJt2D4+8wrPp3R92ThibSENhz3XxJF/zzdIypboEnMGfRnqelhginanfNbgbQu4I5Mje4XjQft9aF+CG2t7hbeP0n6khh4/yTjGlr/iyrvh/s/IfIqswArggbkXfD7gq8pnUDFGv8peiQL2TWELHSR1niUcXir1Rzb3npdf8TeM8uQAmStTZcDQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, May 26, 2025 at 02:23:58PM +0200, David Hildenbrand wrote: > Already in 6.15, gah. > > Please convert that code to never ever take any hugeglb locks unless we are > clearly dealing with a hugetlb folios. I guess we could just do? diff --git a/mm/hugetlb.c b/mm/hugetlb.c index 20f08de9e37d..8bd8b950e4cb 100644 --- a/mm/hugetlb.c +++ b/mm/hugetlb.c @@ -2911,7 +2914,7 @@ int replace_free_hugepage_folios(unsigned long start_pfn, unsigned long end_pfn) while (start_pfn < end_pfn) { folio = pfn_folio(start_pfn); - if (!folio_ref_count(folio)) { + if (!folio_ref_count(folio) && folio_test_hugetlb(folio)) { ret = alloc_and_dissolve_hugetlb_folio(folio, &isolate_list); if (ret) -- Oscar Salvador SUSE Labs