From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 46F27C54ED0 for ; Fri, 23 May 2025 14:48:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7C3F06B00CF; Fri, 23 May 2025 10:48:22 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 79C0E6B00D0; Fri, 23 May 2025 10:48:22 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6D7D76B00D1; Fri, 23 May 2025 10:48:22 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 4B1A56B00CF for ; Fri, 23 May 2025 10:48:22 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 013F8160575 for ; Fri, 23 May 2025 14:48:21 +0000 (UTC) X-FDA: 83474453244.17.6C84799 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf11.hostedemail.com (Postfix) with ESMTP id A938240002 for ; Fri, 23 May 2025 14:48:18 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=vQdQ1RoX; dmarc=none; spf=none (imf11.hostedemail.com: domain of BATV+9d3e714d82903859cdeb+7943+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+9d3e714d82903859cdeb+7943+infradead.org+hch@bombadil.srs.infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1748011699; a=rsa-sha256; cv=none; b=2UVIByvWXjYbpTp+r10Bf9Ucz8XnN904Jj1aAEFRwdA8lGMMYnsTMC1shLhV5yCR0Q6E7R kPiZexeE7K7v7xyfhkJlFDkTM028DaQiKrBA9UMzJtXvxvpmeiKjnnVXrMfuRrOmRartKi 4YsD9foARjOJpnohrB4KnGb09pQiRdc= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=vQdQ1RoX; dmarc=none; spf=none (imf11.hostedemail.com: domain of BATV+9d3e714d82903859cdeb+7943+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+9d3e714d82903859cdeb+7943+infradead.org+hch@bombadil.srs.infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1748011699; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=rui7bylO1304WkfAB2bQLvabtQVIai2NVBo/GdoR6eE=; b=wPKFyim3cv92PCyyRwppDD3R3JKA+Nl3DB3AKKsYYFFwfPOuh0olMwaj9X47RoyuukM1I2 xAuBBTDZzP7A70pRf0XXoty0DXbK86ave/ObYCOVYhv6IwwQFu6d6X+XaWL94TB1VDc+y/ +p8Y2pRG/u3MIFnvkttgfQvBD+veTVA= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=rui7bylO1304WkfAB2bQLvabtQVIai2NVBo/GdoR6eE=; b=vQdQ1RoXhaYHKj5zMddG7xCP8k 2Dj25u5cwsjiJZN5nBt5Enf9eVcbOe7vfW4+VDrUow0b5rrQg2L2nRYSO3Aq722ILgVSYemgmK+lX tgppwoXyUtQARQ1CE7iBpPd/oWA08prYIw3KNOP/IKgHeJcq1On1fx1zdid6pbxjcbmWI5Y9J7EcV GLcfP5nzBD3V9lsXskZ74+EQPVgVYxuo0vM6dqC5tDs+DWSOJk3VfSGoJwe0/rsmH5+sQ6LIaO62f 7Trm98t0ul+p4l1bwY4GzZxgB0uj0ofFCd89kZgVbQBeHxAUNP0FrMRAg2kshuWvXu+jUHA6BDEVG +DV4MFjg==; Received: from hch by bombadil.infradead.org with local (Exim 4.98.2 #2 (Red Hat Linux)) id 1uITh2-000000048gS-1zXZ; Fri, 23 May 2025 14:48:16 +0000 Date: Fri, 23 May 2025 07:48:16 -0700 From: Christoph Hellwig To: Daisuke Matsuda Cc: linux-rdma@vger.kernel.org, linux-mm@kvack.org, leon@kernel.org, jgg@ziepe.ca, akpm@linux-foundation.org, jglisse@redhat.com, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, zyjzyj2000@gmail.com Subject: Re: [PATCH] mm/hmm: Allow hmm_dma_map_alloc() to tolerate NULL device Message-ID: References: <20250523143537.10362-1-dskmtsd@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250523143537.10362-1-dskmtsd@gmail.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: A938240002 X-Stat-Signature: 6uwrqyjbjkdq61k7p8pcz31d3dnzhj75 X-Rspam-User: X-HE-Tag: 1748011698-208984 X-HE-Meta: U2FsdGVkX1+m80hNNsL3XyLkhZyZgoXBdQQN9ecaLWD+02ANRDjeNUI9C5JBSaHQ/3E0cREEuA9dSNo0LmGmi7JgJr8t+dDZ/GPtdAlx+Y7cba977gOX2tdKEJBXLHRZRDkER0CmG6pPDOBG7qNrcuSJKHa1yoXCneBUqYsYaXcd8lFXuT47lQ+33i1R6EC/NGMEe0Ksnz1a0j7IQkgcRXumUwvo0lj4IMJbbD+f4eKG4tYQMVV3aN25Dl7g+pKdm1waMDaHCewatiysNjiTtLWg4EFNlQF6gtRAB2wDIVLCOymi3bqFfdVHx9UCKa34RrCtF9vR9RnC5etvnjnwn5uVNIZHBN/GLdWmA+zq3wzjWhFMmQx5OI0TH4Sw1wIjGrqmhmD3xBqBotOZREgZn+jjk2XZXp4vvmfBJV5NdIGO5+NIENoY8H1+S1O5r6WYYS/t/c8D1vjdKvEyJkeTRnCIPIIQh+KAJctnThsnuWC9ckn4dn/RP03VQZ4X9UV5rbe0VALXpGbd0CuLCeudj2ZNXxHJpA/VVWpXNNIjNaKt2WIijL/mGLjpN2TzhajsndjUlucTaNBvrol4xz0EgAhTGNnQ+10i8s8NdVA+9Q8AZJdwyIpXZsZQHExpEGL8E1bYre/RFovx6oKAeBGPKJBY8vvte367ZS0c6gNlBkCGsbM4gXjJP8ZyGwGa3WQZ0YtSeMOQbiM5fNWD338jFgVKaWxP47wFb6y0RUdhAJA2P1j/Rklr6vDZwDhMGS2+S6ugzR1d+WUTpSbP+9Tzl3LTqZDX/LExjGfU88dsNdc8c1zAA5fAj38kq05I9DR7RkdlxQCPHR3ZoY58KU2xZT0xiCslKmQcUg1wK2sjeJtxupOB5acw6vnpOAi/58gNdqNQkKeW0bpF/QB98VTQHYrXtLnHEEzJuE08JaBIzLR9YpZtfJ9oXGIh2aQcueywi4bKy/qPwJGsLJ1lRq6 E9qstaWE EVsatq8W0yuRL9eJwo9ZCz1G8zu3UbayI5yy3mLp6026ln2j3IVHTfbxyOX1y7OMsZT6oafFAtysiryVdNlekP6V0RWmcsNRfm5eWMiPdhCjNaP2Ys2WR2e8ahKTJE5TuaW4/24UADhQ4hxZRM5jn6C2qK7t2LKxyjtWSZdboVB/R+fw8HNYdRPE0vJ/xahRMucshBz5XXMRVlxmbQ0D2FdwlJWpVeHqbZp4ezq95pvxcDJ99q2dUVYpJ89v1UOKr2ps+Z9BIpz+Y96vtjHkjiOFo5olCdxLNhJZDBSZuVpVvkY4asPrXP1GMwkfSn1Alb0P76mu9nSr9J/sjwtov+OJC+4dCQTYb1QxRSr8mihIiwzMFXNUv4mVAjVpyWr8L0KP44IBcTw2P60sbtPQsWegQBRSX3SW+s6tOM9d6pFg17uUdEnqkdKeaYKgmT+YL73b4ORFzZMyI7N00RL12tK8Uu7YhJXvQcU5JmmPcHPNdFDQYnsEXVAgfVDRXtKeW22OF46V92VaVZODYhvQiqzYDQg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, May 23, 2025 at 02:35:37PM +0000, Daisuke Matsuda wrote: > Some drivers (such as rxe) may legitimately call hmm_dma_map_alloc() with a > NULL device pointer, No, they may not. If something has no device with physical DMA capabilities, it has not business calling into it.