From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A888BC54ED0 for ; Fri, 23 May 2025 14:35:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 254AC6B00CD; Fri, 23 May 2025 10:35:13 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 22B976B00CE; Fri, 23 May 2025 10:35:13 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 11A726B00CF; Fri, 23 May 2025 10:35:13 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id E5BD86B00CD for ; Fri, 23 May 2025 10:35:12 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 31F1B1CE485 for ; Fri, 23 May 2025 14:35:12 +0000 (UTC) X-FDA: 83474420064.04.F61CED5 Received: from mail-pl1-f201.google.com (mail-pl1-f201.google.com [209.85.214.201]) by imf07.hostedemail.com (Postfix) with ESMTP id 1D80B40017 for ; Fri, 23 May 2025 14:35:09 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=f9BGDDSu; spf=pass (imf07.hostedemail.com: domain of 3nIcwaAYKCLUnZVieXbjjbgZ.Xjhgdips-hhfqVXf.jmb@flex--seanjc.bounces.google.com designates 209.85.214.201 as permitted sender) smtp.mailfrom=3nIcwaAYKCLUnZVieXbjjbgZ.Xjhgdips-hhfqVXf.jmb@flex--seanjc.bounces.google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1748010910; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=OHIXFovAEYPRF7pj3DkvXM+Wh6ry7OAZQdb2dc5cgKo=; b=TZLWhN4yM8TUfrx8DYcB1oOq+ILsDiXv8jw1FeVm+vAiR9brD/80S71T3fUkV0XbscTldo Oi1WXL0zG43IGliJZiZvon3kncPyeQF/u53mLB5w9+rrCyUBalFwqrkHXLjiQJe1baHpl6 vW+swxzN9zGyVbDkSEcx/bTVOXTmqyw= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=f9BGDDSu; spf=pass (imf07.hostedemail.com: domain of 3nIcwaAYKCLUnZVieXbjjbgZ.Xjhgdips-hhfqVXf.jmb@flex--seanjc.bounces.google.com designates 209.85.214.201 as permitted sender) smtp.mailfrom=3nIcwaAYKCLUnZVieXbjjbgZ.Xjhgdips-hhfqVXf.jmb@flex--seanjc.bounces.google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1748010910; a=rsa-sha256; cv=none; b=6bEviFezK/zfitH+WYiJDwmYTeeQ0ucHX1O6ISpiIzSnpHahHNIAz4aR968UNEy7HWMpvI /hFc16oS147EGDbUcF4gH616mSVOpuhzE38GSyTIlx+ze21t2o7aiPXgv2wII1nZpU7q4z mjdBaXTuvb7pS2/2mrMPwhEb3PHScp4= Received: by mail-pl1-f201.google.com with SMTP id d9443c01a7336-22de54b0b97so88784525ad.2 for ; Fri, 23 May 2025 07:35:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1748010909; x=1748615709; darn=kvack.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=OHIXFovAEYPRF7pj3DkvXM+Wh6ry7OAZQdb2dc5cgKo=; b=f9BGDDSui4j6n7PbajLCE75uYf+Im0visyNPtEbhI+jfrpkhCjwcY5ne7MpmKPZlJd /45+tafM9n7AuCv6+lN5R0Vv1sFQ3hRFHOnjA9vf93BHXUwPid78E5pWs9MxAWGt2av3 NHyG7tKD6xRKqE/i/nlHi3jx3zZUHVhJ7vzxWzHvao/CukyuKynRMBhzZ/FJiBp/898B lEDcRpwKTANbjJI3424Zhchgo/+z1JQNAa7EvRBm61JGcmkfwH56ihe5yxQZLuEPoUs9 aoHXaJX4K/9S53i6IvFmcjZFTqSld7fW1LIoXSHxmgaGNfqxVvVjWpH3ag1Tig0aD3Wa 0Ydg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1748010909; x=1748615709; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=OHIXFovAEYPRF7pj3DkvXM+Wh6ry7OAZQdb2dc5cgKo=; b=H2jmgzyR+v8Usr6//K3SbXtnsG7rBEgGQ4pS2d3NlWZyVKgQ7Cvexjev1Khg2rE/Ew pbzUP3gg/YsaKKshx57/8f9ZRXyrjkWJ1TNbbaxjgUVMthSlQCR4RoMuX/verSQKbhHu FYnvPtwANRnmd2YmTzvJNNLmg+48pV4Y9IxNg0Vu6eOzhTYYYxpPnBnKkcB2LolVZf5i D++WWU/LHi2xFlmj+4jDPJirmG1IAXedgrsWvjqy90Kvp4RonBgzlIejPdKzxGN2UPOA RrBT4rxWelzsb5WOa9xCAo2uJWfuOphOBnFFNOArRtM/nNt2yAKswwCO1c/qCVic134z P5LQ== X-Forwarded-Encrypted: i=1; AJvYcCUk9Adu24exGAHRsWgze5tuwUVHLgvC58bw39q/o/37o7391oK2jSp5lGxVEnUbyKe8oRGGKkGDUg==@kvack.org X-Gm-Message-State: AOJu0YxykXz9m1DPf1lwfO+Vz1yHNa30o0sq2SLa50WbcOHcHr+ZGMzy +9pw+gPxcMkTQR1DRoIFFFIKNACLVK+e6yUPzLMemZRJbpGTG+D+lP4XzwG1jIwLeAD4UCEZ+gu xYdw5SA== X-Google-Smtp-Source: AGHT+IFz7sb0nLy8RLNRfKCeKqRGA0z4OYWQ9Q5+lv5cIKJ3DXiQQbAp7L//6YajGR6GltgQpVeH/+sDQGY= X-Received: from plka13.prod.google.com ([2002:a17:903:f8d:b0:231:def0:d268]) (user=seanjc job=prod-delivery.src-stubby-dispatcher) by 2002:a17:903:41c7:b0:224:1221:1ab4 with SMTP id d9443c01a7336-231de317b43mr439457305ad.22.1748010908457; Fri, 23 May 2025 07:35:08 -0700 (PDT) Date: Fri, 23 May 2025 07:35:03 -0700 In-Reply-To: <20250523043935.2009972-4-kees@kernel.org> Mime-Version: 1.0 References: <20250523043251.it.550-kees@kernel.org> <20250523043935.2009972-4-kees@kernel.org> Message-ID: Subject: Re: [PATCH v2 04/14] x86: Handle KCOV __init vs inline mismatches From: Sean Christopherson To: Kees Cook Cc: Arnd Bergmann , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Paolo Bonzini , Vitaly Kuznetsov , Henrique de Moraes Holschuh , Hans de Goede , "Ilpo =?utf-8?B?SsOkcnZpbmVu?=" , "Rafael J. Wysocki" , Len Brown , Masami Hiramatsu , Ard Biesheuvel , Mike Rapoport , Michal Wilczynski , Juergen Gross , Andy Shevchenko , "Kirill A. Shutemov" , Roger Pau Monne , David Woodhouse , Usama Arif , "Guilherme G. Piccoli" , Thomas Huth , Brian Gerst , kvm@vger.kernel.org, ibm-acpi-devel@lists.sourceforge.net, platform-driver-x86@vger.kernel.org, linux-acpi@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linux-efi@vger.kernel.org, linux-mm@kvack.org, "Gustavo A. R. Silva" , Christoph Hellwig , Marco Elver , Andrey Konovalov , Andrey Ryabinin , Masahiro Yamada , Nathan Chancellor , Nicolas Schier , Nick Desaulniers , Bill Wendling , Justin Stitt , linux-kernel@vger.kernel.org, kasan-dev@googlegroups.com, linux-doc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-hardening@vger.kernel.org, linux-kbuild@vger.kernel.org, linux-security-module@vger.kernel.org, linux-kselftest@vger.kernel.org, sparclinux@vger.kernel.org, llvm@lists.linux.dev Content-Type: text/plain; charset="us-ascii" X-Rspamd-Queue-Id: 1D80B40017 X-Stat-Signature: rg9u6t53z6hw8bdrkgc1gfmm1748s4xc X-Rspam-User: X-Rspamd-Server: rspam07 X-HE-Tag: 1748010909-507774 X-HE-Meta: U2FsdGVkX1/XNbAJcsW98Uug+ZbLKAq38vSy0tHnU8IB16wlJOP3NqNY9FnDaJ17L/vBeECY32Qi+Y+Vmv9BC+xkpTIiUaiy2/s3XoY+f8m/1RuBQqa/fuNSjRFTm+Gao7yzSxDn2NCKqLAqxsHcW02z/PKj+RCcEO17iSAAZRBG7e7WTjGL30L19YVPtqqPHOfO6J22k4SZocOdIKp490YYYRJMjnTHfp35eC/pha0Wc+IRDnLYAOnI4SCYh2UEwvl/lJlhYyjTfH73Za/VwPc20f8N4YWg2bxW2Be3J3GQQLe0frEYeUJQqfK2QoMkxSSnvsu8dx28+OlU+T7+b8Yn10y15Q1D7jGu2E0Qc3v+FWJzXuUEYfi5bzj7rnfKlEWDhOYeafGEbyk6vGy+bMMOJjJUgrnxRWXaxGg0R4KP19Jcm2A5EiySL31Ukj3i6dpfiqiC0mAAPY+cPTij+q6exFDugcw1iB1OBev91O3+HC6c6WqFGNDIBmyb3xK3qehKVyIXgdYrDGtSFFQLA5FFYIVbP7MeLESBc4oKXzLOvAYqf3qlcg5leqLb3Jy3YQ12SYVPJuHbVikmho1JRrqdohpNHfxztkDTP186iWpq10TixQQCiVyTZggK7ynrUQuHEfOu/wRKcJvbQ5Saa3hv48UZ395h87oQ2ICbsQpR5BVbZL9MeW6bBoF7A070vkvMJ6gsC3yolF0Dhc0mJDTqOIfELCC+of6t54xuaLDX7ohhH1IirwGGXgPsGyqkfrM/Tl005/MsnYwvMW+T0RQLTQnZa3Y9PZaCxUy8pB6pkj68cCJ3CYJd6rf2jA/b6YJOQtETRtlTKm7gHMlmYG+reV9ggKbKwz7NucFcVkT2NJjtIBusXAzzjjasSzQB46m1uNz7VMeiky2acazK4kPQ5RRSI7C9FtDv3jcjYOtscyZ3hOVHd5Ne4awaHeNU9DR8rHsPVJLhVkN1ZcI jLGTBHOQ 4/t1QNx7t7eDbOejTEXxa4lzen6Q9tT6ppOZ2lRd9JcOkijfBqG0N2OocngxTTlVmslpwl30aSlHeznPsntJ14argR9vOtO6jpgDo1R7xCYWcpIZOFKSY9ndeG5JE8W52WWJJMFT+ybAUNhHvtPdJ1J7w1c6r1DIXCgKNJSOqAJPW/Etm+3RZz055tBSHq0xgpvHliM1KgKPGQCG6CJaWm3buUuYb8Yedqnl0tLRP82BqUpGN4+gY3E5HVaew6WiERngsI1PLH9QBhJWC9OSII3PsCVxP0Bnbh9xPtxHnbrEZKxmCu0SbIGHuIW+anCm5pgmlpVHAHZlSE1ybcqP50kBxJthv5JXP17u3k+z8mXxsnG30nZSHi1gTZxBnm424/DiD6UHnQzCWFfCzeG2ZKFPfNQUtXAl6bfHSBkE9Sq/qoboPjYWaApbdZr6tICMVDXGjYRyJ2LtowZzkB3QFcmRwK0GYo1AxPOkzQr8LWdJy8h5t8g8n4IYlpSm/YvavHhJl06dxn9n66+kZquXm30QqugDHx/qk9/fXdYOuMXRmAQGDrmwaRr4HQu2X3o0KRr1Zr5jmv+JS9YaZsMOiCTj3rDj7DvRWfpIYb2IPct+KfAxicQke0YX6uhsLBDDYR2u1mMJP5c1nvDx2uvr3fi45BYI3pGkNcYXXBKj7uGlFuKMJSzc8cfjenlbWvUEB+Mm1EVurqxZXCsufQlBJsLXpCg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, May 22, 2025, Kees Cook wrote: > diff --git a/arch/x86/kernel/kvm.c b/arch/x86/kernel/kvm.c > index 921c1c783bc1..72f13d643fca 100644 > --- a/arch/x86/kernel/kvm.c > +++ b/arch/x86/kernel/kvm.c > @@ -420,7 +420,7 @@ static u64 kvm_steal_clock(int cpu) > return steal; > } > > -static inline void __set_percpu_decrypted(void *ptr, unsigned long size) > +static __always_inline void __set_percpu_decrypted(void *ptr, unsigned long size) I'd rather drop the "inline" and explicitly mark this "__init". There's value in documenting and enforcing that memory is marked decrypted/shared only during boot. > { > early_set_memory_decrypted((unsigned long) ptr, size); > }