From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1D78AC3DA6D for ; Fri, 23 May 2025 08:23:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 898636B00CB; Fri, 23 May 2025 04:23:40 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7FAAA6B00CC; Fri, 23 May 2025 04:23:40 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6C2D76B00CD; Fri, 23 May 2025 04:23:40 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 49E286B00CB for ; Fri, 23 May 2025 04:23:40 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 016E2BFD4F for ; Fri, 23 May 2025 08:23:39 +0000 (UTC) X-FDA: 83473483800.13.6F0EC2A Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf04.hostedemail.com (Postfix) with ESMTP id B078C40004 for ; Fri, 23 May 2025 08:23:37 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b="VT/dk6NV"; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=PE6q+MZo; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=mk2DJrKz; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b="hivo/S0q"; spf=pass (imf04.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.131 as permitted sender) smtp.mailfrom=osalvador@suse.de; dmarc=pass (policy=none) header.from=suse.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1747988618; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=h4BuFL4WZEyP6+SkcQzWwlfaosz8lXC/4Cuh0DB8QLw=; b=LGBjixd1oQafM6MQ+6U+tlM6k72aua2j93Jy624q6Kn34bh33q51bj0obSqjZ7bYzeuoZt KgD/2mxGHswjucgyILTYtl1V0LPabVtsq48NA1rx9F13Jod6tWF6mJ/UF4/d0FnlfstIiV TKCfxJgNVr+TMJWVBguV27cIDOWPcfM= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b="VT/dk6NV"; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=PE6q+MZo; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=mk2DJrKz; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b="hivo/S0q"; spf=pass (imf04.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.131 as permitted sender) smtp.mailfrom=osalvador@suse.de; dmarc=pass (policy=none) header.from=suse.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1747988618; a=rsa-sha256; cv=none; b=vlz/v966yVDdyS7xVdpn4n+Fs1E3kR4eeflb1tOjdxea/sugIlCmwWruzeNm8ZdVDfflHm dhPYfVdceJemYzaoQfeB5oyC1bDXoFjUDU7r3Q+xb7TvuRhepTppUH88WI8JRvwHQTyNj4 o/vsOq3CoLuxPX6mdVc1EbDJlGwSCPk= Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id B3E521F7B5; Fri, 23 May 2025 08:23:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1747988616; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=h4BuFL4WZEyP6+SkcQzWwlfaosz8lXC/4Cuh0DB8QLw=; b=VT/dk6NVtLTDAhe4Zm+jaMw2XqZgi9rrKX/t4liBHmEbPDz8E02ZHtcChM3mhU/aQekjYH N0SlB8RtHLcUCn9UMObyxIhBSMXmw461MGEGImw11Xyk9MI7akMqqgrIDIePnGekp0EAS8 ZM3T2DM/lLrRkz8wMGBWLvOqsQ7co5g= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1747988616; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=h4BuFL4WZEyP6+SkcQzWwlfaosz8lXC/4Cuh0DB8QLw=; b=PE6q+MZornqhww4OGrKSTTR+x4xi8fGMnF2TqD/tg3L3o7o0pvJC9hiAYDo3xmlfofCyxT 5bQHqn1jCKU8ahBw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1747988615; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=h4BuFL4WZEyP6+SkcQzWwlfaosz8lXC/4Cuh0DB8QLw=; b=mk2DJrKzNBLqFGCeDjxllTjKiMJzqgxP5QLcBAIXqjzwpHRvBvvN+1Kz3toam8UeMDISwO WJdcbReNAFeX+fuJU5yZgK8yuEYKvZnOQ/FlTuBW/jyQbaz29FuIRnx3GAdKs8W22UtqzQ JQAyNFPmVvBPSpWfqnSmEHEvM65HVAw= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1747988615; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=h4BuFL4WZEyP6+SkcQzWwlfaosz8lXC/4Cuh0DB8QLw=; b=hivo/S0q3b7XGg8EjKH9bbk69FmGNeTp6btLgqY5LiC6QZOty8K3E8VZCU2s+bddoGTuwH 7zSEA7AsVcbCq6DQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 2AA661336F; Fri, 23 May 2025 08:23:35 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id b/WYB4cwMGikLQAAD6G6ig (envelope-from ); Fri, 23 May 2025 08:23:35 +0000 Date: Fri, 23 May 2025 10:23:33 +0200 From: Oscar Salvador To: yangge1116@126.com Cc: akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, 21cnbao@gmail.com, david@redhat.com, baolin.wang@linux.alibaba.com, muchun.song@linux.dev, liuzixing@hygon.cn Subject: Re: [PATCH] mm/hugetlb: remove redundant folio_test_hugetlb Message-ID: References: <1747987559-23082-1-git-send-email-yangge1116@126.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1747987559-23082-1-git-send-email-yangge1116@126.com> X-Rspamd-Action: no action X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: B078C40004 X-Stat-Signature: ku5gwgig68qmjebe8cm9ktzt7jnnysmx X-Rspam-User: X-HE-Tag: 1747988617-997540 X-HE-Meta: U2FsdGVkX1+HCQtLU70AaFiAz9sdfyu4wScumvL8pHfN+cv7DuCYLhkeupfFzMTJ5znTLp5EfSnxUoin+jb6eSzPdipfjWSTMoQT0QtkJTKHxWA66SuR2HkjsAHTghqp3a+u6NnuGDZ3ml7hJSW3D6IGiOMRVML5UscIlCtUwOexflQgGeqb8SH6nM2ym8EoCHLDU4JO4htOSNkxD7laJGJw95EfBUHO2d1ysDpBnhLYdGssB09YqttHCdNvRQ/j4nqt8iIL+col6plLK9P66Oogg000f7mRB/aC/opQgFLkh/l2tWzVBq4UUmocj4GMq6WKtZvYM/5G1nau3+yuxeLE2ZsxgsWVcyhlYMoeAIoB/4+DU0mvHOUoJX4eGIyVDowmxPD5on7pgZf3ePZ4K5SXBF6R4GM0SDPGJ4wDKEIdTA7Mqi3icnP+fENYoV4eAPxKrDcJpb1olKK184pB6OHSuQnsvHrRfZIxOeCIKcdmJ/KzseYORAJpEus/2ZaeO1NRBQGYWOS49dFD0R6ohlau0UU21D3zOtT+B0IiXr6fXEmWnwa7HA/lneCGBpNRlnvPRF25qYH7z0uKFMeG0wiweh/4WUOwQf9O3dXHiNNGHSM2hpcTpJDTmqo7GuYVYVgSP57Povb3hyI8frTKsTZDImT1YBf05KDSuTuyaxk6CXf/rWLoGB1e8d0s7JkvwAQNw5Wffuujw25CWSs63jQ9HzMsM/MWwy+9xuYYKQopoiELaoIKM27yk/9F4BqawU39bn+FhFV0Mwpww75nlVfY67bmDyKcVDBPgHyeG3kUD9wMf+rswIYkCF2wBKI3J5ihXGxdZOjeKz/9mPwWhEiSKqMVY+83MLegf3lb0YpNhZn5VjrsSg8b4xNEHeri/KK8ms/sPRKI/5xoB+w/0RkgzrNjXlEObSK26KcZdTdnQAV7NSSlDpskj3F1yW10zx01Cl5TrIFcfifhPJf sDQo4Ods yTg9cgJ74/uR+h0/QrWOv9h5quafC5s5K/PDmR6qAo2dIjIP1aiJBXXwRkAPH4uMVRNoRjHqWtP7OooHIzmBnrvbnmTHmfcR0KmLj+7aFDfT7YCsp+lI7+XQC5iNs6i3gTD6+6hdHnaXz9IGeOyN+j98vl61WYACWxizeed5sL8jxDqCDzAww/j3EO7jZhPSSRyMtNzMiphUwRIg+S2F1pmih9h8ZHwGK8YMVwP6qPV/R0mdY6My4HZdbUojtxkLlcihP5/rq6AfrAVSYang+kUPWMxiVHNGKzg3tU8/S/D+BI5lSqtpmJKosuxzl8Iy+UORshmDOr4OIiN0bCeCWwTmSS/xDVZ5mYYBrH5QKzTB9P8SSi5fkkaXqVGeTmgXD0qUkwHEv/v2tiUKNeQJPWIX5HA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, May 23, 2025 at 04:05:59PM +0800, yangge1116@126.com wrote: > From: Ge Yang > > In the isolate_or_dissolve_huge_folio() function, the folio_test_hugetlb() > function is called to determine whether a folio is a hugetlb folio. > However, in the subsequent alloc_and_dissolve_hugetlb_folio() function, > the folio_test_hugetlb() function is called again to make the same > determination about whether the folio is a hugetlb folio. It appears that > the folio_test_hugetlb() check in the isolate_or_dissolve_huge_folio() > function can be removed. Additionally, a similar issue exists in the > replace_free_hugepage_folios() function, and it should be addressed as > well. > > Suggested-by: Oscar Salvador > Signed-off-by: Ge Yang Acked-by: Oscar Salvador -- Oscar Salvador SUSE Labs