From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 33A37C54ED0 for ; Fri, 23 May 2025 08:54:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 836E96B00CF; Fri, 23 May 2025 04:54:39 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7E7706B00D0; Fri, 23 May 2025 04:54:39 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6D7316B00D1; Fri, 23 May 2025 04:54:39 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 4C3F76B00CF for ; Fri, 23 May 2025 04:54:39 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 5EF64C1D3D for ; Fri, 23 May 2025 08:54:38 +0000 (UTC) X-FDA: 83473561836.13.98D4FC2 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf01.hostedemail.com (Postfix) with ESMTP id 335824000A for ; Fri, 23 May 2025 08:54:35 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=wP9Fm5hC; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=S8ite3rl; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=wP9Fm5hC; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=S8ite3rl; dmarc=pass (policy=none) header.from=suse.de; spf=pass (imf01.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=osalvador@suse.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1747990476; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=T82g3E2LV6xN7hQyvivoFGKg/UjdiqSAW5PZAXTFRHA=; b=TtY+0/bECgvAG/Q1CY9o0wHj2vMkX4avybqs7Ndit+P7pJcirR6t6Exb08GPSlz5TKP8kP e2SlZKOslt/5zVROV8VfUfLwHRJ0GWpd9CW3fNejdOoDZRaXJ0fDKAhD/bQHWQM7pVSK8S ZAuhmd5HYTICxU4SugxLW8e2irDLt6o= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1747990476; a=rsa-sha256; cv=none; b=C3YSufB16M89cESpaiVtL9Ow+Fm+0mognNyURbyDFIZVZ3AFKvn7e6ANw/VhRwhrMh7G2M yJ1sCq+J1HOUglv0KAjFrcvWxG4R53pvFECXpzHxHPRcGd+P7QGjH6+Y3JTOjBDL3EZiNR H/ZL/M6sPvFfPOLfUVF0lfPnxCfhRWY= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=wP9Fm5hC; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=S8ite3rl; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=wP9Fm5hC; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=S8ite3rl; dmarc=pass (policy=none) header.from=suse.de; spf=pass (imf01.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=osalvador@suse.de Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 6974421BD9; Fri, 23 May 2025 08:54:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1747990474; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=T82g3E2LV6xN7hQyvivoFGKg/UjdiqSAW5PZAXTFRHA=; b=wP9Fm5hCwE6PDo/RpdBpAQk1d9iWdAN6DLYAcZR8aeYbWkSb9wDZFUUhBA5/NAHiRi+aWl DukagYzz/GP2jf6eSuov2hP8lAMQK1CywbcP3wS1BZ4iDCrojVXEZdXmbvdLUqCWBlsTyD t/TTQaXbqjaqHwElZcvr/ny8rgNzBaw= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1747990474; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=T82g3E2LV6xN7hQyvivoFGKg/UjdiqSAW5PZAXTFRHA=; b=S8ite3rlhC1mmIGHdwWYL0zKOj7ceXDo9A/4+p+Y/YpaJHNd6DCW05Xuz5Io6Qxd2rumGW LibhgAH3FmGu/vBg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1747990474; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=T82g3E2LV6xN7hQyvivoFGKg/UjdiqSAW5PZAXTFRHA=; b=wP9Fm5hCwE6PDo/RpdBpAQk1d9iWdAN6DLYAcZR8aeYbWkSb9wDZFUUhBA5/NAHiRi+aWl DukagYzz/GP2jf6eSuov2hP8lAMQK1CywbcP3wS1BZ4iDCrojVXEZdXmbvdLUqCWBlsTyD t/TTQaXbqjaqHwElZcvr/ny8rgNzBaw= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1747990474; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=T82g3E2LV6xN7hQyvivoFGKg/UjdiqSAW5PZAXTFRHA=; b=S8ite3rlhC1mmIGHdwWYL0zKOj7ceXDo9A/4+p+Y/YpaJHNd6DCW05Xuz5Io6Qxd2rumGW LibhgAH3FmGu/vBg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id B4D54137B8; Fri, 23 May 2025 08:54:33 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id 81hnKck3MGhTNgAAD6G6ig (envelope-from ); Fri, 23 May 2025 08:54:33 +0000 Date: Fri, 23 May 2025 10:54:24 +0200 From: Oscar Salvador To: Ricardo =?iso-8859-1?Q?Ca=F1uelo?= Navarro Cc: Andrew Morton , "Liam R. Howlett" , Lorenzo Stoakes , Vlastimil Babka , Jann Horn , Pedro Falcato , revest@google.com, kernel-dev@igalia.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH] mm: fix copy_vma() error handling for hugetlb mappings Message-ID: References: <20250523-warning_in_page_counter_cancel-v1-1-b221eb61a402@igalia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20250523-warning_in_page_counter_cancel-v1-1-b221eb61a402@igalia.com> X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 335824000A X-Stat-Signature: qs6w96xgac8cffwmfecs74incak9fkn6 X-Rspam-User: X-HE-Tag: 1747990475-268411 X-HE-Meta: U2FsdGVkX1+qEsU3VH8wamGeoYSu6J4g98ylSwfULhgFfz0klTeJgGq2GdDO5RxxRYYgzVmFDUrOA+PQiQxJO5HJjM9XI/+GaWHmZWvs8myq4EF2C1WDh08Bgh0ff9T+Psb8MzfYXf9BKDJsuEb4ufhVLPxYnATxTVuiw28sL+grO58IrPYWGUDLMbZdGyDvhnVEL9QkynvnEXtr3ExAH0TKx0MjUvJpmckCf4YLWj69e1bolki8jECfCOMDofJdDi/xMTyFsO/TfYTLV/PNJMvbrS/BMsqKb/F2tlHCbac5OPU4TPR89SRyf52z+iHTkknLm/Y0dSx9S2fAC7KDi3+ykTWMxcvorcSAAhw28g7fLrTQezbrd3jVNoOGkbUoN1Dn4G2iQReM7tEyuK4Gud3aCZV+VSEiRXvBPAfpP4PD7qao89nGz40alBCxVWuswZDWLKGIvRfStOoES9QiIEt4EOHL1v1g0CzKIbQgoLEYlGIRAACpd1dQrJm6oBzZLThQaDYlZN7GXmv2Sv90Phqy8rqhLwqcRkF5Ka9XkHWHczKg+W7QQfQd65R+t90JP1xvRA3YSx8Zh9x1L3fPMm9uxVetOrpOyIgzF6ggfhhzXLpNKaU0l7Z/YjY3dGvGt/+sKD1Mb+fSzYqMhkS3WyQqgkgjckMTJbdPUhSyygXqceFzDBMPraK/IczyiWJXfjQbZnvuAA3ngnGJbsN8lBWWlj6dC1LnYNjlA3OYqHXbOLoJss8vEBqAXFlTWOL29u86xPkLfzKJDWip/C3uL63Pvz7hPenqMcRWpNpHwh9W5v8RQoPT9HJbFkrX8pjaWEbvbeg6Ivsu2zIcy2df2r6mLz+3Pl19CS8XmpubkGHykEYFJtDGDpIFGzaFtZJBa9ljAMxS66fmFpFO03CnRQhD0B08wKzIuR8Fijd3NLCEAilp4JFgfZxeSiBkODRbgiRle6rHPYkdj6Yk6rt VJJNogck VaEpfUhG1pfcFKZ1hPRMgDz5XookxYfyr5PQ2arysDTTs/9j1TZ1irWWoFa+xBVhXPd2OhnIO/RGG9sA0BlZBeokw0qcD45falgdjvkihBsNLuqgrZDNo2m4Cn0Ggtm7aJnICVJ8Gntv7fdEU6m8XtgFjZfQOH3v2RpCwkJ1tYhwVoQMYINgBqaJsQjRdoZMOR/b+K7g5Ybgu7DzvpYM08n3XJltfJjzvzn+v/Kjab1NAs75Z41o7mPAv8y9KRNpYO93Mqf3rKfhRwgraJHqZHlvzCulf6XrPyKz/fl2OZhWog7dZitYipYZDSFDhlj3DHv8YCT5twpj5+q7wkx3OhZORxCNvjfowf9R8P1CkJZB6FZx2vIIv1BTSqCeff821nssOHupulXRxJW2j4k2Hy61iDGnl3DpDnleIg+HrIyx7bxz5qg+8WKPYiY3j17vQfeeB X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, May 23, 2025 at 09:56:18AM +0200, Ricardo Cañuelo Navarro wrote: > If, during a mremap() operation for a hugetlb-backed memory mapping, > copy_vma() fails after the source vma has been duplicated and > opened (ie. vma_link() fails), the error is handled by closing the new > vma. This updates the hugetlbfs reservation counter of the reservation > map which at this point is referenced by both the source vma and the new > copy. As a result, once the new vma has been freed and copy_vma() > returns, the reservation counter for the source vma will be incorrect. > > This patch addresses this corner case by clearing the hugetlb private > page reservation reference for the new vma and decrementing the > reference before closing the vma, so that vma_close() won't update the > reservation counter. > > The issue was reported by a private syzbot instance, see the error > report log [1] and reproducer [2]. Possible duplicate of public syzbot > report [3]. > > Signed-off-by: Ricardo Cañuelo Navarro > Cc: stable@vger.kernel.org # 6.12+ > Link: https://people.igalia.com/rcn/kernel_logs/20250422__WARNING_in_page_counter_cancel.txt [1] > Link: https://people.igalia.com/rcn/kernel_logs/20250422__WARNING_in_page_counter_cancel__repro.c [2] > Link: https://lore.kernel.org/all/67000a50.050a0220.49194.048d.GAE@google.com/ [3] > --- > mm/vma.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/mm/vma.c b/mm/vma.c > index 839d12f02c885d3338d8d233583eb302d82bb80b..9d9f699ace977c9c869e5da5f88f12be183adcfb 100644 > --- a/mm/vma.c > +++ b/mm/vma.c > @@ -1834,6 +1834,8 @@ struct vm_area_struct *copy_vma(struct vm_area_struct **vmap, > return new_vma; > > out_vma_link: > + if (is_vm_hugetlb_page(new_vma)) > + clear_vma_resv_huge_pages(new_vma); > vma_close(new_vma); > > if (new_vma->vm_file) Sigh, I do not think Lorenzo will be happy about having yet another hugetlb check around vma code :-). Maybe this is good as is as a quick fix, but we really need to re-assest this situation . I will have a look once I managed to finish a couple of other things. -- Oscar Salvador SUSE Labs