From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 02618C5AD49 for ; Tue, 3 Jun 2025 08:17:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 961C56B03C4; Tue, 3 Jun 2025 04:17:07 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 939CB6B03D4; Tue, 3 Jun 2025 04:17:07 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 84F456B03D8; Tue, 3 Jun 2025 04:17:07 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 63D076B03D4 for ; Tue, 3 Jun 2025 04:17:07 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 07D0B1209A8 for ; Tue, 3 Jun 2025 08:17:07 +0000 (UTC) X-FDA: 83513384094.28.B9CD58B Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf13.hostedemail.com (Postfix) with ESMTP id CF00420008 for ; Tue, 3 Jun 2025 08:17:04 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=FJZwonCF; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=oWvD6hYw; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=FJZwonCF; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=oWvD6hYw; spf=pass (imf13.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.131 as permitted sender) smtp.mailfrom=osalvador@suse.de; dmarc=pass (policy=none) header.from=suse.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1748938625; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=L+3MJa4vgeMVcpuCPatCX8ZD9o5YgfCxkGCBD/K8oUc=; b=fKJJzg0/TcxMPSu6XIq1ueF6EqI2z10FZ4vfqlWOu2ZboInwSQQNTyzaqb273aWktyRl9B tXbc9MsS6geWMEoOXeAMtNzHxy84zf+J0BQrDsTGmSNpVu/h7ZFDi4LrJ431d8K3iLfUYt 5YOGjL9cOf/f+pjPuMzOsmyq6GllgeE= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=FJZwonCF; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=oWvD6hYw; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=FJZwonCF; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=oWvD6hYw; spf=pass (imf13.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.131 as permitted sender) smtp.mailfrom=osalvador@suse.de; dmarc=pass (policy=none) header.from=suse.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1748938625; a=rsa-sha256; cv=none; b=yB+rA9A+iirTOe0yaBFfbF5mDqWez41+nJBaTNRFGnOL/NMRJgZFCF1g3Nv+2JZZ9SaQbr IpaQbIvlAsFgGbRLQh2RtnUKlC3J6xmqyaWdpajC8RTMqlzQG5WTqjK6s2ON64+gCy4MGU DU9nWOD6gQy99hmyyAWiz52H8tLsrxA= Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 02FD81F395; Tue, 3 Jun 2025 08:17:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1748938623; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=L+3MJa4vgeMVcpuCPatCX8ZD9o5YgfCxkGCBD/K8oUc=; b=FJZwonCF2vaqqk3lmKYXle3mMcDMZkBAGUEC8xQXBMy0+jqEhgCOWRpmTEETeeofvLNTgC iNojnSz7hnPlwchuP3qe/0H+LIGfKIrRYosnmR4C5hJg4DcglNsojGiOKJJn0WDtuQ1ibu uj8RsAbnwbN3IeKGEtG9awMAH7xpzkI= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1748938623; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=L+3MJa4vgeMVcpuCPatCX8ZD9o5YgfCxkGCBD/K8oUc=; b=oWvD6hYwbJObQ9xjFnoED5Vb3x5oqMrOSt2iJUtwXj9kijOOhWoRjm+mNRhHu5wf8raTTP ED/p3blxJcoVpfDg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1748938623; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=L+3MJa4vgeMVcpuCPatCX8ZD9o5YgfCxkGCBD/K8oUc=; b=FJZwonCF2vaqqk3lmKYXle3mMcDMZkBAGUEC8xQXBMy0+jqEhgCOWRpmTEETeeofvLNTgC iNojnSz7hnPlwchuP3qe/0H+LIGfKIrRYosnmR4C5hJg4DcglNsojGiOKJJn0WDtuQ1ibu uj8RsAbnwbN3IeKGEtG9awMAH7xpzkI= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1748938623; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=L+3MJa4vgeMVcpuCPatCX8ZD9o5YgfCxkGCBD/K8oUc=; b=oWvD6hYwbJObQ9xjFnoED5Vb3x5oqMrOSt2iJUtwXj9kijOOhWoRjm+mNRhHu5wf8raTTP ED/p3blxJcoVpfDg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 38FD313A1D; Tue, 3 Jun 2025 08:17:02 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id MR0ZC36vPmjWIgAAD6G6ig (envelope-from ); Tue, 03 Jun 2025 08:17:02 +0000 Date: Tue, 3 Jun 2025 10:16:52 +0200 From: Oscar Salvador To: Barry Song <21cnbao@gmail.com> Cc: akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Barry Song , "Liam R. Howlett" , Lorenzo Stoakes , David Hildenbrand , Vlastimil Babka , Jann Horn , Suren Baghdasaryan , Lokesh Gidra , Tangquan Zheng Subject: Re: [PATCH RFC] mm: madvise: use walk_page_range_vma() for madvise_free_single_vma() Message-ID: References: <20250603013154.5905-1-21cnbao@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250603013154.5905-1-21cnbao@gmail.com> X-Rspamd-Action: no action X-Rspamd-Queue-Id: CF00420008 X-Stat-Signature: egqh5nk3ocojtgifdg1sfghssitq3c3c X-Rspam-User: X-Rspamd-Server: rspam04 X-HE-Tag: 1748938624-846852 X-HE-Meta: U2FsdGVkX1/ZX/FMaFR3IyumNlXz3s4AdZn5OkHISOj2EuxDJcmy0+JkNj4peie5azDNMD9ASzq+S2RgH0XNIQV1D6L7h1QWoYp9JUdx/KXriKr+PnJUXIQLhpREKAK3BJXp5dboiaP9yHXASiUfvqHvQ+BrnMGDT9J7I633cOflou1D9QMH16Dgv+djtACRZNWm+o6LGlb8di//FnUMYpeaACcS6yQmkFW1oZidIke9sDPg1xuCNYcktO3GAZXgmlmTydZFqPtgksInbkGe5T8/5j0e8Lpa1i9FsB9JGaEPTdEmqnmh5oBk9y3XUsVYK1s2OygUKN7934UUVH7mSG6lyG0flnWZrwSD/xrk4Yx0a9jFhgGFmRu2nJo14TR4apZ1ilrAJrdlqzEhFYgGD3LLCSd8x0cNXqxxHJSmikYtromYUshUfDhE3AerdPaTVA4JlfCFUsOtm2g2Nc3JcfWbWrrEdxfno2vFdxnkw87Nc1LHR9mJfRlwAaUpVG/nvfMeY6keRraSt/32SsvGnqbwxu7b+ZdQhsUINVjtzs9Dt2EydVOyfgpvh6t/bRaM2RHjmGwC186ydafs1Np2nhtGiKjinIU1SytrtOdGX87hnPQ4fYZZ5hqnyBZetNMIN/yh7UKjBZH5uXG2v749CAlNGi90T5YV7Eq2XGloosAQ/uGU5fcy3hsiVZ0vQ7ygbauDda0W5QJbz8TCmWS5zQvxeraPqk4qXdKMekcx5C3vnSbBVXYkQ1rItv1rPK+OAUMfAUe4B+DuzNMYtdTpFmsYxQDgM5EHh2fZRFLSWAWFVK23Y4gGq2PUNR5QkbVfTlmDFrdzEquK2FJNbLcUzLr4i6KgSJ5Qc5x7+HFqMm/E158u0ihFGvb05Cjd2q7V5Bt0rHBO84bE83xCRjXDgIWM7b6AigBheO9Ocs791DxWGlBL9yOUz/FpSzxU1kEhD03k3+thOq4yRF7dJ6q BwTrHt8N /BIAu+7JEPiJT6QiuSfoDepiaJKBsSgJolSGhhJFCDk5YWrn88pFYgyJVLzORdy07jsWm84DHMPMxXc/BTxCZmMGwOewoZCYMVU6ykXSukUWvbXc87QLvkEraJT2OwE5zWJhxXymWZTOue6bPjcYldD7gDeyS4wLvSahP6YYFVhMh0XKrzh7OslLVgwzIhppG+kSd33KC3BVnlC3BzuHb/tLdXjpMUR3xFPsdSDiJ7PB58J1ANzliSa7Ll3PgDpPdfkDz+nJN/5qAhhIV3Vfy4s/zK/CiZu9atrZRwObLcPxWXCF0BCNdkdyWI7FWJw4I47Ld3O1cl2Xv6nM8XNGnovXGtSigA7aSsjkPxObCa8bEjNlpKIa+u9UXsiyqiVZkOxODjhmFQm9FaQuk9S5Iaeiq5g== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Jun 03, 2025 at 01:31:54PM +1200, Barry Song wrote: > From: Barry Song > > We've already found the VMA before calling madvise_free_single_vma(), > so calling walk_page_range() and doing find_vma() again seems > unnecessary. It also prevents potential optimizations for MADV_FREE > to use a per-VMA lock. > > Cc: "Liam R. Howlett" > Cc: Lorenzo Stoakes > Cc: David Hildenbrand > Cc: Vlastimil Babka > Cc: Jann Horn > Cc: Suren Baghdasaryan > Cc: Lokesh Gidra > Cc: Tangquan Zheng > Signed-off-by: Barry Song Reviewed-by: Oscar Salvador -- Oscar Salvador SUSE Labs