From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8D649C5AE59 for ; Tue, 3 Jun 2025 06:32:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E8E4A6B03B5; Tue, 3 Jun 2025 02:31:59 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E40056B03B6; Tue, 3 Jun 2025 02:31:59 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D558F6B03B7; Tue, 3 Jun 2025 02:31:59 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id B76BC6B03B5 for ; Tue, 3 Jun 2025 02:31:59 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 59BC3BA17E for ; Tue, 3 Jun 2025 06:31:59 +0000 (UTC) X-FDA: 83513119158.01.9E9CBD8 Received: from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31]) by imf30.hostedemail.com (Postfix) with ESMTP id 9316680005 for ; Tue, 3 Jun 2025 06:31:57 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="tliTWB/A"; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf30.hostedemail.com: domain of rppt@kernel.org designates 172.234.252.31 as permitted sender) smtp.mailfrom=rppt@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1748932317; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=D+e8eRFTta0neZhW1IU6WI7n3LtpS30ULY8yw67rgu0=; b=7efPGLv7XSA6WgSkdJZLNKA3OslI+Ly3OeDsvZZwEmhiim8gCQ+1NAI/I3bsh7sZSBUNuZ CqjYxuI+8Tb21kYdb6YFKJodFTw/5PnIehnegkFDrQ7SBM+GkBWj1Hawi8o85h+IaXtOzU UllUN/1NZekmnGpvwbno7qH9UYJjhdc= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1748932317; a=rsa-sha256; cv=none; b=dpJrqQZP/HF9p5T1NcbX5bHNFsu83P0n1rwFUfCq1Mf0drudpvwMZJtMH5XZVKvx58487w /QJz+fsrY+JTv4SYvPqXIAyBeX6H1tg1JNz0cOSi/nBbi6LOc9E09ccUDW1DRfCJxU2P1Q ipZbV7NNMubVSkravlFU2ZFHfv5xBL0= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="tliTWB/A"; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf30.hostedemail.com: domain of rppt@kernel.org designates 172.234.252.31 as permitted sender) smtp.mailfrom=rppt@kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id 3F75844D7B; Tue, 3 Jun 2025 06:31:56 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E9845C4CEED; Tue, 3 Jun 2025 06:31:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1748932316; bh=XQo9fDvD2YihXDD5sUzWDL7i7NgwHxES32sHZYgo+80=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=tliTWB/ABtE+huZBN6ZBvcdetSTa0w35dQubD36R8K1vunfvz82nIl9/z0ofkZpBz lO+vp3epcHoF5NvWrSZ1tnTGeKNUwlHG3U7uLQh8GIHiWzypeI7p8Adg4ci80U+Ksp Z9626OWl8fLJDkeVscKChctdACL93mIkn1y9SFURm4GUBoQhnrtNC59yP5Zi1hghz9 RlkyWSYVGAPmzgZ/8KruxKHFYLOAMDcgLZSpTG75bHBW/0Em3zSIgLQPeEHSJ3+b9A 55YHiDxjHBaEaG8M/BrEMH8sXdoSIOC5rlP1WUrd3KIE/iC6OUWeQQvD55EygZtWx0 fTLeLxywbAycQ== Date: Tue, 3 Jun 2025 09:31:48 +0300 From: Mike Rapoport To: Paul Menzel Cc: Andrew Morton , David Hildenbrand , Lorenzo Stoakes , "Liam R. Howlett" , Vlastimil Babka , Suren Baghdasaryan , Michal Hocko , Zi Yan , Juan Yescas , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm: Kconfig: Use verb *use* in plural form in description Message-ID: References: <20250603061303.479551-2-pmenzel@molgen.mpg.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250603061303.479551-2-pmenzel@molgen.mpg.de> X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 9316680005 X-Stat-Signature: q5twudup7zw1a9hfn3gx5yucs1deyt7h X-Rspam-User: X-HE-Tag: 1748932317-104370 X-HE-Meta: U2FsdGVkX19n4F+dOkednUZxcmmaJa6trv1S0PWEJDjgBhe3yYaWU0656iOmmlNoNyNKzKvd+sPV1u3aGgmtmPwePZCTM7SeQDp/9wqZsUO63l1UcWFveE/FL388kUYWOFMtqzNI/0Efshpj+Hpv338+OOM34HAOKfsz8Am6a6+kgE1c30gLmww+TG2j+KLH7Lf5u4e0NpCXuQBvsr8ICMiQv4ZRy/nYtM8qnEli6g1nh5WOm4mMdeG0IHoVY3qo5dFuuhrLGFLyYC/GyNBM6i1mm4jYxwNOfqJzIkmZRGc8WwsxCUiBQJ94dsxvCo08fgEm0oK0ndr4CO345lzX2gzotypq3nr178ZPUmOH13eD0rCMZUPf1aOcspUBoRxSVcX7/6n1LP4CDze7ni01aPnxqTw6qov60MT49nhlx7SgbftVt2eDbqHRvBouAVz1XD7IGDTeZ5U5bW2Cn+3FYe7uuulYnFqs3f/U90HuVgEILeiQBSRuoquR3Xr8FfErcqTgCse1kgGk5jNnYNaZS3PE+lzsAZHI7sfUk/eBrHwR8DTCWKuk4tElq6pnoQzwYeRP7B130rwYQy66JRvxJqYqfbD1bO3Sc87k8TnoJFZE4LcT/zeSM6CwxhNWdBq8idJHAXOfJAv9OhcOWYVN5XltYI0Tr4eh9cdO26o4tok0R4ZsrpMBS5D4RqwRqfKpA+iv/F4sfoP/JPT4ggzZLU28T620FcMhh3mqPNZDvNt29TyrDuylfCfMcLW5O/D40i15LcBtxfl6AEEUyt9fUU5JMXI4KtaRhfR1W/OdgmoEsGZDOOHfdclxNmMpDrjuWBb9sLFELgkXbUa5NhNx3wqcgMUlW1IOEZVcxtO98ZNhDCJCwSJnJqL43z/qJvwJPDyAfmNRShl/ii8MCvSIDSaAl9pEp5Z2qHnsVx8c7s3tUQjVyZepb0eu2P+GBm6aiz5up6/WbDmlarHFNLN AMN85n8c SBa6vap5pdP1zpZ7xx+LCQPmVBazb7nWioSHNT3oVZGQnU+UYKv6PMkf4c/MREZAKIPMiXuf2dDw27MSXoJfgH8cabKU3uGZkk3mWAMlaQqta/WEpxDaoT0o4TaMGE3VSoYtKK9qgj/MFXlrCeoyVYiYKeQ2DuUsaTWciYv1X2goXgFxUVPfEmcL40obXRBHGoju7HTRGPzlBG+DYm9ETkjiBv75b0tvPqSyi9z1jb7P6Wwo/1gj5dQKn/nyctNPGr1wh55GPo3IXBL1YqzkL/4uIcg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Jun 03, 2025 at 08:13:03AM +0200, Paul Menzel wrote: > *workloads* is plural requiring the verb *use* in plural form. > > Fixes: e13e7922d034 ("mm: add CONFIG_PAGE_BLOCK_ORDER to select page block order") > Signed-off-by: Paul Menzel Acked-by: Mike Rapoport (Microsoft) > --- > Reading the sentence it feels like, something is missing before the > *please*, but I am no native speaker. > > mm/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/Kconfig b/mm/Kconfig > index f8bb8f070d0d..e3a07687ed0b 100644 > --- a/mm/Kconfig > +++ b/mm/Kconfig > @@ -1022,7 +1022,7 @@ config PAGE_BLOCK_ORDER > or MAX_PAGE_ORDER. > > Reducing pageblock order can negatively impact THP generation > - success rate. If your workloads uses THP heavily, please use this > + success rate. If your workloads use THP heavily, please use this > option with caution. > > Don't change if unsure. > -- > 2.49.0 > -- Sincerely yours, Mike.